From: Chris Li <chriscli@google.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nhat Pham <nphamcs@gmail.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Seth Jennings <sjenning@redhat.com>,
Dan Streetman <ddstreet@ieee.org>,
Vitaly Wool <vitaly.wool@konsulko.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Domenico Cerasuolo <cerasuolodomenico@gmail.com>,
Yu Zhao <yuzhao@google.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] mm: zswap: multiple zpools support
Date: Tue, 15 Aug 2023 15:59:48 -0700 [thread overview]
Message-ID: <CAF8kJuMj1ioKwt9b+JvLNHEpOLEjo+=RyY9z8yELhhNN1udrtg@mail.gmail.com> (raw)
In-Reply-To: <CAJD7tkZ21fcwS=m4RuctR4H7dG+NvFQgcc_-Bi6Et73ULgc1kw@mail.gmail.com>
Hi Yosry,
Sure.
Ack-by: Chris Li (Google) <chrisl@kernel.org>
Chris
On Tue, Aug 15, 2023 at 3:30 PM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> I was hoping we can add the basic support here for multiple zpools,
> and then later, if needed, extend to support runtime dynamic tuning.
> Adding this will introduce more complexity as we will need to lock all
> trees and make sure there is no activity and alloc/free zpools. If a
> limitation for compile-time constant is observed we can do that,
> otherwise let's keep it simple and incremental for now.
>
> FWIW, we have been running with 32 zpools in Google's fleet for ~a
> decade now and it seems to work well for various workloads and machine
> configurations.
>
> >
> > Chris
> >
> > > has seen a ton of testing. I was hoping Johannes would get time to
> > > take a look, or Nhat would get time to test it out, but neither of
> > > these things happen.
> > >
> > > I obviously want it to be merged, but hopefully someone will chime in here :)
> > >
>
next prev parent reply other threads:[~2023-08-15 23:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 19:46 Yosry Ahmed
2023-07-09 23:12 ` Nhat Pham
2023-07-13 10:35 ` Yosry Ahmed
2023-08-11 21:19 ` Andrew Morton
2023-08-11 23:20 ` Yosry Ahmed
2023-08-15 22:22 ` Chris Li
2023-08-15 22:29 ` Yosry Ahmed
2023-08-15 22:59 ` Chris Li [this message]
2023-08-17 22:53 ` Nhat Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF8kJuMj1ioKwt9b+JvLNHEpOLEjo+=RyY9z8yELhhNN1udrtg@mail.gmail.com' \
--to=chriscli@google.com \
--cc=akpm@linux-foundation.org \
--cc=cerasuolodomenico@gmail.com \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
--cc=yosryahmed@google.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox