From: Chris Li <chrisl@kernel.org>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Chengming Zhou <zhouchengming@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, Nhat Pham <nphamcs@gmail.com>
Subject: Re: [PATCH 0/2] mm/zswap: optimize the scalability of zswap rb-tree
Date: Wed, 17 Jan 2024 17:03:27 -0800 [thread overview]
Message-ID: <CAF8kJuMRWDuY5hbAzbA9bQ5=4RztvD3tLB-W+6besGBk11+pPQ@mail.gmail.com> (raw)
In-Reply-To: <CAJD7tkadpOmERPzUyYUX=8=POan=Pm1zSae81zyRhYLXDHo_7g@mail.gmail.com>
Hi Yosry,
On Wed, Jan 17, 2024 at 4:35 PM Yosry Ahmed <yosryahmed@google.com> wrote:
> Hmm I don't understand. What's the point of keeping the rbtree if we
> have the xarray? Doesn't it end up being more expensive and bug-prone
> to maintain both trees?
Patch 2/2 remove the rb tree code. Just keeping the tree spinlock.
>
> When you say "eventual goal", do you mean what the patch would morph
> into in later versions (as in v1 is just a proof of concept without
> removing the rbtree), or follow up patches?
V1 will remove the rb tree, but does not merge the rb tree lock with
the xarray lock.
Hi Nhat,
> Hmmm why? Is there a reason to keep the rb tree around?
No, not at all.
Chris
next prev parent reply other threads:[~2024-01-18 1:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 9:23 Chengming Zhou
2024-01-17 9:23 ` [PATCH 1/2] mm/zswap: make sure each swapfile always have " Chengming Zhou
2024-01-18 15:05 ` Johannes Weiner
2024-01-18 17:37 ` Yosry Ahmed
2024-01-18 18:16 ` Nhat Pham
2024-01-17 9:23 ` [PATCH 2/2] mm/zswap: split " Chengming Zhou
2024-01-18 15:11 ` Johannes Weiner
2024-01-19 6:20 ` Chengming Zhou
2024-01-18 19:24 ` Nhat Pham
2024-01-19 6:24 ` Chengming Zhou
2024-01-17 18:37 ` [PATCH 0/2] mm/zswap: optimize the scalability of " Yosry Ahmed
2024-01-17 23:41 ` Chris Li
2024-01-17 23:47 ` Yosry Ahmed
2024-01-18 0:17 ` Chris Li
2024-01-18 0:34 ` Yosry Ahmed
2024-01-18 1:03 ` Chris Li [this message]
2024-01-18 3:51 ` Yosry Ahmed
2024-01-18 0:49 ` Nhat Pham
2024-01-18 15:34 ` Johannes Weiner
2024-01-18 17:30 ` Yosry Ahmed
2024-01-18 18:06 ` Johannes Weiner
2024-01-18 18:37 ` Yosry Ahmed
2024-01-19 6:40 ` Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF8kJuMRWDuY5hbAzbA9bQ5=4RztvD3tLB-W+6besGBk11+pPQ@mail.gmail.com' \
--to=chrisl@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=yosryahmed@google.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox