From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB826CF9C6F for ; Tue, 24 Sep 2024 15:52:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BBBE6B00A2; Tue, 24 Sep 2024 11:52:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26C026B00A6; Tue, 24 Sep 2024 11:52:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10E156B00A7; Tue, 24 Sep 2024 11:52:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E494D6B00A2 for ; Tue, 24 Sep 2024 11:52:47 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 639A4141B10 for ; Tue, 24 Sep 2024 15:52:47 +0000 (UTC) X-FDA: 82600074774.22.EA373D1 Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by imf18.hostedemail.com (Postfix) with ESMTP id 859C71C0022 for ; Tue, 24 Sep 2024 15:52:45 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=rIMxNQ53; spf=pass (imf18.hostedemail.com: domain of chriscli@google.com designates 209.85.166.172 as permitted sender) smtp.mailfrom=chriscli@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727193046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ENsNIixmdO/D33v64/Hx/nN4OGp/TO1/agjSHYnW6c8=; b=BcKysN8n1OE+07+FOeBNMtX9XmpQxicMX3lFENaHcC/SnWVXWEw0ag7uUKJzPtoplm6Xse 58ec8Zeud7cffp6uV/J3my5mhvKmnCj3pc/OvTfjEAHWdoCRg3reBJub8ESATqwTzolIMC 3GDZXqZDP7XfcGZt3ttRlHq4dSrCAuM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727193046; a=rsa-sha256; cv=none; b=fJbwA9d0FN8GNHSvOmen/XPK4rZimqZCYcP19lUJ1M8RiYhenej7qqH8H09Cinp1RgVr1A cf5zhLfQSP2F/5lmhArlPTP3XaQK1xnwgu3dwdlf+X8ScqHr9n7KrG1KPfnxT7fFeQgnyt SLhHI6i8Poc7z0lmYCQeFP7iXGwbbgk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=rIMxNQ53; spf=pass (imf18.hostedemail.com: domain of chriscli@google.com designates 209.85.166.172 as permitted sender) smtp.mailfrom=chriscli@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-3a1a4f2cc29so211775ab.1 for ; Tue, 24 Sep 2024 08:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727193164; x=1727797964; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ENsNIixmdO/D33v64/Hx/nN4OGp/TO1/agjSHYnW6c8=; b=rIMxNQ53psXsDXQctRAFCO5Q4Do1AAQ9TMo/jBH4skVCsL+5gtoUrcUQd0ZL12ZDjP 50l1u3Dk+I/Yu9VWnGHH0P5S8k4q9+vlDUMA49cO0xy8TzK0cjYVpKMw7MBhSDx9r+LT wtNiIS4FzxK4SIV2Dmzoy36pMV78zllNsA7gFFgCynOvJ5dM708C4ux+VTAw9RhdFxTu uAUggifSxUW95Sc3xOObAUYNZJkIngR6EF9WzCCUShH65xEByCsVtM9SoP6FQdqfLmCN vpfgxNbodMcJNynnfEbf9ROuM/qSx0i5yi/BOB4df3YRP4yCEJBU1dLTYCA/yIG0MBdg vq0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727193164; x=1727797964; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ENsNIixmdO/D33v64/Hx/nN4OGp/TO1/agjSHYnW6c8=; b=VphvCw15mSXdIwDos5vMwAsYJ6YtY5oo3UdfUfDDxynUGezs3gJ+ClsTdqj8cCdYyG /3UuwiHLPEjTQfPcTr8sq5PRQnqks7aFgmXBZ8i1qn1kCI3hb3X4VUc0/rUlxoEXnLfc 7NhcjtANtBPMU/MkKRSdMmjxBq6GeAXi2FFDz9R+e0y3BAcrQ8nk1jtE4zGqHOnLqyTo VASWj8aT9BQKcsrEOaYNzcLl7qLqyjcAtRR5mxPjBbCIIp4nUli0LrzOrNQBLswEog75 X987uxKIecN8SaiRequaxpme3UC0cojzaQ39+D99dYtOA1hr9XXEfb2g5RRlOj5WSg73 2lWw== X-Forwarded-Encrypted: i=1; AJvYcCXPKxgnAXXGC7w0v0Z2zpZOLo58FcVnr3xurSnYpREI/zvgcYSwcHn7G2dNm14zVremh6th1dQHtQ==@kvack.org X-Gm-Message-State: AOJu0YzDGEzEkozZjQEYC74jV+PVUqe/QsCuoMKvJpCISBot409wOr96 GGEKehm0MoFnIrQpXNOsNLPFoKGdd97ugLoW09lMGoEpK+gQOaa9ZbFLbOacjIgyVQvxlOLZfft JK3MqycXEMSOondf2mEo2xo0hxAcvzOZ5wxqA X-Google-Smtp-Source: AGHT+IELGZjXltkg3qBeobxfMw7rerOwxwG8wpctteLRbwplJ6NsWp8Xt3vulpIq6pA2by6mmcs96Df/iUnCU4neaQI= X-Received: by 2002:a05:6e02:1aab:b0:3a0:91e7:67dc with SMTP id e9e14a558f8ab-3a1a3eebe75mr4783475ab.4.1727193164068; Tue, 24 Sep 2024 08:52:44 -0700 (PDT) MIME-Version: 1.0 References: <20240911025600.3681789-1-senozhatsky@chromium.org> <20240917013021.868769-1-senozhatsky@chromium.org> In-Reply-To: From: Chris Li Date: Tue, 24 Sep 2024 08:52:32 -0700 Message-ID: Subject: Re: [PATCHv2] zram: free secondary algorithms names To: Sergey Senozhatsky Cc: Andrew Morton , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm , Kairui Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: d3xeep7pfsbs67zow4jjntfojep6rptc X-Rspamd-Queue-Id: 859C71C0022 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1727193165-176757 X-HE-Meta: U2FsdGVkX19x5ZTomgKzczWcPwlF6r4tYwxBV0D+k2AcaAPOgOlx4RBE4e+I9gNPmR1hmi1aghCGjqquNp0isUHDgEztFSdiscUk75c9czS8Ek10EuKeOZSBGrfIYOCgVwxiT9bvvMIAePuQVrYBMuOdcMdIg4E1QmTOsENe0V++HHCvcZSxGM83gT86SJ01Y/4jW2U/9MkfnnK+6mKEWOsLwUkNRot+BhwvkCCm7mCU50zjbR/REcMub90Opf5u2MxPGaf/hsV1sdKsi9mwGPO2SJOS7Am+42QfgYjw0bBqX7TtkOgcS0MZPAQZbQV9Tj7dV/Q3REQ9nctgHPlOYj22mA63rbOu1z7tVa0jx66lzlwGq/2wrrPnithFroRioqUTP0GacpkTFeINFWO8nwsuiAMOJHhvqDcReduJFCFIJM9YnhB5NVf8Z8sSGS3OzSuWJFp2wLmne4BTPdjQJjfPNyXvPaJO2dLLxQOGgUDRcDr29b3FSpUdptmO/d/D366Zj14yON7DhaU6fYkPjZGhUlJvRAes7M+741nv7aG6yd/jkvPkk5VbrHAwVuGM9hJVT1YHVQHOoZYIofaHoujxbyse8wQRiqikTJRqkP2H6CIYPPvswYmwImoLbu1ft3mPzBQnt0mIz5pzdl56RlxdgdTpYQ6XIcF6FWZZCGcSgIvnNygupip0ekF3GKEHTCq2iUSLRgrmmKbEN+DXvmmFiV++yXEDY7ZHo3aL27gvd8U+bJt50H/P/IT4Rnq+BydLsLuX7vPngpzEoFf9xqM7ZWWx03Zb2AhgS1qhWyQPpwoNfQscCqGpm8rjlq7Xo0nvdBJYCVj1VurGXEl3h4wVjLPEtMBKG7p9hJqNUtwcqygnx1gFJdJ1fzaLVTs93+7h9kL6CC4S0HGcW6JCdiLrPW8ddGx+PJZhlw8ijJUn/A1n3y2NT2AoIht8FeF6w5YlyBkapCcTNGzKQWW 71ZKG0IR xFc9+OsgWElRe5DXjWlgpUYUzEx5Zc0kq1+1GKaF9aLB5Ns+PLydixWU6/67+hqqd/td5vv1au/W6v3ebdA0GGo+hebYn1J86xyqnhmLx05GDNfrIdnjlyzR9U2IvjH5PXLmKxnYv66lCkvUJvas0vqDgoJZ+SoXCxdhjmuAHHLYPbch21Nxu4bSplo0e6RPV6zwALQUq9hnixMUYnjHl3ncSVgecxefN5gsSeO8w4K6O0wS5G7+86j9ggQZU5jGTu3YTvARanB/HETo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Sergey, On Tue, Sep 24, 2024 at 8:36=E2=80=AFAM Chris Li wrote: > > Hi Sergey, > > The current mm-unstable is breaking my swap stress test again. While ther= e seems to be multiple bad commits that cause it. I have bisected into this= commit causing kernel warning and followed by BUG(). > > [ 56.630032] zswap: loaded using pool lzo/zsmalloc > [ 56.718027] zram0: detected capacity change from 16777216 to 0 > [ 56.725492] zram: Removed device: zram0 > [ 56.740125] ------------[ cut here ]------------ > [ 56.744616] WARNING: CPU: 2 PID: 1894 at mm/slub.c:4556 free_large_kma= lloc+0x4d/0x80 > [ 56.745119] Modules linked in: > [ 56.749551] CPU: 2 UID: 0 PID: 1894 Comm: zram-generator Tainted: G S = 6.11.0-rc6+ #33 > [ 56.750129] Tainted: [S]=3DCPU_OUT_OF_SPEC > [ 56.750908] Hardware name: HP ProLiant DL360 Gen9/ProLiant DL360 Gen9,= BIOS P89 09/21/2023 > [ 56.751354] RIP: 0010:free_large_kmalloc+0x4d/0x80 > [ 56.756120] Code: 00 10 00 00 48 d3 e0 f7 d8 81 e2 c0 00 00 00 75 2f 8= 9 c6 48 89 df e8 82 ff ff ff f0 ff 4b 34 0f 85 e > 9 7d f5 00 e9 eb 7d f5 00 <0f> 0b 80 3d a8 f3 9b 02 00 0f 84 bd 7d f5 00 = b8 00 f0 ff ff eb d1 > [ 56.761370] RSP: 0018:ffffaeaaa3657b20 EFLAGS: 00010246 > [ 56.761676] RAX: 0057ffffc0002000 RBX: ffffece0c1f40e80 RCX: 000000008= 040003f > [ 56.766293] RDX: ffffece0c1f40e88 RSI: ffffffff9a03a131 RDI: ffffece0c= 1f40e80 > [ 56.770931] RBP: 0000000000200000 R08: ffff95571d256480 R09: 000000008= 040003f > [ 56.775540] R10: 000000008040003f R11: 000000000000032c R12: 000000000= 0200000 > [ 56.780212] R13: ffff953787c71e40 R14: 0000000000000047 R15: ffff95379= b2e3e20 > [ 56.784943] FS: 00007fb0f1d58bc0(0000) GS:ffff95567ed00000(0000) knlG= S:0000000000000000 > [ 56.785403] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 56.789937] CR2: 00007f35b6449050 CR3: 00000001112ac006 CR4: 000000000= 01706f0 > [ 56.794784] Call Trace: > [ 56.794941] > [ 56.799377] ? free_large_kmalloc+0x4d/0x80 > [ 56.799598] ? __warn.cold+0x8e/0xe8 > [ 56.799842] ? free_large_kmalloc+0x4d/0x80 > [ 56.800065] ? report_bug+0xff/0x140 > [ 56.800296] ? handle_bug+0x3c/0x80 > [ 56.804703] ? exc_invalid_op+0x17/0x70 > [ 56.804912] ? asm_exc_invalid_op+0x1a/0x20 > [ 56.805132] ? free_large_kmalloc+0x4d/0x80 > [ 56.805344] zram_destroy_comps+0x32/0x70 > [ 56.805568] zram_reset_device+0x102/0x190 > [ 56.805812] reset_store+0xa6/0x110 > [ 56.810207] kernfs_fop_write_iter+0x141/0x1f0 > [ 56.814689] vfs_write+0x294/0x460 > [ 56.819106] ksys_write+0x6d/0xf0 > [ 56.823550] do_syscall_64+0x82/0x160 > [ 56.823827] ? __pfx_kfree_link+0x10/0x10 > [ 56.824051] ? do_sys_openat2+0x9c/0xe0 > [ 56.824263] ? __handle_mm_fault+0xb34/0xfb0 > [ 56.828752] ? syscall_exit_to_user_mode+0x10/0x220 > [ 56.833220] ? do_syscall_64+0x8e/0x160 > [ 56.833429] ? __count_memcg_events+0x77/0x130 > [ 56.838021] ? count_memcg_events.constprop.0+0x1a/0x30 > [ 56.838318] ? handle_mm_fault+0x1bb/0x2c0 > [ 56.838542] ? do_user_addr_fault+0x55a/0x7b0 > [ 56.843014] ? exc_page_fault+0x7e/0x180 > [ 56.843228] entry_SYSCALL_64_after_hwframe+0x76/0x7e > [ 56.843831] RIP: 0033:0x7fb0f1f7a984 > [ 56.844045] Code: c7 00 16 00 00 00 b8 ff ff ff ff c3 66 2e 0f 1f 84 0= 0 00 00 00 00 f3 0f 1e fa 80 3d c5 06 0e 00 00 7 > 4 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 55 48 89 = e5 48 83 ec 20 48 89 > [ 56.849247] RSP: 002b:00007ffc7db8fde8 EFLAGS: 00000202 ORIG_RAX: 0000= 000000000001 > [ 56.853889] RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 00007fb0f= 1f7a984 > [ 56.858482] RDX: 0000000000000001 RSI: 0000560df4e4ea65 RDI: 000000000= 0000004 > [ 56.863154] RBP: 0000000000000004 R08: 0000560e0e417010 R09: 000000000= 0000007 > [ 56.867794] R10: 00000000000001b6 R11: 0000000000000202 R12: 7ffffffff= fffffff > [ 56.872980] R13: 00007fb0f1f7a970 R14: 0000560df4e4ea65 R15: 0000560df= 4e71bd0 > [ 56.878043] > [ 56.878555] ---[ end trace 0000000000000000 ]--- > [ 56.883420] object pointer: 0x00000000f38e5ae7 > [ 56.888235] BUG: Bad page state in process zram-generator pfn:407d03a > [ 56.889026] page: refcount:0 mapcount:0 mapping:0000000000000000 index= :0x0 pfn:0x407d03a > [ 56.889877] flags: 0x57ffffc0002000(reserved|node=3D1|zone=3D2|lastcpu= pid=3D0x1fffff) > [ 56.894915] raw: 0057ffffc0002000 ffffece0c1f40e88 ffffece0c1f40e88 00= 00000000000000 > [ 56.895771] raw: 0000000000000000 0000000000000000 00000000ffffffff 00= 00000000000000 > [ 56.896562] page dumped because: PAGE_FLAGS_CHECK_AT_FREE flag(s) set > [ 56.897332] Modules linked in: > [ 56.902165] CPU: 2 UID: 0 PID: 1894 Comm: zram-generator Tainted: G S = W 6.11.0-rc6+ #33 > [ 56.903155] Tainted: [S]=3DCPU_OUT_OF_SPEC, [W]=3DWARN > [ 56.908082] Hardware name: HP ProLiant DL360 Gen9/ProLiant DL360 Gen9,= BIOS P89 09/21/2023 > [ 56.908918] Call Trace: > [ 56.909484] > [ 56.914148] dump_stack_lvl+0x5d/0x80 > [ 56.914747] bad_page.cold+0x7a/0x91 > [ 56.915318] free_unref_page+0x344/0x520 > [ 56.915975] zram_destroy_comps+0x32/0x70 > [ 56.916452] zram_reset_device+0x102/0x190 > [ 56.917057] reset_store+0xa6/0x110 > [ 56.921874] kernfs_fop_write_iter+0x141/0x1f0 > [ 56.926685] vfs_write+0x294/0x460 > [ 56.931385] ksys_write+0x6d/0xf0 > [ 56.936087] do_syscall_64+0x82/0x160 > [ 56.936656] ? __pfx_kfree_link+0x10/0x10 > [ 56.937257] ? do_sys_openat2+0x9c/0xe0 > [ 56.937810] ? __handle_mm_fault+0xb34/0xfb0 > [ 56.942593] ? syscall_exit_to_user_mode+0x10/0x220 > [ 56.947362] ? do_syscall_64+0x8e/0x160 > [ 56.947974] ? __count_memcg_events+0x77/0x130 > [ 56.952762] ? count_memcg_events.constprop.0+0x1a/0x30 > [ 56.953356] ? handle_mm_fault+0x1bb/0x2c0 > [ 56.953937] ? do_user_addr_fault+0x55a/0x7b0 > [ 56.958999] ? exc_page_fault+0x7e/0x180 > [ 56.959523] entry_SYSCALL_64_after_hwframe+0x76/0x7e > [ 56.960163] RIP: 0033:0x7fb0f1f7a984 > [ 56.960731] Code: c7 00 16 00 00 00 b8 ff ff ff ff c3 66 2e 0f 1f 84 0= 0 00 00 00 00 f3 0f 1e fa 80 3d c5 06 0e 00 00 7 > 4 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 55 48 89 = e5 48 83 ec 20 48 89 > [ 56.966840] RSP: 002b:00007ffc7db8fde8 EFLAGS: 00000202 ORIG_RAX: 0000= 000000000001 > [ 56.971903] RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 00007fb0f= 1f7a984 > [ 56.976953] RDX: 0000000000000001 RSI: 0000560df4e4ea65 RDI: 000000000= 0000004 > [ 56.981946] RBP: 0000000000000004 R08: 0000560e0e417010 R09: 000000000= 0000007 > [ 56.986980] R10: 00000000000001b6 R11: 0000000000000202 R12: 7ffffffff= fffffff > [ 56.991985] R13: 00007fb0f1f7a970 R14: 0000560df4e4ea65 R15: 0000560df= 4e71bd0 > [ 56.996963] > [ 56.997533] Disabling lock debugging due to kernel taint > [ 57.037759] zram: Added device: zram0 > [ 57.088669] zram: Added device: zram1 > [ 57.249105] zram0: detected capacity change from 0 to 6553600 > [ 57.320547] zram1: detected capacity change from 0 to 40960000 > [ 57.443012] Adding 3276796k swap on /dev/zram0. Priority:100 extents:= 1 across:3276796k SS > [ 57.470295] Adding 20479996k swap on /dev/zram1. Priority:0 extents:1= across:20479996k SS > > Here is the bisect log: > > $ git bisect log > # bad: [684826f8271ad97580b138b9ffd462005e470b99] zram: free secondary al= gorithms names > # good: [2cacbdfdee65b18f9952620e762eab043d71b564] mm: swap: add a adapti= ve full cluster cache reclaim > git bisect start 'mm-stable' 'HEAD' > # good: [9bfbaa5e44c52422a046ce291469c8ebeb6c475d] mm/damon: move kunit t= ests to tests/ subdirectory with _kunit suffix > git bisect good 9bfbaa5e44c52422a046ce291469c8ebeb6c475d > # good: [1e673c8cf7f9c1156f615b7c00f224a8110070da] zram: add dictionary s= upport to lz4hc > git bisect good 1e673c8cf7f9c1156f615b7c00f224a8110070da > # good: [3c8e44c9b369b3d422516b3f2bf47a6e3c61d1ea] mm: mark special bits = for huge pfn mappings when inject > git bisect good 3c8e44c9b369b3d422516b3f2bf47a6e3c61d1ea > # good: [f9e54c3a2f5b79ecc57c7bc7d0d3521e461a2101] vfio/pci: implement hu= ge_fault support > git bisect good f9e54c3a2f5b79ecc57c7bc7d0d3521e461a2101 > # good: [659c55ef981bb63355a65ffc3b3b5cad562b806a] mm/vma: return the exa= ct errno in vms_gather_munmap_vmas() > git bisect good 659c55ef981bb63355a65ffc3b3b5cad562b806a > # good: [325efb16da2c840e165d9b620fec8049d4d664cc] mm: add nr argument in= mem_cgroup_swapin_uncharge_swap() helper to support large folios > git bisect good 325efb16da2c840e165d9b620fec8049d4d664cc > # good: [ed8d5b0ce1d738e13c60d6b1a901a56d832e5070] Revert "uprobes: use v= m_special_mapping close() functionality" > git bisect good ed8d5b0ce1d738e13c60d6b1a901a56d832e5070 > # good: [2abbcc099ec60844ca7c15214ab12955d3c11e68] uprobes: turn xol_area= ->pages[2] into xol_area->page > git bisect good 2abbcc099ec60844ca7c15214ab12955d3c11e68 > # first bad commit: [684826f8271ad97580b138b9ffd462005e470b99] zram: free= secondary algorithms names > > Sergey told me there is a fix on the way: > https://lore.kernel.org/all/20240923164843.1117010-1-andrej.skvortzov@gma= il.com/ Confirm the fix in the above thread to fix the kernel oops for me. Tested-by: Chris Li Chris > On Mon, Sep 16, 2024 at 6:30=E2=80=AFPM Sergey Senozhatsky wrote: >> >> We need to kfree() secondary algorithms names when reset >> zram device that had multi-streams, otherwise we leak memory. >> >> Fixes: 001d92735701 ("zram: add recompression algorithm sysfs knob") >> Signed-off-by: Sergey Senozhatsky >> --- >> drivers/block/zram/zram_drv.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv= .c >> index f8206ba6cbbb..c3d245617083 100644 >> --- a/drivers/block/zram/zram_drv.c >> +++ b/drivers/block/zram/zram_drv.c >> @@ -2115,6 +2115,11 @@ static void zram_destroy_comps(struct zram *zram) >> zram->num_active_comps--; >> } >> >> + for (prio =3D ZRAM_SECONDARY_COMP; prio < ZRAM_MAX_COMPS; prio++= ) { >> + kfree(zram->comp_algs[prio]); >> + zram->comp_algs[prio] =3D NULL; >> + } >> + >> zram_comp_params_reset(zram); >> } >> >> -- >> 2.46.0.662.g92d0881bb0-goog >> >>