From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B622BC4332F for ; Thu, 14 Dec 2023 23:23:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21AA68D00F7; Thu, 14 Dec 2023 18:23:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CB058D00C7; Thu, 14 Dec 2023 18:23:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B9BE8D00F7; Thu, 14 Dec 2023 18:23:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F00C88D00C7 for ; Thu, 14 Dec 2023 18:23:06 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AB162802DA for ; Thu, 14 Dec 2023 23:23:06 +0000 (UTC) X-FDA: 81567001572.11.3BECF13 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf03.hostedemail.com (Postfix) with ESMTP id 2E5842000B for ; Thu, 14 Dec 2023 23:23:03 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZigrrUym; spf=pass (imf03.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702596184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1/u39glqJuuCFGGeFe99yJG58ZnMFafYYR4VOOatUWQ=; b=xgxqih+IM25Oh0eHleuqA4Kn5GHcZMbDwZ+CaurTZzTzbpCnyaGXp1NgB6wwjy+nu2dGF1 BafSDdECgAynj1Ys6WzLmRDSLoqyYCI4n0iMpuvYM3AAmp5av80mwLuerstbjYN/VKHvXe t3zNq5je3FAlGydVGh1qhQDsYa3h6QI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702596184; a=rsa-sha256; cv=none; b=I3zH5suvGVpfJmuqObJ+1PzQG38MM3pNnhgMkA87J04JrNBfLNuxINIDoJNiMddN0zVcst fV13NUyZAGSnvJ46y+gz0PRb6gln2AtMaUoEeSurnDL5fLCd6z9Ydh66q2mloY2n566BPt PfHOizyWhxdWiQxjogGQ6pqDsbKBxV0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZigrrUym; spf=pass (imf03.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id DBE0BCE25F2 for ; Thu, 14 Dec 2023 23:23:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B029C433C7 for ; Thu, 14 Dec 2023 23:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702596180; bh=1/u39glqJuuCFGGeFe99yJG58ZnMFafYYR4VOOatUWQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZigrrUymbeTlt6AU1HRAXv7jMBpQWvb1gcpRzKPyaqWPjtK/ZukvpuBH0tx//B5V2 xGGdRQq/UJU8pCYSjQoBtOUnm8yqaYPlQXHninxh7G38lN+ORxGkmOh6VW3p49RE3/ cl9wP/hiz8FsCssjpPtCCdBH7MJn3dTY9y6b52jMNrTjoegH+YCJK4rjX+uVmCB0xK Rvaz8t6iqG+VJA3+L+mriVnrX6buOTQvFQzX6IDvHQYR4oqdliZaR0avGpxBLl00YM ua6J+41beCJ7f57ICKjAZgzd6hVo1NS/8bLApsuDaH1Fcz/RMtrS9q2L5Z4ntkx45M K3AXSTSUzFe9w== Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-7b7020f03c9so2667339f.3 for ; Thu, 14 Dec 2023 15:23:00 -0800 (PST) X-Gm-Message-State: AOJu0YwP+SLtzuz/UhxoXsMthsWjBX68mYoGfQ6h2nHBH6hEaygRPXbD gsePFTh4BaSczup+cVNQqThwcYtrL9YbFM4hn3zNXw== X-Google-Smtp-Source: AGHT+IFZlx16ggQq+ydLOHu7s4g2zI/Zc35QmBgqhM1l+1UkieDfhMFciuUnV5cvJW0sVNZt4OTPYu0mFukgLsviFzU= X-Received: by 2002:a05:6808:1310:b0:3b8:b063:9b56 with SMTP id y16-20020a056808131000b003b8b0639b56mr11308602oiv.72.1702596158708; Thu, 14 Dec 2023 15:22:38 -0800 (PST) MIME-Version: 1.0 References: <20231207192406.3809579-1-nphamcs@gmail.com> <20231209034229.GA1001962@cmpxchg.org> <20231214171137.GA261942@cmpxchg.org> In-Reply-To: From: Chris Li Date: Thu, 14 Dec 2023 15:22:27 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6] zswap: memcontrol: implement zswap writeback disabling To: Fabian Deutsch Cc: Yu Zhao , Johannes Weiner , Minchan Kim , Nhat Pham , akpm@linux-foundation.org, tj@kernel.org, lizefan.x@bytedance.com, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, hughd@google.com, corbet@lwn.net, konrad.wilk@oracle.com, senozhatsky@chromium.org, rppt@kernel.org, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, david@ixit.cz, Kairui Song , Zhongkun He Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2E5842000B X-Rspam-User: X-Stat-Signature: i8biwbmqjkh4jqjakabyx1na4qtdnb9e X-Rspamd-Server: rspam03 X-HE-Tag: 1702596183-79351 X-HE-Meta: U2FsdGVkX185BvAFzW/4TL2JSI1C1dPxNdZDaVssV7iIU/z+t5NzpHVTriX0NXz6+zn7aFj5X3x5E+8PgBcUvhb1CjrFikGggDun8aq2jyJdMIzrSvSsDm/z4yszVXeVEJV4+ZOqVlqNkFZNvSOByZ88jKyXDpd7yODIIKXL6u+I24HkzyQ5d3l6MCIRuxCkrB9uZ/Dp1NQJi57kMc5tEwEdb5/t/0BE06K9cAWF9VCKyty4tmeyBR3ejBub1j2qdoHrDwA3RLcX2BAl8r/NXw1mh4JZqbE1RwADM6Hi3632FmaAowe5Zu6/6D7NF28idHio9pn4aZ3qRwkW27LN3ND5XRifAzLGaNYBesIyoUr8DWVyACe1H0SkjjyKB+ZbuXJgG/EXOHQ8ZWOKf8ODnXZFGSRNBDrAbID1d+BG0lzQTUZMvTap+Kjsjympgll3CMzfEyX54gBdc5ccYqUXHciDmgWUtkbTB5yluSQ5ezep9DZym8ihEWSyHcXM5XL4WOanNxrRrmtBvd6nLt+1re0diDTNNIe/kFc+DE37fdw92nm0OKigh878Xft150KRgVpRQlO5EhZnyYvGjTFf6ovYRU9vim+WhaJnd343vSVZoyKCG3ugnUJDbKAI0OvvXgkX0IdQ1ChwPfsZ+m5z55U3igUR7UYZQ8UNtiGiCwoVLwkEJrNBUklednLWqL6ufAj6zLsG5RMuCzby6Ejvi9fUfHYFGjdjinSh/Ih+CXNPNLC4HSUJ1pazUxFVXeMQ5ZA3YjuCorYBr0mFh9cJ3xXSuVJFjISJbid73UHSTqjo9HdFmmo9tb+DJgJrzG8o5DdDtB7B1eCmWwMHDdPid58z/DBLtl7J8KeyNvJPsCPwaSVVfzWbSfiiyx+YRx2h5/lISrNm/ABOJf970Ughm5/weTZ7RcLMicBP0KbPrYeGlgqnvXzs/pKHeHHGHcvE4sguJirjzcYrybghHCD 5YXK/ftV kIG8WS+fi352pAI0CD4h9VB+VWu8X1+4Ri7PkOLdxCOCbvArHX5BED0xn+elxcz1hx3Ws8pFq2i/LeJeRfnJR34iBHRLZnfqEzGE7eZ10JZyZymgMYAa55dMYSGzd5Aq7l6rszCU4KYCCa456RMpXckzoOWJliZs1y/Gy/MAPcCzz9FKdk/TwYwoxKNHzrcjENyqpETxhgR/iodqFbZohqEivrI8rVonc2zaD5OuGWxuhYHo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Fabian, On Thu, Dec 14, 2023 at 10:00=E2=80=AFAM Fabian Deutsch wrote: > Yep - for container use-cases. > > Now a few thoughts in this direction: > - With swap per cgroup you loose the big "statistical" benefit of having = swap on a node level. well, it depends on the size of the cgroup (i.e. syst= em.slice is quite large). Just to clarify, the "node" you mean the "node" in kubernetes sense, which is the whole machine. In the Linux kernel MM context, the node often refers to the NUMA memory node, that is not what you mean here, right? > - With todays node level swap, and setting memory.swap.max=3D0 for all cg= roups allows you toachieve a similar behavior (only opt-in cgroups will get= swap). > - the above approach however will still have a shared swap backend for al= l cgroups. Yes, the "memory.swap.tires" idea is trying to allow cgroups to select a subset of the swap backend in a specific order. It is still in the early stage of discussion. If you have any suggestion or feedback in that direction, I am looking forward to hearing that. Chris