From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4C2FC48BC3 for ; Thu, 15 Feb 2024 01:04:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D5578D0013; Wed, 14 Feb 2024 20:04:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 385B48D0001; Wed, 14 Feb 2024 20:04:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24DDA8D0013; Wed, 14 Feb 2024 20:04:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1714B8D0001 for ; Wed, 14 Feb 2024 20:04:06 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E33901A041E for ; Thu, 15 Feb 2024 01:04:05 +0000 (UTC) X-FDA: 81792241650.12.FD5C5DD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 070AA160009 for ; Thu, 15 Feb 2024 01:04:03 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kVBrsHMA; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707959044; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rbE3QPNgWMIaJ1L2TSQ22a+WzhFErTHWiJS3uEgyVrk=; b=iReSPASMZnZKi3zB538r9GMu7KkYW35KBhqTXgn3EfMEzjksKN9309vTd7T6DwwvTOG71r IUxEJuyEpPsfQWhiU+GyixUcTja8KYZHYoVjF07JSveS7Zr5k0jJxqlO61MRpx+on3+Mwd XvKd6KkhRpbxXlAInPYS9CtmfukDHFM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kVBrsHMA; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707959044; a=rsa-sha256; cv=none; b=CPEOO+QIgMs/xQOU6AdUJ5Zs0DgalcYmLmsuYKq0AlKHGijX101dTBA+9c+OKAVvWNUXNf /tSz4L2L/Nh4mG8rSDHdO96QMifouADuCdF8XJSUeQRQh3s5xptBTUHBBxGdi4aoop+65E THVbWk46W9Kh6qy1A3IdjJklL7KtpHs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 165DB61BD6 for ; Thu, 15 Feb 2024 01:04:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07DB7C43142 for ; Thu, 15 Feb 2024 01:04:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707959042; bh=AFIEZrspV5zSanxweZKG4w8pZtq/hNqIYlVJ0DALHqc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=kVBrsHMADVrSNoWoaUDXgTiAGfGbbJ9bVBRZOpsFqJe4y9Ou6s2wDzxvLnqsJKD53 7odHBEplA3DQXmx+BOYCFi4T6r6cvj19DL3K5hBjU+mfqfU7A510Y/erI5pupfxhJZ Pn8+ukC6xFh70wH8oJcVtd4jQNDlC6IrAMgQHosnwa478BB4soVwn3b1MZELeu95xW jMfJOPOyxfw1xCH/FLT17cw7forHtcCfvSCilNI7Fz7yJ7nbZHdUxRFNNQKaSAvV8a 5gAv/knFsrRQgxL7RaUxgPYFjhNKtdMNkgMBpnRNzThAdiS2j0d+bso8BC1P/oXiDt Maf9p02HQ4JQA== Received: by mail-il1-f178.google.com with SMTP id e9e14a558f8ab-3642ddb0310so1656955ab.3 for ; Wed, 14 Feb 2024 17:04:02 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCU1rmlVLt/vCoI7Ql263U8AsSKeNXdx8WnE2nRRuHRvCHeFTQ+muTBznx5rk0UePe2Q7GebcuOOGUXxrK8RD/dNlzY= X-Gm-Message-State: AOJu0Yx24poToZU2Vy1vtfTVT2n4ZJG1pj22RA0NbKLVZy7SJiI0VfRV NBhIg6TOH17j9b7zAhMSYULByt+P3uu99jvebiPOnolTDdOjVsbDSZxr1JKWlqm33nSo5fx2hxQ S+5awgg+vEUFhdEyqO6evzEzP5jppt4VoMI7i X-Google-Smtp-Source: AGHT+IGhz74aPmK7rKmScOst/rNBWBrM/czpuZT6ISx4KY0n+9nVENJQgM3AzCqF/bkf4YNEsYZ6Op+Clpvr/RGTdiU= X-Received: by 2002:a05:6e02:5aa:b0:364:26a6:cca6 with SMTP id k10-20020a056e0205aa00b0036426a6cca6mr211380ils.5.1707959041056; Wed, 14 Feb 2024 17:04:01 -0800 (PST) MIME-Version: 1.0 References: <20240213-async-free-v3-1-b89c3cc48384@kernel.org> In-Reply-To: From: Chris Li Date: Wed, 14 Feb 2024 17:03:48 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] mm: swap: async free swap slot cache entries To: Tim Chen Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Wei Xu , Yu Zhao , Greg Thelen , Chun-Tse Shao , Yosry Ahmed , Michal Hocko , Mel Gorman , Huang Ying , Nhat Pham , Kairui Song , Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 6g4xm8jpziapja9y795ofswjjz71mrup X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 070AA160009 X-HE-Tag: 1707959043-447519 X-HE-Meta: U2FsdGVkX19EooazmemC8+J2vzW0V6AsYpkuk9BnFnJkDrUUvPAewydB3cAoNxocGO8M2a+g7BA6h7RJgKSQAfXndsQqTGqRJB+myDpOAKik3sZOZ4aI9IDSl6ZfN2wdd1jh6Jve79zHBW8QxkQRaSklFEKJc1/1SlCG+e79uQzPTC/4A0HKj9TuEsEro/stVW5n+KXLPxyP53UU2lMhtbeJwZ2EhikxYbg5NwLFGI53T4vc28Cshx/qKPDEOkQ4zAVo0NsaENQPzNLXiMYABHUPFLA3U1QJL3mXSgN2Qt3yWaeHhIlbIQW1qo65dZXDrjUIzZhEgOymYijdYCOSkEoUZUtFa+zHcj3vYGI+Ltgg5t+Bd+HOOMT8tIll8MU2dBaN2gm0AcCHgfyXi6FB7vYQJLHn/LKoF6Fvap9mqesUkv4zshZE9mIjjOeUevFcGzuj8rKTct4Qx+AZa1fLV8B149x/xzLFA8MPEtRu2BrSfEbYlaT6Xw6L9SRs3/tytV7/5uteX9bLUP1hL8KWsk0Xh1YnC6EuibaOkQjQfwWyeXo28Cj8WbNE6xefw7OB0Sbs3VJOS00yVKp12tJZo8hSQT54vlkipJkRWhrG6em1kQzSFckqwhTS8NZCgkgW35a+cTaIKvDk5K92fg36BQL1r6S/aTxOmSwRfzTSwZixIpkLlQ3PoWhGy4DMSN8Fwg9yYnBsC8CzY9SPq71qpPTvQ2QZ5lWbUDG5M3VBqGVdvPSTGyREY2UFiYvUrq8Qztj13FqT++zqDBgrvYsESUk5tlgzFgwWMV6T3zwhXm7ohtGUqUs2HyHwAg3ds242jJuIUpgO1VDr7TbGGRsB29NyCjJUwFy2VQ29oddcf4TGLsTDjQomACdL9K1Y1I0MssNTTu8IwzG722YUDHZU0S+tZUcj7RqBMHiuyLv3nOBSf40hxPTkLUE57ZbmQfeQ2bQLTFNHSJZziiCqHGS Wvkxu1CN GYCBMoO/E7dRFaee6oPAyrEm3VlxN/xZL/jOcwOwxclriDl2iPvpZQKXt6y3uWBqhBOpKH0fVLfCqz+VqHgKk1JfX5aIhMwiwsWQeH90+eJ4kFNRl9+d2Lu1QmJ8rwrRNpCgsKvHi/y+WW4KCzEmQjFoNq6Xhk8fFx3nYxcIgGt0yIc1kOEvpCHOD2cbbN1aRquivfudYyiKGq+gxr3kxBPYBCFHm9mbjhf/Ny1KFz9C4IVuVROpO9Veb7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 14, 2024 at 2:54=E2=80=AFPM Tim Chen wrote: > > On Wed, 2024-02-14 at 10:56 -0800, Chris Li wrote: > > On Tue, Feb 13, 2024 at 4:08=E2=80=AFPM Tim Chen wrote: > > > > > > > > > > > > > > extern bool swap_slot_cache_enabled; > > > > +extern uint8_t slot_cache_async_free __read_mostly; > > > > > > Why wouldn't you enable the async_free always? > > > Otherwise the patch looks fine to me. > > > > Thanks for the feedback. > > > > Just in case someone doesn't care about this optimization and wants to > > opt out this behavior? > > Anyway, I am happy to update the patch without the sysfs control file a= s well. > > > > At least I couldn't see a downside to enable it always in the latest > patch. I think adding an extra sysfs is unnecessary. Thanks, I just sent out V4 to remove the sysfs control file. Chris