From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2B60C61D92 for ; Tue, 21 Nov 2023 15:46:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 347166B0488; Tue, 21 Nov 2023 10:46:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F6C96B048B; Tue, 21 Nov 2023 10:46:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BF926B048C; Tue, 21 Nov 2023 10:46:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F3FBB6B0488 for ; Tue, 21 Nov 2023 10:46:06 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B66711CB36A for ; Tue, 21 Nov 2023 15:46:06 +0000 (UTC) X-FDA: 81482387532.30.EEC4262 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf14.hostedemail.com (Postfix) with ESMTP id A00EA100015 for ; Tue, 21 Nov 2023 15:46:03 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Nd10M+JV; spf=pass (imf14.hostedemail.com: domain of chrisl@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700581563; a=rsa-sha256; cv=none; b=eMG5uMe7ep2X54dsokZQje5nMjmrEQa7CVJQPUwCWUBAe+jZ0KpvWS0athT1fHw5tMgxuI qYYBAK/E9cUMADlFUn/hk9ywpAqGIMQiw7jI/IoQ8hYUQolIHWdcvyJSYn8xw2ml5gRg92 6McduncRAFVQlCYN1T3zf/Pxe6g+m0I= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Nd10M+JV; spf=pass (imf14.hostedemail.com: domain of chrisl@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700581563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QrrdlxnPkvBTM/dyyHD62Af+aE8UzFW+pcUz2BBDeuU=; b=NVC+yffIM7VC3zOYMm6TZtJn+3FXGKMItvfm1rAgTNpvc8uvd0vKH4h70jJeL6zsOTyU+4 2bfwbn06SIow9gayho7WTmW7KsIrmx3pdYzGZPVgGBlNI0xFXgPHjG6i8btqtfUPRRCI3J WPHMdyQz8+kP12Sid3RSaEbRn+EpDyc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 11000B822B2 for ; Tue, 21 Nov 2023 15:46:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D61CC433C9 for ; Tue, 21 Nov 2023 15:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700581561; bh=QrrdlxnPkvBTM/dyyHD62Af+aE8UzFW+pcUz2BBDeuU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Nd10M+JVclQzaCLDrEsgLBawo4Wg9OoO8L8dtHIvU1EhdwDQFbXvgdxX37SJxk0cH nNunW/tN/1zbcY6PnHy2ISrWW/ThPx84ryM0Qp8SrvgcVa6XmkoeMram0+9WqNPdy/ WfyNPVgX9tapd87DtoJhQ821Hpj1zdts/Zm3dLc4L+3Z8fBFLXQ3GZVRC35pEgukhB JETA7Djd4871RBNinv12o+cEwlryvS/DlmjzhA1bm9Z1qKhZqCL9fPUWIC5nxy8qFM gCdRAie605+dIU4t1DZvknlV/YinUJM5b2i9d5Ct0fq4ai2uBCuaRKYWUzdfnlYYto 2YQNx9QCojyIA== Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-27ff7fe7fbcso4439327a91.1 for ; Tue, 21 Nov 2023 07:46:01 -0800 (PST) X-Gm-Message-State: AOJu0YxrQqKUUDGbHjvmB82uGSQjle5hbmcs8EruPBWAlxStHxNU4WbS qIb4HojnfF4bhcZEnHHhXat5PYxZpEOdO+g7FoiBqQ== X-Google-Smtp-Source: AGHT+IGegx4rQwcGEz/T77/nwkD5/STT5cfrYqzCCH5FAqe8ldX/x5YzOTvHgrPX7ZS/a+tkjb3nmpylxoncPAQcNcs= X-Received: by 2002:a17:90a:fd02:b0:280:3f33:64d8 with SMTP id cv2-20020a17090afd0200b002803f3364d8mr12148287pjb.21.1700581560471; Tue, 21 Nov 2023 07:46:00 -0800 (PST) MIME-Version: 1.0 References: <20231119194740.94101-1-ryncsn@gmail.com> <20231119194740.94101-11-ryncsn@gmail.com> In-Reply-To: <20231119194740.94101-11-ryncsn@gmail.com> From: Chris Li Date: Tue, 21 Nov 2023 07:45:49 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 10/24] mm/swap: remove nr_rotate_swap and related code To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , David Hildenbrand , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A00EA100015 X-Stat-Signature: cgmxoaj9f5rbofjf1jy9m64n1z5wwggz X-Rspam-User: X-HE-Tag: 1700581563-293938 X-HE-Meta: U2FsdGVkX18VXMgA1c0lAeLmpj5kKDvZZFVoH7E8+zfT4EakfjfRWAcgpYJwAvBb3x9vABu9Nk7m1n1nYCRGa+3qLuRzxu/71rdom3Lnl2uPvPLv0R6PghNYbB8U9aS6hBg4qMEJLOzicy8j3hq/KPhOGjZdHniv9ICAxdGr5U2Z2m3VKpY7pj5AO9FHce4XmB9vYxIVtnDNmIohlpdAS4xtnZEfMuVRMwCo1FVzpj/5grHgyZtNJtVVpsRVgS3yrMWB+oYUPrP+IFxOYK1YoV+JogCUmCUeUSc5WPOUco/zN6llYiBTTpzwwFEkNXyd90uAudMRHgOf3sklm7Z/T7aGoHfj1szU9Z6bInsjBDj6J4rAeq+tv5NWH0pHT0rDASi1VU/VuYE4DQvrn8Ut4oilojinRGEU+qcUs5lvup8HKcmx+PHXIHkU0cYf+bV6rje5zBxh3BjlkTh/fK9HLqgr2m7GJVWPTzdXMKISnQuUC/okuRJUqH7YC4vy0slJmSXALR4yanAWOXY7V/pZJXu0VZ4SdB4dse0hm6+DxUzLCF1g9WvKlcjyAR5dwfHlpPpBTayIwJ77XU1lKaUrijOSQCUWLxBhc0j8yBlVgGNao3yMAbL6WHN/TEhnEKh9hRKSs3VPzk2CZUxFYejXMydXurSv287Qf15bLOHCxq1mPlDP5HWlAN2vuRSYMX+ZDz8WJl/b9Xi1CyX6w5d7+CaRPQvw+PpbxVFGgGsRyObhHJEY6hXCqTUipGBfevpFA0d/aUVCimnBFagZxHPd1IncNXw0+8UIHveCe/kkazF2Y6lieh3wY4G52O+jEtACmqCer8cYZmB8CN/zZyXkRqhaW+Z+H0lZZZxg9ly683T0MSVeFscUFavLVb6Ze4y42jgUOPVsVwp9VIHrLXilYQXTwdIGiLFHa1AThOz2vhrurPxrhAkhHI8RG1G64EFCojun/Jd+yVXGFTdIOVR OFcWm/B/ 0PA68Syz7njICiZzSFSgWXo4FXLiAd0xgg2UVolRpHIzN/QWt33aZf7JjyE0ScJ2RD6kZHmrIgHsI/LaOD4CR0yjCnk2t5rdz72UepJ3iLevNkU3/uJIkbLg+Xc3rcaJQ+2+gtgB1ELEYH6te3mVFRvE7kLEb2V1u9WpnXenD4B/j3Zc4kHqV4KyYD8j+uz/viLpiyTxGh97FfPs/b3gc605YueqdKBxH2TN+w0rkeHQVwUthXLIgewQYpqpkR/WwwqjEfX+k6CbZPwE3NWEpMNYLc7aQevbhfXf7MyyMBz1yxJbcH2aYpmqpsfgeZfxtvufstF55gKfY+pY6Eo80hASsZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kairui, On Sun, Nov 19, 2023 at 11:48=E2=80=AFAM Kairui Song wro= te: > > From: Kairui Song > > No longer needed after we switched to per entry swap readhead policy. This is a behavior change patch, better separate out from clean up series for exposure and discussions. I think the idea is reasonable. The policy should be made on device level rather than system level. I saw Ying has some great feedback regarding readahead cross device boundaries. Chris