From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82A1FC4167D for ; Thu, 9 Nov 2023 01:08:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4BF66B024B; Wed, 8 Nov 2023 20:08:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DFB796B024C; Wed, 8 Nov 2023 20:08:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC3F36B024D; Wed, 8 Nov 2023 20:08:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BDF5C6B024B for ; Wed, 8 Nov 2023 20:08:39 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9A9DA409BF for ; Thu, 9 Nov 2023 01:08:39 +0000 (UTC) X-FDA: 81436630758.09.5D6269C Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) by imf30.hostedemail.com (Postfix) with ESMTP id E07A48001E for ; Thu, 9 Nov 2023 01:08:37 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kAwpRQlS; spf=pass (imf30.hostedemail.com: domain of amoorthy@google.com designates 209.85.161.44 as permitted sender) smtp.mailfrom=amoorthy@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699492117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7QtjMEn3JvZfL2+9Ot0aHfDjSbnUMOfTRHsLPFnN/cE=; b=1SAjP+v74YfoDInNi5VRNx4Y7nVAQxVbyLRWzcAU+VbuZEaHiBNaDEAiLc0gbwOY5UrHye sAqlAOTyoKPKucVkC8laKoaaB5Gq4f/ECpcC+WwdBXdvRhVljVvmcBQnzVNAn8RNQxp6xg nplcWUQj1cxBbkP9BcB2C1NKAFLxk6Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699492117; a=rsa-sha256; cv=none; b=lTkSnTBMEaiYVYMtDvl7fxriMWNnGk+62XeAc1138LknU3xwAVmXUHqg2a3G2NXO7+GGhK 8T/j4cvLBJC1DMuE9WqsrFm7V/wVtpS8Ym09MWidwaoFgslNsPm1q6HtT5KMH19CKCPb8Z nYrTN3Q/nmrkZi5D1pMxwtMXIsa5ErI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kAwpRQlS; spf=pass (imf30.hostedemail.com: domain of amoorthy@google.com designates 209.85.161.44 as permitted sender) smtp.mailfrom=amoorthy@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-587b1231dbeso165029eaf.3 for ; Wed, 08 Nov 2023 17:08:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699492117; x=1700096917; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7QtjMEn3JvZfL2+9Ot0aHfDjSbnUMOfTRHsLPFnN/cE=; b=kAwpRQlSmb251nh/Bz1sy1u7FMDMWncLMWs0dnmmX8KwZ/CvnReUJSl8FCaxX/rWI0 1ZuUGlDfCTJ12es5GTi7OiYynlYx4Zw+qeyorFTJ7OUIZR+8g+0Z5X+UlF4XvFz9HBwu Jfdgax+1x5Jb1Spav2CJm5wqjqWGF8paK2SIzoKQ690He4k2TVga7rGGaf6nwdgqgAX7 4qZyRTtpX/ZHFT0D7EJJrNQZdo8Qb5P3Hv+3VdjMBxF53STFUX8M7MgqA1CMowxWvSyf 2P0yKtJbvzoCYvl/PjAhp7iF1UunApTsQWK7G6OiswegH3C5gBj1q2OC/FXY1HLWrL77 iO9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699492117; x=1700096917; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7QtjMEn3JvZfL2+9Ot0aHfDjSbnUMOfTRHsLPFnN/cE=; b=f7k3PG2tiJQMgehCDl1RbYL5+UZO1kTs/fcKt5lNZMC7+z3kjyjxuVeSO5/rnMXT1W Bdkd0h9NQ1FPCocirHPdxQv5Y85XpvfOCgx58OJwzluO/3Fkx+qhq/5AptEEXDwtpYJ3 OgfE8MxqApg0ZrX1XQHwNzShrHb1D21e8iHQIjGqkIFup+mABye6cUGxeRAQkPtza2+u e3omC4Bq0jrYCu+Zl5PfmoAipFYCyPwG+lJcNOQWQAwsJ4kBs1vF03hn5a0VsLmPrDn8 n/CXn09YeNoFQioN0Djql/7RqXVG9D39Lo61iGeRGRD5a64NJHEhj1q3L+qwsuU1zJeY 35jQ== X-Gm-Message-State: AOJu0YwiduQigw++k+fgIhZCVdaRhwRZe4lL/jktUoV8naVzues9Sc1f YE1auKZqy8O9GfIyS5dFExgRetSJlIrnFdeVGF8fGQ== X-Google-Smtp-Source: AGHT+IFaOEA03XuxazKl3zVOaUpDe2bAHjHbEU9NUIQA9ZcNh5LArgqxcn+4MTtdSbfjNu4oRqbtO3sH2+Wygyf9VBk= X-Received: by 2002:a4a:e088:0:b0:587:873d:7e2c with SMTP id w8-20020a4ae088000000b00587873d7e2cmr3411182oos.1.1699492116891; Wed, 08 Nov 2023 17:08:36 -0800 (PST) MIME-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-35-pbonzini@redhat.com> In-Reply-To: <20231105163040.14904-35-pbonzini@redhat.com> From: Anish Moorthy Date: Wed, 8 Nov 2023 17:08:01 -0800 Message-ID: Subject: Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags To: Paolo Bonzini Cc: Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 5zsh4x18uaeejuos38frkfjd5dp4w8z5 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E07A48001E X-Rspam-User: X-HE-Tag: 1699492117-876521 X-HE-Meta: U2FsdGVkX1+Pz/4C3GuaOZkY5cP3Wo1IvtuPXUQ25ZwCPPRVJDy/c0Zha/uE0VPRl8PriLDD/nUBXL3YpK8nJ7TKX9g3XktSmPNcGZ3JM2pqKgDmQLD07ueb1bB9W0C++WKfue4RyQl2UPBwmHd4iAGlSmjY902QuCizhQZsAvBm8Fvs50yl+3mqd/SPqgflJuLKSJCUV3rzN/JcyfLCONjFR+9x9PBCKfjIHBwu/X7emrdO2mLAf+mGk0OlZQJ9Ol6x+OQUzLPW7DgV/9cvh0cLB+SCczDJRfI4TU5OQ5grsWWUZEsyMG0OOnlyaeyo+9DLuQdxeIlRFG6R27bKBYA8j4EZL8A6MRMWLRn19wlW6kZkqD/QejSgugfC2MVlayB4qJbrd2XmTds3YBMhjMwbO42H2/RRAUuB9GeJds0r4LHNtGEPyN6SJ/rp4OFbqvgEZ6tgzPwa55AvSJm3DbhbY2Tgx31TtJbbr8ym2iBonXZeSF8ExT/fKqTlLikYDS6/1tH9WMlBzlDbaEwlryq/MOragYVBOBGWvnD6UDlTMIVP61eJyNIzL+hfLC1wBkZxYZbVp8Q6ibrjkCcUwEs7egvvW3nMBJAyzZOrfFEuYd3zLuFZUNDTcGyDMg59KkTeQ3pFIU6asHn5N21Kk1Sa6QPoJQ4YM0F2DYL6c6p9bdwtKyf7FsC1U9RgWpH11+T021FuA8MJXS1al1ZuuhlEyx8roKXbBRJlK0Pj4DPfkfJmrVzlYElcG77aiUgN0zno1AMylq+6JaDo5xOuE1phSL/o6iL2llTltBQfDfjIUYRsMELQL4jzQ1MTCnp53npJRD0ZInlqw5ROOLusWnyGKICi+I2+BC35qX40mMj9fil/ebgIczRAnM7fke3siKSlRxIVV3qwoRogtVCRfKStVOIV40ebUWlljw3iJM/r4Zjrn+p2T9rNCfDFIDkLVJO8mEiTibN6YqH2Evq 2nik/J6p TxkVfi34nKbYKRBhlSCVMQvREzbjH2THjKNKrPCsjnpjiv1P+6il4DeKwWFy22i1F4Wbpsr+PKjIiQzFa7ZJ6J7CPIhgnxOVwsDgXqOREWdDrN+Oha4tMZq96XuS2Lt4J+MHWZPd4dyF6D+r614partHBIY/X77/DNHEGclrTHLxm7KLcw0Ki6ALeIwVAGFh+Kxjk3oDn6fFDTMqcRztKxUmzgCPAhzwWhESeQ548iiiOhBrPjLQTQRxLB15fQCyouPfCDMLgQYUWJ9C/PwHFcT7FXFUc/k2MuAJUBXG5e5UPQK6kB1d3/gfwTOxI10k8OU+t4TtdHaGbWNUPlyTkVWx2cRKFYkJCvsIWWjyWFx5NBFMrx3r0gH8G3/Zaha7sBDw+PYftJRt+4wEUr5WbNfv2FA+VdAG/Kvsgk4enIsj5oFY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Applying [1] and [2] reveals that this also breaks non-x86 builds- the MEM_REGION_GPA/SLOT definitions are guarded behind an #ifdef __x86_64__, while the usages introduced here aren't. Should On Sun, Nov 5, 2023 at 8:35=E2=80=AFAM Paolo Bonzini = wrote: > > + test_invalid_memory_region_flags(); be #ifdef'd, perhaps? I'm not quite sure what the intent is. Side note: I wasn't able to get [2] to apply by copy-pasting the diff and trying "git apply", and that was after checking out the relevant commit. Eventually I just did it manually. If anyone can successfully apply it, please let me know what you did so I can see what I was doing wrong :) [1] https://lore.kernel.org/kvm/20231108233723.3380042-1-amoorthy@google.co= m/ [2] https://lore.kernel.org/kvm/affca7a8-116e-4b0f-9edf-6cdc05ba65ca@redhat= .com/