From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 507C4C3DA4A for ; Fri, 16 Aug 2024 16:27:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B844D6B00D1; Fri, 16 Aug 2024 12:27:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B34236B00DE; Fri, 16 Aug 2024 12:27:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FC386B00DA; Fri, 16 Aug 2024 12:27:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 83C6D8D007E for ; Fri, 16 Aug 2024 12:27:41 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 225F414016D for ; Fri, 16 Aug 2024 16:27:41 +0000 (UTC) X-FDA: 82458639522.05.2B1D223 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf03.hostedemail.com (Postfix) with ESMTP id 53BE220017 for ; Fri, 16 Aug 2024 16:27:39 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=YgK4JMVr; spf=pass (imf03.hostedemail.com: domain of kinseyho@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=kinseyho@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723825586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A7WwxLAS0ZUy5wWtJOP42rw5b2Ueq8dEn+7WiJY79gY=; b=Ahk3fXFYhxCojvRBPyWG7lsiz19r78/ZKonR0jduE5bR/PEayAvlO5bono2Qv3nsDxKk7a kW6CHyUMrl7JBQm/FW7/q1kTeJzg5ehu3HTVQs1mtBLbthgxVsM7gJskytVMURNgnGfVwL IajA4rbCEDYMQ8FvPyKLCloEFPQTKE8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723825586; a=rsa-sha256; cv=none; b=f2AdBA8LjGVuDQdmCb06rBCSZEvjgivuK3fctzjgDS8F8SRucmzr6CHRDV7LC9kKvg0wvb 8LbWA2Udfk25y3WAI/7eRNAASOYJVvrEDGYPqqP5FMItD7h8FeyqZ0H5N/0blAiPGafkgN 6uZAANThh5wCed2VSKeA0ekXdmJZJC0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=YgK4JMVr; spf=pass (imf03.hostedemail.com: domain of kinseyho@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=kinseyho@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-65fe1239f12so21359447b3.0 for ; Fri, 16 Aug 2024 09:27:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723825658; x=1724430458; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=A7WwxLAS0ZUy5wWtJOP42rw5b2Ueq8dEn+7WiJY79gY=; b=YgK4JMVryuZVkgQNTaQIJK97YaQduR2PFUtSeYaXt+kMBtK4bjleyktC6TgHJfbyXg tefgaY+rxWm4oL+W4H0mVZtrWNsN6aEsjNVpDgathLq+9t2GJSEhAqUTDZfTvqqQ+yAt zg+BvkjnrKBGdsmmQSagYDTNCSIe2qqlyCG6rwAvG4mllJ2uqSVvjdhO3srjaO6nqNv6 zLMKMrJJYNSh71GOV6p823mmyRdUT+658DOvuTqnTo/uBdhKh6YP5BgA3+67JkIa7Jpo 7VkPv7IDw+I3Y9/PNpWLqMFCnfWQUgaI6Kc+EV2nVuYNallsRU2FqrkrLEnIZoHNh8Ck l1OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723825658; x=1724430458; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A7WwxLAS0ZUy5wWtJOP42rw5b2Ueq8dEn+7WiJY79gY=; b=AtpLUcP2mFcF/3s4vg+fjGKWgieII6xb5bGu+Ax6vK9oZT+PpeHFXRtYQs9D1uBzbK +Rtlr/Q2q/6iOb7TQWu3QmR46Iww68u0Q/QpBdAwE8/gFc+5cJn3e8hVtL+OAo0jV2/u M1mE9+femF9twMXGgc/14+PJpPrTDRm7kjnitXu1yGuccx3W+QgN8PqHejUDhKDr1xle gTqhgVXqyrXJ14oYDkUVb2CMXHB85byYlCkQw59P0eSJLu8gy03Y0PHnapUioYqjIsWb Jq5o1lIKLGLyTmq2Ue/nIxhvCZf17lVRm92lq7aWr6NMAtakMqCE3jr+oEDTKglfcH5v REUg== X-Forwarded-Encrypted: i=1; AJvYcCV+VU7as73rFWkkKr81TJYh/7iL70oMrqWN4I53np1Ned8B8ufsP26Vx2JYl15MscCUpLb9HQxIVi17H28bM769mBY= X-Gm-Message-State: AOJu0YyMlzUStM35VKfN0QqxJJLqUv3Ex+1OBDZpF0nI+0bq3EXDOco/ IyD2BaAkisgF7myFIUkHrEm8HZAE4tt1V/CNw8HCDZjSAS4qXzbZRLalU/NtjKA9VR61H8jHOee r36SJYrf3eN3FkO7T9Thl+jIsCNooo0suTbwH X-Google-Smtp-Source: AGHT+IFS42kfS4NEIV9e6Cd6qxnCl6eGj9iWg4DjB95brRzDynPcHRqhZmevD3bVnTKtacXx9wDPy2RuXbvwtewuVaM= X-Received: by 2002:a05:690c:3085:b0:647:e079:da73 with SMTP id 00721157ae682-6b1b7a6cbadmr33163627b3.10.1723825658162; Fri, 16 Aug 2024 09:27:38 -0700 (PDT) MIME-Version: 1.0 References: <20240813204716.842811-1-kinseyho@google.com> <20240813204716.842811-5-kinseyho@google.com> In-Reply-To: From: Kinsey Ho Date: Fri, 16 Aug 2024 12:27:27 -0400 Message-ID: Subject: Re: [PATCH mm-unstable v2 4/5] mm: restart if multiple traversals raced To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Yosry Ahmed , Roman Gushchin , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Tejun Heo , Zefan Li Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 53BE220017 X-Stat-Signature: rzga86z5dfjkj4faeyruc5146rp34fn8 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723825659-167046 X-HE-Meta: U2FsdGVkX19anvjuDXp+c7yu0OBA7NiQMx0816pGydQmFuUh6QcHiEXSdVgsoOqwSBfrjemasKQi0mHqPsFShUehluXue1q3U/TK3LZ24WrbRo7YcU+SZTV7HhHQeKcHFIhd29Pkb/LKQsTWfmYW4bDanolLL4MMtoZQM7G63hNB7+NdGqYHP2mFANgO11TZomNBC1ZFAmLaxp6TF5MoWuLx09sX8Levjxj0Q4xRlQOGJpcdYv4ylcgNWqMQSu/4g+waNyUKymFdYlGIbuFYTDIGTUzjTu5EMw3TVLGIuEoSZGhf42HBF4GOrxaPhlDe2L9wy9MiStIkJVVD7qSXLqrZolS1/Qy6Ouwk+bSk/l0L/QhTDHwx3VVKBSejh5RMZJEnkjNo04I+GTXUGjFSIfraRV8oFj5kSeMwiWvMR2PDmV2yImSl25Va5x4t2t1IuBLbkeiJ4AbeOHe/IJMvD5sqLnNfg3zNpG9D3ZJPG6pehmpmvB9HqF8hXueZYkPH363iyhHWFARKXhZgm2/HfwHm8zxh3K0WEQ8vreT1FNw3Oxa9SDja8e+1FIlOZXLWzMHjR9ctXQJOWMsINHTuDwSZAHHm3zkYfWOqVdXDcARojtE1USA8y7wEFVcHu//i4n0U4xk2mrhCE33cQmd7icsQhLtZxxgJUvQ1d7znJRIMnf7lhdSRKt1hYuReNTd83yYk0Wmo7uTNvkaFb0rxk+RKmz8x1zTVw8GrbI0tPzS+m08nnbbn9FgKq022mnswj69WYo815FFG/QkMJ/uDVDFaq0I/4GBF/LMkcd1NQrs9fZrTIibfJilsUJPQphR0mI2vzyiAiOnGiNHeOCOiI2PWCk12JFxbIJIlpF9124si/0+8J9luo7RdqUepL4PV8IonXM871Jj0+EDLaQpEPXPbGpAfnhz4P/nYbLOQyiL2tiRUpgpKM/CDUSI9IDawsiatAwxUfgvIZnMeio9 ZgPD3Tbf IfKtFxXt52jo8pZOqtvge7zLx6Emr6ZqgUdmJlWkfQvaGYQtSRfOFpBw/RL313FRnr2O++un5TQkYTkNLQzqM6FP3f8BnY4rdiF3B2jE5gvQ+sz7rq2BwHmrkq7IwD8lmMg7NwqBm7qVBLjpNKHuz5NudAy8bMmmuBAvAHFU/cegHdAk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Michal, > I may be missing (literal) context but I'd suggest not moving the memcg > assignment and leverage > if (memcg !=3D NULL) > css_put(memcg->css) > so that the is-root comparison needn't be repeated. I might also be misunderstanding you with respect to the is-root comparison =E2=80=93 the reason the memcg assignment is moved is because it= is possible that on the restart added in this patch, css could be NULL. In that case, memcg won't be assigned and could be left with a previous, invalid value. By moving the assignment out, it ensures that memcg is a valid value. Best, Kinsey