From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9568D597BE for ; Wed, 13 Nov 2024 00:19:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 372838D0003; Tue, 12 Nov 2024 19:19:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 320588D0001; Tue, 12 Nov 2024 19:19:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E8518D0003; Tue, 12 Nov 2024 19:19:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0122F8D0001 for ; Tue, 12 Nov 2024 19:19:54 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A104916069C for ; Wed, 13 Nov 2024 00:19:54 +0000 (UTC) X-FDA: 82779162018.19.82FA275 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf05.hostedemail.com (Postfix) with ESMTP id F054C100028 for ; Wed, 13 Nov 2024 00:18:32 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1PruVboR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of kinseyho@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=kinseyho@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731457105; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=syV3yYdAawmGgH9foa1REVrhWT3O13PH4ob3NUaHMYI=; b=uFAK29qaB6lwJV1jvcd3NE9ueSUfn4cm3F2SAbzf1fIyR8SRFrvpkxQxNb0d0h/DDGvi+d TvWmU+FiQYskU8eKxr2Yk5VcHMpL8/Atyi17K9okn+Tb3lbAQXH8eUCUPPaIOalJBP9nmY Tmf7ggx3Q0Lx+qwiOyvSvzfuWjLA4cU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1PruVboR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of kinseyho@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=kinseyho@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731457105; a=rsa-sha256; cv=none; b=WMxZ2opZTaGaaQORYlTzvNc7vNuRLCNsgkLDq/Iiu70l+zD5qYZqLFapGxd93xYk5sHXKd x9w+/PHNqd05qoHn2Q1JkuI/ctcALipJeDs+7HwjslPPyejFoXRL8FD/7MaoFYohOCOkhT MdU05qwJLQfIbN3a6gnipSvEBsyvkNA= Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-6eca7391be2so15540797b3.2 for ; Tue, 12 Nov 2024 16:19:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1731457192; x=1732061992; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=syV3yYdAawmGgH9foa1REVrhWT3O13PH4ob3NUaHMYI=; b=1PruVboRV1BbcLchoSsMvQmfqAXNvS3JC6k8bFPaTCYWXBnUDOG24IWGoAzRXQYNdc lGmQr6SF+HhJJ7DF/Q6jm2ov/JlyK9mkvnyPLD9re+hlfM+mg1qAifEOAEpOh3OPSDLK EY5Gys7R565UHqAQjG/o7Xh4O6l6Wl28/67+FOUBbHcqojlYMucVj71iJ28xeROWgozI VroLZ/9taWknrYO4IO8Px0AkD2tmZv1hAxWLvjxp2HkW6YVSNBBAf0Bf5a0LukB0jK9U 9S/9bWX4HACP4JddDBY4iBr/mB4MaExD4ONZvJ8ualChLCvZyM5qIV1jBDy/rIQm8j+b 9zUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731457192; x=1732061992; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=syV3yYdAawmGgH9foa1REVrhWT3O13PH4ob3NUaHMYI=; b=IJgJrfYlxhQW/R6JX3dUJzqXlLvzBB01jJoNnxQm2AFEP5V+pePLTPTc50qUChkFv9 5BAcbaGosLMF6S9exEU4P8ubyoPRW7cuoD5wW2udksKrlFvyy2vyEkC1cUYJQaf0MdA0 uDx1/iq4ZXGdU1MAD+hbP0CEOoh3GWTpMWaiidiPFI9t5siSy3XbhoCu8GRj5pocZAbx SwBdKZ7EX8Jg2G3omHvneZMTP24aLOjTGPp0lNN6m/3yHO7ODVzT6yxpbiC083WDfqvM ackUCzHeRie8nmp/LwaFMZpN8qxlOXpUtyZQgEjpxMRVCU9KqTFBakApWyKMWaE7YrjS 70Kg== X-Forwarded-Encrypted: i=1; AJvYcCVGHyWh3401pNpR4qJB0gzPg/pJfLOvcgxQfxzpv8h6r+g1aYWv18BQDpDxc5ZWPCidzcpSqWO+8Q==@kvack.org X-Gm-Message-State: AOJu0YzdEdvv3XlzuXAe785hWye3g1O4u2g8zlix7D6sjb4WhumnaYlX MiOVqN6M4qFgUDsVo9p0C67ZhyTCkyKLo2nV02RTS8qKrKa6ETo/hFCwI7aucCXnsNyNCYP3a2G 9krWkMRPvOWr6ExFe8yWgE7u7CVMsZzEnxRvm X-Google-Smtp-Source: AGHT+IGixxxDoJV0YMo0rwsoyhEldF96phuEv/rTRk4BAVR+x+HH2OZUws6MZb7CLu9ro/nwBiDd24leVC52cMq5E3U= X-Received: by 2002:a05:690c:744a:b0:6e3:1ce7:addd with SMTP id 00721157ae682-6eaddfc5cbcmr187848187b3.37.1731457191802; Tue, 12 Nov 2024 16:19:51 -0800 (PST) MIME-Version: 1.0 References: <20241031224551.1736113-1-kinseyho@google.com> <20241031160604.bcd5740390f05a01409b64f3@linux-foundation.org> In-Reply-To: <20241031160604.bcd5740390f05a01409b64f3@linux-foundation.org> From: Kinsey Ho Date: Tue, 12 Nov 2024 16:19:41 -0800 Message-ID: Subject: Re: [PATCH mm-unstable v1 0/2] Track pages allocated for struct To: Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Pasha Tatashin , David Rientjes , willy@infradead.org, Vlastimil Babka , David Hildenbrand , Joel Granados , Kaiyang Zhao , Sourav Panda , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F054C100028 X-Stat-Signature: hyriadjjrj34ewy4smskgpqx9fa6sub5 X-HE-Tag: 1731457112-589792 X-HE-Meta: U2FsdGVkX1+MMDlwfbHj4djZmawLb1OWLQkwsyZVTKsoO0g50AKRmskF6rQ28WscUViDnqa463RNfQ/SVhV3QaqRpgxJFofuOEWcG3My8+Lb/HeIHPKHUeq2ES9V8iDuhiw9WpVZLYtx+ESdDBfYczle+cB+ym58kLTFkSbW/7pFzxFW2NOq7ede676EEO2uWRdJe8tnTyoVZgZ7slhD4z7M5vD0GFjXPMXeJWX3mN65cvoun2dpE+r/95Gu4+15dUbmfvfeOzI2pfRhTBEtDxjIKljrXW6vDM0jAGFcW7UOl5N1sLEiMgEBGQD5Y1f4EYfn+GyhNHqDB05eKQ4/ysiwfRiZpBipUdYJJrPW4eLtOjesNQuiR+61PQSuI45mjm123Uz5FLix93zr2mlI/P/vp1o4eYP1Hi8Mtg6FeA8qTFN196wb/dtWCERWZ2UU5K1knZ3lBv978ud3dR+W1xB232cn5YenSiC805zzmL6YhupZkVDAeMi2LBD3YJPzACQ8UYhsDIX3ZSCB0QoNmwkQQhUQi6YSUu/IoUENRGnueCLUj+lsUcN3/XEl3+pfR6grgPTUUbGaCJgCXPg0+mlZK0kpSH04ti4MxMA8cekAnv9KiwNTI3/J1bd7C49cySOHac++CrbSsBmPaWOXT7a8zUgMnMoK1Vqn9c4q3xTakSMOGN0/jQ6hfnN1tAsQxw3UmFMBMxVYiL8B4UNYamVhAFp1Uahgx7XnmGoiFYThinF2m+Mj0P1Y4IdSzaIBb9WS9otkdZfCo+U1bF6OAA9MrMKhBT+pn78Pjy0aD/3RVZOy4kL7HsQhCKbs2YFX829pFFYqMQhL7WITv6J7vi/kKJg6MUAz96H3Qq8d871OrCvtvi+7fubee7ZQ0GEqp2GftN78lp/k/rgYPbzF5BMgnXjkp/nY8vmX1/3t8JYLuOPrCVcgJJETL4dQSZI+98gmvANrTF/vZMHB/7t M3vZW2JG LPQejLGIZ6jFGR1XfkLf6hQZ/gNrN1WyoKB/iiAEPIQ4830qZWLTPsZChufXTtu96S7MqHD614Jfm5P7X1bsbOf7Wr21InvbD585J63YyU5qiac3D948eY0rwl0e5CYSqhVsG7VKDrMrHbI1OH8wzRE/koEP1L8gKNAIqNNvNJEnRWlyziuwZdXHCg/usPyRixEYDQ1POI+l6PAJrd9n6QWDE4w5UmDrolIB/o/DJltbs/CV7uKgOvaYT0+qXOFvLWRqG3M3sNFkLbqh+61+1VDVYfw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew, Thank you for the review and comments! On Fri, Nov 1, 2024 at 6:57=E2=80=AFAM Andrew Morton wrote: > > hm. > > On Thu, 31 Oct 2024 22:45:49 +0000 Kinsey Ho wrote: > > > We noticed high overhead for pages allocated for struct swap_cgroup in > > our fleet. > > This is scanty. Please describe the problem further. In our fleet, we had machines with multiple large swap files configured, and we noticed that we hadn't accounted for the overhead from the pages allocated for struct swap_cgroup. In some cases, we saw a couple GiB of overhead from these pages, so this patchset's goal is to expose this overhead value for easier detection. > And: "the existing use case" is OK with a global counter, but what about > future use cases? > > And: what are the future use cases? As global counting already exists with memmap/memmap_boot pages, the introduction of a generic global counter interface was just to try and aggregate the global counting code when introducing another use case. However, since the value of pages allocated for swap_cgroup can be derived from /proc/swaps, it doesn't seem warranted that a new entry be added to vmstat. We've decided to drop this patchset. Thanks again!