From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFCAAC3DA64 for ; Thu, 1 Aug 2024 22:33:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFC936B007B; Thu, 1 Aug 2024 18:33:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BACF46B0083; Thu, 1 Aug 2024 18:33:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A744D6B0085; Thu, 1 Aug 2024 18:33:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8967D6B007B for ; Thu, 1 Aug 2024 18:33:07 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3DCA1A0B9C for ; Thu, 1 Aug 2024 22:33:07 +0000 (UTC) X-FDA: 82405128414.02.DF89153 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf08.hostedemail.com (Postfix) with ESMTP id 7FEC3160019 for ; Thu, 1 Aug 2024 22:33:05 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Em3XLR+K; spf=pass (imf08.hostedemail.com: domain of kinseyho@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=kinseyho@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722551527; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3/DCHf0Mi7MnHas1RBkJFo29zzAxPCVdB6sNJMKMnxI=; b=fwk9javiNxuUIqyDKqmuNB1TQnofVzNynMqhMMg9u8HhpI0Apjk9vFQU6KthqOdvrnxlJ5 /D86nmFhePBawvkh4Xrkvtaqcrn6rmh+UM2nERJXSAH11oP+C2pA09eBu9Q5aeiifGNyT7 oRIGC/kZ58aevdXO3MUJJyLUhLlxCaM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722551527; a=rsa-sha256; cv=none; b=Ecg+fYhhLL5udRTE85QBBYbHGlaSOvm8+iO0keJ1gmJsUR9B/KY7s38kMIJjoYJhrooWsM UtNDcLpClCAlHIz7yzsLCpucMBijZtyoY4THcBmNARAJy+UdTxPysDyNeVTWWRBxVFSVH/ 9bME0PsgEN/QKwtfl6s5yKhaoTAMAfc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Em3XLR+K; spf=pass (imf08.hostedemail.com: domain of kinseyho@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=kinseyho@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-44fdc70e695so1132171cf.0 for ; Thu, 01 Aug 2024 15:33:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1722551584; x=1723156384; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3/DCHf0Mi7MnHas1RBkJFo29zzAxPCVdB6sNJMKMnxI=; b=Em3XLR+KniOy9aLdYsr++nwYGLY5pPb5htAJJf8JpOmCBFfQClwd4yH8+bZMmiYpCL gTeC4ZdLiqzFI8QS6G0ERRMbvy6DnYeSgQohfmZKZJoNr2Ra9OOSZNqilf3SRoO4g+pR D439aAqzdBQ4DV8UMhKjJPjpzXXqzqOV4gFTnWItmrVoQFv/RiIWtrCvg6VWmczt5Xqn uSi1M7XsxeeQ1qRxDMBE6t2U88nr4MlWv43h7Cm/vCl0+Mf1QzRh5SRZ0pFRu+l5YCyd j2OKku6tVXHr1T9lWPb68QM3YVSNW289tcy9GhdNJXgaztbqY4EBOOaGxPx/rwJsDxHI AvvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722551584; x=1723156384; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3/DCHf0Mi7MnHas1RBkJFo29zzAxPCVdB6sNJMKMnxI=; b=MHwc91xnm67dKKJb6s7eq6DOUwg2uKTVKX3U93c/T+6o2sJxwANuhWFHBSRANm75bi ousTwajmcclBTB7XqQNiFY0nj4P5WIwRwPJHtONkKNOJxG3ahDqXsDpaJ9ffhCvLapQN GKkFMv4JBDRqisg9wd4dNnVtdSkeqR0KZ8PxGy6Jd+1b0PC2u+lOldzJWlUb7LiX3Oxj kYUqSZ1knC6coQCDVgN401aSTijyBM/ZIAQE3r8JbN+htDj7qUUBEDTnuyMK40sWEF5P Um+Dlj6UFVMzpn3FH6fxx4HQs4btffcuqBa6N0KjjQ2Cw7l1luSpfuCrj53tIlHCqLJj lYXQ== X-Forwarded-Encrypted: i=1; AJvYcCUlvfb8V9n7M6DdSnw7RYpymrPP3Z9gm4kyrvfhVZbTtJlnm0sVzm1B+YapVf8u/CoEU/SjAUxyZIsup4GrDk3Hj/s= X-Gm-Message-State: AOJu0YwFdGDWpGjb1PVoi3eHLfGonM0I+h8eBJRTCrFIdq4/9QegBqqc oEXAuf2DX6BnlP0nKMd+IP+diI/wBEplAaJBMtbCGsCtAIBgHiMJoTpzw4EtSARqR2IS+CafiT6 0Yr8LpJs3OCwBr6QpymUASe0V5LC+3FVcbWliqfaATwrFaUE5W5TZ X-Google-Smtp-Source: AGHT+IH4kx5BEHl2MYQeOJHqrPo3QiJWVFAMVijD+Yxbtszwwy+ECUOT8thV7bNlHDwKHQFEx5C6piS9XIci7cSVp8M= X-Received: by 2002:a05:622a:1388:b0:447:cebf:705 with SMTP id d75a77b69052e-4518c40a992mr555461cf.0.1722551584421; Thu, 01 Aug 2024 15:33:04 -0700 (PDT) MIME-Version: 1.0 References: <20240724190214.1108049-1-kinseyho@google.com> <20240724190214.1108049-2-kinseyho@google.com> <20240725204346.GA1702603@cmpxchg.org> In-Reply-To: From: Kinsey Ho Date: Thu, 1 Aug 2024 15:32:53 -0700 Message-ID: Subject: Re: [PATCH mm-unstable v1 1/4] mm: don't hold css->refcnt during traversal To: Yosry Ahmed Cc: Johannes Weiner , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Roman Gushchin Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: gqkg6xkiayw5w7fecz3dddgd3r1qajy1 X-Rspamd-Queue-Id: 7FEC3160019 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722551585-887857 X-HE-Meta: U2FsdGVkX18WYWx00Uy0t8jXEBo3yTxBYom/TPdh0oGp5VNdxqxOeQ2fmJz/DDVOQBpbmUrBt4Cn6/sK5XnPDKcN3qIO5Ac1mDXEx+lPET5HESWEs67hllyPmt36W85f2JEne0DO/FRvLJETJTg9BIUbAOtBP8fMchdhLE6/9YoE3ejGzX5GFR3i3iEJSAiNFak17+/IxUBSCnSX+q1r5Gjal3MmeoYWdzz6W4G4eT8kAMwWF5MYggCqkX4KP8lMC6JDd7NTH5qzcN5yJQVZyXlxHweCkDK1sME6+cq5OxvcNFkRYMlTyJ6vCOrLEg4CbdVckkcET2osQBpQZEwbw5MKiYDYM9qqSJvTa+iQOaWGXoRFcYCPvMxl/LP3LhTCofXAMF3ioLvwikLpaasQ4IFklpRINdBMiLf8W18eTxcKiKzd5rKD1x1pKQunVQeXYvNArgc4wQscgaFFT+J0KCTtnO+eEXOJhLrdbbDlQPf0IB6GhM2ZRFJ+TdOGutpcUma+HOtqSlz/QZb/6MTkmD+pmb3i9GcAaUotOWO5a3A15VGG+pBwAf2fiekl2c9rW9mmyzm0GAMuza5WH2PeXcR9SAKkrUitzTj3CI3Uvars8LQU1KAimVGCgFCPQKEiZlXTzHUE8ILa1DZZNQgnUb1/IJ70WoIkuvGn8W4aqhrQ4eMRmSQWxsUKzYR337WIAP707sZS7VAc1nMkiwzeiqRrgvI08dE13Y7Pj1HhNafcsVKTblxCU77sgMeFS1O73J//GyOIXscTKEShGYshCMclY1R1yC2DYfGFdAynuzyO5Eo7X52tCtQkCx99dbAzMM+n1GNPmF526TRmd9hl9tgwdt9mrPWJNlziKPSiwwlvAxpZnc2uAozAH0Vmv0hTzZUWe7HdDM/C7iJwqmZ7DUytsmBoqR1SB2LTLkU5yl3a2FpPvb8QX8myG3Aq36B+D9D2LE1lDhEEND3pNAy bH+1YmMw 2xc/XnPIJFzbuTZeDyerXbWwfVgVFIzJb0Lc+iyUG7T7+lbk3sQIQfiVTQPE0i/dhruCd2oi6kWCYC+PDaiWcsvkhETR6NG1mSoUr9yBbuzDhFg1yQdGIzwbxyuXOhU3R6grEt9CXZg+7Ov9sXUbcVrv5erPO5F+PrfRjygs8PfdydLa9IfOc9uupeapb8Fx35be/76OtG4LTRBp31CXFNkH4KQcLuW5IgzvYoh3MDNzchNw3vDovh3OE+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000079, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Sorry, I replied to this email earlier but it had some issues with plain text. Please ignore the first reply of mine (the one with HTML). I'm resending the email below. Thank you Johannes, Roman, and Yosry for reviewing this patch! On Thu, Jul 25, 2024 at 3:34 PM Yosry Ahmed wrote: > On Thu, Jul 25, 2024 at 1:43 PM Johannes Weiner wrote: > > What does this buy us? The tryget is cheap. > > mem_cgroup_iter() is not an easy function to follow, so I personally > appreciate the simplicity gains tbh. Yes, the main intention here was to simplify the code's readability. > This reads to me like it is intentional that RCU protection is enough > for @pos and @root, and that the sibling linkage is RCU protected by > design. Perhaps we could clarify this further (whether at > css_next_descendant_pre(), or above the definition of the linkage > members). Do we want to move forward with Yosry's suggestion to clarify that the sibling linkage is RCU-protected by design? Perhaps this clarification can be made in the definition of the linkage members so that the safety of the css in this function is more clear to users. If this is sufficient, I will make the change in a v2 patchset.