From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2CCCD12D7C for ; Mon, 11 Nov 2024 07:20:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38AFC6B007B; Mon, 11 Nov 2024 02:20:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 33B0D6B0083; Mon, 11 Nov 2024 02:20:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DBAA6B0085; Mon, 11 Nov 2024 02:20:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F25A66B007B for ; Mon, 11 Nov 2024 02:20:04 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 546A612171A for ; Mon, 11 Nov 2024 07:20:04 +0000 (UTC) X-FDA: 82772964204.05.8C5F2A7 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf05.hostedemail.com (Postfix) with ESMTP id A46F210000F for ; Mon, 11 Nov 2024 07:18:46 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="mcGGnw0/"; spf=pass (imf05.hostedemail.com: domain of gregsword0@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=gregsword0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731309411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WOmU+DqOTssuNxVDSw47mJh+RLlQKxt2hGA3wP7JifE=; b=c3qBifYYp79hpFIKJd22QepOeTDA/Ngsvi+lZe5l70Gi9mwQ0lbXuOdkzcPNVN3duaC5/b qic0kqYOF680Xa+/Vt8++wpxjzDSmBP72pMb9Ku3SSlm7skfH2WQC2PXVSpPSu3ZNIPqH+ Du9tyb9rl0kVd14KaZAN+PCPspb0J6M= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="mcGGnw0/"; spf=pass (imf05.hostedemail.com: domain of gregsword0@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=gregsword0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731309411; a=rsa-sha256; cv=none; b=rkG7JrmwKLtgO8muRTSqZRxOe7gzAFrilZ0foSGHBQAgaqRYUVKFjSCZ8wait9mgebkf2+ fkiBHXFB7zNabkcU3lPetTDcByst/hOnyaN0/wqgsXEyc5tOeluv2oLzQvqo/iHQr0MiFp wvGzmZlV8VKuQI8b7HY6gvgC2VuzpGk= Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-7f4324503d7so1829267a12.3 for ; Sun, 10 Nov 2024 23:20:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731309601; x=1731914401; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WOmU+DqOTssuNxVDSw47mJh+RLlQKxt2hGA3wP7JifE=; b=mcGGnw0/jjyfZX0VrenjeUkkwNPQmwpCAIsOaNIUGCiaktwpvP4SSBum+rKNKCPwV4 mcbLLYwBeLIeCjhVGSKMwnlNt3CD6WnwFRHH7NpU/tIN0xDG0qbw+cYl6fEIPeolIaW9 8cKushopSFhUBM27BhpahBEccSZ7noi/8DWjVrg3+3gO9k3xLqrhB8KJjLMuz0TujNIv Q4OMW2U0mV1WF/RwCAI8Z0wjLC9Cd2/HmTSymJbfJdvIl57VQBbm9s7J0FNi96bykbUH u+jBiU70DzqLU8hC55QQaiHqvqpYEiAVt7AZfRpfa15tvQ0LTrAijYrWLlmbvuJjqAUf bCDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731309601; x=1731914401; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WOmU+DqOTssuNxVDSw47mJh+RLlQKxt2hGA3wP7JifE=; b=CGsECYcy22FvZYNQjyYdx9T3od8IWRbcDw2MweVcyVMCmIsP4NHtjcvYhE5iVXA9Yf zviacinf3TPJJqlCyWGja+bzyQ5gXRe6Uda+8gD/Ymt2FwetRsVWqYIoLkmavmjtlg8E fOIKqItaG6ZoWQxynSdOtXw9tXRIhkZwR0Xk4TNpQLI9Hh7E0/A7FWCraDU8blqU3AED 9fGkW0E+70LEdZzHs5ZwEG8SB13jalAwa2JClXrvYga5Np+js2RzJOa65ngyTj0zcfgY WVbfqIWq700r8UsDr6x2D5nL4Mcg3L+FdFR1uel+XIXAAkVaYPq9iZlf6BnJKlGuDewL vOkg== X-Forwarded-Encrypted: i=1; AJvYcCU1W/YuXgS9w9qBUv0VyswocVh6mPzY+ZgCumXPt3mHI6XfL5qk1SR8te7IJ2ZDAl7YDOyqcrfbSg==@kvack.org X-Gm-Message-State: AOJu0Yz/nQ03K7m/AqR4+5swLMJUxHbDmboy+4W03ypGWZS3RBIgYtZ1 uk75sg42tIlGxG6E2znzOc21o3MSRcYM+UZVAit9eP1rd2/xil9lJrF4eV8R3RFJpDjO/7stEP3 8hn0l1wupa9LA4sApIMJsyfkeGN8= X-Google-Smtp-Source: AGHT+IE2GbhyhHM7VLZoUXFICAIpmggZuUxeUy9Xke7HCQ1ScZ37Bf1N00DNPtc+BrABfZWGfVXnr9FTBKVDLWlkvX0= X-Received: by 2002:a05:6a20:6a1c:b0:1d8:d880:2069 with SMTP id adf61e73a8af0-1dc228395camr18138782637.3.1731309601118; Sun, 10 Nov 2024 23:20:01 -0800 (PST) MIME-Version: 1.0 References: <9515f330b9615de92a1864ab46acbd95e32634b6.1730298502.git.leon@kernel.org> <5ea594b3-7451-4553-92c1-2590c8baef20@linux.dev> <20241111063932.GC23992@lst.de> In-Reply-To: <20241111063932.GC23992@lst.de> From: Greg Sword Date: Mon, 11 Nov 2024 15:19:48 +0800 Message-ID: Subject: Re: [PATCH v1 04/17] dma-mapping: Add check if IOVA can be used To: Christoph Hellwig Cc: Zhu Yanjun , Leon Romanovsky , Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Leon Romanovsky , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A46F210000F X-Stat-Signature: jio4byhy5pmodgtw56ch6d7zde3wxs9r X-Rspam-User: X-HE-Tag: 1731309526-25402 X-HE-Meta: U2FsdGVkX18FQB4U5viejRhvAEEniB1CjdyPes1esCGa2ryuD65XqXRYLsoew+2FkRC/nIHkPue7Pr20AZlOvZt80ZigoSkgUJmywwzh/6qk7xY5mwX36/s6NDVmGbv9AzC2Ks+lDx4NpQ+BWgdstZoq1yAV5pDozHBQYVPZa7aCuZZbthfmX6z+yRJOArmtMTS5sNZJPA8f6CEV0Ml9p6V5xLuab+N3OwUcqdN25hTHjcfwT+VlxCJZeTAc9z8874jD0Aozy0Wi2sO/IzGV4IXLky+JOCrLONzabZoQUQyD9oVqsvZg58jakEtyg47ZJ2g7yy+hnXIpq7qRuq162TK1gqHBeQrahZ0TwlTMiwgvfDdULbsBk0vEENJf8iylorkBwKnB8JUHiIrTMC05dPPByitts6KxWTLUhyXTJciJFHooguub24zbYJo6YHL2KK9/EexyZ5iVIVwe07mxEG6p+IcOFZC/k2Pdw6YquPGPBko24HsHIucRHI4qCpWCRzNHEMRKFCgYUM7A+BFGPJ9A14J5s4Et8WfUXvYlE8In2pH4a7NUhrp7qoINoS3PSToP+zQ2qlnJzEk9hDbtWnPmlXPdAglqV0Ft44jrr7qgljAdagW/8IIJcwGFI3Y6tquDM4ynxsIe6SG5+fVI2NT+9EkoFBRttGRR8brJznOvwVCALyNG/tTX2wl/fRutcTXroBy3IBlK4Ig5+uZ81MqYasPjnd5kDn6dNVKURQLQWpgETfxTqCFbIwX1g5WXtxA2dRa6kFSMrRU1zGKbXikobG4aUQmSd7+wzPgAB2gc8ZRrKrMnrD6YzBis6oAjYdBrEfKRd3+VDog56LwI11lBojAa2DoHKISPjSpo9crl0tQE59O6SH2zxNbgWACfZDfsJ37aceMPH1fADyclni3rWSr0kdzrHY/v3w49/BWvf6RaeuzfgqfM/lGR/LGhs8k+QAOfgXmNHR3USxj MrUItq+W xrGETqZ2EyE6HgwCHnfnJwz5QYCnpHe4slIij6M5pNjnq8jG+olX7QRNtNhQRMwrgUfioO/aOEVyOqPl7reD5Gm76Nw9ulqny5nrXRu/eOndOITSByH7Woxt/vtrrrrr3NOnWlazspUXzYq1ueYdYczaT/EyxFvWAmZMdzuZnyh/WoWj35s4MFjYPoTatLKW2kYMoAMej7H6Ul9qqRs+i2KDPF4fhrAxda2hxu5A7ZAHgjLxBM0vnNyR22q0CUjs8JA7XyE3TuXJtuPNOkq5aJC5T6uUxIHX5jOd0bevNTyUwtLLMzTSOVmQXm+WrVTmLk67x X-Bogosity: Ham, tests=bogofilter, spamicity=0.000075, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 11, 2024 at 2:39=E2=80=AFPM Christoph Hellwig wrot= e: > > On Sun, Nov 10, 2024 at 04:09:11PM +0100, Zhu Yanjun wrote: > >> + > >> +/* > >> + * Use the high bit to mark if we used swiotlb for one or more ranges= . > >> + */ > >> +#define DMA_IOVA_USE_SWIOTLB (1ULL << 63) > > > > A trivial problem. > > In the above macro, using BIT_ULL(63) is better? > > No, and can people please stop suggesting it? That macro is so fucking > pointless that it's revolting, Why do you hate this macro so much, have you considered the feelings of the macro author? > >