Re: [PATCH 7/8] vrange: Add method to purge volatile ranges

[Minchan Kim <minchan@kernel.org>]

Hello, Krzysztof

Thanks for the fix!
Just FYI,
I and John found many bugs and changed lots of code and will send it
to upstream, maybe end of this week or next week.

Thanks!

On Tue, Oct 1, 2013 at 11:00 PM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> Hi
>
> On śro, 2013-06-19 at 13:34 +0900, Minchan Kim wrote:
>> +int try_to_discard_one(struct vrange_root *vroot, struct page *page,
>> +                     struct vm_area_struct *vma, unsigned long addr)
>> +{
>> +     struct mm_struct *mm = vma->vm_mm;
>> +     pte_t *pte;
>> +     pte_t pteval;
>> +     spinlock_t *ptl;
>> +     int ret = 0;
>> +     bool present;
>> +
>> +     VM_BUG_ON(!PageLocked(page));
>> +
>> +     vrange_lock(vroot);
>> +     pte = vpage_check_address(page, mm, addr, &ptl);
>> +     if (!pte)
>> +             goto out;
>> +
>> +     if (vma->vm_flags & VM_LOCKED) {
>> +             pte_unmap_unlock(pte, ptl);
>> +             goto out;
>> +     }
>> +
>> +     present = pte_present(*pte);
>> +     flush_cache_page(vma, address, page_to_pfn(page));
>
> Compilation error during porting to ARM:
> s/address/addr
>
>
> Best regards,
> Krzysztof
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a hrefmailto:"dont@kvack.org"> email@kvack.org </a>



-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>