From: Bjorn Helgaas <bhelgaas@google.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
zwisler@kernel.org, vishal.l.verma@intel.com,
thomas.lendacky@amd.com,
Andrew Morton <akpm@linux-foundation.org>,
mhocko@suse.com, linux-nvdimm@lists.01.org, linux-mm@kvack.org,
Huang Ying <ying.huang@intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Borislav Petkov <bp@suse.de>,
baiyaowei@cmss.chinamobile.com, Takashi Iwai <tiwai@suse.de>,
Jerome Glisse <jglisse@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH 1/5] mm/resource: return real error codes from walk failures
Date: Fri, 25 Jan 2019 15:19:58 -0600 [thread overview]
Message-ID: <CAErSpo5pAQs-SJRKc-ie15zpSqf9FsPWnHeSpggU-EeZDg=AYQ@mail.gmail.com> (raw)
In-Reply-To: <4898e064-5298-6a82-83ea-23d16f3dfb3d@intel.com>
On Fri, Jan 25, 2019 at 3:10 PM Dave Hansen <dave.hansen@intel.com> wrote:
>
> On 1/25/19 1:02 PM, Bjorn Helgaas wrote:
> >> @@ -453,7 +453,7 @@ int walk_system_ram_range(unsigned long
> >> unsigned long flags;
> >> struct resource res;
> >> unsigned long pfn, end_pfn;
> >> - int ret = -1;
> >> + int ret = -EINVAL;
> > Can you either make a similar change to the powerpc version of
> > walk_system_ram_range() in arch/powerpc/mm/mem.c or explain why it's
> > not needed? It *seems* like we'd want both versions of
> > walk_system_ram_range() to behave similarly in this respect.
>
> Sure. A quick grep shows powerpc being the only other implementation.
> I'll just add this hunk:
>
> > diff -puN arch/powerpc/mm/mem.c~memory-hotplug-walk_system_ram_range-returns-neg-1 arch/powerpc/mm/mem.c
> > --- a/arch/powerpc/mm/mem.c~memory-hotplug-walk_system_ram_range-returns-neg-1 2019-01-25 12:57:00.000004446 -0800
> > +++ b/arch/powerpc/mm/mem.c 2019-01-25 12:58:13.215004263 -0800
> > @@ -188,7 +188,7 @@ walk_system_ram_range(unsigned long star
> > struct memblock_region *reg;
> > unsigned long end_pfn = start_pfn + nr_pages;
> > unsigned long tstart, tend;
> > - int ret = -1;
> > + int ret = -EINVAL;
>
> I'll also dust off the ol' cross-compiler and make sure I didn't
> fat-finger anything.
Sounds good. Then add my
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
next prev parent reply other threads:[~2019-01-25 21:20 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 23:14 [PATCH 0/5] [v4] Allow persistent memory to be used like normal RAM Dave Hansen
2019-01-24 23:14 ` Dave Hansen
2019-01-24 23:14 ` [PATCH 1/5] mm/resource: return real error codes from walk failures Dave Hansen
2019-01-24 23:14 ` Dave Hansen
2019-01-25 21:02 ` Bjorn Helgaas
2019-01-25 21:02 ` Bjorn Helgaas
2019-01-25 21:09 ` Dave Hansen
2019-01-25 21:19 ` Bjorn Helgaas [this message]
2019-01-25 21:19 ` Bjorn Helgaas
2019-01-29 1:18 ` Michael Ellerman
2019-01-24 23:14 ` [PATCH 2/5] mm/resource: move HMM pr_debug() deeper into resource code Dave Hansen
2019-01-24 23:14 ` Dave Hansen
2019-01-25 19:07 ` Jerome Glisse
2019-01-25 21:18 ` Bjorn Helgaas
2019-01-25 21:18 ` Bjorn Helgaas
2019-01-25 21:24 ` Dave Hansen
2019-01-29 1:34 ` Michael Ellerman
2019-01-24 23:14 ` [PATCH 3/5] mm/memory-hotplug: allow memory resources to be children Dave Hansen
2019-01-24 23:14 ` Dave Hansen
2019-01-24 23:14 ` [PATCH 4/5] dax/kmem: let walk_system_ram_range() search child resources Dave Hansen
2019-01-24 23:14 ` Dave Hansen
2019-01-24 23:14 ` [PATCH 5/5] dax: "Hotplug" persistent memory for use like normal RAM Dave Hansen
2019-01-24 23:14 ` Dave Hansen
2019-01-25 6:13 ` Jane Chu
2019-01-25 6:27 ` Dan Williams
2019-01-25 6:27 ` Dan Williams
2019-01-25 8:20 ` Du, Fan
2019-01-25 17:18 ` Dan Williams
2019-01-25 18:20 ` Verma, Vishal L
2019-01-25 19:10 ` Jane Chu
2019-01-25 19:15 ` Dan Williams
2019-01-25 19:15 ` Dan Williams
2019-01-25 23:30 ` Jane Chu
2019-01-28 9:25 ` Michal Hocko
2019-01-28 16:34 ` Dan Williams
2019-01-28 16:34 ` Dan Williams
2019-02-09 11:00 ` Brice Goglin
2019-02-11 16:22 ` Dave Hansen
2019-02-12 19:59 ` Brice Goglin
2019-02-13 0:30 ` Dan Williams
2019-02-13 8:12 ` Brice Goglin
2019-02-13 8:24 ` Dan Williams
2019-02-13 8:43 ` Brice Goglin
2019-02-13 13:06 ` Brice Goglin
2019-02-13 16:19 ` Dan Williams
2019-01-25 19:08 ` [PATCH 0/5] [v4] Allow persistent memory to be used " Jerome Glisse
2019-01-28 11:09 ` Balbir Singh
2019-01-28 16:50 ` Dave Hansen
2019-01-28 16:50 ` Dave Hansen
2019-02-25 18:57 [PATCH 0/5] [v5] " Dave Hansen
2019-02-25 18:57 ` [PATCH 1/5] mm/resource: return real error codes from walk failures Dave Hansen
2019-02-26 7:41 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAErSpo5pAQs-SJRKc-ie15zpSqf9FsPWnHeSpggU-EeZDg=AYQ@mail.gmail.com' \
--to=bhelgaas@google.com \
--cc=akpm@linux-foundation.org \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=benh@kernel.crashing.org \
--cc=bp@suse.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=fengguang.wu@intel.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=thomas.lendacky@amd.com \
--cc=tiwai@suse.de \
--cc=vishal.l.verma@intel.com \
--cc=ying.huang@intel.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox