From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx166.postini.com [74.125.245.166]) by kanga.kvack.org (Postfix) with SMTP id E720A6B0005 for ; Thu, 7 Mar 2013 07:55:32 -0500 (EST) Received: by mail-wg0-f42.google.com with SMTP id 12so6559340wgh.5 for ; Thu, 07 Mar 2013 04:55:31 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1362393975-22533-1-git-send-email-claudiu.ghioc@gmail.com> References: <1362393975-22533-1-git-send-email-claudiu.ghioc@gmail.com> Date: Thu, 7 Mar 2013 14:55:25 +0200 Message-ID: Subject: Re: [PATCH] hugetlb: fix sparse warning for hugetlb_register_node From: Daniel Baluta Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Claudiu Ghioc , trivial@kernel.org, jkosina@suse.cz Cc: akpm@linux-foundation.org, mhocko@suse.cz, aneesh.kumar@linux.vnet.ibm.com, dhillf@gmail.com, kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Claudiu Ghioc On Mon, Mar 4, 2013 at 12:46 PM, Claudiu Ghioc wrote: > Removed the following sparse warnings: > * mm/hugetlb.c:1764:6: warning: symbol > 'hugetlb_unregister_node' was not declared. > Should it be static? > * mm/hugetlb.c:1808:6: warning: symbol > 'hugetlb_register_node' was not declared. > Should it be static? > > Signed-off-by: Claudiu Ghioc > --- > mm/hugetlb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 0a0be33..c65a8a5 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1761,7 +1761,7 @@ static struct hstate *kobj_to_node_hstate(struct kobject *kobj, int *nidp) > * Unregister hstate attributes from a single node device. > * No-op if no hstate attributes attached. > */ > -void hugetlb_unregister_node(struct node *node) > +static void hugetlb_unregister_node(struct node *node) > { > struct hstate *h; > struct node_hstate *nhs = &node_hstates[node->dev.id]; > @@ -1805,7 +1805,7 @@ static void hugetlb_unregister_all_nodes(void) > * Register hstate attributes for a single node device. > * No-op if attributes already registered. > */ > -void hugetlb_register_node(struct node *node) > +static void hugetlb_register_node(struct node *node) > { > struct hstate *h; > struct node_hstate *nhs = &node_hstates[node->dev.id]; > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ Hi Jiri, Can you pick this up via trivial tree? thanks, Daniel. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org