From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E6FAC369AB for ; Thu, 24 Apr 2025 15:44:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 240216B00A9; Thu, 24 Apr 2025 11:44:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EE9D6B00C0; Thu, 24 Apr 2025 11:44:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 090E86B00C7; Thu, 24 Apr 2025 11:44:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D7A116B00A9 for ; Thu, 24 Apr 2025 11:44:09 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3710E5E09E for ; Thu, 24 Apr 2025 15:44:11 +0000 (UTC) X-FDA: 83369358702.20.F5B0DA1 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf11.hostedemail.com (Postfix) with ESMTP id 5B92740005 for ; Thu, 24 Apr 2025 15:44:09 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VAosN10D; spf=pass (imf11.hostedemail.com: domain of stephen.smalley.work@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=stephen.smalley.work@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745509449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NKYBJGRW3NLditWJHCd6B3AWhUotnr3wjlWIP9wQJYg=; b=RKa1iwFkvIPXk+7+wYw0IsWz4rANUpQ82FGQV3p+yBGIfGbbGG0XW++RnQ6lLsbtVuDy9W i+Gg2w4dJ9qtTMuEF0v5rJks8Xx/tTud6XXaPw943Ni8ZAlaKbsCvhXkzqxQpQknPdRiJw XIjrhA5PA5Hlo24PCjT1JIFvjGnXehI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VAosN10D; spf=pass (imf11.hostedemail.com: domain of stephen.smalley.work@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=stephen.smalley.work@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745509449; a=rsa-sha256; cv=none; b=8HgLCqn3E3ySUJyy1vSPpvIvZZACtJFjHyR8Ltyy0766womqefgQxFQUsySHc5ISyUxL9o wKDNRYC+QjIGsFW6uAFDwlr3DTpcOXW9JHoiRPPOhfM7s8jKlIgXcFz/wVVpwQXTd29DR9 sL6w/7kcWN8tbEF5yvKF9Ux6RGSDoTg= Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-b09c090c97eso781716a12.1 for ; Thu, 24 Apr 2025 08:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745509448; x=1746114248; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NKYBJGRW3NLditWJHCd6B3AWhUotnr3wjlWIP9wQJYg=; b=VAosN10DXKhLmVXZADk+dI28VEHTKhP55LY4cX2HuCxn3BQRMwVjcaZZn4HGvOf31w GuOo8DhY6hP4g/tke9dTbTe34kTG7rXYi2khR2kyGF7igELUrrfrXPCepPDjNOW8Svff cdV1fkvHdjpAu4tnWG+ZHrUBSYgOyx28sHLFfsoD8tNZcG9AHVoImDyV/a+tZClIE0ld 0lMWsMKcT+GzhFyxHmxuPi8kha4hDbMSsWs0S8R6FTnSzcmkdEzTcanoOxyvTNonpP08 mICFqjVGlsRNQLmPJvH4yn6uwj6zNdgwcYf6GiNJbjGwwgYAcJxf/4f6Z3qMMu3+bN8p 8eAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745509448; x=1746114248; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NKYBJGRW3NLditWJHCd6B3AWhUotnr3wjlWIP9wQJYg=; b=qoY/eiPKaVVSVS1vyaSfoiBaeGtZLs/DZl1FroItmd1eKJ9Ex2G+76q5ddlF2TDUQx AAAkKHhEvPTCXAhjyh91WvyfARE8uDyUFQoF+OfBrjs+wmrtZK62ABn8pBCxoLj5BqN2 ei2/4dW6Xay67TPls0MAUImHy7oV7X5N1WtIXV6nWTOAWzwIIUTgzIvSXioqPEtivdjj AwkSqLXClbQ3fx7u7HOvelIZYAh5qW6SzTkngIoVDJ3DI+Uyyvs4PJ2SkiRkVUW3GLzB FdKJ7e0BK8/mwQk6I4Bbar/j7CtqLVy7d881Txt9IqNjQpcotYZXNojE28zTSRJCQRSD 6CYw== X-Forwarded-Encrypted: i=1; AJvYcCUVD3vuQtNZJfs+m6gDgmd+Jc1MjKUBTWrGVpKSsbFzHn4CSBSGRsDcvYmv7m9rlcQ235ZHZD6ziQ==@kvack.org X-Gm-Message-State: AOJu0Yww+JZkMQkVqoFqzNPob4K/eLzL1Lzvj5OwQpGqRhk0xHbMSoZ8 qZqNqTTsmf2IJkbuv2ZjIOom7Qhtd8Ew3vRCbyLoyjImGdPalE0iVsgJlG8NbcT4P9+p0PeJw6C La340GFPvQ82mAPPJgeOTPb0cxxU= X-Gm-Gg: ASbGnctEKnuE99UXAs9Jsi1v0A3as5OaCfHQWaV59asxX4KY6lZ7UBsm2VbnLCgoMsI Qr0U71PoLVA0aFOVll5YQS8kkG53/y/+Rz5lJFqvlNleoqOczzY7bWtMMf4pXMKmyatIS614qIW jhS55xaCi0EldoKlOM17JDnchtQT5/MGZO X-Google-Smtp-Source: AGHT+IExkOfI5k5BNcG7WP0dv3ff3ZjZnNG+ANJn4rp1JjEbkTgLNnWinqdWCZ12YxP21dwWCmISmEhEEildeIz1PSs= X-Received: by 2002:a17:90b:1f90:b0:2ee:aed2:c15c with SMTP id 98e67ed59e1d1-309ed3521b0mr4687662a91.28.1745509448048; Thu, 24 Apr 2025 08:44:08 -0700 (PDT) MIME-Version: 1.0 References: <20250424124644.4413-1-stephen.smalley.work@gmail.com> <2025042427-hardship-captive-4d7b@gregkh> In-Reply-To: From: Stephen Smalley Date: Thu, 24 Apr 2025 11:43:57 -0400 X-Gm-Features: ATxdqUFYwUVwbOLgKuPMj0VkvJRIPCYIatOOHAVWcZMu6tTjFJjA7nGJQgros6k Message-ID: Subject: Re: [PATCH] vfs,shmem,kernfs: fix listxattr to include security.* xattrs To: Greg Kroah-Hartman Cc: paul@paul-moore.com, omosnace@redhat.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, Tejun Heo , Alexander Viro , Christian Brauner , Jan Kara , Hugh Dickins , Baolin Wang , Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 1gk97a64jpxifnmx7k49xe97b3kpd5n6 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5B92740005 X-Rspam-User: X-HE-Tag: 1745509449-248128 X-HE-Meta: U2FsdGVkX1/mCZ211K9OQcOUBguJxp9zMtJsvIW2nHdAZTGMrn5EcjcvVTPqkES+oG6U3oFL5r7R4tdgixt5jfmfAbc9n3NYK9Gfsvs0Fb8brlnacQXPrdHf29mCu+pWiku4fPN1gTU0os3RmELtbiWiS/es+bB80/ALg4PYQQjT/lZ9WnZoXFie78dk6tVM+Rz7NfkPBhO27FgZBk6KKF4sD8ybHEPSzg2FBomOluZZjLKedrb8BK/Nw3twPTcYXdyqvfTBOvzM+eh+FhChqJd8eVnQVtO56QZAl9io+XHSStHJIPPJx1WyO76JNaCCsuMEVTE+ATFN0bxVOgmLJHHcUKcG86xxj4eSB54iNHX5Br+gUhH8ZGLDLJKTLN3LoHOmgp4wrq8ump3ifAgLAZXCl+CKtLDMikh2BYELtfEtceBtV3dMtWBz7r0Wc9O3N1/Ht1IOvWY1r5JRohmV2dadLV/uM/eFoFWpiIV78Qx91is3qqNAqcXaCHWBPs+d5sYgCA6+X0J2+/EiiKLYl/YwrwpUpLfML5qwDGkK3o4z4fL+SWcE+QwS/80e76ici2JlPOTNNgmZEMLa7cddZ4dZ+b3JmV/mzyMMoxf4TvxNtkcfgp5Xcxn4E+ftp579YIH0i6MaYqM93hYyhawajk7WuKW5gIv5AZsLjpiTYxzA/42HLIMvbpkF2+Ku0QvPJXueBf8/EYzLN0yIxJco+EjTsDyIKX2Vzkrj5/AFKGpmlPu8U72YppBxQQk/7Rapk86/0B/xX5Tju6C/bewKRdW9drbwT1LbLct3KStlaV+xrB27vERGf9q6PoR6PA/BdVZ62NGEwKemnINzbAn8ECCqJ7+frGDuhayYqu6aB7kMd1/4zvySCC7qiVZgymd+rY15WGI1P3+yfmkBLgzuZK262xrGSHtD3gi0IE/XQz2mgjFebPOEsl3HIswvM3gcEZNRAPP+qOT8VVg+oYY Xaw7/fD3 eQyItnSY5WnWhccTgoZ0EOZNhR2DGkYLs9QD7ox1HWhDBgC4Qcw8nkc/sohP3X7KTUuc/T1qoovZc2i2PhnhepV+3uxvUjyURUk5AchGER3Xji17sMa2ivAlNEhjXQ38nbxM5Z7tv8RtJAbxc9xYCU6YBwafmlY7kKHKxadUU8I4TKJ641bwbinWHZMice9P9R8sk6242geH+/2VD+TpqxkEY9FoL+Mliei99kLAQGi8jICUCo0VmGLbm6l7eC+uWNiFxxSJXK9O8FTrStMnpg/kzlH4GnySTlDxZ0MQ6SjwJNxfyp73B5Y3/WPt02iG467bktkPYcZhqHxsp0GSHr0G9ctnnfbZmiPldrat4fY6Z2aj3bYiBQ+FYXAsjfwQs+hbBqAVgAfsT4Dj7KfAVcWxV4yVHxlydDUAqnONVQhnhf9Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 24, 2025 at 10:55=E2=80=AFAM Stephen Smalley wrote: > > On Thu, Apr 24, 2025 at 9:53=E2=80=AFAM Stephen Smalley > wrote: > > > > On Thu, Apr 24, 2025 at 9:12=E2=80=AFAM Greg Kroah-Hartman > > wrote: > > > > > > On Thu, Apr 24, 2025 at 08:46:43AM -0400, Stephen Smalley wrote: > > > > The vfs has long had a fallback to obtain the security.* xattrs fro= m the > > > > LSM when the filesystem does not implement its own listxattr, but > > > > shmem/tmpfs and kernfs later gained their own xattr handlers to sup= port > > > > other xattrs. Unfortunately, as a side effect, tmpfs and kernfs-bas= ed > > > > filesystems like sysfs no longer return the synthetic security.* xa= ttr > > > > names via listxattr unless they are explicitly set by userspace or > > > > initially set upon inode creation after policy load. coreutils has > > > > recently switched from unconditionally invoking getxattr for securi= ty.* > > > > for ls -Z via libselinux to only doing so if listxattr returns the = xattr > > > > name, breaking ls -Z of such inodes. > > > > > > > > Before: > > > > $ getfattr -m.* /run/initramfs > > > > > > > > $ getfattr -m.* /sys/kernel/fscaps > > > > > > > > > > > > After: > > > > $ getfattr -m.* /run/initramfs > > > > security.selinux > > > > $ getfattr -m.* /sys/kernel/fscaps > > > > security.selinux > > > > > > > > Link: https://lore.kernel.org/selinux/CAFqZXNtF8wDyQajPCdGn=3DiOawX= 4y77ph0EcfcqcUUj+T87FKyA@mail.gmail.com/ > > > > Link: https://lore.kernel.org/selinux/20250423175728.3185-2-stephen= .smalley.work@gmail.com/ > > > > Signed-off-by: Stephen Smalley > > > > > > As this "changed" in the past, shouldn't it have a "Fixes:" tag? > > > > Yes, I'll add that on v2. Also appears that it doesn't quite correctly > > handle the case where listxattr() is called with size =3D=3D 0 to probe > > for the required size. > > And doesn't correctly handle the case where the list size exceeds the > original buffer size. On second look, this can be done more simply and > safely in simple_xattr_list() itself, avoiding the need to modify > shmem/tmpfs and kernfs. I'll submit an updated patch. Submitted here, https://lore.kernel.org/selinux/20250424152822.2719-1-stephen.smalley.work@= gmail.com/ Sorry I forgot the Fixes tag again but added it in a reply.