From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9D87CD4F4C for ; Mon, 9 Sep 2024 01:08:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2308D6B00F5; Sun, 8 Sep 2024 21:08:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E0CA6B00F6; Sun, 8 Sep 2024 21:08:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 081A16B00F7; Sun, 8 Sep 2024 21:08:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DDB3E6B00F5 for ; Sun, 8 Sep 2024 21:08:54 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6597FC0497 for ; Mon, 9 Sep 2024 01:08:54 +0000 (UTC) X-FDA: 82543415388.07.BBD58FF Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf25.hostedemail.com (Postfix) with ESMTP id A5FFDA000B for ; Mon, 9 Sep 2024 01:08:52 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=f0AmpC6S; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725844020; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aKNbVeIN4E1J7b6asuuyRn99aGJZxDfyfdXFbSw1yAU=; b=JZcMstJwc/MCjTZs9YiH+B2VI3cWbvDsJWr/gdBvXi7oZkVoZzw2BY8DYE6Uz7jYZ6AFSa J7NKjzwgNojD7Pq3r/Ubrlr0ePRxGSY8OzanfxNJ5qlsIrqr91T3jXiJCflZqB+WtEYSRd mIjvUhmlIK4wzvhuGQsJ2fQps46HTrs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725844020; a=rsa-sha256; cv=none; b=sttoMEO9ZlZiQ6jmkD2B2KovMVfqhkAAAGNbjkc+mNSvsIpNB+5jc97cGahtOleuzpIv/W SzyucA0cyyBn44NIPbbr+alZ57at9UE4NQFhPXuJfogxCt6ehbSa4JJ2Va71ZMO3YYrEWa iHOP+2yIi9RsdEQ930pA1spOJASJyCY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=f0AmpC6S; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2d89dbb60bdso2571778a91.1 for ; Sun, 08 Sep 2024 18:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725844131; x=1726448931; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aKNbVeIN4E1J7b6asuuyRn99aGJZxDfyfdXFbSw1yAU=; b=f0AmpC6SJXyQyGt8YIJJiN+m9y+g0SrRxs1rA3Dw7SsIh6uWDvJjtqNbHrq7VKD35A gNe9KPg7aHCIfFPiAywHc/YdQ+kk62Czf5cL7MgMb7AtZH9TV5tVKpz2NWVnVBwUcFUz polg8q4B4KljhyusfGLjfKNuoabKettj8BNIcwfUhK3ptdL3LuiLxkV7ujbKlKUl0GAc /E3ZjqdeTji6QGasR0DR/fEHl26ATSwetfIcvwBFWNdtMnUeEVclkaH+SS3yBrnLLrpW k61I96WflNICSYxRbDfdvKYWSPzHZtlDFEqCGRxAtof6/OO9Gxe9hlifJsxa6EidLphC rXJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725844131; x=1726448931; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aKNbVeIN4E1J7b6asuuyRn99aGJZxDfyfdXFbSw1yAU=; b=kALPrCP1A0bTHCv1pfgTbGGJRR5+acRbLmHwWEUzH2/tP8er19V7PD1v4xdGTPE74T jz+JvFuwlP1tgGc55yh15mhLHyMxp3UlzlJoeiYirrL52LgyUKyGU78sXJlJ72Nox+KR 96ZjN+Os4N/ZpGseKnWhxTlgyPTzGlH8ZH+0J34D0uj7WIacPsGVIjI/+y4BAHjdKfNj sHIjHBVnRxAc/tIe4zbrioycBQ72d99/hSd608J/vGeS9KP5TAJuLFSN2UAfXB1sAUjX ZpWPk01pf88PutetBlHGHsF1uMcmNVJsjtI1i94Tc4HnZ8asRFRtSKtIpSvJ/QKigl75 N3wQ== X-Forwarded-Encrypted: i=1; AJvYcCWu2JoMG09jLnbXdipfXm/nlnMw2yk03X/s3t/xsi83sF2X96umNpcdnZlazQdaCUBVL4TUAWM3fw==@kvack.org X-Gm-Message-State: AOJu0YwukKb3F/yScQbhA6aMQziJfh807CLzG4dpy/3ldK7LDRqy8VNP csZkEinZQo+kEpu8HWItr250Oez1yCPW/Yv4pRASbiJalE7rtZ0ualNbtw2vJz30teWXMgAGSRl YMoKZ6Sj/k3jK9W66GXd3vqtT0zs= X-Google-Smtp-Source: AGHT+IHviyd+MztZHLZ1PONgr8WHid8/FvS/G7KWLzX3Evvawum9LD2znLZsH3oJJGDbwpitRHcujJMf5zch9B8SpsI= X-Received: by 2002:a17:90b:3504:b0:2d8:d254:6cdd with SMTP id 98e67ed59e1d1-2daffe28fadmr7420121a91.38.1725844131190; Sun, 08 Sep 2024 18:08:51 -0700 (PDT) MIME-Version: 1.0 References: <20240906051205.530219-1-andrii@kernel.org> <20240906051205.530219-3-andrii@kernel.org> In-Reply-To: From: Andrii Nakryiko Date: Sun, 8 Sep 2024 18:08:39 -0700 Message-ID: Subject: Re: [PATCH 2/2] uprobes: add speculative lockless VMA-to-inode-to-uprobe resolution To: "Liam R. Howlett" , Andrii Nakryiko , linux-trace-kernel@vger.kernel.org, peterz@infradead.org, oleg@redhat.com, rostedt@goodmis.org, mhiramat@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, paulmck@kernel.org, willy@infradead.org, surenb@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, mjguzik@gmail.com, brauner@kernel.org, jannh@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A5FFDA000B X-Stat-Signature: qqqcrq1g7d3j1qhiumkshwpbob56mx44 X-Rspam-User: X-HE-Tag: 1725844132-91706 X-HE-Meta: U2FsdGVkX1/PvCKhEeZzCgo0PJlOBo6QR20mn+iZ8m5pLEQX11fvrRWvhR78qZy4q82HAnMK541J+iFWqYpIV/f/Y6ICCOjHHFwsdkZkLzIXAK+4i56Ukq4VkHVCe+dIuMVkifZ65lVFTtbcLayFEgubzGQE33HwXeOEBYZihnwieqzyuhtTZPwkkWlkkSL3QCP3+ekr+f3Q4FYNB91U0+PtKhskN5H4If2EqTfHuRN9Xujf921BtKh3ee4cg0724bOH3KE8uFc1OABeG0wKSMZorDvmLUDIoquRQfDgR/pS1qBXGcdT7nt9nKavZqySlGup4uyIB2n9u6afNymXHPmM0yCPLlBKCBKDsAQz1vEYg7JABW3GTUDGV3puGh1eUs6nT5hznWsyHVi6q6ayjBZxAfGTh8gtKJpvPbl06hySbXsFhrVTnuvApo/D3tPm27ehhhbXRrXSqIbOM7gCJAS7amXau7Nq7ZtsFHpcz4GD1tpO8H+Y6ysh2nr8mio+AMuzjXJg4Th39E/r2DxKoRigDtjWv+AnpWIuXIeE+LxoC++Mxwu5V8E7iB+oF5to1v8vQo+mqB6a4oePdziZKzg4nmKUpz197WpF1c7nUxX4xAYKzGxsJpQvse6HCHM+EJGk/QZxl0NkAT/KYS7VPq16k4Mgx9b/JihQXpIitdj+SVsoLT6CEPjPbCEdEHliN/yblFY7tN92+cleEj4bHaGNzIirP0ey9oH7q2E5nR6PSP0KzYbB0hK0ir7G9AxIXfWSF/8o+PqcwQJNzWM4cdvR+qbTpVf9v63P8DDhy05xoG8QMmeOSLUDCy6JoS0jOc60Uw/YkLtBwNkVoSkQFU48gLUoXQ1MyGIKvveyl7a1UUfzhKag3Z3V56tkbnTyZZVA0pskC2+S7wPusZnlLm6DQLJlsiPxKwAuF9LXV0G14RX3BijhHeTCRDf5Mr7sogIGpPvBDSHX0EDxq/Z QltWwoLR MSOoNQ4sOfR5QdaWVR4dS0U3nfWBrrABIX8L50EKQU7Qjq4v+VOzyBoGqcPlx6qgEHIQwJpOHC10Km+synsbArpu+cT8Aq9h/AhCOQ+kZ6z1g1pb69hGDKhoLJHt17ICyk+bYEwua3f/zNQ92RsR2/6e1O3E56W4VsHlfJSkXM7PXIieVZ6RE+2NviAxhnnGNb/ZBe87+qoPPogeb7emRrxcODKAF/Fc4QBCikyyvfv+LL6K4t88JlemcYHG/bEfGwpLg1GNaJ0kvT65l73mbxltxy0yyKGKij6Z9Qct3jjebTaqvRLOKXTmQ9tZ4G7LdGbt5wHKE+KFBjTte2hTd7qBABhGkeIYRlsAmfOWgQWnO5vtCkyLBC+wYgOW2AR3BSiwR0LWiJihXT05alH2glM3VDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Sep 7, 2024 at 6:22=E2=80=AFPM Liam R. Howlett wrote: > > * Andrii Nakryiko [240906 01:12]: > > ... > > > --- > > kernel/events/uprobes.c | 51 +++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > > > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > > index a2e6a57f79f2..b7e0baa83de1 100644 > ... > > > @@ -2088,6 +2135,10 @@ static struct uprobe *find_active_uprobe_rcu(uns= igned long bp_vaddr, int *is_swb > > I'm having issues locating this function in akpm/mm-unstable. What > tree/commits am I missing to do a full review of this code? Hey Liam, These patches are based on tip/perf/core, find_active_uprobe_rcu() just landed a few days ago. See [0]. [0] https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/log/?h=3D= perf/core > > > struct uprobe *uprobe =3D NULL; > > struct vm_area_struct *vma; > > > > + uprobe =3D find_active_uprobe_speculative(bp_vaddr); > > + if (uprobe) > > + return uprobe; > > + > > mmap_read_lock(mm); > > vma =3D vma_lookup(mm, bp_vaddr); > > if (vma) { > > -- > > 2.43.5 > > > >