From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6EB0C00140 for ; Thu, 18 Aug 2022 21:52:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50DA58D0002; Thu, 18 Aug 2022 17:52:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BA878D0001; Thu, 18 Aug 2022 17:52:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35B728D0002; Thu, 18 Aug 2022 17:52:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 265558D0001 for ; Thu, 18 Aug 2022 17:52:44 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F32B8140927 for ; Thu, 18 Aug 2022 21:52:43 +0000 (UTC) X-FDA: 79814063406.10.9CD695F Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf08.hostedemail.com (Postfix) with ESMTP id 4278D162FA8 for ; Thu, 18 Aug 2022 21:21:42 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id q16so2277268ljp.7 for ; Thu, 18 Aug 2022 14:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=erWfx2JL8VWK/Fye7TEq9V21Uimrc0ebZ49GLDL2zgo=; b=Lz2iNaQP2P0Z6N2IOph6qWi1Zxr2Wk+aNsIAu4DHI96Idb2HK2EYVji9rPh1UZ2m86 kQgUgs5De791SDHluwVuxaNRYPvXlHmnO44ZXI/9K+HJt2VTCaHkEZO0FCmEFvH7hI+0 brnFtbsQB3eCUJOhrb2WRjmM+G8N7bonDL1bSlEnVaKrsHMa0hkaOcIh/MfGl8AVe9CZ Bd6VB5Ja0Y6kphczVBVOwpTmbgFLKDYcFjP+Zs2w5pwz6JDYnut4Z3SCRMqIr8gRSUsJ ZT4mX2cvVpT4iXV0YwY0N0PloTD7IhJonTfNn5D29rqawzXVHarkLx2vNNL59pndJ1uL urHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=erWfx2JL8VWK/Fye7TEq9V21Uimrc0ebZ49GLDL2zgo=; b=fjkjfxpIENGaG7fb4QIl1xI5I3S+1iDQdjDxko31x3bY7g/Nn5nHG5eEi8PrWgQXlT sxWM2qt7A7Bo1FH2eD1VMFH2o1my/ZyTLR4lfoDegMozowMPbw0ZEVZScfV49PUaz2Y+ NvSM3/vOHs9hvh7e+seOHNE1oxdTNgaBsB8AFZWFNBrUmE0KxfFu9n9tG1F1IAYjn7vs 7EBUZgB7uc/eIHGHIubAMJEjoBVdofVscykC2F7kKACXNZSiR//DMtxf/Q9pWT7/gO5d zTXvuZwGopil+voD3Ppwsym5bkC2bG4nIkPDmJwgr9MqUEbhoqEpje0CXsCo+SVqh8IN XSqg== X-Gm-Message-State: ACgBeo1aIk0nn5kpdypUPzSUhvIczHurQFdr5i8GaXYRxhbop5BrS26L vkZvQZMrafjSk9UFyLuVh/tVhCPb+7wo6mXbwiDJ5onUc/0= X-Google-Smtp-Source: AA6agR73spocumYGQcOQpcTXHqFeVLgovu5/02VF4b82mQEK8vuHOUDcMnSTLOchQ7KFX/R0+Ee3vWDHGtPvtToCOtI= X-Received: by 2002:aa7:de8c:0:b0:440:3516:1813 with SMTP id j12-20020aa7de8c000000b0044035161813mr3125797edv.260.1660843856121; Thu, 18 Aug 2022 10:30:56 -0700 (PDT) MIME-Version: 1.0 References: <20220818143118.17733-1-laoar.shao@gmail.com> <20220818143118.17733-8-laoar.shao@gmail.com> In-Reply-To: <20220818143118.17733-8-laoar.shao@gmail.com> From: Andrii Nakryiko Date: Thu, 18 Aug 2022 10:30:44 -0700 Message-ID: Subject: Re: [PATCH bpf-next v2 07/12] bpf: Introduce new helpers bpf_ringbuf_pages_{alloc,free} To: Yafang Shao Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, songmuchun@bytedance.com, akpm@linux-foundation.org, tj@kernel.org, lizefan.x@bytedance.com, cgroups@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660857701; a=rsa-sha256; cv=none; b=OZlHWUJl4jbyS9S/MxPAzBcKQuKE7F6kFCmcyp1u9307GS0yrXpnbyUdRl8/OENIHOb6BS qBzW2hZC79jEo87fJ/5L09J/xtFed4IkW80BGXKA2A6zjlNkgL6gKZE007fmR9nGm5cR3A rMZd55FnQqJfHZ75/rAcxoOkoOVR1gY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Lz2iNaQP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660857701; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=erWfx2JL8VWK/Fye7TEq9V21Uimrc0ebZ49GLDL2zgo=; b=MZN5pipgeJu+eL+OdFUXjVr3wkY+er0PafN/13CXsPddPhSKQHaRXxSH6UfVZskpkpSvWQ PwkkC9UBp8jmJtvxPWYj1RK1gY+MX0eG87VadRprKx1TIgSe+7ox+AI2YeXTU78VMDQY+r Ml5V6AMi5sbZC9WC89sLzQBkQwxAcsk= Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Lz2iNaQP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com X-Rspam-User: X-Stat-Signature: juqam4bzcjt3behnepg6atrp5ny8ay7o X-Rspamd-Queue-Id: 4278D162FA8 X-Rspamd-Server: rspam03 X-HE-Tag: 1660857702-355501 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 18, 2022 at 7:32 AM Yafang Shao wrote: > > Allocate pages related memory into the new helper > bpf_ringbuf_pages_alloc(), then it can be handled as a single unit. > > Suggested-by: Andrii Nakryiko > Signed-off-by: Yafang Shao > --- > kernel/bpf/ringbuf.c | 80 ++++++++++++++++++++++++++++++++++++---------------- > 1 file changed, 56 insertions(+), 24 deletions(-) > LGTM. Acked-by: Andrii Nakryiko > diff --git a/kernel/bpf/ringbuf.c b/kernel/bpf/ringbuf.c > index 5eb7820..1e7284c 100644 > --- a/kernel/bpf/ringbuf.c > +++ b/kernel/bpf/ringbuf.c > @@ -59,6 +59,57 @@ struct bpf_ringbuf_hdr { > u32 pg_off; > }; > [...]