From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69729C41513 for ; Mon, 17 Jun 2024 20:38:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F13EE6B00F5; Mon, 17 Jun 2024 16:38:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC3F26B00F6; Mon, 17 Jun 2024 16:38:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8B0E6B00F8; Mon, 17 Jun 2024 16:38:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BA59E6B00F5 for ; Mon, 17 Jun 2024 16:38:25 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5C27B121A7A for ; Mon, 17 Jun 2024 20:38:25 +0000 (UTC) X-FDA: 82241543370.06.561A931 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf23.hostedemail.com (Postfix) with ESMTP id 93152140014 for ; Mon, 17 Jun 2024 20:38:23 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R2TxdSBs; spf=pass (imf23.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718656697; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wWKtaKnmvywmEIjC97Wx0A/LSKQpHW9eCV1f5V8v23A=; b=N6CS4rMZ6L7zNJoiWRszeOO6LuFPpdSM3aC206s2B3jC82aAa8rfepoS9+dFURZ4gCf6yO c0BZ2KoapU5GgqZbnd3dt8tAeeq0Zpjvibs8CM05hZhvbMXQY/HDkNIgJXRBdDgf10CPRp 7K1wQSzsNBbcsM0aORSs2YnTrgdpoEY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718656697; a=rsa-sha256; cv=none; b=07AuSzeZ76er9Tnxw4bH8bY3/dlnHWPgxVid5iML9lmdhfsLJ2FTY/7KcujlnDgPUOidMC arfhMe9p3xg4H6XmS6fNlXGWZiidSK1Eow/KXkN0bvtbd3/yVwbx/kfvILqG+3+xT+dUPP TOGAEEPcZvze7UoPYuvoN3GJa1psmBk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R2TxdSBs; spf=pass (imf23.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2c3050f4c50so3739518a91.0 for ; Mon, 17 Jun 2024 13:38:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718656702; x=1719261502; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wWKtaKnmvywmEIjC97Wx0A/LSKQpHW9eCV1f5V8v23A=; b=R2TxdSBsec086fOND2Q3MdcL5eauoSEsCHoy4BheS/MPWJzyFJ3YG28PebeS+/fTS9 kx6IEVRZv/Bk6n5RALG+hkfvcjw0Es/X3P9hM0elrwum74Y5tdQ6qtWSFMzxPqkIggcf qb/AWaUtbwqpuzv009GQpUQ3vc8a9tDntx9FCfoRdizrNnmzWZL2XwCcYkUjDvbJ9+a1 FsjTUsJx79iHorb3ZDbfhqh6+qNXONhCWiD+mooKJdmMOr7bYF6lDjrLtS5P8mU3FDco yJ/Y5xXG9FBThwDnwejpUHGzvSuF0XQMD0zj61p3qXG6mnhFoag+VTPr5U5mq9aiHxkU DxyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718656702; x=1719261502; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wWKtaKnmvywmEIjC97Wx0A/LSKQpHW9eCV1f5V8v23A=; b=qFkKiYUxJdVk3iZfun6Gacgm7pCJ3rhaQQ74RH/ZBVUrbZs3KhUqmXMq1Sw+TSfbOR 1IyZA15/M/JqToevFKkUkHEYLZ17eoDTzgIszZ/F57/trv1oUN0/w/sc7vfjabbADG35 zBfkkxZJV6aPbZGd8EpW8ZhwVA7ST1xRecbIubca03OkQfR5GVcV0EscPUsFHWx2sQKh RPB0CFMaomo7GOGYQw/7W/7NIT5Xfevo25dqNV0raoKM5zNrhU1gbg+lDB5UaCetyg5/ fyIHPFIlYjUnwA/tKXgvMakQ/ckPpovtonM3Q65n3FB/9auWjsmJI3tXfNGctsLu95Xm SwJg== X-Forwarded-Encrypted: i=1; AJvYcCVFM++ybYwrNJGWggYY6BMU+Y3kPXX38uKb9Q5yTttWeojhOZtu7IdnoPqyEOvpFhuseoUxSqpNSelBVX+rXK0WD68= X-Gm-Message-State: AOJu0YzJmCjD5yvBrCYu9AUqPDyxy2Md5ZR8a/RN33b8EI8dUW4gx0Zl E285mXnxS0XVDeXueAgjyQU3IFV/hcVDyZYIiALRX6Oh6MeUKA8Pb1Zoi8IXxbIjBJrWdAtozhF 9j82s9xYBhb5VmfIC9dyBos979+c= X-Google-Smtp-Source: AGHT+IHsVSmW9ATxtdmSI+tE9L87wx8WVFIdF5YxHYndtJYHztnhDuuQsyxM5VE2Kkq4gSl+0bDQan0sDRLRS68xATY= X-Received: by 2002:a17:90b:611:b0:2c7:869:4370 with SMTP id 98e67ed59e1d1-2c708694475mr89731a91.7.1718656702174; Mon, 17 Jun 2024 13:38:22 -0700 (PDT) MIME-Version: 1.0 References: <20240611110058.3444968-1-andrii@kernel.org> <20240611110058.3444968-4-andrii@kernel.org> In-Reply-To: From: Andrii Nakryiko Date: Mon, 17 Jun 2024 13:38:09 -0700 Message-ID: Subject: Re: [PATCH v4 3/7] fs/procfs: add build ID fetching to PROCMAP_QUERY API To: "Liam R. Howlett" , Andrii Nakryiko , linux-fsdevel@vger.kernel.org, brauner@kernel.org, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, gregkh@linuxfoundation.org, linux-mm@kvack.org, surenb@google.com, rppt@kernel.org, gerd.rausch@oracle.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 93152140014 X-Stat-Signature: ozit915pd5ikionjia1hxgij8z5ehb3c X-HE-Tag: 1718656703-179773 X-HE-Meta: U2FsdGVkX1//7j8XnxfMaY9q41YKjn9zv3/DVBgz6o0CTUCo8SUG1D2hogZ/2ftFyBIaYQDYvKLSH7LsxS1G0d+4qJxIAVv6Y33fADQvvps+NyIuWslHHcPZfXvCXtgVQeTqckJoczsvNpblp7bG9I5SjhFZu6cIY4BZML4muMsEfWpqWS5hyC1om8PE6A1fG8RLAlhKCLiv6Jx8Ulinqe1UA13si7s3msnb0vZp73NgjmCQCD+qld5o0gdqaQ8hMzWJQA/AXjPw6EGAhjDjh2wEd7ZxojcMPADoZjlUU9aKRE+kj29GmK88SAtiLP/vyrgZykUx2Q2EkOOe21blhEskVYYQpG3aC7LtZpt1FKa6Guj2uJUDsLwmpZjHAxkcLnuCTBhaB8C7NiefP9xQZaMJwZa3Ld6++qCIZQwNG0llz5tqNSrrMoX0BelWQGMnRODT3NtdplowRghj4P5Ep/Yy5h14JakrdmZa8xtkshHLQV/J3Iu/7LRhdcJz8fhGAMeNZMF5+oMaPo/sLgZMh3oxllry+2LDZ+H6tQWV+oc+i59fYYEs5lEMNQ95D99E/t3IH61eJhoWknaJyECUT4YE5UfEaLX8AErXVtE9m6In/7d++VNABREhKGrQhyeJG7MM5HXUs7T3BpNFL1N9kFzMj9AcygtBbEynAv9Sh9enrnuCingLU/yFO088C6MXE/oEwlRFF54WPPY5dETZMIo0JqeYEDBbzYgsbMqHcvqIAHYWjxOpPeqnA0NY588r3D3cC3Xpg4PTe1p400rBi3YI1xemW/83tynGpOc7oPyZQPNBCQ9eqZhhCsNmswQISRUjcQ//EP1ekoF3NmhVRmFCcE1mQ3/o9NLEG4DvHFHjV/6yvf1rdHbW4b0P1cwnq6/y1+v2BFpFICxSPHzGx3C6X83IcU4LZzXkUcv0Rk1fuvdusYJ4jdaja7duifEnw6VMpE6qbIWAczKz7/b BhAAYiC3 ZTOu6yVrPe18V6dMX9dzMLvs9qj6u79lzYMmEubBJ05d/dDI1onmDO3zT9SBx4P8p0CmY+ouoUvpGexkrN2qW7c73Hlf+L3l9V4z3lRSSrR5buCgcDTbS5d7lhI2Pks3o3dtk8mqF/nT63CkRxSj1KOetcsWdHRToCEV52IGdEY8h1deU8TyCUV2X574S0972XGjkrkwxPMIbb/QpGT2JSUT6cx6dSpo4SOJCtBle9IcC535zdlYxegHVbJg/QyvnWRwjap+ggJlrQUcXeDHwdOq5b+dNXmCj2Q/J/lvD0sukjvGOzlRcSmSgJ1jFwLjFDkp8QguJDrDMnS+S8T64ri4HcquIRKa/I/l9+AvoP+rlQg5eThLE252KNeZJZznJ4fhkCWJhF/1UpqniD2WxG5Pa+Wz11mureyMtDmLEf1HNyCGlBGwPEAxMCpCDqltUmEkeTJThsG9pDyI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 12, 2024 at 11:28=E2=80=AFAM Liam R. Howlett wrote: > > * Andrii Nakryiko [240611 07:01]: > > The need to get ELF build ID reliably is an important aspect when > > dealing with profiling and stack trace symbolization, and > > /proc//maps textual representation doesn't help with this. > > > > To get backing file's ELF build ID, application has to first resolve > > VMA, then use it's start/end address range to follow a special > > /proc//map_files/- symlink to open the ELF file (this > > is necessary because backing file might have been removed from the disk > > or was already replaced with another binary in the same file path. > > Can we please also add the vma_kernel_pagesize() to this interface? We > have a user who parses the entire smaps file specifically for > KernelPageSize, which could be included for a low cost here. > > The only way to get this information today seems to be from the > /proc//smaps file and it is necessary for certain hugepage calls > for alignment reasons (otherwise the calls fail with -EINVAL). Adding > this extra information would allow for another text-parsing user to > switch to this API. > Yep, it totally makes sense and is effectively free to add. Will add in the next revision. (and sorry for the late reply, been travelling and generally on unusual schedule for the last week) > Thanks, > Liam