From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 595CFC3DA4A for ; Sat, 27 Jul 2024 00:38:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D00E46B0082; Fri, 26 Jul 2024 20:38:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAF256B008A; Fri, 26 Jul 2024 20:38:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B76876B008C; Fri, 26 Jul 2024 20:38:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 99CD26B0082 for ; Fri, 26 Jul 2024 20:38:11 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 28203A1869 for ; Sat, 27 Jul 2024 00:38:11 +0000 (UTC) X-FDA: 82383670782.01.0AB1C01 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf03.hostedemail.com (Postfix) with ESMTP id 5DC3C2001D for ; Sat, 27 Jul 2024 00:38:09 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lwMk8OV4; spf=pass (imf03.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722040638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C04Scg6I7CABHPEjc8V3MN/P08PTu2wPz8zjUnSZGdA=; b=L7E5bZDhN0nrd2EQlBcwByLyHWjAPP1gY9XFK/AZa2R/hm9tgtEkgBfugKE9cKEyRYGsPO 9nm4esRT48tx1miz/V65mRPUt15oo20Tis6AU+/KXKgSDf/0JcN48ZydvOzQnJ+GVaEt+H uz4NazsETU+bTIprBGUEdzPHeiQZjvo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722040638; a=rsa-sha256; cv=none; b=Hrtswdk2/I+zu8/MZ3r7DhID1DcMVyku7X1oXXBUiM98eyJzkIPHv9Ue+hQXEGxSIHrntW QZrNfpYiCUmqU++q2EZCZQg/FsUJC5YAmAOcBIbfMrw+B3MirEGn4XuQSmRzTa6zcWRUyD ULUUchbzD3UNbGGyo+J5NMnIBJpBaKI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lwMk8OV4; spf=pass (imf03.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-7a2123e9ad5so940720a12.1 for ; Fri, 26 Jul 2024 17:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722040688; x=1722645488; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=C04Scg6I7CABHPEjc8V3MN/P08PTu2wPz8zjUnSZGdA=; b=lwMk8OV41RtrSLN2+gVAewgrsBgKlk0EH61es5KSsVMMDi2xrE2XNFQ6aW3ucPaagk i63GOAA+6RBJLvnLOCY1hSuhU1OS+QI5ng/hhl0Tj/eYWUgki5tG6j0XmpKR32k/yrwW gcNWoEO+ONlDhtOLICpOUL2iaFfGjpbDwwzQJmCpybHPwyj6P1TlF8kNGzWZyGe6dNql vl5ytu2XY+JcMrBK0p4me0Lko2wDFqeKDQO1lv03MI1ShqpCBucixT++3hmXS1IJeqet 7a0Wb5p1IGnfC4rymqfVSPlW9MFXUgrhYzW0yt2Dg4Rs9cWanFxQTa/OSlVd+cIQJhPu d7wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722040688; x=1722645488; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C04Scg6I7CABHPEjc8V3MN/P08PTu2wPz8zjUnSZGdA=; b=ORntbJ6lBLGNB/Eqqi6nX3slSen5V/NVhdEZNWHLqUh9JXSL0iiebzg5EA2VsV0VGg dyKZ9ilZUOITZyglldUyEZk1LA2lOuSgE8XCfM49rgD77kU9zncQIfZhKMv9JjjgzTqS VaKaBFL1NDzQNLXMyERZjHELZpud94ONtkpck6fShcMaZIt31WJ7Uxqq8WvuRlC6iEQo c5YTi6/YJpyafAJ10eXUYJPeD+/oS+TzXPAwHwbmXlW2SSThxZ0j+8l2u4wm6iXFptBH pTTOyZe6v3tgru4+VCq7xkCzxYmeuR5ry3LXKYaYonKc6z/yNETJLyTQ5KbdnH7uSWQg JfTg== X-Forwarded-Encrypted: i=1; AJvYcCV8eKOFLihrcnskpws8LFV+KagJUN6GT4s5hmjpQrxXCt75vTM0lbqQuwSJVdY0KgEaYCPR1ll8Q4KLqHJfVEDDS2w= X-Gm-Message-State: AOJu0Yy8Be4ZMgdKtkrn6O9bZlrXrAbgn9Sm+ow54UVfHZHDpt7KIsAZ QB+SEYty9s6XacXPFih4x4GbIqx4llWyLi5MRK0FNBNLq5DC6LMoL8tvENNL9y3PIenlhwplUJ4 dSmyG3D1FmejkMWah48aWbnqBjyw= X-Google-Smtp-Source: AGHT+IGDaXyFN5/aNyXrQppfxXb+HtLbGx8WKfn8WTn3itrECa199GUlOuZ+kBayq+PY6WOZA6/jL+emVLC+52+ns70= X-Received: by 2002:a17:90a:ec0c:b0:2cb:5883:8fb0 with SMTP id 98e67ed59e1d1-2cf7cf7fd03mr1873756a91.14.1722040687978; Fri, 26 Jul 2024 17:38:07 -0700 (PDT) MIME-Version: 1.0 References: <20240724225210.545423-1-andrii@kernel.org> <20240724225210.545423-11-andrii@kernel.org> In-Reply-To: From: Andrii Nakryiko Date: Fri, 26 Jul 2024 17:37:55 -0700 Message-ID: Subject: Re: [PATCH v2 bpf-next 10/10] selftests/bpf: add build ID tests To: Jiri Olsa Cc: Andrii Nakryiko , bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, adobriyan@gmail.com, shakeel.butt@linux.dev, hannes@cmpxchg.org, ak@linux.intel.com, osandov@osandov.com, song@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5DC3C2001D X-Stat-Signature: khuk5yugk8bxgu5gk6gk8naoepoqcd3p X-HE-Tag: 1722040689-262570 X-HE-Meta: U2FsdGVkX1+Kx2b4DG7b6O9G8JLXPfqhexg77Qg7v6BndhiMPiBi0AZE04svkUDLh5/e93Fw9oFdAHCQPN+bXrHK9324dxp92Gm17BLRckHwI3gcf0y7MFnG5Dd6Hj3d81xWGSAa3ZokXmLheajQyL8WkRtAvWTDdTDvSw597cbxCbMUhEOPFhvdBidVOPsdSqTs3enBeX6h9HoyMJD7gkxcYC+3NV6w6z4OoeIQODkl+c5KGkgzUo2UMfr1F4yKRLWaW6up3q7uJYyVPlIYmNjucZlkAVU173+kVIrknkP9IIUX/zS5bQMXmvjet/YXgDW8pCyQF6bpcrxuS4OnRV9dven4zGBpJgzApLP/H10R1xSiCTrkZoNhffcL6+JH12v7Z2GSq5XjYWXPP9PGvVAsdOGD6Ma/0os4v56aZILTtrv5n7d7vwqD1ytWZFosQ7DTNWRpXCqYvy9erd6OkKZVxzjdJIqSeno1rHpkX8YRD353wiqRu+yFPmppnvktBNcQLtHBKaqD7TByxp+V2IJvRrC4JbLrhpOIpBJ6+SjOf0AumVKLwAvfjuVo3nHnIKoO/C9rOckyVtRugocfaHG6Yfmb8cnlrj6llXlKHNMLbh/of4x2e5uJLqViF48hz8o/C29l3mYJr4cOlCnR+qDB2JvTcb2OheFKZTcwC8G3Frjs8JzTgNYzMDDhLRl23mU6EsCaT0/YsoD57seQkWRAYKErO1i+W0xravx6EJgEgjdR5uxj4CcIVMcvmtgrtzVf9ReXHSw/MaezY00/hIEe2mk82wFPVp7+ZG08EqcOeCKm1LJnb86BwtCAw6nBR8eOCR4DB3XZYAkMnvUVCb6q5HpvPtkHsm7UTIP79Hnex3xYG1uigoSJYrYeKlbe1x0ynOrR29T37+mRXK/wXMHi0lNgx1zCaJdyZ+T9X9rzlXXg2VFQlkLhJcR0Gta8ijD3J/zh97bQj1laoOB 1cLMtyOl bq/pN7OgPjHXbclqo/xPLsPM2PSZpL1Yr0ndjuSLZpC61ZBwsfuPbkS/uJbzLUpF7rfOHV0Fqfz00Mq77y/PycNE7wCvOVcu/Q0ixdY4vQFdMJI/TT5ZWw6429OK8212TbeW5cck/B4g+6x1E9V+KymjpHenChGaFU09tst0IGF2ZsmAAFSDWX0+hrPVIYqExUPU8kO2Lx+8GeaOmtttmNfJ5511bZJ3EBBNr90vg3KAo0svsRIKKud0DZ1eB/OihfbeBfwvtKPmNW3QW/wVKTeZIdF8G2AtWsHYO9/44YA+vFNM6b1wWY5PgV+9Mtrf9hZWG60PxcJQlJc9JVRgjGMwFeH8NSMVsM5L8FPINs3L81AfQr6QFNlissQEANxwSBvej/93jzrZiCC9u715ahaSlyewK0IHTgO+5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 26, 2024 at 5:27=E2=80=AFAM Jiri Olsa wrot= e: > > On Thu, Jul 25, 2024 at 01:03:55PM -0700, Andrii Nakryiko wrote: > > On Thu, Jul 25, 2024 at 5:12=E2=80=AFAM Jiri Olsa = wrote: > > > > > > On Wed, Jul 24, 2024 at 03:52:10PM -0700, Andrii Nakryiko wrote: > > > > Add a new set of tests validating behavior of capturing stack trace= s > > > > with build ID. We extend uprobe_multi target binary with ability to > > > > trigger uprobe (so that we can capture stack traces from it), but a= lso > > > > we allow to force build ID data to be either resident or non-reside= nt in > > > > memory (see also a comment about quirks of MADV_PAGEOUT). > > > > > > > > That way we can validate that in non-sleepable context we won't get > > > > build ID (as expected), but with sleepable uprobes we will get that > > > > build ID regardless of it being physically present in memory. > > > > > > > > Also, we add a small add-on linker script which reorders > > > > .note.gnu.build-id section and puts it after (big) .text section, > > > > putting build ID data outside of the very first page of ELF file. T= his > > > > will test all the relaxations we did in build ID parsing logic in k= ernel > > > > thanks to freader abstraction. > > > > > > > > Signed-off-by: Andrii Nakryiko > > > > > > one of my bpf selftests runs showed: > > > > > > test_build_id:PASS:parse_build_id 0 nsec > > > subtest_nofault:PASS:skel_open 0 nsec > > > subtest_nofault:PASS:link 0 nsec > > > subtest_nofault:PASS:trigger_uprobe 0 nsec > > > subtest_nofault:PASS:res 0 nsec > > > subtest_nofault:FAIL:build_id_status unexpected build_id_status: actu= al 1 !=3D expected 2 > > > #42/1 build_id/nofault-paged-out:FAIL > > > #42/2 build_id/nofault-paged-in:OK > > > #42/3 build_id/sleepable:OK > > > #42 build_id:FAIL > > > > > > I could never reproduce again.. but I wonder the the page could sneak > > > in before the bpf program is hit and the buildid will get parsed? > > > > > > > Yes, and I just realized that I forgot to mark this test as serial. If > > there is parallel test that also runs uprobe_multi and that causes > > build_id page to be paged in into page cache, then this might succeed. > > So I need to mark the test itself serial. > > > > Another issue which I was debugging (and fixed) yesterday was that if > > the memory passed for MADV_PAGEOUT is not yet memory mapped into the > > current process, then it won't be really removed from the page cache. > > I avoid that by first paging it in, and then MADV_PAGEOUT. > > ok, I triggered that in serial run, so I probably hit this one > you did it with v2 of the patch set? I had this bug in v1, but v2 should be fine, as far as I understand (due to unconditional madvise(addr, page_sz, MADV_POPULATE_READ); before madvise(addr, page_sz, MADV_PAGEOUT)). At least I haven't been able to reproduce that anymore and BPF CI is now happy as well. > jirka > > > > > > > > or maybe likely madvise might just ignore that: > > > > > > MADV_PAGEOUT (since Linux 5.4) > > > Reclaim a given range of pages. This is done to free u= p memory occupied by these pages. If a page is anonymous, it will be swapp= ed out. If > > > a page is file-backed and dirty, it will be written= back to the backing storage. The advice might be ignored for some pages i= n the range > > > when it is not applicable. > > > > > > jirka > > > > > > > > > > --- > > > > tools/testing/selftests/bpf/Makefile | 5 +- > > > > .../selftests/bpf/prog_tests/build_id.c | 118 ++++++++++++++= ++++ > > > > .../selftests/bpf/progs/test_build_id.c | 31 +++++ > > > > tools/testing/selftests/bpf/uprobe_multi.c | 41 ++++++ > > > > tools/testing/selftests/bpf/uprobe_multi.ld | 11 ++ > > > > 5 files changed, 204 insertions(+), 2 deletions(-) > > > > create mode 100644 tools/testing/selftests/bpf/prog_tests/build_id= .c > > > > create mode 100644 tools/testing/selftests/bpf/progs/test_build_id= .c > > > > create mode 100644 tools/testing/selftests/bpf/uprobe_multi.ld > > > > > > > > [...]