From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39AE6C6FA99 for ; Wed, 8 Mar 2023 01:27:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1A036B0073; Tue, 7 Mar 2023 20:27:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC9C06B0074; Tue, 7 Mar 2023 20:27:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 992C66B0075; Tue, 7 Mar 2023 20:27:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8B7676B0073 for ; Tue, 7 Mar 2023 20:27:10 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5F96E1C5AC6 for ; Wed, 8 Mar 2023 01:27:10 +0000 (UTC) X-FDA: 80543992620.15.89237F6 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf06.hostedemail.com (Postfix) with ESMTP id 8D0B918000F for ; Wed, 8 Mar 2023 01:27:08 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DMwo5kjt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678238828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tLH4A9cIITiWgvTROt/796Hn74B0vtkSJjpGSyylmcs=; b=0gKm3qbyWg89XzhWciN9MpD6OI2IH5V9Cw3e2AU8593sx3RSKEa/SGw4w2dAGtp+xowo8O 6iRLwZjsvgWfP4nJbQfPibJDRSYWyLtNy2htBwyWRXbwxFP1DHeCzpQfMHXdhrfe3SYvZw q6fKsH7sijpLz0aZbQZfjm34c11iDCc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DMwo5kjt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678238828; a=rsa-sha256; cv=none; b=pxGLUhxAW8eMN+96ftcMFbfUjJgq86o8MqqrwMIGAl01Zyy0UWOzXBWAeBoyjfleLKkzvj Bkd90eaQyb16mxWCdCOHHh0etNIlSElUlELFJMFMCQirJkNBJghqQaDO3/yuY0ad21cosw qt/O+YqZy+rULZniSBqUlUqyiOKzdSQ= Received: by mail-lf1-f54.google.com with SMTP id k14so19479437lfj.7 for ; Tue, 07 Mar 2023 17:27:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678238827; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tLH4A9cIITiWgvTROt/796Hn74B0vtkSJjpGSyylmcs=; b=DMwo5kjtJ0pEg4akabpwnYL7kh9ckO3fLY+pCLYm8gJUW2oegTMKUBiB03gdZdMktj AO+S8rDv4AzV9PeCrNzSGezQNBhqVT/tMBMVsOOFdcgqj4YyKFrJC34lPusSFVH0Ycy1 tLBtVYA12i3wOlDDqfAmiw/utn4Taugp63aSOu/ME+HyiN6R/mqKc75agAm3XYkvqAbI jRimA4r2ZV3MQvu4TBxgmRWHnoY2zJlRbqrwQ7qVV2+fBKoEezFhgtuMz48Jp4XsOZo5 RzVJzZ1J1deBJYgNeiEIAKZrUcuX9N2vEQz6K3Rd6B9WleoKsVejX3ui7rUzd9iyvGmy W27g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678238827; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tLH4A9cIITiWgvTROt/796Hn74B0vtkSJjpGSyylmcs=; b=PWhzcDCV0F0rO9/iO07/UQu+uIzmJEiQQkDiOm3Dl6ysa22Ut2996/T9x4MnAhWGEe KEyEvPLXZ/7FzAmtBliekjA8N3fK8rWGLIlziONt0dDOQg1s3OVQDx4go7ESMg9AqClM BZWNnEf4muijIS8UTL30INYAc91gqPT+SKHoQKtVV5yJUJgnSnj5pklCdslfeSvLskgb fC1Hynj1kf7z8zMfwm6DbdNu/61fkTjIBy/TTcGM1HDsOb8Kf7XusNtAWzSD+u9XZORv 5Af9dY7uyQ7BE5fWp+DYJCZv7J5JsHg93l/ImLC4wnaO27e1BADZyBMT8afN0bWa3AHS naJg== X-Gm-Message-State: AO0yUKXOV+h+N/IhHsz9uK5sDByqevzEIt2yqNBNAebzYXQJ6/o9i3yI emTZFk5rlRF3Fs8JhTkgHhExgJm14+6FdZac6+3QNnA9 X-Google-Smtp-Source: AK7set8Qd4OHKSzPmiTWMliy10a/G8dDy8JOTmOGGJCFt+t8GRv8SHa9aGKKXq1WB+UO6VNza4fdEfQXn7owmJDnpb8= X-Received: by 2002:a17:906:4bcb:b0:8b1:28f6:8ab3 with SMTP id x11-20020a1709064bcb00b008b128f68ab3mr8269471ejv.15.1678238352239; Tue, 07 Mar 2023 17:19:12 -0800 (PST) MIME-Version: 1.0 References: <20230228093206.821563-1-jolsa@kernel.org> <20230228093206.821563-5-jolsa@kernel.org> In-Reply-To: <20230228093206.821563-5-jolsa@kernel.org> From: Andrii Nakryiko Date: Tue, 7 Mar 2023 17:19:00 -0800 Message-ID: Subject: Re: [PATCH RFC v2 bpf-next 4/9] libbpf: Allow to resolve binary path in current directory To: Jiri Olsa Cc: Alexei Starovoitov , Andrii Nakryiko , Hao Luo , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Matthew Wilcox , bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann , Namhyung Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8D0B918000F X-Stat-Signature: rgkn1suywqm5d88d7ato9nnzjcn673xp X-HE-Tag: 1678238828-613250 X-HE-Meta: U2FsdGVkX19kh/gYNc6J0zynDIRcSy8xcBSJbsORSkSTGZFRZAGF+ag99gQpzlNaHztoAlhJLgrOsQIv2zCsJsFV4zsuvE2QzNSU1jZWtfafxdZPos5PXP+3R6xzFwhc+GPVBCkjEtUl+93D4A8amHTNgzXXOMa+HaA7Ht6fyxpF7PTPsXUTd9DuDGl90RIPADg0J85rmT0JXqmTGbaE7cuLZqeB2MqoGSDRWlMtSEzfDBf2uhbRKuO4ShI6GGoA9dZMp4kC4JGe2O/Ejy1edwlIZsWwYm3RLiLp7DDlk42uRxr/32i47X16+0WPVSM4POnMiYxH55yJPeN24wIwJvyrhjPgFIwfjW0hhy5AhwNxrPGqUKCxoZn+jwPqSlz4Fnf3PtKVnO9syidduelb50tpHK7w01a2CkdM754UoAeNvUjcUkIRIt3hM24zwbF3S+woFjpsgnFDiKX9g4EleL2aCDNnkzYzqj6OeoL8REA8LTGZuuuyy36gmW3pmku7AoMY0HW5y2dZ78LqALRwEDnHyZ90lCWPPO6EKd4pkPlRpfElmM4W37NVmNt24ZQtlRwy6Jzi2yhJuVPMWCMjbgO0AqXAFDKVtWUaNc8/zXT6YnBzTaBxjI11IrURErNZfuHlT5Q/GsHdM1wFNRtS3xr2qPchnoAegnl6r3gTDoDlxwp2dvfnZ0h1TZ64ha++H0dHlQOg8bYRznp3fcLSq7aq5UAC/W5iRcYd5a6MrOGgaj5FXvKoOXr3xppBBf+YD/r4sxazHnTtyUDZL2a5jjMrjsFFeULwlHNq72p8QMrX3iYslza5A4+GJBTfwcz8tTsQ4K8XGx7W9jQskfNawUAMxacRR9P9K7GWVAeaJZu7/b0GFa+3WH/v0qc/nwFX6K4P1Ea53jcJp9wtYh/Y0GUbIhpXrKsE9cLgt5ECJ9w6cIusIUU/+uBWit8WTBOjFZUxCowZ+0eohmjgEvr BUgHzOwt ZKdWq5G+773spBppvs4z05M1UN2dO1O6Cm8RD8bAOCtTHLouLoIRj8/1xICyzfDRfqcNfikMuZZXD4Pwm4782NnH6H0ZjN9hiGpuQ9LPPasIEfbEpR80M1PWEcrC16mVu/cZZyRvI/m3z78MbquaWcRbd/uawUTMbj/aSvmnPPjcorKo0kks4k0nnfQbo9GsBjZkDQLrmSKtxb1aOP9qdvsjoxHxKN0/0YR/7jFNfgo9EjLhztEM7hcVeGYd5Gn4UYxlkKeBqnGsjEeX1xSSD6Ha3KEL3+SWiCAJA2Fqp1N1r4fWMMFQY7HMiFwJGLe2YlVF4dxG8FRcWlaNiczLrBRz2nWclqajL63NIXnmV2iP195TsWiz9oHF4ap5Dyn5t6JHuawakUssflF6c5nD/XiRoMKjFyAzS3ZXapHyEcEXUkHelNM99weQPfAx/s0jz7bowsqUal2u97owUWTVbnq+p76ONwlj6viWaC8NGFoYAENck7HrdyvdSOyw9HP6pCVgF2ZdHoluc5R6UjoXz2v3lrA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 28, 2023 at 1:33=E2=80=AFAM Jiri Olsa wrote: > > Try to resolve uprobe/usdt binary path also in current directory, > it's used in the test code in following changes. nope, that's not what shell is doing, so let's not invent new rules here. If some tests need something like that, utilize LD_LIBRARY_PATH or even better just specify './library.so' > > Signed-off-by: Jiri Olsa > --- > tools/lib/bpf/libbpf.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index 05c4db355f28..f72115e8b7f9 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -10727,17 +10727,19 @@ static const char *arch_specific_lib_paths(void= ) > /* Get full path to program/shared library. */ > static int resolve_full_path(const char *file, char *result, size_t resu= lt_sz) > { > - const char *search_paths[3] =3D {}; > + const char *search_paths[4] =3D {}; > int i, perm; > > if (str_has_sfx(file, ".so") || strstr(file, ".so.")) { > search_paths[0] =3D getenv("LD_LIBRARY_PATH"); > search_paths[1] =3D "/usr/lib64:/usr/lib"; > search_paths[2] =3D arch_specific_lib_paths(); > + search_paths[3] =3D "."; > perm =3D R_OK; > } else { > search_paths[0] =3D getenv("PATH"); > search_paths[1] =3D "/usr/bin:/usr/sbin"; > + search_paths[2] =3D "."; > perm =3D R_OK | X_OK; > } > > -- > 2.39.2 >