From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AB69D18159 for ; Mon, 14 Oct 2024 23:41:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F13086B0085; Mon, 14 Oct 2024 19:41:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9AF66B0088; Mon, 14 Oct 2024 19:41:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3BBE6B0089; Mon, 14 Oct 2024 19:41:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B1F1D6B0085 for ; Mon, 14 Oct 2024 19:41:39 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 07E0D1C6B12 for ; Mon, 14 Oct 2024 23:41:30 +0000 (UTC) X-FDA: 82673832108.25.A88F3B0 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf04.hostedemail.com (Postfix) with ESMTP id 7127440003 for ; Mon, 14 Oct 2024 23:41:28 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="k/Ceg7AJ"; spf=pass (imf04.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728949154; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bK52o27K/sxt9HmES53yJ6IXLDUKoQtM4kWshgQf9a4=; b=qV0F85u7s06ypOItO5Xy/zo/4Qr3iiw2pQdaEYmL3h8qy4vtnVEsLqYANplldtCVJ56Kf0 6Ss+2yD2heHmIF9u6MBjfxfIe5t4gREoL67SqGROS3PruFNKgwVcAZb43G19dKekZymsjq vJDIMtiJFyhVNO0jSaql5NLchC9hC+Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728949154; a=rsa-sha256; cv=none; b=xBWy87ibZVn3saxXPOmehmv1sHUuQPSnpJyLwcqODYDqJjBZF7ZOkMBz8yHEYJITnTyJX0 aZVFKYmzwkywv7EvfF7sCN23KD6bamQybZhGT3REas8/P27Bq7Kw/rHsYc4KYWUQSSZjft aHNuAWOGjp/0CpqAYtz60PujiYhZsKE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="k/Ceg7AJ"; spf=pass (imf04.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-71e49ad46b1so1862352b3a.1 for ; Mon, 14 Oct 2024 16:41:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728949296; x=1729554096; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bK52o27K/sxt9HmES53yJ6IXLDUKoQtM4kWshgQf9a4=; b=k/Ceg7AJOT8ZqcDiPqUMLrWVzbY+fCbpcepOT/UWV8a086mZM8kqe461B9jNMWeNXK AP4STEM2kuxw8p53vAH37kpw9Xuxq/RE20MZ9b2s3GH34a4v1IvJoMuIA1+xp5Ustrig bOXPtQgZWJjheYRAQSRrzb77yfAm0l32IP8tH+sqDO9pBdYhlGw9lOv4v4Zgqi8x0xTr k81Ds3pHRct2Spf5ZxyekHsaVRfw3x/l82/FUWODuvqUdGinA7bVST6sl4iaU78Y45Xb ZV4uPcEUH9ceE7VVUsUhSWWWEBRtRN6/WfyR0HYBE0QNmf7R7bA+iuYAN7mL2mtGre4B xRbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728949296; x=1729554096; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bK52o27K/sxt9HmES53yJ6IXLDUKoQtM4kWshgQf9a4=; b=dJMKdPZodx5qEDoaNaI0kjtFI1SCdRu0vpUjANQnlbgXUXHkKEd5t9rveRqOaOx0oe nJ5TULmpyL4LFao+zv7gTTIt0ZM8+dFNzcIsP7o6fOBnJvLtnHg8hTz41xI1VkMtUHRW C87+dORvFEjYHlj960K1SSpb4uJb3Va4fdhmO+YlVNDKwqoq6qW4lVTypJrPTkGvKkqQ XRpWeDvkeJHK1bYWnFBG7py5JFNkBMEAm1P3pKIBgV9hK4iUNaPsSyWcyrbnxLcjWk62 Jvc4OwA/3x9C+SI0UQa8w2dtOaiESyvPy6JakVp8qq3vOtZTmCQcTzmHbH8M6zVCM2bL XKlg== X-Forwarded-Encrypted: i=1; AJvYcCVL2ye0zjfkK5E/e0NVc1Kvln3gu+oaKzd/6ho1rBvzQFsegxMuT6KzKKNwynmZtLHLXBzL4N3M+w==@kvack.org X-Gm-Message-State: AOJu0Yz0mzI1PrNaf8zWeY4IMZ6s+ryLKTdKpeHEnIeZZdzdbq8NdrrR P6t8jlp+p+/IlFYtt8iK18yNZwa5UItcNrMu0rmvaTz13mKO2GcUc4zE9v5qtZSV2fVurgIojUw bAqBZsLeHytCXg1zw3mpntpJCWVI= X-Google-Smtp-Source: AGHT+IGHFa1V22MLVRYcRiiXB0DFIYqasAQr00M5QX3r/+G7CJO1LHeIByP4GF1F4OSYMedSo+2A/WzhQZbDCMnLGY4= X-Received: by 2002:a05:6a00:1256:b0:71e:58be:3604 with SMTP id d2e1a72fcca58-71e58be513dmr12072639b3a.4.1728949295897; Mon, 14 Oct 2024 16:41:35 -0700 (PDT) MIME-Version: 1.0 References: <20240829174232.3133883-1-andrii@kernel.org> <20240829174232.3133883-6-andrii@kernel.org> In-Reply-To: From: Andrii Nakryiko Date: Mon, 14 Oct 2024 16:41:23 -0700 Message-ID: Subject: Re: [PATCH v7 bpf-next 05/10] lib/buildid: rename build_id_parse() into build_id_parse_nofault() To: "Lai, Yi" Cc: Andrii Nakryiko , bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, adobriyan@gmail.com, shakeel.butt@linux.dev, hannes@cmpxchg.org, ak@linux.intel.com, osandov@osandov.com, song@kernel.org, jannh@google.com, linux-fsdevel@vger.kernel.org, willy@infradead.org, Eduard Zingerman , yi1.lai@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7127440003 X-Stat-Signature: dw4p4ke3ybheib36aggzpfdi89kb8dxi X-HE-Tag: 1728949288-663116 X-HE-Meta: U2FsdGVkX1+438GKni/q6kqdGG0NyXaMLIE85G1+gPPCFZUAGXfMwG6Zm7jK8Ek+Qt0na5cFugGuDK00U0T559wi6Npu0/18FHMUJaHBJ0kfNpgYSVRSP5DvtpptN7RgFzEin27hSoa/gTdukiTFhqA/i4AFydmSRVs2llQnu5NbT6IDQ7RDaOYFyuCpyruzu6fHwH0tbYYS0G4ChYihY64xP52Yc+xHPB8FGXhRpXrQhGg2L+wRc/aDb3aL3oa6Y7Y/6kT/RwnY3ptlM5t4QPXXrRb1Xpcr/pSwsqKOBndUdIpDZbqJhz0E9EQThTDEzSfqWu2B/KOy2iph2K3uSnu2ub2gE9Lb2E/4K1XY4ktwa0+2DSxqMN0ymYkMVvIYEqscRrHGt5EkCpK6eE7eWCNnyrP0YVQMJLFhhheV9iU/EkLF0CtSOrWJVeTTZ01A9YTE7dfjMOUq732dliakUtgCGMnAy8zWqfJwz3WiAZHD2dXMg2mHHY0/OQ0Pp8cNdHla3IUsxMRKbs/WOW8nZI63u3y2xbafmU9MVWSfLneCj3j+gktm4l8Wy/nWMlKb9V/irt6bP7NesP5VxQl+0hGJGzEhADK6rYgxVRBTeulQvxjVJ+VYmdYFwJ6HwPtYBDXJoIlR5syQMfKmFst3tHgP003Hd6W6zNKrenmMotoeHPjq35LESMph4135/FcI2Y5aNBMpqxZ3SuN2Bw9AQZB3GZj74MNbNkO3o0EDuI6n+Vm1t6lU80yTRaOd1Iju+Uoob3RwA9g9EZ2gCSGWN0yprcXILO+EjHqQSubmNZkm2IYFht+2533I3YKzCq6s8oCrn5LSuLhQP9O+o9ttSE6uuPGSLr0IuRp/XskiqWzkhnyalR3S34agF4wSDc7AZZoGKhuobsP2GzvbAKFxTVYQ9LAsmziwhjgStp/IZZuFK6dnUCqWIpmPVvJpyglzmq5Wr5ArF5dzpBCLMIH XV7++aXI H59+xCjphZtgSF6VlZFbo+pxiHwrtVzcefrtfqrEZoh/+rG8mbMkFlMzLA8dcqnWWqHp6iiLv8Qq7qLDmbzz7hwRjECBTZ+yCiFbkliZEbe2DJRlki4l16IUIkgo/Z5wdccHup2Y84Gvug1nzQJNMHMllZVoPuSsO2hs1BO0Ll28Lbk61oGJDfn+BMFuUD4A3NTYexSp1E3Kg9s9xiJfY9L/Y8jMePrdknZYJLx8hCUYU3pGvhquu20qw1+hUyRrYuP1k6o03Fh0sirN9NTKgsx6+BXIzIVe4eFGzUOANlB+0ayj7ifqXG+P0E75rw4J1Y+fDyFZlLgS3gFCHIAvWgqVhWP0n/QwU3CZroSfrbMaaP3y2TvBN6zdcAbwr847H1PMfdDDnO3jW7MBxzyZxifWlR8wCFZ830yY0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Oct 13, 2024 at 7:51=E2=80=AFPM Lai, Yi w= rote: > > Hi Andrii Nakryiko, > > Greetings! > > I used Syzkaller and found that there is BUG: unable to handle kernel pag= ing request in build_id_parse_nofault > This is a memfd_secret() file, which needs a special treatment, I'll post a fix soon, thanks for reporting! > After bisection and the first bad commit is: > " > 45b8fc309654 lib/buildid: rename build_id_parse() into build_id_parse_nof= ault() > " > > All detailed into can be found at: > https://github.com/laifryiee/syzkaller_logs/tree/main/241012_225717_build= _id_parse_nofault > Syzkaller repro code: > https://github.com/laifryiee/syzkaller_logs/tree/main/241012_225717_build= _id_parse_nofault/repro.c > Syzkaller repro syscall steps: > https://github.com/laifryiee/syzkaller_logs/tree/main/241012_225717_build= _id_parse_nofault/repro.prog > Syzkaller report: > https://github.com/laifryiee/syzkaller_logs/tree/main/241012_225717_build= _id_parse_nofault/repro.report > Kconfig(make olddefconfig): > https://github.com/laifryiee/syzkaller_logs/tree/main/241012_225717_build= _id_parse_nofault/kconfig_origin > Bisect info: > https://github.com/laifryiee/syzkaller_logs/tree/main/241012_225717_build= _id_parse_nofault/bisect_info.log > bzImage: > https://github.com/laifryiee/syzkaller_logs/raw/refs/heads/main/241012_22= 5717_build_id_parse_nofault/bzImage_8cf0b93919e13d1e8d4466eb4080a4c4d9d66d7= b > Issue dmesg: > https://github.com/laifryiee/syzkaller_logs/blob/main/241012_225717_build= _id_parse_nofault/8cf0b93919e13d1e8d4466eb4080a4c4d9d66d7b_dmesg.log > > " > [ 26.168603] ? __pfx___build_id_parse.isra.0+0x10/0x10 > [ 26.169447] ? __pfx_d_path+0x10/0x10 > [ 26.170068] ? __kasan_kmalloc+0x88/0xa0 > [ 26.170743] build_id_parse_nofault+0x4d/0x60 > [ 26.171473] perf_event_mmap+0xb44/0xd90 > [ 26.172134] ? __pfx_perf_event_mmap+0x10/0x10 > [ 26.172895] mmap_region+0x4e7/0x29d0 > [ 26.173526] ? __pfx_mmap_region+0x10/0x10 > [ 26.174210] ? lockdep_hardirqs_on+0x89/0x110 > [ 26.174956] ? __kasan_check_read+0x15/0x20 > [ 26.175655] ? mark_lock.part.0+0xf3/0x17b0 > [ 26.176369] ? __sanitizer_cov_trace_const_cmp8+0x1c/0x30 > [ 26.177277] ? arch_get_unmapped_area_topdown+0x3d6/0x710 > [ 26.178195] ? rcu_read_unlock+0x3b/0xc0 > [ 26.178879] ? __sanitizer_cov_trace_const_cmp4+0x1a/0x20 > [ 26.179808] ? __sanitizer_cov_trace_cmp8+0x1c/0x30 > [ 26.180634] ? cap_mmap_addr+0x60/0x330 > [ 26.181300] ? security_mmap_addr+0x63/0x1b0 > [ 26.182029] ? __sanitizer_cov_trace_const_cmp8+0x1c/0x30 > [ 26.182930] ? __get_unmapped_area+0x1a9/0x3b0 > [ 26.183705] do_mmap+0xd9b/0x11f0 > [ 26.184291] ? __pfx_do_mmap+0x10/0x10 > [ 26.184938] ? __pfx_down_write_killable+0x10/0x10 > [ 26.185758] vm_mmap_pgoff+0x1ea/0x390 > [ 26.186413] ? __pfx_vm_mmap_pgoff+0x10/0x10 > [ 26.187129] ? __fget_files+0x23c/0x4b0 > [ 26.187803] ksys_mmap_pgoff+0x3dc/0x520 > [ 26.188490] __x64_sys_mmap+0x139/0x1d0 > [ 26.189143] x64_sys_call+0x18c6/0x20d0 > [ 26.189805] do_syscall_64+0x6d/0x140 > [ 26.190425] entry_SYSCALL_64_after_hwframe+0x76/0x7e > [ 26.191238] RIP: 0033:0x7fb10be3ee5d > [ 26.191837] Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 4= 8 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <= 48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 93 af 1b 00 f7 d8 64 89 01 48 > [ 26.194753] RSP: 002b:00007ffe95b14e28 EFLAGS: 00000212 ORIG_RAX: 0000= 000000000009 > [ 26.195976] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fb10= be3ee5d > [ 26.197126] RDX: 0000000000000001 RSI: 0000000000002000 RDI: 000000002= 0000000 > [ 26.198282] RBP: 00007ffe95b14f50 R08: 0000000000000004 R09: 000000000= 0000000 > [ 26.199471] R10: 0000000000000011 R11: 0000000000000212 R12: 00007ffe9= 5b150a8 > [ 26.200606] R13: 0000000000402eb7 R14: 0000000000404e08 R15: 00007fb10= c078000 > [ 26.201757] > [ 26.202132] Modules linked in: > [ 26.202663] CR2: ffff888010a44000 > [ 26.203219] ---[ end trace 0000000000000000 ]--- > [ 26.204002] RIP: 0010:memcmp+0x32/0x50 > [ 26.204685] Code: 06 48 39 07 75 17 48 83 c7 08 48 83 c6 08 48 83 ea 0= 8 48 83 fa 07 77 e6 48 85 d2 74 20 31 c9 eb 09 48 83 c1 01 48 39 ca 74 0e <= 0f> b6 04 0f 44 0f b6 04 0e 44 29 c0 74 e9 c3 cc cc cc cc 31 c0 c3 > [ 26.207669] RSP: 0018:ffff88801fa675f0 EFLAGS: 00010246 > [ 26.208529] RAX: 0000000000000000 RBX: ffff88801fa67728 RCX: 000000000= 0000000 > [ 26.209655] RDX: 0000000000000004 RSI: ffffffff86583240 RDI: ffff88801= 0a44000 > [ 26.210801] RBP: ffff88801fa67750 R08: 0000000000000000 R09: fffff9400= 0085220 > [ 26.211929] R10: 0000000000000012 R11: 0000000000000001 R12: ffff88801= 0a17c00 > [ 26.213053] R13: ffff888010a44000 R14: dffffc0000000000 R15: 000000000= 0000000 > [ 26.214186] FS: 00007fb10c02d800(0000) GS:ffff88806c500000(0000) knlG= S:0000000000000000 > [ 26.215467] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 26.216393] CR2: ffff888010a44000 CR3: 00000000124e8000 CR4: 000000000= 0750ef0 > [ 26.217533] PKRU: 55555554 > [ 26.217989] note: repro[728] exited with irqs disabled > " > > I hope you find it useful. > > Regards, > Yi Lai > > --- > [...]