From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A09A2C433EF for ; Mon, 1 Nov 2021 23:47:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 23C5960E90 for ; Mon, 1 Nov 2021 23:47:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 23C5960E90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 952CE940033; Mon, 1 Nov 2021 19:47:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 902BB94002B; Mon, 1 Nov 2021 19:47:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CA6B940033; Mon, 1 Nov 2021 19:47:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id 6ABC294002B for ; Mon, 1 Nov 2021 19:47:28 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2D63C184215FE for ; Mon, 1 Nov 2021 23:47:28 +0000 (UTC) X-FDA: 78762000534.27.3E8E88E Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf22.hostedemail.com (Postfix) with ESMTP id BE8A9190B for ; Mon, 1 Nov 2021 23:47:27 +0000 (UTC) Received: by mail-yb1-f174.google.com with SMTP id q74so42682388ybq.11 for ; Mon, 01 Nov 2021 16:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Sf1MOARYDjP4TdzVuSLyJGMCk0C2bT96cLtb/iSHOvE=; b=SmRguYNmZ65IXjC5kS7UQZRTfWQSdxG3tt0NMqEE3jWrUYTo0GxWeERHGJGqffLMhO mUpNaR7C7soFG4z0owyxtBpWpkIIwvI7NmZ1X9AdSpHW94bF9X0F2JYuleAt/1sHg0L/ 5zrYaqQwj0Suq5S5VsmoV1AZdC6+4yP/fsMOSEXMRg6e4wm0lhJ2QLDw5Gk9S7qwsRw+ 4Ge1C6z+tXJAZUZgehS4GLqH1/7jQ+JcX7YrRez6DqCs2zac2rP50sEIyn+lO7WeZt0c XBXE/edBJBpIPW+IBzEvHdctfSqV5hvPkoQfNas342hISax3YHARRiHhQ7FBsPBgRiOl mZFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Sf1MOARYDjP4TdzVuSLyJGMCk0C2bT96cLtb/iSHOvE=; b=5yHG3pllRd7OVkeeEkL1Fg8x18yVJayM+qn/q2Scw8DIYhmwgWcVRO27pOed8pZ6a+ t2MZTfMZM37fj/nVQJZ06lElqRgK3is+x0k6rwK7zMK7vin/lBzvbVKkWO6ZWwlwYWPJ /XecuMhfBxnOhSsVrecQsEbfkoXKrM/Tykuc6geYfrOhorTwK/ZilGb/z5m0q4zOPjS7 JnwtgtAed2Z1hDnjzr7QhbqNo3CwuTUYUKu8/CVHMx3/eXlTVtbjNcZNCVGuR3MDT50q y4xdi1Yn0pukbGJuwBVUC7rPoFdxtUGeHTKWDZnN/h/N6NOGuaGh5eT38NFvkGxI4KDg SpkQ== X-Gm-Message-State: AOAM531JOPejFKmGaRzVAd6nteUwnUVnO7GkHpNSYh5mY7G+QHKspgeb aVf8k76WuHwthWyDdsM4uCU0ya46wuQ94YTjkM0= X-Google-Smtp-Source: ABdhPJxxytkF+I+xIYE57g7IWWkQCLnoV8y619WwaJHG8gGGeHV30HWL8AmkKNk7EfNuLQNSutDI8kZo20T/HYQbqVA= X-Received: by 2002:a25:d010:: with SMTP id h16mr25598551ybg.225.1635810447094; Mon, 01 Nov 2021 16:47:27 -0700 (PDT) MIME-Version: 1.0 References: <20211101060419.4682-1-laoar.shao@gmail.com> <20211101060419.4682-10-laoar.shao@gmail.com> In-Reply-To: <20211101060419.4682-10-laoar.shao@gmail.com> From: Andrii Nakryiko Date: Mon, 1 Nov 2021 16:47:15 -0700 Message-ID: Subject: Re: [PATCH v7 09/11] tools/testing/selftests/bpf: make it adopt to task comm size change To: Yafang Shao Cc: Andrew Morton , Kees Cook , Steven Rostedt , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Petr Mladek , Peter Ziljstra , Al Viro , Valentin Schneider , Qiang Zhang , robdclark , Christian Brauner , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Vincent Guittot , "David S. Miller" , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin Lau , Song Liu , Yonghong Song , john fastabend , KP Singh , dennis.dalessandro@cornelisnetworks.com, mike.marciniszyn@cornelisnetworks.com, Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, Networking , bpf , "linux-perf-use." , linux-fsdevel@vger.kernel.org, Linux Memory Management List , open list , kernel test robot , kbuild test robot Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=SmRguYNm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com X-Rspamd-Server: rspam03 X-Stat-Signature: nd7fzqjjg7z3isaw8dnughzycismdzwu X-Rspamd-Queue-Id: BE8A9190B X-HE-Tag: 1635810447-290587 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 31, 2021 at 11:04 PM Yafang Shao wrote: > > The hard-coded 16 is used in various bpf progs. These progs get task > comm either via bpf_get_current_comm() or prctl() or > bpf_core_read_str(), all of which can work well even if the task comm size > is changed. > > In these BPF programs, one thing to be improved is the > sched:sched_switch tracepoint args. As the tracepoint args are derived > from the kernel, we'd better make it same with the kernel. So the macro > TASK_COMM_LEN is converted to type enum, then all the BPF programs can > get it through BTF. > > The BPF program which wants to use TASK_COMM_LEN should include the header > vmlinux.h. Regarding the test_stacktrace_map and test_tracepoint, as the > type defined in linux/bpf.h are also defined in vmlinux.h, so we don't > need to include linux/bpf.h again. > > Signed-off-by: Yafang Shao > Cc: Mathieu Desnoyers > Cc: Arnaldo Carvalho de Melo > Cc: Andrii Nakryiko > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Al Viro > Cc: Kees Cook > Cc: Petr Mladek > --- LGTM, thanks. Acked-by: Andrii Nakryiko > include/linux/sched.h | 9 +++++++-- > tools/testing/selftests/bpf/progs/test_stacktrace_map.c | 6 +++--- > tools/testing/selftests/bpf/progs/test_tracepoint.c | 6 +++--- > 3 files changed, 13 insertions(+), 8 deletions(-) > [...]