From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 790A6D0EE28 for ; Fri, 11 Oct 2024 19:41:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C461D6B00AE; Fri, 11 Oct 2024 15:41:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF6566B00B0; Fri, 11 Oct 2024 15:41:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABD996B00B1; Fri, 11 Oct 2024 15:41:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8D5176B00AE for ; Fri, 11 Oct 2024 15:41:48 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BC15F1A0DFF for ; Fri, 11 Oct 2024 19:41:39 +0000 (UTC) X-FDA: 82662341412.07.F3FF4B2 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf04.hostedemail.com (Postfix) with ESMTP id 523F540004 for ; Fri, 11 Oct 2024 19:41:42 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mybfc50U; spf=pass (imf04.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728675567; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GFisYns8aYjAhl6piQqkukXDSbbS3j/nfB3lQWveeRc=; b=tCKAYuCerX6iPPjaoVKeEA5hGhRH8XkzETMxjbDhFeAFuxSSeZHynIQ1nFy3K2kAP/nl/h c9rHmLeSLfxiW0TzjDPNQbvUHx6wHmE8sxafciAikeKx0TJDTrwZafMhLowNjGeNwoq8/z l7nl77Fzumt2IUI1vRWOXmZrPsCVC7A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728675567; a=rsa-sha256; cv=none; b=N7Ct8FCZr8GpVapRP3Aa6uuCot+Bc83DYg8GLa0v3wkmm5x5t5236gNEkUe2vvJgsWmpHx v+bhude5d/GJYnBpcP0F80ZKt9OXWwBnB9Z3S+Ci95kR/u3R3SsM+ViAJfbOlC9TDyXqO2 FPGX269uvbLgUJ2bBCcXU5HjQJpXVpI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mybfc50U; spf=pass (imf04.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7e9fd82f1a5so1604348a12.1 for ; Fri, 11 Oct 2024 12:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728675702; x=1729280502; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GFisYns8aYjAhl6piQqkukXDSbbS3j/nfB3lQWveeRc=; b=mybfc50Um1QDkYv63N9pAbUUAZ/ZoOYlreo8QURZBeC/XbjilGEjhlcWSMkK3v+YuQ bdtcomxXRKPudjqUedxZDUdrLxGRNDh8NrszGVN9Zi3e/nHK18E2pL3ibW2PKNOKo4FU GgXynFw59EXVuyg7I4TTv9J521JZyBQiAqSbWpH+pMtO2GgIFojMtjc17RaR72oor6GY AC/PYF3qDi63cCUzXhsNJNH4CHoIjH9bJc965lq9Z6aZCXRo/awtUWsTeSu1eGSwpiQm eCNgj35HgNyTMYmzoz/viGFuWsgRHTFrTpHpC8RR8/FMK1ms3Olit8PSGvlWrwkqZsT+ ez3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728675702; x=1729280502; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GFisYns8aYjAhl6piQqkukXDSbbS3j/nfB3lQWveeRc=; b=B65AVxPOFvjPdA4DtnVOyga3EnecyWWDWtgUv05PNcb0zVYfUiGksjq5wLOcSfVdWA o1np0wwVTbdQ4UGpzStJfX+huihXQSqWHw0IcpE79Xsw/IrBPq3fA8/bC8ZRA/f9wt2/ NatldkLDhp0XwHgOModws0SkWKR4md0WvOL3xcoW5xbriLWU/BzcGX8x13Ap9keEsh4R HfuYEwFE5rhHdxuiP0SAPxdnGanZ4XV/FoBegabppBoqwnVY6LUeNB6uRHowZ0HXKK78 AgaZiiDpcuRG2OzfZHhDG7QOGNXxp77C1SzFHTBgHv4ROp0mAUgpsJRkdMLHca7fc9tg tUPA== X-Forwarded-Encrypted: i=1; AJvYcCXGMkIxkwhMI2NuWHrhRd75nv1SxAQ3M0906k1iyR6MgFp2RzFTcM5D4KNj0v3LyOe1+8k5lAHNFQ==@kvack.org X-Gm-Message-State: AOJu0YwjdS9aer/ZkvHCmL7Izslv8wQ0H84ljevp/YrT6l/mZwkNjUto 8A3lioqBc3MC9+CL0qoAD+McDfyMciP58maoHYUQq+N6734BqiRFQN1J2Ak39YvcLvW6E5hr1Jn 0JaR2aTt+S7pBX4bhW9zo1M0UJE0= X-Google-Smtp-Source: AGHT+IFnIrTaf8dYQzeaJQDq3FbVwzr/O9BD84DlhpqT0nVFykaQwNo0eH2D8Ozpoz1RPjpQ+hUs1KhMQ/opmBDuPvA= X-Received: by 2002:a17:90a:fe18:b0:2e2:af52:a7b7 with SMTP id 98e67ed59e1d1-2e31536e834mr601877a91.34.1728675701822; Fri, 11 Oct 2024 12:41:41 -0700 (PDT) MIME-Version: 1.0 References: <20241010232505.1339892-1-namhyung@kernel.org> <20241010232505.1339892-2-namhyung@kernel.org> In-Reply-To: From: Andrii Nakryiko Date: Fri, 11 Oct 2024 12:41:28 -0700 Message-ID: Subject: Re: [PATCH v5 bpf-next 1/3] bpf: Add kmem_cache iterator To: Alexei Starovoitov Cc: Namhyung Kim , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , LKML , bpf , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm , Arnaldo Carvalho de Melo , Kees Cook , "Paul E. McKenney" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: rkroehbfgxgip5qzw1r3rf1ncg1kzzht X-Rspamd-Queue-Id: 523F540004 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1728675702-703381 X-HE-Meta: U2FsdGVkX18u6XdJHIRRuFmGXjQ5ngV8JLTeiLZQkxhBdrKkEwHeWUGlimoRoa1q0wCEQhHeBTznByULmGfh6n/u67ArphRUjiTmCqM8ZSCK9t2Zue807q74vTaovwdE7pxORaQLDGnHH2mfR8gsNITHICBb0R8c3vt05vyLkjLVpo429w1B/egYExxhfTTZ1xvorYcOezdxsjqsreSFRH5Q4AbrL66HcxHTnn4WH1AfYLJW9aE3lrcNG0UCKJosTnHp1fHOL5mbkG8Ry8WpwPWlH3fZU7m10vMwaptiBqtG6AGvga+8AolbNbDFhww+89OuSBhD+peXMB7SuuDc/k3BVA64MD1xzE/gxIz7Bpkv3RHO7naviYg1pVoLCr1ZIj9e7DsirCxH25Q4siBAnTSbzCxZyCzAC4O0TWdfDJXYBdrIos+rn05k65OUpy8MYD2DZSkDZ72Cw4aJbxDidwNPverWqcfMBxDY8d5LdgWdeU9FghODK/JgUv0Lk5F3kn8Iv3iqOg0RYLGIPuVaZpm83GdV/eH7E5t1fb067TesyFUqrdv/r+4/z4YLM7x+zVHz2XFaMDvUgST753d3b7fjJ9FaTYXQSFJRdTJ81fq/EZ8IT/ucx3SKkF1LUWJxT4s0/Ia0RGkSZjEPrzMl+/Uu2n4MsR19jD20fIRXZGkR+Gr5jKPSU8MT0De+NNmtS5UQOV/UP1viGshdthlOLW2ofk4ZZBj+ALXGDAukoqhkImwXlh0EO0DhBkfHz4m5X2gCSa7/sdN+tOMooRPOD6sX6iqpbuOxj5414L7tGig30FUMdlNbONNQq7f06zDzTinp4GnC2ZPPy/0oRf+ChSMvXWjoFHo8psphRt3NCnd65VZ6UObEaANwr2LsnlPQMTENw98Odhhk8B6qSUy+ByhETnqzhI36Yq2ChFtJvFLo81zCrgJpHKo0quGu1yxU7oYJbWpPuuEzGcMXho5 wg07fN81 u93VAgAt/+Iff/0Dj+qjzXylt1yo9XHP4JgihX5Cc7vRJBgT/Lt29VbA9D5i23+CtJDFid0SE9CCTwaCqftX24dwutFtJ96V2ROlOtcs/Khe0B6UMrUyiPpGGPyeq4prQDkoz7IjW4XNscBSW+F6vlybuf+OMC6xkJo3wD1FmapsxFiMPCXO2+zQQJXUoVcn+M9Uxt/FzO9GwC1+24/r6oqUPFJDkCeO7Rvboms2xkILDvkFtmzdvx0ou6+iYIJns5OCJ1Ef7YW0kydTjN2EfHB7iLeky83VYzhUCIVW+aabfgC/rmDKxEZ/PO8uB+kR8XYmvfAmd8S68BVw19AQaak8tqm2ruqQBXzBcMrc2K1uzHfAxhCf6YR7MQVDC8S2cy/Vp9EedeJryhbnEPFtjQecGVOHHR336+GEcIJxKUtcvx8pQ6Ip7DT2YMp9m4HDsH+NqrY+bRUNMRP4V2DuHEwS5HR/6NsiZtElqiDLA+mm+jg+YU7/HD9YDhrb1lGBBf1Xf7XYRwQ5rsrM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 11, 2024 at 11:44=E2=80=AFAM Alexei Starovoitov wrote: > > On Thu, Oct 10, 2024 at 4:25=E2=80=AFPM Namhyung Kim wrote: > > > > +struct bpf_iter__kmem_cache { > > + __bpf_md_ptr(struct bpf_iter_meta *, meta); > > + __bpf_md_ptr(struct kmem_cache *, s); > > +}; > > Just noticed this. > Not your fault. You're copy pasting from bpf_iter__*. > It looks like tech debt. > > Andrii, Song, > > do you remember why all iters are using this? I don't *know*, but I suspect we are doing this because of 32-bit host architecture. BPF-side is always 64-bit, so to make memory layout inside the kernel and in BPF programs compatible we have to do this for pointers, no? > __bpf_md_ptr() wrap was necessary in uapi/bpf.h, > but this is kernel iters that go into vmlinux.h > It should be fine to remove them all and > progs wouldn't need to do the ugly dance of: > > #define bpf_iter__ksym bpf_iter__ksym___not_used > #include "vmlinux.h" > #undef bpf_iter__ksym I don't think __bpf_md_ptr is why we are doing this ___not_used dance. At some point we probably didn't want to rely on having the very latest vmlinux.h available in BPF selftests, so we chose to define local versions of all relevant context types. I think we can drop all that ___not_used dance regardless (and remove local definitions in progs/bpf_iter.h).