From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97F2CC4829A for ; Wed, 14 Feb 2024 00:29:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10D148D0011; Tue, 13 Feb 2024 19:29:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BC758D000E; Tue, 13 Feb 2024 19:29:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9EF98D0011; Tue, 13 Feb 2024 19:29:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D70078D000E for ; Tue, 13 Feb 2024 19:29:58 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9CA26A2370 for ; Wed, 14 Feb 2024 00:29:58 +0000 (UTC) X-FDA: 81788526876.18.DB94051 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf28.hostedemail.com (Postfix) with ESMTP id B78EEC0015 for ; Wed, 14 Feb 2024 00:29:56 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gAdokRRR; spf=pass (imf28.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707870596; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5fux2eg+/xiPmeQA+sAKohz2TvVs026HnNubH/qW0Io=; b=h/Ql6ppDfSq0SKHcFCIiQWnllLKo5puM0uvClbZgj6QJ9/iuHvE50qN17juTnFc5AypVIW 95npog+kv5l+M18VGWvPD5CJ2m1dSTtxlLNjYVFKApN7/6iwDlWCdlxdlgt28oFM+bkQLN 5iirk41q/8dVxXd1eq2oqV0gtZnXkJw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707870596; a=rsa-sha256; cv=none; b=IFgrIRizb/Zv5sAHOcLB6CwVv4s8m9x61NnVmWOf4Xkkg8PNgBMhl140fCs4VfpybsOGhF zeHcaEW7utJTNxtWJYMWzD/vC4Eza8k+H7P5PlGbJqz5kpmEzlg6vpf5L+IFfIOq30jTfw pcVdpnSZPF2PPYmN0HFHxUoWem8JlvE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gAdokRRR; spf=pass (imf28.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-295c67ab2ccso3032522a91.1 for ; Tue, 13 Feb 2024 16:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707870595; x=1708475395; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5fux2eg+/xiPmeQA+sAKohz2TvVs026HnNubH/qW0Io=; b=gAdokRRRCsH7OxlGSiEUE2rfjfEdCpPNfjojlIxUsb6Q6oAfI+q6d7Un/ATZlQSKsq EzdM8wdTgwyP03djVgXOE27flQ4cBvd+l/OepvkGy/VunFv8PtOLF7pfHVyqkrVbWj9O 66gBg4IcxAaMsg47BViNSEJq55lJCk/p2/pi7I62H60/NEboAIXqpWJDj1RZYY6e5p8v LsSijb+9M30qDkIHoXc9ElXZQWtqJTix9VbMtdPpUeWyGG2c1pBE9jp/p96k+Yn9IeLH +CWPiQA6kkVAWPgYClR6IxV5AKEzgRJaJFt6VSA2/skmeAFjIvRm/Yc1GZdtPO8woghv t3qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707870595; x=1708475395; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5fux2eg+/xiPmeQA+sAKohz2TvVs026HnNubH/qW0Io=; b=azJDeJFBwZSEbJb4Srl5eFOvIvt4OO/VRyhUY5YsvPBZ/2p/k9HdQ5wLuLLE6mQIoo G3j9PexQ1PaUDorzC4Kdsw8X7yeQaWJTxhAaNbCqrWcXHjJ8sj9t2K3OycY5PpSzVbjs JLt04FsY0xSS/MgXWm7YfnNci+W7meKXF649mSipBdId45EcY9E5gSAuwAgNfSld/FQe q/TIMDHiWjXIiNKMQYtmYxBRAc4srt6frG0sISfZ8p0WdspUNq8efiksvzJYG3KoGkE0 uwW0SrvVcmA5fWiI+8vt6UFqKVoZGajA8cMjz9IWHvPYF8xijatGo1ZgwRvZ36wndEwE 0XeQ== X-Forwarded-Encrypted: i=1; AJvYcCUwXSqmH6LEq20FMJtGi+TudrYkKyBeyMO+a+yOagP/QY4K/7ph148kftl2gbGD/ecsH1Yfcj5QgGKKHacoXGmvx7k= X-Gm-Message-State: AOJu0YxpnAdB3HT+/H0I+E06H/NJWiqT9qXXvddtXgWc+chZbZf1Rovm jsgrvcanNB6zjAYMcB9uyAHXI0C6ac6681a2HJ05zNhkzeeXQ5slKwM7lOHYYHW3Qk4QSD52iW4 pUzSB9VucV43bSkszSi0zSysxgcs= X-Google-Smtp-Source: AGHT+IE+v7yJbxaSsKt94A+5QCquxuqInjdOBaGqge2m9ZHyWfFqhEW6nZsCuTM3G/VkJGuLfjB4TRS/15NNUOOtnoQ= X-Received: by 2002:a17:90a:f40c:b0:296:15ed:b220 with SMTP id ch12-20020a17090af40c00b0029615edb220mr885759pjb.45.1707870595471; Tue, 13 Feb 2024 16:29:55 -0800 (PST) MIME-Version: 1.0 References: <20240209040608.98927-1-alexei.starovoitov@gmail.com> <20240209040608.98927-15-alexei.starovoitov@gmail.com> <7af0d2e0cc168eb8f57be0fe185d7fa9caf87824.camel@gmail.com> <978e656fb27850b002194f0cfdbe603997ef70e1.camel@gmail.com> In-Reply-To: <978e656fb27850b002194f0cfdbe603997ef70e1.camel@gmail.com> From: Andrii Nakryiko Date: Tue, 13 Feb 2024 16:29:43 -0800 Message-ID: Subject: Re: [PATCH v2 bpf-next 14/20] libbpf: Recognize __arena global varaibles. To: Eduard Zingerman Cc: Alexei Starovoitov , bpf@vger.kernel.org, daniel@iogearbox.net, andrii@kernel.org, memxor@gmail.com, tj@kernel.org, brho@google.com, hannes@cmpxchg.org, lstoakes@gmail.com, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, kernel-team@fb.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B78EEC0015 X-Rspam-User: X-Stat-Signature: euzktkezfhingj4ztsqinuc7yjne46p8 X-Rspamd-Server: rspam03 X-HE-Tag: 1707870596-261203 X-HE-Meta: U2FsdGVkX1+U620fF0aiEbaTKJjcaXQbnAOfi/MYeRD9WW4+oywmaTqhvXCcEiCcHUQXVmqPfvAA8PMgf6d/mt1RhcgvEocqtWBK/4orGTKcLX2NVJJHQphvJy6f19rjZh+EiRVULiwI4AEQ4jlpCELg9YPlCenGBkGp9Xx+uAlUpQw7/h0blTZpul7DuLCLHxiGQ0T//Yy49ZwTjDz7MgoNRVKbwfdnBKYnqNw9ONUy0mX/WMSjNP6U9GYroburO0y8CkvuvgY9SpZW8N5C5JT8dWQ6iTEsk8erspbvHDGAfsOAxNz4Yno4WTZUUnOBvZpXJTnZypYie2/v3nyQDaS1fypKOgLC1lu+mZBJYmi/gGmpjveJzG4coSC5km1AA9XMUkV0KEmL45RKEAF9PORzmOx/Xldy30IA0CWOcWAoMDhU8dvzBk8g6Y9Vh8+Dq06HvZ4Gd/Eb7gedMLEg+SzxbofSPzZDMGYUgfcAZxvnQlqmz07gEnOdgRbiP9OPbX0TUz8TM+e4xyzLJXxqWbIkTV6/J6Pd5vetMl45G3QAyO3TKcdqySSW3W2bKz8bPWMt3LVjF3Q73LVe8LXK6T/dH1mdidk7Vv5CVFTHWEEoPPfcD0nPpHBe6WCsHkneLoy6nD6bGA2S54MDrOBInUql6tMBIs+ZCjoEalEM6pDVNE9Y7Xd7rKkZjgvMhA6oveQTzHw8HJ1Q4iyJQJjIrqY3JvaB6InC/jq1GKfTqGuZp+ozjpsNBRJBQF0NIFk+I8uLySObtEoXn11Ntzz2+uhnsvCkbTaVehQ58D+i7XjBL8Ef3GsosK/ggG+lOvrfS7Lx9G7H7wRTLq5I1xV02sqYxTK1qUasVxndCebuMCajqc6IwrR/1pV9Ha+Uj5/I6TeDrjv+C5vlBduLiu3oxt7EXPt4ci/a6RL0zbtupGOZ8/1ZwIE8pBH7a/rABgDyrjdnC9dFRgtvLe1sWUz In9+Sptg 9toKBvUXcG1vueGLa2Yj6SR7qVCahZvlBqT9IBnDRkQrdQ75C9yVfZqE7yMC0yg+fhGPFFuzl7s+Phf6Cjk6HUr+odfk39GW3+ZcSZmucCI2iJbM24bDQgw89hqsYY72av5c6dKDPRjQNOtbmF1X9B3o+PrjWcL6UhxsEbFwb9fI7KbiTBr6aznWWWxPLD6t0SSmRLUFPiLHD9JuvmSXrLGCuDOuzdYorShZEMSmK8Evs7zusMok4JHQqsvtNqiPW2D7zTHcxfOs6jMcHy9oGkvp4wKICFuvBImJtSKOcTLGjKAZCCutPF1vgCVmAv7nLdL5nlKDka1WXlf9psB6wQYVfTPz5CGjVOjpc2q+OgYlbKEq/RqbeZK1wmVIRRsDf3AAF/uHmGAdYptowXf9PDL5Z1VfgM6iFphvoUNjpyC3RGY51i81gSvYpzj+zVX232y0ojgJiVAGjsv+nTTBo3zGgTtr4rtT8FSrBvL5GPdZbB10= X-Bogosity: Ham, tests=bogofilter, spamicity=0.027584, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 4:16=E2=80=AFPM Eduard Zingerman wrote: > > On Tue, 2024-02-13 at 16:09 -0800, Andrii Nakryiko wrote: > [...] > > > The "fake" bpf_map for __arena_internal is user-visible and requires > > autocreate=3Dfalse tricks, etc. I feel like it's a worse tradeoff from = a > > user API perspective than a few extra ARENA-specific internal checks > > (which we already have a few anyways, ARENA is not completely > > transparent internally anyways). > > By user-visible you mean when doing "bpf_object__for_each_map()", right? > Shouldn't users ignore bpf_map__is_internal() maps? no, not really, they are valid maps, and you can bpf_map__set_value_size() on them (for example). Similarly for bpf_map__initial_value(). And here it will be interesting that before load you should use bpf_map__initial_value(__arena_internal) if you want to tune something, and after load it will be bpf_map__initial_value(real_arena). While if we combine them, it actually will work more naturally. > But I agree that having one map might be a bit cleaner. +1