From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 251FBC6FD1F for ; Thu, 16 Mar 2023 22:37:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7BBC900004; Thu, 16 Mar 2023 18:37:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2A70900002; Thu, 16 Mar 2023 18:37:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F256900004; Thu, 16 Mar 2023 18:37:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8FB85900002 for ; Thu, 16 Mar 2023 18:37:01 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6097B4014D for ; Thu, 16 Mar 2023 22:37:01 +0000 (UTC) X-FDA: 80576223042.13.1F94CED Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf02.hostedemail.com (Postfix) with ESMTP id 9906080013 for ; Thu, 16 Mar 2023 22:36:59 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ij85mTrQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679006219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gDnCsGM/FV1yfEUIqdP+WO9uXlOSf1wmfPkNbc+Ep1A=; b=0HJv6wv0oMGNpvPscvJvkB1il3AFDCBExO6UjUzpJcg9kT2PicqTDhoFEOyFwHWCR4f7H6 jfAyLJVtW7WIwdOGBZXo1oVprcL3tSphSmdvKOl0VCfAXSbt0xHb5yXux9HopgdZrXEFyw 79DABTS3IfVLQHdPvYbPjCnkjHxmVoc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ij85mTrQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679006219; a=rsa-sha256; cv=none; b=IGpU9onQxz5w/HA5n+2bEJ2rTVFiTakxTtBhLnnTkIxsH+lOtjkq5nRx8FCPsz6RqKdpe/ 0ipJ7ycXRBx9RCsSaep4UFnMecJyoAR0VBSjhmQZOiMEXKAo1PRTP5r22jErsPuIHIOcNK WhkoB+DYWfBYOsULOng+awwaAR2oKhs= Received: by mail-ed1-f45.google.com with SMTP id fd5so13572013edb.7 for ; Thu, 16 Mar 2023 15:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679006218; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gDnCsGM/FV1yfEUIqdP+WO9uXlOSf1wmfPkNbc+Ep1A=; b=ij85mTrQsntyqaM6cYuQUcOw0ZVEZaogn+UmtL4AdzKsjIpIykVVEc9T6NaoHuSvFn qD5fBvBqM4pVlBiGKwVOang8C1VcmLu0t936OUjLkRl5Ncv/21XOHsFhl3BhGRopkJ0i CprpN/fg55PCEhGt84hVw2ojJHBdULh01mjLVDfBFcLZ3/UesQBOx0EWab76TTpaN4hJ Gv0AdjlgBN9Ft7BZkZ08+kYX9AGR6MrGWY//APrptfEuaoU07bwqvCjsKdZOg4mLzvVn wCUKhdj74B1mdK4nIveVEfIc45r3R2s0whRYhcLvV/MWBNeuaggNKngOnWpmIodrP+BY aHLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679006218; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gDnCsGM/FV1yfEUIqdP+WO9uXlOSf1wmfPkNbc+Ep1A=; b=WSqdQOihFv1HdhszirLqWhm+22NA2X4nlWFKstiaaZDKWl4mpiM0TvdB45YgeFvuc0 vwfaSeuCkrijmxBUAq82DzO6Uz2QO5RvXxN92DbzbwfmVQEhjezqQx0V5npzpid3yp90 o7bO0+MI32D1YERRqnZT2Vq1O3tJUHRP4V7opSLSqM6hOfc7B3Po5m9oPexeLG6bHS7l wVtjUYmkCq3OxjpFaVsB7X1Q0y5aYAY9oHYgJRFZqQL1gdztArhRseW9slNBrzbOtEid l3hVjzA0H7MPSfyH8IXvjR9TewxvoeF7UZHx6JgrY5XPKU3mybDsKBl/L4s345gGVClN CzhQ== X-Gm-Message-State: AO0yUKXDeDi+WNZBR0zNa4y1fX+/WDXp9/4zlgHuW73nLNjq3M69xycZ ARYfgqHmkKb6WQU2NbKo7YVvVXR7C92AnobCwGM= X-Google-Smtp-Source: AK7set/fYofBPE5FDtJ+WwJR9R3P0GNPMgNfhVh7QImSlv+fd8oGgSx09RSedQu6am3rrZne9IkTLIcoG7c1+0R1TTk= X-Received: by 2002:a50:8e14:0:b0:4fb:f19:883 with SMTP id 20-20020a508e14000000b004fb0f190883mr683888edw.1.1679006218096; Thu, 16 Mar 2023 15:36:58 -0700 (PDT) MIME-Version: 1.0 References: <20230316170149.4106586-1-jolsa@kernel.org> <20230316170149.4106586-10-jolsa@kernel.org> In-Reply-To: <20230316170149.4106586-10-jolsa@kernel.org> From: Andrii Nakryiko Date: Thu, 16 Mar 2023 15:36:46 -0700 Message-ID: Subject: Re: [PATCHv3 bpf-next 9/9] selftests/bpf: Add file_build_id test To: Jiri Olsa Cc: Alexei Starovoitov , Andrii Nakryiko , Hao Luo , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Matthew Wilcox , bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann , Namhyung Kim , Dave Chinner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9906080013 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 9ce9ohziwz5zqebtuxwgprx9nui9bpxq X-HE-Tag: 1679006219-314015 X-HE-Meta: U2FsdGVkX1/rG1lUdGCAwKXCkYSZnsOQ8WRieDVsz2nVRsfccwCVCQ2ivDUlrCR9hdBBoYumGjkDALgjdKm6lu6RoRhdapzWK9bKdoEUN8cbTiNs85opbo8Y5AHsQH803gHRVTLbbUX7k0dYYyNmsIRTTP2LRdmVUb0KuuxkhlIVLom3oM2c7T+1IEP0ajNZFWw5RGySjEaQTe/l8uYsRDilWF20+4SmomavPN20MYExoWN/wJbXYcO1vHyiCm/XtJChcVepko2tfqWEpd5Lg5VwMWwHAaizig9R7IyCc63tm9HaXnWRaM2mGx1C7GKYgUgkqFP4M+3QfKxEG9B7gbARS//yMrRHjA3b+g0WcYXAB9ckp2arxwXWoCjHhgSmRtBgB6qsyz0iuWZxJVuweiUh3SWThhjnVUEmAAGjO9iGN5pCDqaIa26DDKi+YtCpjaKZHzK1rDU32MF6oKwNGDhvRf+Rk9wvTPm2HumRzGZlts3TC8nFKDvnNXWwPmEoTIPe7VIsZFKB5KrBsr2AUcnyxLOdptxaizIO7lpawe/PZO5eMgMWk0/7QEMYqZerS7+oNwEKIKjyFXt6Gr+6ybfVhWbEGi+pswxzA7eXl5btUUUJ/VV5oMM2ylzVFAvWWgZMRW/udP4EYGXuSKKKENI3HiwDyqoQN/4M1Cg1ye3XMfLi/N8+hwrO/CeYHn7DxPetaEI6w6DkrpYRLArOTy/hh6Sd7GRDJTjZVC2JdCDaI9fuqJb6l8xxh1lrzQt+qH0KCcDj5OIIeuEXCojCh+zopqiQcPrNqVEQjNObmorPV8jno+9KPZ/V16fSUTlOuYvFSl6Ki+oC8Ksbk9Ijo5gqyuQENsCAmTzw4Rds53zbS32KVRL2T41vo1uxqYqkF87huzH/i7YQsxStJ3/5cxTd96I5frGSVkYn6472KzC547c5LCnP3krb97kQT2a9mrI0C7YyzlLjDEvrSq4 peoFOW6J BJsFBagJKexMwL40iDrgHe9YQ0KlGuwEst6OqC1wi9n7s2pNCredi9hz3HkyOoFjQr8EycnHk2zp/zbzBSVtKbzFh53rTvVjn7o8otMTUqO2R/CuHzpIHaA3U+S0BAWYfaXehV2x/b9lV/zb8Id1Sdl56dq4Sf9FnnlKHjByP4i2JcedwLOJyK2QUB+RxsDaM8dlBq9YAEAZEnJ0IgVeKk1ARyRgZCac8HDUZE0e+ipN2uZziDP209Hm544pPJCJO6WMdX7XHau4kqvo42qGtLI8B/zK7nmfFrVRHaqQ4RtTOGIaqbq+Rvi8UmqR3MtuJD9h3j43AxTh0r2uCIwrU6CGdJLjuaMlN8G5WsHnLjqObDIieMG9aVmil5mr7xy6crBtGC3FRC4BxXxw0NWrAaFSwx1rxaQMM3TGVHJ3gT0EU4dAhogTrlHYl2Rr1kbfdrlucYth0lss0kXAwOwRjYumaEF3Q5fmdzlcTDMxTcXlugbBfaxOg5tKikE5OH2XmOMY4Gw04LO6rbhvV9AP5dNA0RNsi0YS+a+fy/dLF/jlIPDwx+HOM4gPeJ63kG5DPV2kwwuvPAUWd4Mo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 16, 2023 at 10:03=E2=80=AFAM Jiri Olsa wrote= : > > The test attaches bpf program to sched_process_exec tracepoint > and gets build of executed file from bprm->file object. typo: build ID > > We use urandom_read as the test program and in addition we also > attach uprobe to liburandom_read.so:urandlib_read_without_sema > and retrieve and check build id of that shared library. > > Also executing the no_build_id binary to verify the bpf program > gets the error properly. > > Signed-off-by: Jiri Olsa > --- > tools/testing/selftests/bpf/Makefile | 7 +- > tools/testing/selftests/bpf/no_build_id.c | 6 ++ > .../selftests/bpf/prog_tests/file_build_id.c | 98 +++++++++++++++++++ > .../selftests/bpf/progs/file_build_id.c | 70 +++++++++++++ > tools/testing/selftests/bpf/test_progs.h | 10 ++ > 5 files changed, 190 insertions(+), 1 deletion(-) > create mode 100644 tools/testing/selftests/bpf/no_build_id.c > create mode 100644 tools/testing/selftests/bpf/prog_tests/file_build_id.= c > create mode 100644 tools/testing/selftests/bpf/progs/file_build_id.c > Looks good, but let's add CONFIG_FILE_BUILD_ID to selftests/bpf/config, as Daniel mentioned. Acked-by: Andrii Nakryiko [...]