From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49712C3DA4A for ; Sat, 27 Jul 2024 00:36:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA0336B0089; Fri, 26 Jul 2024 20:36:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4E766B008A; Fri, 26 Jul 2024 20:36:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A15AE6B008C; Fri, 26 Jul 2024 20:36:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 847B86B0089 for ; Fri, 26 Jul 2024 20:36:25 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EB8011A0171 for ; Sat, 27 Jul 2024 00:36:24 +0000 (UTC) X-FDA: 82383666288.17.6ACC0ED Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf09.hostedemail.com (Postfix) with ESMTP id 2B516140008 for ; Sat, 27 Jul 2024 00:36:22 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KJpkSnVC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722040542; a=rsa-sha256; cv=none; b=SptLXN4I+lECWqKG+EzBO3qUDG0PJEwKOEs5UhYDYksCK0RgD9dBKAh6sMNCWh2zRfjxyz grLsjiimekKRu/1HbwivXTffVnk53RgKHe6efQNuApXCFwcArOGdUIWE/eEuzYPy6gQkQM 6RsW5t0TqSbwWXgs0vft8RbWJajkXOs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KJpkSnVC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722040542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N6DOLgzo2vSm1czaf3MoumkD2UqTQhaH54biVlwoZB8=; b=vDSB8zj9ePCW2HwE+IxJiVuGLySbDpX6safq6MN8703ZBVT5x5Xb0aDBGghTtznCL6eaUn MqH6aF2a4hcu9wrTnrhQY70Cc28ZXR93OCJ4RDzuWtaiDj3xuqHY1uc9Kolq3hchUN3tNm YgG7PrHFELjulk+iTmZSoUd543JGOyQ= Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2cb5deb027dso1119401a91.1 for ; Fri, 26 Jul 2024 17:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722040582; x=1722645382; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=N6DOLgzo2vSm1czaf3MoumkD2UqTQhaH54biVlwoZB8=; b=KJpkSnVCLz/Z/j0JBR6naFHUs3TUMdZy/c25NUlGQZmdxyq6tB/kcGMtpPcJbUzy3i w4CZkkqMPrVf6sJ08tqUxDqdAqKPx1/hJTSNXnNs/8mUl7HJNbO6ZuzuttBoBH7tsQHV NhkKgWrfSKOkRkQ6K9RSOQldYhP/1MSiNiKxvI1FRsYClJBjcmBgq4402FkbqKkeTHaO 6EdAiG5e+reW5Y3NiQEtRbJ/kYsDwIGxteQWrop7ljm+gqWBILUK4e+rNkE0a1C0WCOk bodkzAOhGt/VUMFQdg6sir7QewE+dFLMmByP91k1nA0jxlRQoDOtSLhNeouQNuxhYxoJ GdTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722040582; x=1722645382; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N6DOLgzo2vSm1czaf3MoumkD2UqTQhaH54biVlwoZB8=; b=hojTsIAN4D3dHBY38MDnh9F1TUwJlbmlhO20RVyQpFaqyMvzZYGWJyNfQs0YDcFdOh Ny1MatVTOy5+FhDbAdcVfr4anZit7sRyjAMv9EYSQLewyKsS0bkdptyPs9uyArWUVua2 dbidO0BqcpsgtfrPA0mHH1wBKLNvR8JeCyTIKFK5WXiEHYwAKTgWRrhovfHtmtB+GEz5 Td/a5lUxnOB0EGi9e307RgeI9kwd8vJjhkDC71e4VfplUlZC5fcjJJMAqvDbCQuDEa+9 rkrkAJSvuSt4CHylvgGMAQs2uf2jMXIjge2+xosIhG0iMjTeTVUDuumZnspvYozqac8l 85qA== X-Forwarded-Encrypted: i=1; AJvYcCXqple+7XxCUNyOYln56sT2eRVeheNsgovVQt3FTkVtBQ1+cb8M8zriE8TueQBtTEsg9ZHQ2Emna5qA/qvvyd+TSkU= X-Gm-Message-State: AOJu0YykUwdzF4iac4jiLajtIgnFjnp0DEzLYtFPi26p1bWKw2XBzFnI WVeSGqx4t3YHVZh7IBopjXNUG+yVWh4dCv8YYdHf5l+Smq3weJsEuJ5Un1e5dx7G8PHECClvS7K +Elj9zByroERiSKcBbU4azFx9N7c= X-Google-Smtp-Source: AGHT+IEDveRTEjBkhikQn0+KodLLwquamSLnUuW13hIVekUOCZL63vbIsF3QLEMtRXwVApNPVsbX4f0IybqVPrOwttw= X-Received: by 2002:a17:90b:3149:b0:2cf:2ab6:a134 with SMTP id 98e67ed59e1d1-2cf7e60c0b4mr1374751a91.32.1722040581813; Fri, 26 Jul 2024 17:36:21 -0700 (PDT) MIME-Version: 1.0 References: <20240724225210.545423-1-andrii@kernel.org> <20240724225210.545423-6-andrii@kernel.org> In-Reply-To: From: Andrii Nakryiko Date: Fri, 26 Jul 2024 17:36:09 -0700 Message-ID: Subject: Re: [PATCH v2 bpf-next 05/10] lib/buildid: implement sleepable build_id_parse() API To: Andi Kleen Cc: Andrii Nakryiko , bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, adobriyan@gmail.com, shakeel.butt@linux.dev, hannes@cmpxchg.org, osandov@osandov.com, song@kernel.org, Omar Sandoval Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2B516140008 X-Stat-Signature: yn1iyns7idxtrgmrynjktf4rqw81bofz X-Rspam-User: X-HE-Tag: 1722040582-432886 X-HE-Meta: U2FsdGVkX19zUkFi5Xr9Y9eKdp5ewvmpKO/sIj7EmHCNivzMU43lZ7L3xXA0q0rBXafc2nIMriJXPOun3kF4/dsTFjcfnas6DFXD8erDuPgyyZxB9cfh2hTvU2Ie4jIAgYt9gJ0AW+YZFkC+R98srGkv2ooVuZg2JhQqIq8dRLShze2VH7/KUUHR8WlOcj0Pyewp7Ai6bEj2OgFtoiev2+Ds/hakODA0Ok8pn0MrSvSnLZRcZEfy2mFva0SMbi/0FhFM8kdl2UEKy3RHlJGpOLqA9zfZra+TGPDT2VIn9TBrYnEm1uqD/h5WyeCEhl9d+j3X+TFahoPHrZ/RKkLdWbDRBlipx4DG5tzwxQAyVuQmUxaDHDwIpjPPuQhiIL4IlE3sjHV0vbIwU8VfHRu/g8VUDbJLsngJPMqUUEsRByO3fI/whcuYkOCLccGsxr5FgEjkdWZ31qiWOsqyPBnrU3qq5W0zzxxOp3o88NTBnciOENcLYOJvJBk2TCjKuzsR0VGCe+4coi9O0mQHUGLIhR+QSk4EjBs234FW//zoXJlbZjYPoVhhz7FeB94ALB1juvUv1cXI5+Qlz6x/7tFQ1Jg+ItMQurkQr8I3o/UC7rhDpsAwMxX+1LfpzlEt7tZVf++A1WUMpcHgqprNgKi22C/gpxeM9QMoYVlYTlJTRTZIlNA05On/DzHWZ+VIfyAZTbQAsIKc8fogt9a5aCCqR8/SGh0XOJh451HK2Q7cMQvFemR/YtgzvUIPL0R3luOPnw1ApoKbpyngjv35YaSX70lKzvqZmMJC1L0ovtkzQ1yrE/wFxIXgxagBseHg1d+eX+toV0bvfq9VmyXlWEIkPYKhcNgGmwrKg3tloUPLc0wEVbb+p3z9RkkFUnZF/a4wvZQRPWup0N9o8HhrvXgXjlgYA29GriFsDsYYRRifmCG+2bnLqyZyI2G6vEjviHj9tuI6MYpS3zVvjW84Vum x2H5p78U 4OYwHj7oKM++I2r6K1a87vLt6ozVmwEM4f56hCalQKQu3JvShCWVKs9bjszw0w/mnUKyy177h739Bnpd5XkKmVKwBEsLnLyGvNo71zWjffQzSVFa2n003WC6Fry3sy7auHej73qef6hlijVdihMrmmsZgIWvVTtpK7RciskjMw8NU2r3wjYqH9Amh4VXt26J0ZFLm1RcRobeVt8SyVYuaCKtS+vkaELdoKG1Mz08tXD7hv1uYfjPdzGVNAXoChy8ViC5kVrhmoaYVwKsMr/ridvReAcdUhtuBRdLIBbNPNW6Z9vxGNTfec4WdtRyJzfa14LzP/F1Xcb9ZB/udOsFzQdgglM8M1o39RIrZ5QvqembsXJgywutVIjjINRYzH2h4ERoGt7hEwE4MJ0s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 25, 2024 at 3:46=E2=80=AFPM Andi Kleen wro= te: > > On Wed, Jul 24, 2024 at 03:52:05PM -0700, Andrii Nakryiko wrote: > > Extend freader with a flag specifying whether it's OK to cause page > > fault to fetch file data that is not already physically present in > > memory. With this, it's now easy to wait for data if the caller is > > running in sleepable (faultable) context. > > How does that interact with kmap_local disabling preemption on highmem? > There is no active kmap_local when we request a new page into the page cache with read_cache_folio, because we do freader_put_page(r) -> kunmap_local(r->page_addr). Did you look at the code and it looks broken to you? If yes, can you be a bit more specific what and where?