From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E96EAC83F22 for ; Wed, 16 Jul 2025 18:10:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 897058D0005; Wed, 16 Jul 2025 14:10:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 847418D0001; Wed, 16 Jul 2025 14:10:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70FA88D0005; Wed, 16 Jul 2025 14:10:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5D5A18D0001 for ; Wed, 16 Jul 2025 14:10:49 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0B8221D7192 for ; Wed, 16 Jul 2025 18:10:49 +0000 (UTC) X-FDA: 83670918618.29.B1D48A4 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf14.hostedemail.com (Postfix) with ESMTP id 1C9FF10000D for ; Wed, 16 Jul 2025 18:10:46 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E8WoW6d+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752689447; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/nPLDzt8OaNCeZXVo+jqqenY1sk4GVXTkfMw9ymIdMY=; b=JBfB/ZIYOi9tsnzRfJ9PuQa5dW/q0MQPkcY++UltIy2FhRXlFxGYKPJbx1ObZkI3e/B6ES LEvAMkTjZsWK85YiPAApRElOyQOFBFdhgyCCTnORyfu1B7k3qPuLYsZv9pxOqCrn34+Pn0 O7Jubh11WLIIH+QJpslKfnSjj4iENOU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752689447; a=rsa-sha256; cv=none; b=x13oNwUzqOhD1GdUIOPd1+a0thjYpzT8WmbA/sgRs5/ppyRgJmO+a8nKQ4tV9vCIc1S3aR GpSLMW9+WgRmKRDlo4nZVnB0llRSke5BN958edfllpC7iAoONW9MsjcGq096OE+C3VlqtH EKsQ6QL24n4x8eD7jw97EisVbAPVuLI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E8WoW6d+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-31a93a4b399so229209a91.0 for ; Wed, 16 Jul 2025 11:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752689446; x=1753294246; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/nPLDzt8OaNCeZXVo+jqqenY1sk4GVXTkfMw9ymIdMY=; b=E8WoW6d+KEC7TN+qeBQGbX2n2LcJH4/5UTcRRys4ZjRtK2+58GvdXjcQ9iWKgaKb8X eoQMo7qu60FiNvz00baGDqLvDkL3kqFMivopUrfdZDsoXPluoJeOBsVdOI0Eex2tT2PT YPyNaVLRw0qNaBwotAKdzyyNUxICUlbrXib2XZ7P5GBrI4WSGw6K/K1VBfiquDW3a4Fy nsK8QEpuCsVJOaHWPpqkzT8RWwcAtUevMLa1aZOLzJExiFDWH1GfF7NxOQuU6fOjVCln EOjuqIVsi+yUBH2E9jtxJB4fCg0e2FrpAkkr4VPuCCJw/mFDDifmyZcUfKFKwwd50bcS 7pdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752689446; x=1753294246; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/nPLDzt8OaNCeZXVo+jqqenY1sk4GVXTkfMw9ymIdMY=; b=Z2l0UuDFnvR5qoizIbwEMtmWHD3pRffIy8kkK1v3jKVISXJDVQof4lfjMKjhFqVax4 YbTxS9GhyZ1N01GwIz1lozo5ZGyn8PrYCrePdaUcD5EHnBRxHL4R+ep4IZRSFxhdALYY rUxTXze8UG6/913Drln0Amsh/fwLuSctWOj6EwwBhaYXGdivZ6+P5zHEFn2wbZwlI8hZ uNFa9KxLLxWLpt7sRb6kYzEZrXVakf1cLWqDlkWcYI+eGeKRRe8vgZA0rARJhcz+qpjm 3yfMzYfbznNMEVnOZwFrVdA8RO8D93dhrVaVFPlAFv1FzpFPilCCin5WJl7nqZvWL8X7 8z9w== X-Forwarded-Encrypted: i=1; AJvYcCVXPm3RBcCCpFVidSUAz51oN4/fERMjEm4R9a+9a4YBxh90Ix3t+EvqvV12egE9k+Bz2lIQLumERQ==@kvack.org X-Gm-Message-State: AOJu0YwHtD9JDOQgo5K0BRZapzFJTpDN0PIGbW6ehP3eI95OZHS9AEkc bTQHr6VlHH+wkFzTwcFOJCB0mUau8kwIEayiHw9vYpjFyBbmMlJF77Gq2Oy+BUSDlHsGqGUhPHi Vr/y4KLYMyd0RlP4pV0TtRFjlH1Uhrbw= X-Gm-Gg: ASbGnctgPJw7v2qJ4cwc6XT1syBV3SRDMlGrF81AvNwJ3qu6VfF92AOVZrk7uMqEosi xKk7Qjond2hGCh20vJFQLR2Az/0egdKUx6clOnNEyCZ+SDSEiXdMD1Wi3awaAtjgw91OykpQVhT bCDLpmHtq3D8XffWUka88+63QCy5VLvwR1KRG6SGibfj0EoHClcz9RJhJFSMwrO1OFfrxyOgMd3 z67zw== X-Google-Smtp-Source: AGHT+IHJlbpu3WRcygpiaRDlDw/e+VIPCJBjgw4iqNxFgRP6FRabw5/rvWyqRZpyKT6y3Ac9F3Ie0dVmp6jE5D45Muw= X-Received: by 2002:a17:90b:4f4d:b0:31a:8dc4:b5bf with SMTP id 98e67ed59e1d1-31caea3feaamr467632a91.17.1752689445698; Wed, 16 Jul 2025 11:10:45 -0700 (PDT) MIME-Version: 1.0 References: <20250716123916.511889-1-bhupesh@igalia.com> <20250716123916.511889-4-bhupesh@igalia.com> In-Reply-To: <20250716123916.511889-4-bhupesh@igalia.com> From: Andrii Nakryiko Date: Wed, 16 Jul 2025 11:10:33 -0700 X-Gm-Features: Ac12FXxkQF7EcMzWycD-nloRUfOkqsw4tlKLzrY1mRXYqv2TM-LS0bucIaJdoMY Message-ID: Subject: Re: [PATCH v5 3/3] treewide: Switch from tsk->comm to tsk->comm_str which is 64 bytes long To: Bhupesh Cc: akpm@linux-foundation.org, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com, laoar.shao@gmail.com, pmladek@suse.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com, mirq-linux@rere.qmqm.pl, peterz@infradead.org, willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk, keescook@chromium.org, ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-trace-kernel@vger.kernel.org, kees@kernel.org, torvalds@linux-foundation.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: eurig37kym771x5te9h7b3kk9t1wp5io X-Rspamd-Queue-Id: 1C9FF10000D X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1752689446-702941 X-HE-Meta: U2FsdGVkX18A2x5rzlnr9o1tRE6S+pnmHwPE7lNLGn7x6sog/UHcHJ8eZwC9jS8vfAMs5jkiSiBowYyGHluJ/3czavWzw8LptGebTEcqFcnVImOO3PJFAydtcnplyzEQNpoRUq7uofJCE7eFJygv0TcEJVprhEHfNxiDSDeVROtJdRY1iB8ir23TUl3wCuHTX/cYXhKFWc5utkIYrM+RBg6R7Gs+DKJc0VD4iIqDEBJ0koHEANUIkHJxnF8Hhce4gtu8GCTGxSBPI+eHF1JX4eJu66R07ALTKBcayJX9ePp/FsBce8+bl8rh7jSdj0WgK5CeGCsJ4iLFGzr+mVIDuM3Mq6GmySOqvJVsFZA+zfuobG6oChONz67ohBhLCi2Mt5x8VJ5tibaClqn1XIWbDMusX/a31bBtPkIvRTblX7PKWgwUD7m56wyhY+Yj+IfNG1LTNAT6ePX8Axuiq2T7gp+x1ggHQwwkpXMiAj3OQChh/HgF+faAUs13l9+3XdRpXTcRgH1KAW75tkvykSe/9VqaTBpw5dpoHRaGP4/aS2tuaPhJ4zzPXBL5xb5w89+/9QFbwuVKjo84EMSnUByL13d4HpNjRzfLkC7PNOIQJ7VRO4P1UKGrTCz2vE31GEA06CZztjSGqLw1XHxr19A6Qf0P7sBSAQvaTHkFMrBo8vnjXwA8Xu8zQZzoh2Tl5gGBTDed0i6fWzu/uqLSFHDEPJxt+RfjY6DtG7dDk9xE/Gun/Xjl/5WEnJFHvTbpaHA0tiVpJ3PG8ms+C068+zLowCy1zq9ydDbIEj6R9XeEHL0foDRJ2/O3/hDqi35m8s6BAs/2LlV6od2GAFHsyyihtZil7ZMy+vu3cPsWpXLdDcoc6SMEU2GAV9XL4keIrGqT5d9Ccw57E60bQ4ZWRJaDw2K5x4U8pk/tcSweYVOEmcS3pkJ57U3sHEGAi8KsrmdnHzuu0MV7WeZC/5R/YNM hJUjUav+ 5+v9cNEF7OXZj7onC7ELmJum88xnrSXpVutUx10eeduf6gA6XqjuQah9ArqBLhroK8RC5dwNT2OfXGXTMLQ4HYHnoO5WQVRvOC09pctJMc+/2mJ7BoALaZMehCXAvJzQXkPOKS3uL+1PaTwQepbFRoVbmj28IFJgB6uH082chVnxJkJ7cfPp2aZwG99j2CMlRSFZWyIiKI1KmsIK8EpuMd3smMrAv4vLvMLievbeamE+JzEDjUrsRCvoBHk+tXMHKkUFte2kRUs1H+6a+6yeCKMcTdiMP7ZG3qogZv/uAjo1kOaI7rFbDncaDVoDmd7+N9Lw2ZhRfBl/qrtGbtC9LWNnfYvuEFYI4jpr4BxpXe25zdhpLTQ54ljV4P9kLvZyZCCPWyfi8Rajq6QOE8IC1NjTeuqqs6hdtaAEDUTCvl+OXxVUw89kDK4EwuMxkRbm9Mt9zGX3bgabDObW1dhk6OHdrqRYwvDD5JZZCO9lj5ZHT450fDF1CEzKByJp0Ca1ECCt7srieOJaVUv4mRhONxbWprI10KFxY1Ol9PWUxvTp/wW8/KsR9nj2dvwZuvFylHtzfydzSXG6iaCLtQKZ3aSJhsw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 16, 2025 at 5:40=E2=80=AFAM Bhupesh wrote: > > Historically due to the 16-byte length of TASK_COMM_LEN, the > users of 'tsk->comm' are restricted to use a fixed-size target > buffer also of TASK_COMM_LEN for 'memcpy()' like use-cases. > > To fix the same, Kees suggested in [1] that we can replace tsk->comm, > with tsk->comm_str, inside 'task_struct': > union { > char comm_str[TASK_COMM_EXT_LEN]; > }; > > where TASK_COMM_EXT_LEN is 64-bytes. Do we absolutely have to rename task->comm field? I understand as an intermediate step to not miss any existing users in the kernel sources, but once that all is done, we can rename that back to comm, right? The reason I'm asking is because accessing task->comm is *very common* with all sorts of BPF programs and scripts. Yes, we have way to deal with that with BPF CO-RE, but every single use case would need to be updated now to work both with task->comm name on old kernels and task->comm_str on new kernels (because BPF programs are written in more or less kernel version agnostic way, so they have to handle many kernel releases). So, unless absolutely necessary, can we please keep the field name the same? Changing the size of that field is not really a problem for BPF, so no objections against that. > > And then modify 'get_task_comm()' to pass 'tsk->comm_str' > to the existing users. > > This would mean that ABI is maintained while ensuring that: > > - Existing users of 'get_task_comm'/ 'set_task_comm' will get 'tsk->comm_= str' > truncated to a maximum of 'TASK_COMM_LEN' (16-bytes) to maintain ABI, > - New / Modified users of 'get_task_comm'/ 'set_task_comm' will get > 'tsk->comm_str' supported for a maximum of 'TASK_COMM_EXTLEN' (64-bytes)= . > > Note, that the existing users have not been modified to migrate to > 'TASK_COMM_EXT_LEN', in case they have hard-coded expectations of > dealing with only a 'TASK_COMM_LEN' long 'tsk->comm_str'. > > [1]. https://lore.kernel.org/all/202505231346.52F291C54@keescook/ > > Signed-off-by: Bhupesh > --- > arch/arm64/kernel/traps.c | 2 +- > arch/arm64/kvm/mmu.c | 2 +- > block/blk-core.c | 2 +- > block/bsg.c | 2 +- > drivers/char/random.c | 2 +- > drivers/hid/hid-core.c | 6 +++--- > drivers/mmc/host/tmio_mmc_core.c | 6 +++--- > drivers/pci/pci-sysfs.c | 2 +- > drivers/scsi/scsi_ioctl.c | 2 +- > drivers/tty/serial/serial_core.c | 2 +- > drivers/tty/tty_io.c | 8 ++++---- > drivers/usb/core/devio.c | 16 ++++++++-------- > drivers/usb/core/message.c | 2 +- > drivers/vfio/group.c | 2 +- > drivers/vfio/vfio_iommu_type1.c | 2 +- > drivers/vfio/vfio_main.c | 2 +- > drivers/xen/evtchn.c | 2 +- > drivers/xen/grant-table.c | 2 +- > fs/binfmt_elf.c | 2 +- > fs/coredump.c | 4 ++-- > fs/drop_caches.c | 2 +- > fs/exec.c | 8 ++++---- > fs/ext4/dir.c | 2 +- > fs/ext4/inode.c | 2 +- > fs/ext4/namei.c | 2 +- > fs/ext4/super.c | 12 ++++++------ > fs/hugetlbfs/inode.c | 2 +- > fs/ioctl.c | 2 +- > fs/iomap/direct-io.c | 2 +- > fs/jbd2/transaction.c | 2 +- > fs/locks.c | 2 +- > fs/netfs/internal.h | 2 +- > fs/proc/base.c | 2 +- > fs/read_write.c | 2 +- > fs/splice.c | 2 +- > include/linux/coredump.h | 2 +- > include/linux/filter.h | 2 +- > include/linux/ratelimit.h | 2 +- > include/linux/sched.h | 11 ++++++++--- > init/init_task.c | 2 +- > ipc/sem.c | 2 +- > kernel/acct.c | 2 +- > kernel/audit.c | 4 ++-- > kernel/auditsc.c | 10 +++++----- > kernel/bpf/helpers.c | 2 +- > kernel/capability.c | 4 ++-- > kernel/cgroup/cgroup-v1.c | 2 +- > kernel/cred.c | 4 ++-- > kernel/events/core.c | 2 +- > kernel/exit.c | 6 +++--- > kernel/fork.c | 9 +++++++-- > kernel/freezer.c | 4 ++-- > kernel/futex/waitwake.c | 2 +- > kernel/hung_task.c | 10 +++++----- > kernel/irq/manage.c | 2 +- > kernel/kthread.c | 2 +- > kernel/locking/rtmutex.c | 2 +- > kernel/printk/printk.c | 2 +- > kernel/sched/core.c | 22 +++++++++++----------- > kernel/sched/debug.c | 4 ++-- > kernel/signal.c | 6 +++--- > kernel/sys.c | 6 +++--- > kernel/sysctl.c | 2 +- > kernel/time/itimer.c | 4 ++-- > kernel/time/posix-cpu-timers.c | 2 +- > kernel/tsacct.c | 2 +- > kernel/workqueue.c | 6 +++--- > lib/dump_stack.c | 2 +- > lib/nlattr.c | 6 +++--- > mm/compaction.c | 2 +- > mm/filemap.c | 4 ++-- > mm/gup.c | 2 +- > mm/memfd.c | 2 +- > mm/memory-failure.c | 10 +++++----- > mm/memory.c | 2 +- > mm/mmap.c | 4 ++-- > mm/oom_kill.c | 18 +++++++++--------- > mm/page_alloc.c | 4 ++-- > mm/util.c | 2 +- > net/core/sock.c | 2 +- > net/dns_resolver/internal.h | 2 +- > net/ipv4/raw.c | 2 +- > net/ipv4/tcp.c | 2 +- > net/socket.c | 2 +- > security/lsm_audit.c | 4 ++-- > 85 files changed, 171 insertions(+), 161 deletions(-) > [...]