From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89C86C3DA61 for ; Mon, 29 Jul 2024 16:52:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 206826B00B1; Mon, 29 Jul 2024 12:52:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B6D56B00B3; Mon, 29 Jul 2024 12:52:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 056806B00B7; Mon, 29 Jul 2024 12:52:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DB5456B00B1 for ; Mon, 29 Jul 2024 12:52:34 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 891241403E7 for ; Mon, 29 Jul 2024 16:52:34 +0000 (UTC) X-FDA: 82393383828.05.AB11B16 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf14.hostedemail.com (Postfix) with ESMTP id B7D76100023 for ; Mon, 29 Jul 2024 16:52:32 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Uqs39Sms; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722271892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F1ho5QoGVALlGvO1PPceVK1Uz2j6z5FfEI7hQnwqjGw=; b=oM8744rNCPckHyJbkFIf8kz+6hVMiSLX1m4QAmB4QX84ZHcQxN4FRG5WZWFqBDURJ7LF3L v4vgC2MA1R1I5W2IycCDXhUEjmCHvuY3qK8CREmbRfM2xXpeEW89Xt5p+uO5Mzq3j0VNbt CFUaJluwdNOpBh5loHUL7xWCqbv8pck= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722271892; a=rsa-sha256; cv=none; b=22rEDlnTeQ6DqfzL9UH48gn09pHLwFZI85wTZ1s5+x5jndDRO5MGwX+2q0kgMh16wdu0js tZ/DO+QD2iYh0zzWhlaYL+pk3PoGwCuU0N4MqZHUJKQBM6JlFSVbBlmkEL34Kw9tI96N1z yVDDU+wmHTRaI+7+SPM0y+49S+U2b7s= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Uqs39Sms; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2c964f5a037so2177512a91.0 for ; Mon, 29 Jul 2024 09:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722271951; x=1722876751; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=F1ho5QoGVALlGvO1PPceVK1Uz2j6z5FfEI7hQnwqjGw=; b=Uqs39Smsx8rT/eJxV5vVZgaqRf549HP2eNn8NCgL1IOPJgi+XTknyJ3tYbupgLOmQy a9LrlR39dJyIZpR5K1XOufKYLuEi79oeYt2q1C0Kyq9RjtTXP5sgQIcaPhjwISOtKNYJ mwZsBkSj3PRn/JBhwtldyDaSSZNW/CNgX27D1s7uqT1QEMNaFekltrnmGj/an2RWm88F e/j2ZysIZq5639Ni/C3kX0IAM4HV7GhqMW5VDgjvisWrZFQPfuWH4HUroLeJsJk2jZmR 0UWx3oaLwQmPxMAgNnXU5U2yg4012W5OVHaRhRVF0vy8WXPTbrfXMvDQt7e6/yI8c8OD dAKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722271951; x=1722876751; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F1ho5QoGVALlGvO1PPceVK1Uz2j6z5FfEI7hQnwqjGw=; b=EY1Ohivg5N8DA9ZwW5dpzmYXrktgb+PlNkfZItidzowFp4u9PryC+UaHhuYtrnjBy+ pgGRYWiMthqWgVpDB75iYQ1R4QgHDY43QByrikipzcpR78NJIu+/59ELabUctdCwVCtz TXHhv9ss7aBF1snjpaOno7h6bmhgt90p1BwWLk4byWJIDXZUiOUGPdzHT8h5UPM0GeM+ usq7rD2YbIdXnAg+IggH9xtNpCjRC/vYAbEje+bpyQzOkg3UCLih8f/3JMAONqprE1XB vN+N7Qn8P8J5iMf55SeiANv/0tujpPKJj0QsiVVyUhpxHa15bchEe4bKyIiM1QuQWi1q PBDw== X-Forwarded-Encrypted: i=1; AJvYcCW4LtSXZ1xTQnHjuEEgur9FuFL68DY8gYUZirzmoLf8Z/gAbNmC8PbCVAovp/Bsiboq+M/D6wT1Kyys7IRYsWPsLN0= X-Gm-Message-State: AOJu0Yz8cnoekyrEle/B5xdRnprpdY90GMiCR5hEEue0dm8zn9XcIvcb dkiKogmz+K+E8yRVifUzZ7w48rbfFyQBxWGWZmV+XVAXsWXbG57BEYYVuPWixP82ZrRNdDKwC+g Kc/8PKK17QOdQKsQxYvruoetC1xI= X-Google-Smtp-Source: AGHT+IFOQKm1kOOY1enndLUmrwVyPkPWD9zlOkNYF4MshasZERBRGWashb+a1LdHxEgXCuM3q9OHW2D9HSs6IbtHY2s= X-Received: by 2002:a17:90a:a018:b0:2c9:359c:b0c with SMTP id 98e67ed59e1d1-2cf7e82fdf9mr5911155a91.28.1722271951367; Mon, 29 Jul 2024 09:52:31 -0700 (PDT) MIME-Version: 1.0 References: <20240627170900.1672542-1-andrii@kernel.org> <20240627170900.1672542-4-andrii@kernel.org> In-Reply-To: From: Andrii Nakryiko Date: Mon, 29 Jul 2024 09:52:19 -0700 Message-ID: Subject: Re: [PATCH v6 3/6] fs/procfs: add build ID fetching to PROCMAP_QUERY API To: Jann Horn Cc: Andrii Nakryiko , linux-fsdevel@vger.kernel.org, brauner@kernel.org, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, gregkh@linuxfoundation.org, linux-mm@kvack.org, liam.howlett@oracle.com, surenb@google.com, rppt@kernel.org, adobriyan@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B7D76100023 X-Stat-Signature: rommz6gwo6fmrhy1m5d9py7pbwyojapt X-Rspam-User: X-HE-Tag: 1722271952-970190 X-HE-Meta: U2FsdGVkX1+R2ZV+LsVDztovidJSYStOEbjtCTPCF53Roox4Q3EopYf6K/hlOfleO6hYsk5dLpwArTANRydLKoVYLDyG9aq5eBgCQNvHV8I7GovmG9d80pnU5yu5LL04cY7xtmG6qHOmsS4unlxdDvYePijTmV9+KHhvCyjqP2Xq3bvnf/0hU6TvlG/prJFTDbdAo+mpVvbxSm7X8SdDf/5BXyGzg4NLSqRqHCBKIIvv4CgF1Q1y17qK79rRuFw1eUvRv40vKsSCV7rbmh46SRnaJkhF3b1I/Rb6xuYDl1DKghEn9N6p16P+df7ipHcRnsjO0hzCz4noswJng1P5ZJgpjomiIKkNbrq+ybhsPDbtPFcU8TFJsILJXJwkgI/iSIbn+7DyvOBzoHnOVpsOm4DGhK0izGa66uWLmX9Df/fxg4RDBG5myX5Ya1bUlOw1JA8F+lC7PNnJLeRBi9Ur4zZlKIA18q0cEAshHNRtxBBglWzrtnCri1d5p5xKj5jDARz6b6PItVfjzwQXdnidQj290RklXiirjiW5qVk9H8qCsRDcvyI88if9UxxaSSn4D8pbfl/EqclH80z51+A3sXkrm+7ugBLn7GD2F6blofjwiMWqNF/W3GiurgDfuTaZDkhilzK/tNLn7e0Su/d1RmlBTwITN0lvur2YfvdP1mDO5PLvooGKlkSLDfopltsDnBbNZC5OfFQnl0XkyYTWbtlElYBxCwNJ02UmQtmy/knAp7LHVVl6Mga2F16DkDxw+yQ805Dzi2QRgu4vbifgpZu9bNP6RhpxRS2nY8MZVSTz0VTKpflwPUqyS+woH/dIA9CSVLDy4U3l+0iMXBpF/4Nxz/xFlxIyCt8j/sAhQx7elnRsEEcdcAXDMoa23MCML2oK7gVhasvbtmjgVNxAeHpLevQwgdEoq3uxlQcSXUVPHTkYoOvHvT7FQvCLGHHd2uZc0xZTSCLdAhzIQPZ p0SlMR7l B86q48NlCYWTZ9Ecey2aijHgtLenHUpsGJ4isdsFx379T3GJkSxY6Omyd95ILYONqlDnfSpoPtNzeIN6MFedj+k5w08EzdKS+mxTvtS8Ut01tkYFA1sKo1Av/5lOvSC6QDnvtmprHVAAK485322Q5FKi3DRMziptbM3Fbd/0LT2qHgFbV4pENolJERKzOsFFFHIhLRQFSmWx0uShe8/DhzVD5PBvvVWfemG+CYNeAuzZ0FGd+D26egazHxTTu2sfr6dfffQOhTmtnzNtli2Vby6VYyyN8BlhdRAdCIAS+800ViqwHVWtNTlrmYPRBWRdiUhhzUCtuB7qVIgf8DVqikjrgi+LgSN3rNmUQTLZyrfxNWh3Q+RaCXrPfyQegggUOQVWErzOaHB9d34JhpY9X7is+DDsaTHBccQdIODJFG/+9XHir7AJVp1EnYSxIwr9A/unoQ5MEvtcXvwA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 29, 2024 at 8:48=E2=80=AFAM Jann Horn wrote: > > On Thu, Jun 27, 2024 at 7:08=E2=80=AFPM Andrii Nakryiko wrote: > > The need to get ELF build ID reliably is an important aspect when > > dealing with profiling and stack trace symbolization, and > > /proc//maps textual representation doesn't help with this. > [...] > > @@ -539,6 +543,21 @@ static int do_procmap_query(struct proc_maps_priva= te *priv, void __user *uarg) > > } > > } > > > > + if (karg.build_id_size) { > > + __u32 build_id_sz; > > + > > + err =3D build_id_parse(vma, build_id_buf, &build_id_sz)= ; > > + if (err) { > > + karg.build_id_size =3D 0; > > + } else { > > + if (karg.build_id_size < build_id_sz) { > > + err =3D -ENAMETOOLONG; > > + goto out; > > + } > > + karg.build_id_size =3D build_id_sz; > > + } > > + } > > The diff doesn't have enough context lines to see it here, but the two > closing curly braces above are another copy of exactly the same code > block from the preceding patch. The current state in mainline looks > like this, with two repetitions of exactly the same block: Yeah, you are right, thanks for the heads up! Seems like a rebase screw up which duplicated build_id logic. It doesn't have any negative effects besides doing the same work twice (if build ID parsing is requested), but I'll definitely will send a fix to drop the duplication. > > [...] > karg.dev_minor =3D 0; > karg.inode =3D 0; > } > > if (karg.build_id_size) { > __u32 build_id_sz; > > err =3D build_id_parse(vma, build_id_buf, &build_id_sz); > if (err) { > karg.build_id_size =3D 0; > } else { > if (karg.build_id_size < build_id_sz) { > err =3D -ENAMETOOLONG; > goto out; > } > karg.build_id_size =3D build_id_sz; > } > } > > if (karg.build_id_size) { > __u32 build_id_sz; > > err =3D build_id_parse(vma, build_id_buf, &build_id_sz); > if (err) { > karg.build_id_size =3D 0; > } else { > if (karg.build_id_size < build_id_sz) { > err =3D -ENAMETOOLONG; > goto out; > } > karg.build_id_size =3D build_id_sz; > } > } > > if (karg.vma_name_size) { > [...]