From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Shakeel Butt <shakeel.butt@linux.dev>,
Ihor Solodrai <ihor.solodrai@linux.dev>
Cc: Andrii Nakryiko <andrii@kernel.org>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org,
surenb@google.com, Ruikai Peng <ruikai@pwno.io>,
Thomas Gleixner <tglx@kernel.org>,
syzbot+237b5b985b78c1da9600@syzkaller.appspotmail.com
Subject: Re: [PATCH mm-hotfixes-stable] procfs: fix possible double mmput() in do_procmap_query()
Date: Tue, 10 Feb 2026 13:38:31 -0800 [thread overview]
Message-ID: <CAEf4BzZnwhGW1VPtQ9svSYUp-+c8=9rxyupF=Xf+WG3sV14oUg@mail.gmail.com> (raw)
In-Reply-To: <aYui6BgekgRplVka@linux.dev>
On Tue, Feb 10, 2026 at 1:30 PM Shakeel Butt <shakeel.butt@linux.dev> wrote:
>
> On Tue, Feb 10, 2026 at 11:27:38AM -0800, Andrii Nakryiko wrote:
> > When user provides incorrectly sized buffer for build ID for PROCMAP_QUERY we
> > return with -ENAMETOOLONG error. After recent changes this condition happens
> > later, after we unlocked mmap_lock/per-VMA lock and did mmput(), so original
> > goto out is now wrong and will double-mmput() mm_struct. Fix by jumping
> > further to clean up only vm_file and name_buf.
> >
> > Fixes: b5cbacd7f86f ("procfs: avoid fetching build ID while holding VMA lock")
>
> Why didn't the BPF AI review bot didn't trigger for b5cbacd7f86f?
>
I was wondering the same, tbh. I think it's because I marked the patch
for mm-stable tree with [PATCH mm-stable], and our BPF CI
infrastructure just ignored this patch (even though bpf mailing list
was cc'ed).
> > Reported-by: Ruikai Peng <ruikai@pwno.io>
> > Reported-by: Thomas Gleixner <tglx@kernel.org>
> > Reported-by: syzbot+237b5b985b78c1da9600@syzkaller.appspotmail.com
> > Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
>
> Reviewed-by: Shakeel Butt <shakeel.butt@linux.dev>
next prev parent reply other threads:[~2026-02-10 21:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 19:27 Andrii Nakryiko
2026-02-10 21:07 ` Thomas Gleixner
2026-02-10 21:30 ` Shakeel Butt
2026-02-10 21:38 ` Andrii Nakryiko [this message]
2026-02-13 23:45 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzZnwhGW1VPtQ9svSYUp-+c8=9rxyupF=Xf+WG3sV14oUg@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=ihor.solodrai@linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ruikai@pwno.io \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=syzbot+237b5b985b78c1da9600@syzkaller.appspotmail.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox