From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DB33C00144 for ; Mon, 1 Aug 2022 23:17:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9A256B0071; Mon, 1 Aug 2022 19:17:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1E276B0072; Mon, 1 Aug 2022 19:17:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 996778E0001; Mon, 1 Aug 2022 19:17:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 849146B0071 for ; Mon, 1 Aug 2022 19:17:01 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5A948160C01 for ; Mon, 1 Aug 2022 23:17:01 +0000 (UTC) X-FDA: 79752586242.13.5AFBDE7 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf29.hostedemail.com (Postfix) with ESMTP id 073621200E8 for ; Mon, 1 Aug 2022 23:17:00 +0000 (UTC) Received: by mail-ej1-f44.google.com with SMTP id kb8so8459928ejc.4 for ; Mon, 01 Aug 2022 16:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=8OXsGkXzPNYuoAlENJmJBTtuEpOWte6d9Xn7bPvey3w=; b=VP54bwv7/eb1KQzOUK6UmmYFC+I/Brorumxmqlmtw6mRz3koO5NhD7vi2gqZuR4QCq xFrU+7H2/Bb3UEeLt4L8lP6Pg19Zb08aA52mTTzp6cMZm8wUUmx7PXldq8D5o0k0/bdV wxdkU8sgVh90z1WaVjMMGVwryy33+03UkgfS+pEEP14X4X9D/mb0l58lFrjKGBgyo7Ui nC/vxCmVV4LoU+bcU9reyBqTsUHBsh1RxMtE//BMs4RPuSkY6V9jUD6gtGSRMYvkgvHU cG5Pwqiqfx2370ePOOD8tYnvjc6yO56Qa9XM5u8rgwLUkRDNkd1FdMGKz2z6bau7r7OH uAJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=8OXsGkXzPNYuoAlENJmJBTtuEpOWte6d9Xn7bPvey3w=; b=0/PS9LK7JMAMnrlnVr5D+C6kQ70/85e5QhMaUFkoMhyFQ5veWSjicBZ5lUwcLzCosl DLPPz4KotMcm0nKYb9dzUZLSBTlEu6gpHkeZRj/G+28zK/AmeWgaV0Ip53SNcqXVn6yh qTpSESfJsXnippJ/93SLgILDXeHH0DoybEFi73eOgjtOidT96cGQhIRq0MHm5Z+7Fp1e VGsjfBIp4kWaCGE+jkTgp9xGFRciwzRJcS+CNvuu5rYROWs7qJKkCLrWBt1rwualDU/B 9xaZrHsQu11Zxzt7UiNbhRsZUOUEZVqvI+XZWINJiNMyy05R6om32nr9oqLPKDFjK2Fl spoA== X-Gm-Message-State: AJIora8jxN/cOqAAopjz3e8XLbiV0ZQjXaEtMEj9/+YLKM/55741XkEq h9mTdS3YHHV78Y5TIBj6i6Bo/qShEZ8XOsi80Rw= X-Google-Smtp-Source: AGRyM1vJxd/mFep8K6CGnFKBefNGT9Ceip4PPOpHGi69dZsOJKP/gF1BC9WYSnxGrjgtoeBH5OupI8E/LUswKeDGfKA= X-Received: by 2002:a17:907:2ccc:b0:72b:6907:fce6 with SMTP id hg12-20020a1709072ccc00b0072b6907fce6mr14381139ejc.115.1659395819643; Mon, 01 Aug 2022 16:16:59 -0700 (PDT) MIME-Version: 1.0 References: <20220729152316.58205-1-laoar.shao@gmail.com> <20220729152316.58205-11-laoar.shao@gmail.com> In-Reply-To: <20220729152316.58205-11-laoar.shao@gmail.com> From: Andrii Nakryiko Date: Mon, 1 Aug 2022 16:16:48 -0700 Message-ID: Subject: Re: [RFC PATCH bpf-next 10/15] bpf: Use bpf_map_pages_alloc in ringbuf To: Yafang Shao Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, songmuchun@bytedance.com, akpm@linux-foundation.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659395821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8OXsGkXzPNYuoAlENJmJBTtuEpOWte6d9Xn7bPvey3w=; b=W71IyeY82Hj5m5sFwghrFBAGu0o0AsmO21Xnh3I5Kje9nnfvZAjneWeRzBbTYuRfbduZIe HcQ9LMiaXQuQImPMHdBbIs1Zd9c4jKN2X7ouBJP8ai2QhnWwGt3zt/5GIZIvS49lvZwd/c Rs52+NnPRnnkHbD5+sD1L+hUzQ1E58o= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VP54bwv7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659395821; a=rsa-sha256; cv=none; b=TQOEhDb32v87V3FWWi4UXtAjp3mNsbjHtnj1k+wb0fASNO+na2If9N+R7L0oaM8HqXSYGV uSfe8MFSQpd46IeZ8eukdoYGMwjXXwFssfQoBQBzdbDa4dvg06JxhRi5W4CYYshPpavbNa z9w/vOsEzZZb9KvG/CW8vJYrlJQzwfU= X-Rspamd-Server: rspam02 X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VP54bwv7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com X-Stat-Signature: 7m5ectsiaibonx439j4dca37d33kotwn X-Rspamd-Queue-Id: 073621200E8 X-HE-Tag: 1659395820-571021 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 29, 2022 at 8:23 AM Yafang Shao wrote: > > Introduce new helper bpf_map_pages_alloc() for this memory allocation. > > Signed-off-by: Yafang Shao > --- > include/linux/bpf.h | 4 ++++ > kernel/bpf/ringbuf.c | 27 +++++++++------------------ > kernel/bpf/syscall.c | 41 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 54 insertions(+), 18 deletions(-) > [...] > /* Each data page is mapped twice to allow "virtual" > * continuous read of samples wrapping around the end of ring > @@ -95,16 +95,10 @@ static struct bpf_ringbuf *bpf_ringbuf_area_alloc(struct bpf_map *map, > if (!pages) > return NULL; > > - for (i = 0; i < nr_pages; i++) { > - page = alloc_pages_node(numa_node, flags, 0); > - if (!page) { > - nr_pages = i; > - goto err_free_pages; > - } > - pages[i] = page; > - if (i >= nr_meta_pages) > - pages[nr_data_pages + i] = page; > - } > + ptr = bpf_map_pages_alloc(map, pages, nr_meta_pages, nr_data_pages, > + numa_node, flags, 0); > + if (!ptr) bpf_map_pages_alloc() has some weird and confusing interface. It fills out pages (second argument) and also returns pages as void *. Why not just return int error (0 or -ENOMEM)? You are discarding this ptr anyways. But also thinking some more, bpf_map_pages_alloc() is very ringbuf specific (which other map will have exactly the same meaning for nr_meta_pages and nr_data_pages, where we also allocate 2 * nr_data_pages, etc). I don't think it makes sense to expose it as a generic internal API. Why not keep all that inside kernel/bpf/ringbuf.c instead? > + goto err_free_pages; > > rb = vmap(pages, nr_meta_pages + 2 * nr_data_pages, > VM_MAP | VM_USERMAP, PAGE_KERNEL); [...]