From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7E4BC3DA7F for ; Tue, 13 Aug 2024 03:06:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 023FE6B008C; Mon, 12 Aug 2024 23:06:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F16196B0092; Mon, 12 Aug 2024 23:06:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDD7E6B0095; Mon, 12 Aug 2024 23:06:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BFFDC6B008C for ; Mon, 12 Aug 2024 23:06:42 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 79480160591 for ; Tue, 13 Aug 2024 03:06:42 +0000 (UTC) X-FDA: 82445734644.01.61EC79F Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf23.hostedemail.com (Postfix) with ESMTP id AB3D0140007 for ; Tue, 13 Aug 2024 03:06:40 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="ONj/0NPT"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723518322; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PoKhZzfJJfzz5NYdN/8JKDEU39D5A8RsoqhUzJC6Q7w=; b=zN6mtyoBf8q6PebQvpUX9eX9t7IJ29PjXACdbYF32hXx17vLjD1NZ3nm6/87nga1Ux5QC7 2ZUgq/msiWTNn87b2JrFOyFgI3716a68OmBGixIfXX+buqB5jzRgolkUulFuzTahLRjvrT 0WD2LpSc0r+0YtvYK79PYcqOArktf0k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723518322; a=rsa-sha256; cv=none; b=KcTgmOoAyudursraR4z8CgGETB353b2LKFmFnDU9UNjn0OeGIp63zQY1V97iyY6WiKDkTH uW7GK490nfsJPbt4mGlFXss7zX7eGFq/JQDlzsOcuVYWv99ArzYqqTo1bhg226a3qxDBVq FvVUSHtwJitEBBjXr+vCWI/1MkuYBk8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="ONj/0NPT"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-7b0c9bbddb4so3339622a12.3 for ; Mon, 12 Aug 2024 20:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723518399; x=1724123199; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PoKhZzfJJfzz5NYdN/8JKDEU39D5A8RsoqhUzJC6Q7w=; b=ONj/0NPTEPGdpn29ZC5Eib1U+4YEznFTt9ew4szjMlTC6++fj2LcJLzaRHubQwbEqj u3n2IEwpKVCRWzVLMYJHHClFNSQBtApV7Cg7/LETjtFCMhUCnegjr5NTYjDzLq2lKnyy kvy54STpr8Nl9D3Isjjf9BJzXZrfb4zcTHXXqx2pmfw3Df6m9o+83DCNiSBul52eMa+B 47MCj9TJ306E1XEeRZCnlCzxLdQdbq5Ua1i+rlmom5F3eceESyKaiaUMmTadGJ1ClK74 fSP/w0E5P6/8LCQ9EoTJCXItvtxsR+Nr3TyhBhbbzoy7+MjBanaDbDfPv6/VuuOW9wB0 EoRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723518399; x=1724123199; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PoKhZzfJJfzz5NYdN/8JKDEU39D5A8RsoqhUzJC6Q7w=; b=rj1i3HUJSUrevVYLjBXVUguERdBg28keW8kPm3ZbnynQYxo+hlFpVA046g/t4fMziP FbrcabsjjnUt+g5mHlCRBg+W1QL7sek26S06n/uh6A2zKk4pz1WvMk5HQY1ZInbzliyB B+f80kzou5S6TssY1a+vdCCWhdVE7JQpyNdPB0UNrplG6+s9klcJ9ND+wscGDfZj+ZiT ES4MvMOgjMQaDf5K7LQKC8mDZzG/IbhRETtVTSFyo3CqQY2FraXbRioiumOvHtmvCyKp 7FGaEEDMd0YTwfJyhmedhBS/YYReJGwlNMjTpf5aPToCrg5KuzilKWX0jV31QjwmZklp MVNQ== X-Forwarded-Encrypted: i=1; AJvYcCVIIMOmak4tLg/zzr4BuR9mOXGGP4rPY7oiGLmfjneBkvZGQRD99+oRUm+23G30eizPtEuBaPRISUv2jkNRBY+8i38= X-Gm-Message-State: AOJu0YxoU5jPOR2X5u5yiy46UHwHMF/ajv/DxhzD+O7uukqXu1sKlauJ HqJZm4AqzodWOCNvO49wMaVc5+hON2IZyicC6Hrw7LFqIjlALp571WmSwt/Ot/+rAZJaM+iQWL6 sA0e5J6mlpMICN3dV+/KxnWQJOcA= X-Google-Smtp-Source: AGHT+IHX8wZ/bPU/GlY6AQHbS7k7uR+QrtnEQNfEaBVgSMhUvVXsqF1j4Vx8qbOq3HDY0vOjZUETY+EVV21p/TXBeu0= X-Received: by 2002:a05:6a21:1813:b0:1c4:d8ec:b59f with SMTP id adf61e73a8af0-1c8d74c5a2dmr2691569637.25.1723518399241; Mon, 12 Aug 2024 20:06:39 -0700 (PDT) MIME-Version: 1.0 References: <20240813002932.3373935-1-andrii@kernel.org> <20240813002932.3373935-2-andrii@kernel.org> In-Reply-To: From: Andrii Nakryiko Date: Mon, 12 Aug 2024 20:06:27 -0700 Message-ID: Subject: Re: [PATCH v5 bpf-next 01/10] lib/buildid: harden build ID parsing logic To: Andi Kleen Cc: Andrii Nakryiko , bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, adobriyan@gmail.com, shakeel.butt@linux.dev, hannes@cmpxchg.org, osandov@osandov.com, song@kernel.org, jannh@google.com, linux-fsdevel@vger.kernel.org, willy@infradead.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AB3D0140007 X-Stat-Signature: b365x5cd34sj5m9fbgjsgt1ctue8bg6w X-Rspam-User: X-HE-Tag: 1723518400-96231 X-HE-Meta: U2FsdGVkX1+oVWcSLYKu8jtMc0K9qLrR4Hm2Qhti/VgFrv6w+Iy+XM3Hxs4B5kGp0rqIRy92hfjxv//sj4Wr879tSgQdHhDxnVfSqfrOJcJE0tpvPi+1fuZWed7Dr/OMQzktpB13iHcFLU/YSE2XfFZ9/ifqD5rgx8BltvfRtYRUEjN3XtHRZmUCNMsWJEZEc/RqrntYb2MF4koGe3w/KKyVC+C6nSZCvJLyNceOAlwiUQIODu/EnuEWSYhEKNflwmdLUlql+FGxaZwk2yX8dy8V10ykF4OmfIpJkwoyand3K3r/ER63n7VMZGAUxVF8CHJAahAp26xkh02wh45KYtLmiHM6cHPM3xw18Ie4m/Fu/whzadfB4smC+OkfT5XaJwh3JrgcQagQcK1GSAX09Jh3n+2gZFNlkd5MWlDZqQqH7JGf0eTS2ON3oBYoXO/B+crT9qVoBNaOtFn4aTJvx+Zdp48xvupnyN+KJN+9EVeM2zy57lw+RGuJZQmNcaOjdJzdXJqqfzRryylXoptwn5Ty5dJZ9rjraEp6C988bvyUb3JhJfbnOX8Vnj7jSgp9nty+6WihfisGzfwegatWGtQlFbjJqrxSDifbVsbouVmlKT34YjN6NUILmGQ586eLCcAb/ZGcXlDlSXMmgOgy/JIPVtFsp9uMYPVtKweckBFB8dfubJcfLSZAo8y2eD0B6msCffew2A/mWw8wHVNIFPxhJ/UX7jKWwK5R9cBxlqjLugIcnVwLLNjX83FQ3Q1FmjbUw6JH3Knl9rim+ioZs+9Hw26xSXnte1gurqJnw3MNCn8Km2u78D94aBlBv1+s2zeiR1HIPCHYUaCtcPr+Ca1QN45Sso4TqGdRXq92rx8VxdJK/4VTQ8MqgvcZOZomBml0NsMeWRIqhemERXVBV4eX3AaW/rQSiEeZ+coy0mkTlNZ8058hrqbFYoDjvlOXOoimAk4hi3YutmncO61 lXIyuCZP a1Z7xxpz5kiPvcA3/lD8mAujQN7NqQQsr2JZG18uUFyv1ABjdmqaGXOsytOhHagdVrPb5konP0CGOUf+EEadEFBj40xNH7I/IKlfP40GqRSckDlsVu9SreSdfgkOXAVLXtuiNBqlOQj6jdU8IjEkW7BcAnM9T/yi3A54goMN74s7CxSLUzm7jEVMInTq+KG2e7Z45IcCbyfeBc90dOUX1+ESo7vdYGJdOYm0t/ULDtjd7beiwbHtQhRRA7o7F4ApR87iremjsa8sJ119zMkzDeYACq20tHMSQC5Dvcxv4+GLnMRdUFGI3bAUqF5WVlAkqYiBZsESvBtZwh/fBjB5pRMogR797LCEwrCQX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 12, 2024 at 5:52=E2=80=AFPM Andi Kleen wro= te: > > > @@ -152,6 +160,10 @@ int build_id_parse(struct vm_area_struct *vma, uns= igned char *build_id, > > page =3D find_get_page(vma->vm_file->f_mapping, 0); > > if (!page) > > return -EFAULT; /* page not mapped */ > > + if (!PageUptodate(page)) { > > + put_page(page); > > + return -EFAULT; > > + } > > That change is not described. As I understand it might prevent reading > previous data in the page or maybe junk under an IO error? Anyways I gues= s it's a > good change. >From what I understood, one can get a valid page from the find_get_page() (same for folio), but it might not be yet completely filled out. PageUptodate() is supposed to detect this and prevent the use of incomplete page data. > > Reviewed-by: Andi Kleen > > -Andi