From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94E43C27C53 for ; Wed, 12 Jun 2024 06:58:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 232D76B015B; Wed, 12 Jun 2024 02:58:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E2A66B015C; Wed, 12 Jun 2024 02:58:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AA896B015D; Wed, 12 Jun 2024 02:58:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DF6C16B015B for ; Wed, 12 Jun 2024 02:58:14 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6E06AC0FA2 for ; Wed, 12 Jun 2024 06:58:14 +0000 (UTC) X-FDA: 82221332508.28.141F87C Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf18.hostedemail.com (Postfix) with ESMTP id 990E51C0014 for ; Wed, 12 Jun 2024 06:58:12 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="g/sSSMJv"; spf=pass (imf18.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718175492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yf54Wa1SE9vp/tJ3cJNQWcthR5DhTfYZVQgtWp1NLZ8=; b=68sRhs9DeyPZ9Kr2rXF/RhqqiQw36O2Vzs9yPpxp0cO3KfoHNV7DlYajalATX4I8CUeH3O C64h1ajQd152Jl1J+0A8/nBCo/+WfQP/hMhml9gHE4geaHvC3Ui8apv2flMYQpFTbLIDY5 oXTUYxsJo9CvGwm7edvnsUUP8YVm0q8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718175492; a=rsa-sha256; cv=none; b=x1+6+t3ltchlrB1ftGU+2yxH1irfye/rXLpbz+hwnRZ+ORIRgSa/rkHfrwGx28wLZ+WDj7 /yla5ha9Z4D0rJzz2tCGOI0XLel1teRV9kqakRoFEhOkmrbYSkRTsS7GYAZRNXLy2RAyR7 6p2bYaMNswsvx/+V8qujw9CMyJv2STM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="g/sSSMJv"; spf=pass (imf18.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2c1a4192d55so5388006a91.2 for ; Tue, 11 Jun 2024 23:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718175491; x=1718780291; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yf54Wa1SE9vp/tJ3cJNQWcthR5DhTfYZVQgtWp1NLZ8=; b=g/sSSMJvVMl3R4hxXm4CeilWtIRo/y0rsBRhH65MtPX7h3OzV7xZ7kzJBUgrF1tzJx twyNj1Ef9DBu/z90nbmEUG7SIxbMazFuCCwYKxXhGJ2V5pyOpiK1N6AmLqpqKGkjRwBq r8FgvSSf9KFV6sgE3CeM7+XH5IT4H1bLBQTj+yzMyPUGz+r3WeO9Q4E7QHwULaI0H/iq HTPQJX7hYTx+Nbu2S5H5+nX1ITuHdUZoPf02bYXzjlBmHFGU/LojWn9cgx2ZoXw+EWWs OXM1ZExTSwIM837c5XyZEvp+71X0A4jOQotPmx/FRyaAfqVJCvJJcUIam6hYSQiE1vKW pp7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718175491; x=1718780291; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yf54Wa1SE9vp/tJ3cJNQWcthR5DhTfYZVQgtWp1NLZ8=; b=qggl+6HAJtQ5tm+1u2eKtMHbuvWNcKpP12jbtjqqxpgDxSw7FcybGx+YcseMoVYGkF GLX8MwfqD44f2Z9/t8DDA8qlBABoD4Gh6twOajHgBQlIzsrMspVxSXfN7heB099akZ0a I0JqpAz03rB1FJZ4pKMXlJiajp3dDsdePdlhTAqBh5qh85nseAoAi7UmlyPKwTQpqqaA QYv/NvKIoPwIKLvpedvMXcpMNqBFyE8epOI3YNdMc8giGMYcIlQoAbcIdTrLPJsgeoFD uAorVNoYXlRX3DL2Zx7J1BTKLWZUEpAj/vQ3mUgXe68yJBOCsSadh11VgAmlLFo7/tW8 sjgA== X-Forwarded-Encrypted: i=1; AJvYcCX2RghqXn+KhdxyEIBxKZWQWwGotiIp2GPSKfG94aEHWdPhc7yk0wYBpNnpDwGByxYLXZFtz7KAxDwMQ6gsPAa9Uf4= X-Gm-Message-State: AOJu0YxnB791cOxr6/xaa/Cwv1jBQJSIFrRTcnKWTVhnNq/amxsyNODt zfuRN5Q8tcpXy9x7ymdHB0ifR5qBjuRvsAtgweb1zszt5J7Zyl2bQWtMQ807qs9lr5EuULw6hAX vn5RQcNcEmFgCaScz4zXJh9OaMPQ= X-Google-Smtp-Source: AGHT+IHq6UY650bqkZXEO4Gyq7SUgAT79l/h3ccYb+ytWMAxBcDebAD+GbEVhvRZDVgYp4BMB/TR1C01JO23VwA/DWc= X-Received: by 2002:a17:90a:8985:b0:2c3:274b:dfb0 with SMTP id 98e67ed59e1d1-2c4a7629f13mr949448a91.17.1718175491330; Tue, 11 Jun 2024 23:58:11 -0700 (PDT) MIME-Version: 1.0 References: <20240611110058.3444968-1-andrii@kernel.org> <20240611115950.35197b36eafe0a804ecaa0de@linux-foundation.org> In-Reply-To: <20240611115950.35197b36eafe0a804ecaa0de@linux-foundation.org> From: Andrii Nakryiko Date: Wed, 12 Jun 2024 07:57:59 +0100 Message-ID: Subject: Re: [PATCH v4 0/7] ioctl()-based API to query VMAs from /proc//maps To: Andrew Morton Cc: Andrii Nakryiko , linux-fsdevel@vger.kernel.org, brauner@kernel.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, gregkh@linuxfoundation.org, linux-mm@kvack.org, liam.howlett@oracle.com, surenb@google.com, rppt@kernel.org, Alexey Dobriyan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Stat-Signature: upa3obsjk7stp61uuxw7n4otzbfb1hno X-Rspamd-Queue-Id: 990E51C0014 X-Rspam-User: X-HE-Tag: 1718175492-111514 X-HE-Meta: U2FsdGVkX1/brSmdisfigQ+bgUhhSNQ8PCti2IbbMfOe0d6Ky7mZ1dnizhgjJmPoglbaM4yIeVCeQsuYKuM96cO8dqrpujyRy+X884ebRDJ38xDy2gt2hb/8JBiCqBqx+/46bfvwVNTuf6+OrVTzfsBL0un0znGtMIvTxv6CA3fqdW34IMLV/2dVMmjWw9A/EbS8RCHQJLyC1BN5ZDZuwU9pvxAkBNRLfKtaUqnMelcy2Rfp+Ht6CxJqnXnL3ygdEqotqwFO2aitcmC3lIZOhUTeLN/lAjv8ZE76waRmidPnHXnGIv93291zANy9Vxc7YAsgDczRNK5Kp0BDk/4dLPA2Zw3M67MzHBTIrZmV1gJFF949KPA+4tcJ5S+yUVA7NTqbtEs7G/+pAcAE+iPWzPYEyRX9Dl402h+Q7wPyidvUUjn80Gly72A6XhcGNSbKYAyea3Oq2C9n8KSGUjYbao1HrKHNe28qrJNpi72o26CMc9Oi9dB//lt9ceYxEZ76UzvZuLg0RWBe3a/mH0dbDT9W20bNnayU4fzzrcTo2sIbuSoN04cygxK/jYBEdzOGoyxYOEKsH4DC9T+YCeLNUnw+wtwZBIUbuPacPWiVw75av6GR3Dm1SwQXQx2jmYXnbBELKrdyQKCz7vzHHm33qmj2cwLYFYFtUaM4Dp6g2zn8eA8gTTxqEHSBSisZpJhb2gwCbbeH8jBqGhst5yZ2hiemkhwBWv2NI6BX1pTIhiv//SKjlCdteRJvY6sSekYTktEpY+M/HSjoKht8JaYLnOFfnMrJuhHc0XRU1wl+pKxuiEU0Cij7XUoRmcb8TkPicmPnA1LSk33lwnkOKDnm60sHYEhZfTdnxvD1rEpGxuAtvorrw8jXXA8KGxkc0RqqKxbsgXo07dKjrolgiqb7PAmYEftP92qaAM9Lv/8kUVWaQyaESNp6s6M2lgk0gdeJWxYN74TDReRlF+sg85I wvZD0yQJ BiRZ0ob8LTivCdE4a092ys3XUzZGIZUnScXSCzdOtatriHGxN9AnyO/L3z6ImKGfdtMJwuvgwbvfr6vN/hlfa0aKoJehvX86ecZAXAfNvQJ2RtE9UbdqzjYfNdEOyRY11sdcdKFhEvxNiEWYPrZupgdETyTpo3MKW6L0F6xo3EoFcLUAGs5TWLspyM+gt2GBs6nRLTTh8Ai4pITaHilwHV7/ktg/VxKSbF4ri1yaqPRH60xMOoXortIplNi+rKAN6TNU20oZpdvkfm7HmjeE53vV5+zTgmn+M7GSvZ2u2EByVU2/fnU+CcbrzxAHi7vUSv+pASKimungC/Ot54mbFUW/wzBphTQKhdIGTR8+s2wzKFJSoutRJSA5AI6B5zxM4ZxwT7MbcNgjWE7AZ/kbWjE6R7+lqNqvulBAL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 7:59=E2=80=AFPM Andrew Morton wrote: > > > (Please cc Alexey on procfs changes) ack, will do > > On Tue, 11 Jun 2024 04:00:48 -0700 Andrii Nakryiko wr= ote: > > > Implement binary ioctl()-based interface to /proc//maps file to al= low > > applications to query VMA information more efficiently than reading *al= l* VMAs > > nonselectively through text-based interface of /proc//maps file. > > Looks nice but I'll await further reviewer input. > Thanks! I'll work on adding more tests meanwhile. > > > > ... > > > > Documentation/filesystems/proc.rst | 9 + > > fs/proc/task_mmu.c | 366 +++++++++++-- > > include/uapi/linux/fs.h | 156 +++++- > > tools/include/uapi/linux/fs.h | 550 ++++++++++++++++++++ > > tools/testing/selftests/bpf/.gitignore | 1 + > > tools/testing/selftests/bpf/Makefile | 2 +- > > tools/testing/selftests/bpf/procfs_query.c | 386 ++++++++++++++ > > tools/testing/selftests/bpf/test_progs.c | 3 + > > tools/testing/selftests/bpf/test_progs.h | 2 + > > tools/testing/selftests/bpf/trace_helpers.c | 104 +++- > > 10 files changed, 1508 insertions(+), 71 deletions(-) > > create mode 100644 tools/include/uapi/linux/fs.h > > create mode 100644 tools/testing/selftests/bpf/procfs_query.c > > Should the selftests be under bpf/? This is a procfs feature which > could be used by many things apart from bpf and it really isn't a bpf > thing at all. Wouldn't tools/testing/selftests/proc/ be a more > appropriate place? > Yep, agreed. I used BPF selftests as a quick and simple way to validate it's working end-to-end (because we use /proc//maps across a bunch of pre-existing BPF selftests, so that gave me good coverage and signal). I'll look into adding more tests under selftests/proc for the next revision. As for the procfs_query.c, it's not really a test, rather a custom testing/benchmarking tool convenient for development, so I think I'll drop it from the patch set for the next revision (and maybe will put it up in a separate repo on Github or something).