From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F046EC433EF for ; Thu, 28 Apr 2022 16:23:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83BB58D0006; Thu, 28 Apr 2022 12:23:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E9BC8D0005; Thu, 28 Apr 2022 12:23:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B33B8D0006; Thu, 28 Apr 2022 12:23:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 5D3B28D0005 for ; Thu, 28 Apr 2022 12:23:06 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E69D72AD3C for ; Thu, 28 Apr 2022 16:23:05 +0000 (UTC) X-FDA: 79406807130.25.DA873B5 Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 2CCA54004B for ; Thu, 28 Apr 2022 16:23:00 +0000 (UTC) Received: by mail-il1-f172.google.com with SMTP id i8so2310357ila.5 for ; Thu, 28 Apr 2022 09:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BFhJTeBHegUGtkoKbPnigoTiPCA3aoao0K+t84QabKg=; b=jfXKPvMzYUegjls0RnwX8rppG+Ce5wuHyePNtzxGVl+zXyb2acEES4JRq5s3Robr3W AY623UmGkEqjuPDd0mngHOQHxpCkAkAFd2aFU3589FRzNtpTicD6Hv6oeXRpa0weT3yg TlW5cMZ1ALl7VZHhvqWjvwEJLI4dqRtMZAOZWy/vy6R9w6RJ+3ALAjvmqjE1MkjK4gUk yY0SGHz5Cwn4Dr0swRqp7cwUAfDck1LUFA/KKe0tRD3A+hu09E4eU7Gx6wJ16K7DZsvY U0Kk3W6c7jGJuy4BdJsXNsiDgIt/Bbi7yvVLjPBwkQ8Z1ac6Uxb2DWlDCIc+tFJNlLhC s63A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BFhJTeBHegUGtkoKbPnigoTiPCA3aoao0K+t84QabKg=; b=C+00y1R25JbmSAwrmWUvmCURJ2rxs1vVq6wQiDafUGma8bo/3Mjm66Wo87HjjC+fO/ CvKjW1zfEUT3lLN0fGHKFyxZ8QhSqjuxXGrdG77NIQsrHllPZOjuPUJtFzZpXPc9w7t2 FDuDMbqiL1T2N0YhyoHfJHs/ore6bv3eYp0Z8vcUPWLcH23w49X62vYcg7VXZ5V2WaNT TmFB22dWRk71VQYdsEsfbPwAt9jCOL3DhK59N9TDPr2egCKJ+o54F0eqViJDqfE9+NS6 2dQFoaYYgRWDt4HAAiL5oYh0EoRTOk/JmCiuVUuCUp/VIShQ0+Ra1jg0PO/mxGKAlsCH B5Vg== X-Gm-Message-State: AOAM530cfk/MUY4RUU1KGITKhkjxcGkQM8mIf1BmT2vwHlX/C85yPxg0 pRhpBZ02EvucaqFsJa6lAw922OYOeKHVvumFlcXwuJwPqBCk4g== X-Google-Smtp-Source: ABdhPJzHur/icTYgIyTfK7H0clyD69BvncoOM31SARFGHRbB1eRkm4EmwY58j2ayT+Bf0E9S2cuGD1rcv1FWr/ye3oY= X-Received: by 2002:a92:c247:0:b0:2cc:1798:74fe with SMTP id k7-20020a92c247000000b002cc179874femr13498199ilo.239.1651162984685; Thu, 28 Apr 2022 09:23:04 -0700 (PDT) MIME-Version: 1.0 References: <202204271656.OTIj2QNJ-lkp@intel.com> In-Reply-To: From: Andrii Nakryiko Date: Thu, 28 Apr 2022 09:22:53 -0700 Message-ID: Subject: Re: [PATCH] libbpf: fix returnvar.cocci warnings To: Alexei Starovoitov Cc: kernel test robot , Julia Lawall , Andrii Nakryiko , kbuild-all@lists.01.org, Linux Memory Management List , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Network Development , bpf , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2CCA54004B X-Stat-Signature: zmqrb7j95ciz1h41jn9u8eoptaxda73e X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jfXKPvMz; spf=pass (imf01.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.166.172 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1651162980-116946 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 27, 2022 at 9:07 AM Alexei Starovoitov wrote: > > On Wed, Apr 27, 2022 at 1:04 AM kernel test robot wrote: > > > > From: kernel test robot > > > > tools/lib/bpf/relo_core.c:1064:8-11: Unneeded variable: "len". Return "0" on line 1086 > > > > > > Remove unneeded variable used to store return value. > > > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > > > Fixes: b58af63aab11 ("libbpf: Refactor CO-RE relo human description formatting routine") > > CC: Andrii Nakryiko > > Reported-by: kernel test robot > > Signed-off-by: kernel test robot > > --- > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: f02ac5c95dfd45d2f50ecc68d79177de326c668c > > commit: b58af63aab11e4ae00fe96de9505759cfdde8ee9 [6746/7265] libbpf: Refactor CO-RE relo human description formatting routine > > :::::: branch date: 2 hours ago > > :::::: commit date: 9 hours ago > > > > tools/lib/bpf/relo_core.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > --- a/tools/lib/bpf/relo_core.c > > +++ b/tools/lib/bpf/relo_core.c > > @@ -1061,7 +1061,7 @@ static int bpf_core_format_spec(char *bu > > const struct btf_enum *e; > > const char *s; > > __u32 type_id; > > - int i, len = 0; > > + int i; > > > > #define append_buf(fmt, args...) \ > > ({ \ > > @@ -1083,7 +1083,7 @@ static int bpf_core_format_spec(char *bu > > type_id, btf_kind_str(t), str_is_empty(s) ? "" : s); > > > > if (core_relo_is_type_based(spec->relo_kind)) > > - return len; > > + return 0; > > cocci is wrong. > It missed append_buf() macro. Should be irrelevant once [0] lands. It makes use of that return value directly. [0] https://patchwork.kernel.org/project/netdevbpf/patch/20220428041523.4089853-2-andrii@kernel.org/ > > Please fix cocci so we don't have to manually deal with > broken patches like this one.