From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5774CC3DA6D for ; Tue, 20 May 2025 23:32:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD69B6B0085; Tue, 20 May 2025 19:32:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CADE86B0089; Tue, 20 May 2025 19:32:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC5A36B008A; Tue, 20 May 2025 19:32:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9DBBD6B0085 for ; Tue, 20 May 2025 19:32:40 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 217681A1830 for ; Tue, 20 May 2025 23:32:40 +0000 (UTC) X-FDA: 83464888080.02.48F87F0 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf08.hostedemail.com (Postfix) with ESMTP id 3974B160002 for ; Tue, 20 May 2025 23:32:38 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=akgFcyBo; spf=pass (imf08.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747783958; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=btSbgWZQEQxAvW8UqKA0bLcDfhKnAe/VIvlamnBbDZs=; b=dZAnJIz/OIJqFcLwacFtOAy4frxY0/a4lYOIODDDr/sMbRfhMcP/Z6kHyMI9xo3fdbR072 54xaw1FvfBZyGFUk02FYDuY5GfMpgeqXXOj0qdLrRxex0Lxpqjf4lYEJ/bJLJkVIYi9mHu 7+qQPgviFJErMeVxUt7m6MZ1RVk8+PE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=akgFcyBo; spf=pass (imf08.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747783958; a=rsa-sha256; cv=none; b=kZPrdTeuHNv3/vjGrtpuGg6Wx/eH6QoK85iZ7dF741145rzKIr3vg9wBLTjm1DkVJvy/yo H0NMb0K4SfsMVDZ2Rl+uav3W2K1JYboHHWi4Ow/AWQL307Plfa75848g7SbHW9ouXYk3VX LDWAZwaS/eU5wqzU7Jb+fXxSwrac1+w= Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-30ea7770bd2so4946154a91.0 for ; Tue, 20 May 2025 16:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747783957; x=1748388757; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=btSbgWZQEQxAvW8UqKA0bLcDfhKnAe/VIvlamnBbDZs=; b=akgFcyBonknWbGe7SdynL79O0guICW3Wn/i5neguDqqm9v9yejh1nTa34IawvKF8wv We0O3Tzrw9n/h7TA6W40cxwyPme4AhKeoMu/bvOiFjTblNRwjPZkYk1ic5i3VHmN+yD2 KnrvUZ4LAcznmmzIcwoexcMuygkmiQNRtcvcP4lujEWwmHPJP1n4AGwVkhyd4BkRv4va 9gsZBKW/4usaRjF+xnfR0ogJTz6HMBfHiZ+Xy6OTlO5A81Ld8u1HtHoW1gEUM7IYsp22 5TLKfXA/l6Klc1D4l4rmXaAmRgib5aNUGoaTQ1Q8VGECHuBD49bZ/xD2mYeGVnSSyxDv uNEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747783957; x=1748388757; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=btSbgWZQEQxAvW8UqKA0bLcDfhKnAe/VIvlamnBbDZs=; b=NP1IWImNylGI8u61umSWAZ4S8cKuN3v3G62VEsJeVSqzRafMizTs+NHr13BZ2zwwKo kKl0G8CGFa2QAFQUZ1l24yLJS66tbBLf1rIzNXI9NRnFu3Br1AKY+VRHxirmKorG1s9g Ert8fD5dr3GYKKn3Rebh8r1mOsS7Gf67dy69jlPapsv3U0wAurNOivG0e3Q7JtDjzygb syFvSyBkK/NjEFaqkSBvEQpnGvLF/+IL9p4CRPHe8VC+Ha0e4JNhEXmhSu105lW2YdBC ghvQ5o0uiEAqK+7TruGiz3j/aoPQGkhdF8hXpOnBPa/NZbdKUWDAFzQxpRzm56ER30d0 is6g== X-Forwarded-Encrypted: i=1; AJvYcCX/uqbkLgHVtRNyxklKJzTVAzrJGZizCeSAkKe93M5SmUzpFRJVmEhQRaWSCQDEe6tJCq21dZKiaQ==@kvack.org X-Gm-Message-State: AOJu0Yxk9zlwJZYTyOZbekLkOsKVE/UGlZsN/UUy5a67lJEuii/YiGSF /VpKcjwtq6zVrdzhua2or5nakHyMsbpowEp+qQxWotBpOYKSzHq0nkN+Oep1kTAGO2jttiDMMgw RHDFBclZfqtkezDE9l1vCWBk6DjgD2kE= X-Gm-Gg: ASbGncvblczk4HIejE8OZdb3GPh8JOtklJZYZnTLXhwO1N/mqGd4KdVp0OZNXKxUfcw v7aPksQEfTmSwbw0l6zVasGynxUXZtIWvN4SAxpCBJP+GNkZ+wHtQIkDohp2mQ0xUvssnoWXa1y gXd+JHorU7oWYamoS/m8X1KWU6XJgFPWm5b8NH55uOcXpaKNFl5oKDQlFFezE= X-Google-Smtp-Source: AGHT+IHCHSkY4+oYnt9LNhIX4Na6slRaBPDssT+/pu3BfEjEThTmfyyyV8EoIQf2QB8ifbPtIr+bFxV0og9MmakT3z0= X-Received: by 2002:a17:90b:4c47:b0:30e:391e:ac00 with SMTP id 98e67ed59e1d1-30e7d5564f2mr33847458a91.18.1747783956877; Tue, 20 May 2025 16:32:36 -0700 (PDT) MIME-Version: 1.0 References: <20250520060504.20251-1-laoar.shao@gmail.com> <20250520060504.20251-5-laoar.shao@gmail.com> In-Reply-To: <20250520060504.20251-5-laoar.shao@gmail.com> From: Andrii Nakryiko Date: Tue, 20 May 2025 16:32:24 -0700 X-Gm-Features: AX0GCFsqSuLMxdRF1OOKdGhrul1QiEzKLm6-PSF1Ax2BBApTh3q9xUkEnLQYkpo Message-ID: Subject: Re: [RFC PATCH v2 4/5] bpf: Add get_current_comm to bpf_base_func_proto To: Yafang Shao Cc: akpm@linux-foundation.org, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, hannes@cmpxchg.org, usamaarif642@gmail.com, gutierrez.asier@huawei-partners.com, willy@infradead.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: y4ty99wcc981ysutcq87rqdmdp65e9as X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3974B160002 X-HE-Tag: 1747783958-165761 X-HE-Meta: U2FsdGVkX1875jAzC0wd2VJPLwoWOWDFLEArSk9jUOE6jg5zkEHRbn2z2t57uQJh2hNWTdlu3FCyUPFMvEZJeUHlx4BRiXIMGk2IfWGxN9R3/+xTLxP4wBDGiFEAMnZwUH9l1gVeE9XF96L8YnZ8f6dlMb7F4IULhkFfPlv06RzGUbu6wy3fVy/7gvj3WjCvGMN4D7cgdtkgNSuYaKpX6xxWVATQgAtcLU9gbxvAZbnXQNkyo763iOkQEmgjdpnoWNALWNXRpTOSktslLbSVBhRUt2mDMw90rBiUqSvWGKSiy3TNOTeHhPJKyZnD5vZ58x4AbVcdF69pbjThr1DPNuuEEzRJlysKBK9Uv/HmTB0YMK7Bh2dDwlz/ed13U++WFB/WewlcWTrcC6krFeis4SFQAezk6lz5DScSyN5rF02CR4vuCBtOCfnSn+JRB0XXEjpob1zHfobGtKejao870TRBjGunBHI96gFk3iqerq5mdc8mBMVcodaqwYQdLRaeC/vdXhaid5TxiW017RJxLPXeiPpRzq0rSds5nb/iPGbWGdu3A9dtOC2jJtuqibU4mQrNiZy2FJWxOjYxKq0usIxzxR1NRIWG7uHzOmTVPCMgjHSM6ylwqv5q7wKTTLGXWilQy0DUoZrvJGMOEtkB2lpNVcwinUFmDLYLUyVqyf8hSKwohGamut+SsXF23WF9FZtHgqY3H6ZvAwspOcmoHO6w4eZ8qMNntCFvuEkSe0PWlGB3aXiilww0Erh9R8+zVlhJGm6YtCDnNA9b0m9dsXACsZ+yOZFyMqlvjVyCLcdrXR2Qk7Bx1ln5Ifi/arnznANvDTSj7ktPfypykKVm8SssTWZ7gF4/VroGN5rnbdA1wVeJHMRI/E5wJo+baW4bIQ9Nk3py5ut128su7+MOwju6OZZlFrp5EXS7Zxx3xPBLkwe+RzE3cFiSy+DTM3/adZ8j/z05DOFPIw7fsbg Bfnpk+PO mF6ko+Cnm3B0GI+TpjWqJRaJDG0fXKGTpfqEjNEO/SmWRY/WH2LHVGY9V8ZFlm58ZTWm+hbYb6sfr8AFcs3khOUUSpInN4cwfePJp0AHR6RVyV/o/jWVqc+Usyn/t8KSaITtrR/tBQqh4rXEbvpBgJC1bdOa5MqCnsoWwretYtrTIJp8F1KcOOAKHIXSvMPaOTuQd7aT+ge0+lgaSUz5BfA4Fwb17bRknlvzoL7TWN5YeiIvNXLtmDNO+gXaJU5QNSiU/cHXhpLvEj2banNFvfFler4KrMj+iNMyLd47qjlV7YeYKwpopoKrtggo2Pdy2NvkZ/1R3G1zgdgZttWj+MA0YFLket8qXBQsPXMfnzNAihqaymRfAoaCdtfXRccFEnM6lKunM7BdSxuCL+HK+6jqeWl59oMgKleAy5NXmlFY/Klvu/Lj5KSdbcJjIt6KSpo1ZfEa0HrToGHsmGX/jf64rGt2G/a9E3xnhwWaPvKA70bg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 19, 2025 at 11:06=E2=80=AFPM Yafang Shao = wrote: > > While testing the BPF based THP adjustment feature, I noticed > bpf_get_current_comm() isn't available in bpf_base_func_proto. As this is= a > commonly used helper, we should add it to bpf_base_func_proto. > > Signed-off-by: Yafang Shao > --- > kernel/bpf/cgroup.c | 2 -- > kernel/bpf/helpers.c | 2 ++ > 2 files changed, 2 insertions(+), 2 deletions(-) > please rebase, there were changes in this area and bpf_get_current_comm is already in bpf_base_func_proto (and cgroup_current_func_proto is gone) > diff --git a/kernel/bpf/cgroup.c b/kernel/bpf/cgroup.c > index 84f58f3d028a..22cd4f54d023 100644 > --- a/kernel/bpf/cgroup.c > +++ b/kernel/bpf/cgroup.c > @@ -2609,8 +2609,6 @@ cgroup_current_func_proto(enum bpf_func_id func_id,= const struct bpf_prog *prog) > switch (func_id) { > case BPF_FUNC_get_current_uid_gid: > return &bpf_get_current_uid_gid_proto; > - case BPF_FUNC_get_current_comm: > - return &bpf_get_current_comm_proto; > #ifdef CONFIG_CGROUP_NET_CLASSID > case BPF_FUNC_get_cgroup_classid: > return &bpf_get_cgroup_classid_curr_proto; > diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c > index e3a2662f4e33..2a60522cd66f 100644 > --- a/kernel/bpf/helpers.c > +++ b/kernel/bpf/helpers.c > @@ -1965,6 +1965,8 @@ bpf_base_func_proto(enum bpf_func_id func_id, const= struct bpf_prog *prog) > return &bpf_get_current_pid_tgid_proto; > case BPF_FUNC_get_ns_current_pid_tgid: > return &bpf_get_ns_current_pid_tgid_proto; > + case BPF_FUNC_get_current_comm: > + return &bpf_get_current_comm_proto; > default: > break; > } > -- > 2.43.5 >