From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1637DC43219 for ; Mon, 8 Nov 2021 18:20:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9B90D61989 for ; Mon, 8 Nov 2021 18:20:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9B90D61989 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0A8CA6B006C; Mon, 8 Nov 2021 13:20:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 058446B0072; Mon, 8 Nov 2021 13:20:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E887A6B0073; Mon, 8 Nov 2021 13:20:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id D88696B006C for ; Mon, 8 Nov 2021 13:20:57 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 91C8C8249980 for ; Mon, 8 Nov 2021 18:20:57 +0000 (UTC) X-FDA: 78786579354.13.F0DAB15 Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by imf12.hostedemail.com (Postfix) with ESMTP id 46EDA10003F8 for ; Mon, 8 Nov 2021 18:20:56 +0000 (UTC) Received: by mail-yb1-f169.google.com with SMTP id u60so30162341ybi.9 for ; Mon, 08 Nov 2021 10:20:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r7XPmJ4Slk0Ee3SezOzVKKKVWOfK/ZMFCj2/Il/40bw=; b=iz01UfRunQAw2bNi51uhKvnwK2/Te9f/yoUFFKDmp5I6iZld01jP8o5venupoJWDO+ mT94brOYF2rsnQ9uqe12t0Y+xbOW7arQ2DH21TpPvZeFWaXI5omzz1VApkGnM2MZ15FJ 1zrT4C+5b5xSRAioqhGnsxz35d7mTG9TJy1xlk8nSZNpch7bGx/VzMczpRLQYkDGKLgP 5ReQhsl85aBI38ZkG/w/Zi2jMhqZqgCQ5fiW15aIJpYxdPWKRvVUhoLq9j1KgTwlCnT9 nr2UlZ5lWY9ldfsGC+IC+8RUNbeyEOvkY8IZR5FH5Fq96rFeepMMgtBf9TwyowqfnTsJ FQFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r7XPmJ4Slk0Ee3SezOzVKKKVWOfK/ZMFCj2/Il/40bw=; b=LGmQXVB9y0nHhXfTY+mxq/j5CyiZpUNpZVauvknN5LXU1hOJQ265Dp0EuMJnabec1Q 80oQvzYE8JNShZZXI5MOAeG9Kf8qtzMWnfBYVcSJPBJiNJfKjfCmO7lpVU6ADr98xSqY sGrjwKIYY21tSEcPcVKJVuuszVwOFrhr1Lb5fTxg2XRayXrngdGpgPyNVrzEKTt2IJ2+ kAw0BJHKU8qrREpz9nW1MLf4Thhi+xCyM1PiSfS1x18jusXiKtATRE2xfkGM7pGWPWPg 8nNOhQ3+w2WtT6Muhi6l0K5OieDfF5yCu3FQl3PYpgXrugefw8+mKligerymyH3kplTj SMiw== X-Gm-Message-State: AOAM531VVQnAipt1gB923NVtiuki/46YEPDUlvHo8pBid4eAewYGB4HA MTgInbqSUgYhD7RIG5jvE03xMT712wf4bS7xBB4= X-Google-Smtp-Source: ABdhPJzKAxzbKjPtiiGNx7AYawm+AKqI67L99mxmMg0zsCRfBfiQ633kM0HeDLshFyAnNtdF6Ej5bom8rFbvvTcqyW4= X-Received: by 2002:a25:cc4c:: with SMTP id l73mr1441620ybf.114.1636395655412; Mon, 08 Nov 2021 10:20:55 -0800 (PST) MIME-Version: 1.0 References: <20211108083840.4627-1-laoar.shao@gmail.com> <20211108083840.4627-6-laoar.shao@gmail.com> In-Reply-To: <20211108083840.4627-6-laoar.shao@gmail.com> From: Andrii Nakryiko Date: Mon, 8 Nov 2021 10:20:44 -0800 Message-ID: Subject: Re: [PATCH 5/7] samples/bpf/test_overhead_kprobe_kern: make it adopt to task comm size change To: Yafang Shao Cc: Andrew Morton , Networking , bpf , "linux-perf-use." , linux-fsdevel@vger.kernel.org, Linux Memory Management List , open list , kernel test robot , kbuild test robot , Kees Cook , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Alexei Starovoitov , Michal Miroslaw , Peter Zijlstra , Steven Rostedt , Matthew Wilcox , David Hildenbrand , Al Viro , Petr Mladek Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 46EDA10003F8 X-Stat-Signature: 5qgug6gaxdctgcsas98auqx7984kfrf1 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iz01UfRu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com X-HE-Tag: 1636395656-219747 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 8, 2021 at 12:39 AM Yafang Shao wrote: > > bpf_probe_read_kernel_str() will add a nul terminator to the dst, then > we don't care about if the dst size is big enough. This patch also > replaces the hard-coded 16 with TASK_COMM_LEN to make it adopt to task > comm size change. > > Signed-off-by: Yafang Shao > Reviewed-by: Kees Cook > Cc: Mathieu Desnoyers > Cc: Arnaldo Carvalho de Melo > Cc: Alexei Starovoitov > Cc: Andrii Nakryiko > Cc: Michal Miroslaw > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Matthew Wilcox > Cc: David Hildenbrand > Cc: Al Viro > Cc: Kees Cook > Cc: Petr Mladek > --- LGTM. Acked-by: Andrii Nakryiko > samples/bpf/offwaketime_kern.c | 4 ++-- > samples/bpf/test_overhead_kprobe_kern.c | 11 ++++++----- > samples/bpf/test_overhead_tp_kern.c | 5 +++-- > 3 files changed, 11 insertions(+), 9 deletions(-) > [...]