From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7463CA0EFD for ; Fri, 30 Aug 2024 17:55:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EADE6B00A4; Fri, 30 Aug 2024 13:55:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 699AD6B00CF; Fri, 30 Aug 2024 13:55:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 562506B00C9; Fri, 30 Aug 2024 13:55:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 30A826B01B3 for ; Fri, 30 Aug 2024 13:55:21 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C1265140298 for ; Fri, 30 Aug 2024 17:55:20 +0000 (UTC) X-FDA: 82509663600.12.0BBF072 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf10.hostedemail.com (Postfix) with ESMTP id B5DDAC000B for ; Fri, 30 Aug 2024 17:55:17 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=abZSVmke; spf=pass (imf10.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725040496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qZ762szQ1qEpWPo0O5KQwapOAPZbS/knJpSelWgCLe8=; b=WNB5r/eCNrj2aaepq2NUVe7x1w/g+XZsF4xHeKHwhkgMqvWjq2w3PcIyg1HHzUzUWWsGDz AIWkahRXGh+zLYlcfkZJiOD0xWfnXyWlltIi7NqhTPKTyUrNo9Te6BREwsxIlimzoqD9tZ cIgw8QCCh8fmeIWdPP/yGogeAUWKfsc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=abZSVmke; spf=pass (imf10.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725040496; a=rsa-sha256; cv=none; b=g13grbLUeYd6qrxCRxVugI6seQEAxWKzjh/zQVIfb/ucB65hQYSdPdfmkneAjEjRoZJM7p s+R8HxjDq9l2SnC9+kYEsGkHqwkoIuRn6oYnwZaSWXH0G+B673a/tH5Uov6jy4/PBhvaOi We+GpJGwvdI/HkWMykRqBDwVnbKOYfs= Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2d86f71353dso648934a91.2 for ; Fri, 30 Aug 2024 10:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725040516; x=1725645316; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qZ762szQ1qEpWPo0O5KQwapOAPZbS/knJpSelWgCLe8=; b=abZSVmkeH+0RIp+XeYhoybrn7+0RdMuPmiB46cfcfiq8QqaeCSaPYz6MJFFkc8Pdkv gocWpJ6uvDGXKL88alr1RreRkguutFRykgd3DExJhVaM+V99bzWofHVz6DKfzzXXT4jj eJZC+bPkt9yBI2NeJr5VOinLBfFUsDR1kndUayYwIYKNz+rV+WTiE2N8UND8drXrk4dr CP2XBUJc2d7e6Af0dO+Q8S6/7ejFJB+G4b3800CXh9PlrVn37Rx2hvlgCsT606NEKg7/ fRl4OqJY0wm7KAt1Uu9mmg8A0nBKD7AmxF9KXeqgcFsxOyOTcNNCSLZH+W+OizstC9qO BJlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725040516; x=1725645316; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qZ762szQ1qEpWPo0O5KQwapOAPZbS/knJpSelWgCLe8=; b=tBVCQrDmDcDKieV5Nkf2P8oVz7P5lEHsNQ7sIi73suEJcvFL8SdV5XM/auvcFdAJ7d NNfk2GD5i9awO+TC/79lZNF7a14hswAeyKvscUZp1Fh1AI6hVSrQAdyHheWqHl3idrT4 aOBr+/XvmsrD23xsthSC+6dgRMvw0grsVIUWu+RbW6jCS3/I1JWiU4jyuz6xPaodH5vo yWgb0MlyF1X5Lj13sxPa7ZAMKXz9su5hvp4TcKEphoV0M05uewo9Zk53MFVPaVg3xr6r U6aROHEFPIJEHMQidCbE9xp/uadUh8rwdags9aonuBlfJuX3AX60F6ReaVGEvBrwNQtu hQ2A== X-Forwarded-Encrypted: i=1; AJvYcCUzhnMMaeHQBBXgmClMoSe0puNCnYOej8NRdAufbQD+OfuWWidcA+h6mVv3ynOLswrlXrmOAfTqow==@kvack.org X-Gm-Message-State: AOJu0YwcyQmn+/JfePmoFiDpio34acS5QJePoMANehDsjtCAZdklwiHD Dje880PJl3NP5RL4EnalpMQNLTJzOOq+KO3K1rIyKhKgOzYSDcSzoRhVWqw9nJvd6OtgvZwWzqU F+5bhqwuE/0Kbc0TR4ifWrZ6JQXA= X-Google-Smtp-Source: AGHT+IHtJjX1Gwk7q65iKPb2jj2ZTbFe6Gbjk0MA9s/QRUze7TuxIpE1CDYdoK+SEpOHhavyYH0EIzF6ReAgjG7xuJ8= X-Received: by 2002:a17:90a:ce90:b0:2d8:6f73:55a with SMTP id 98e67ed59e1d1-2d86f7305edmr2818362a91.25.1725040515970; Fri, 30 Aug 2024 10:55:15 -0700 (PDT) MIME-Version: 1.0 References: <20240829183741.3331213-9-andrii@kernel.org> <202408310130.t9EBKteQ-lkp@intel.com> In-Reply-To: <202408310130.t9EBKteQ-lkp@intel.com> From: Andrii Nakryiko Date: Fri, 30 Aug 2024 10:55:04 -0700 Message-ID: Subject: Re: [PATCH v4 8/8] uprobes: switch to RCU Tasks Trace flavor for better performance To: kernel test robot Cc: Andrii Nakryiko , linux-trace-kernel@vger.kernel.org, peterz@infradead.org, oleg@redhat.com, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, rostedt@goodmis.org, mhiramat@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, paulmck@kernel.org, willy@infradead.org, surenb@google.com, akpm@linux-foundation.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 46kbiwh5jjo8t35yjm7h8rce5ku6sncy X-Rspamd-Queue-Id: B5DDAC000B X-Rspamd-Server: rspam11 X-HE-Tag: 1725040517-898057 X-HE-Meta: U2FsdGVkX19uB7zoqcreVjwON192i19vdNDnPXeIjOyRLTkENEEbjvHX9UThVTeoF1U3neF8NH+Og2+jB+IZ7gEi5lcic4VHgJMvINkX/EbGJDDALRM5IqCr7I21GWJlf5euT38I4p2xTrTvjJsRkXY8AMqJuU8qmaZI/FYeQKBBkE8D3LatL+4xMz0EHAEefBcan802pVklQn3aP6oq947jY80RLDIywAn1xYSSXc7blzNUztjpEO7yGk+sxnFDTOn+t+4yorlXEi6vqzPRUWLOYTNWGedJjXG1cOeA+hENgEz0QCXjfJJgRempJ3zDkIX0QqyLfqhcTAFrqH0a+5xoKhZMAQCazVh3banU1l586rFScOUXTIItqNd8BP7l+ZgW72OdGRPdZYZjC76jhzGZPgr7bPmmpuo8tB+lfyn7jbD47D3ZlSUH266oi149VKIBZspGpK/Px5hog/Gf2+kgvOVt61ac6P15naFZ0zDqId0g5PH0/fSsr4TYRbW7uMkhe2+GfFE9N3lLVfJUZKN5xp7jCTfdJaJHkMkbiVOhAp1HiDOBTcNkRtdUXr8/KHlS2sFp7Gvk+XuNZDm1J3mdP19y7NBlIUikK1xQuJ01ikl23IsW3bgTia7VOReg/zTSrRL9SLr/XU4md0qfUUICvTIBYhXvQchujhpGC6kLEu7/Kp7tttGfvqVtLOB+lCdFQoJJrdB27e+rgkkcDeywSYqiSIlsah3skWlADu4KD7el6JauHRw90/MTCLrGR45yjVQHpI5bCYEA64o+7I6Cr5nP6a+us6MuvvSXco651o/l2hv/S00MbZ7Jay24iWurxqvoHx8rkafgsltvwQOrjVYcWF5WNGegRMvV6H6XAhXDaRijB+QjJ8gCXkTRXLBeNr1asOLgu7RoLsIUL+EyYMzRuMeznJVLRECLQWVChhSgfYUeVo29m5ahvdm/cunlbKfTsDCG/7RrCaj OLfGTIaI VOPtLPFtyilGlNPVwYsmNrNA+tNyjSXHe5030XuWse+/YhQW5fejoLc25duldj0c2itslK0EZWsSRrEfaL1Za0JFA7MEUN3fO/hjEjVeldsM1wSx3Ks7uCV5KxEhwyfF6rmA5tvGYdhqY5y8JA8mJPk3o1CA5/dRTfMxVoQp+AZcZIUz2FsPkRQpEGaenLR1QRbTgc42pkZyRd307THK8vBycrw5dKSkHhOjFFszjSAr0sqD5inKzbSgFmnnQUKCDt6h8xDrmJ+QmiO71wYLSg2Uxlli7bFZNNujJDb83gxDQPzo1BQGrxmWnHDPlpQtqUhUK2tBBYdSPLHbF68JpBTxqJV724/4x5aJIr7Izh1jYx7oxMSLtOxLspdjJyJU3asTQdvyEfJzC7fWDr1V2RgORg/M7J8BCuYdB4afokqTHofbp8FrZ+Bsxo3hZy88dAiVBKr0TjLI5TE4pHUhEQLj3ew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 30, 2024 at 10:42=E2=80=AFAM kernel test robot = wrote: > > Hi Andrii, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on tip/perf/core] > [also build test ERROR on next-20240830] > [cannot apply to perf-tools-next/perf-tools-next perf-tools/perf-tools li= nus/master acme/perf/core v6.11-rc5] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Andrii-Nakryiko/up= robes-revamp-uprobe-refcounting-and-lifetime-management/20240830-024135 > base: tip/perf/core > patch link: https://lore.kernel.org/r/20240829183741.3331213-9-andrii%= 40kernel.org > patch subject: [PATCH v4 8/8] uprobes: switch to RCU Tasks Trace flavor f= or better performance > config: i386-buildonly-randconfig-004-20240830 (https://download.01.org/0= day-ci/archive/20240831/202408310130.t9EBKteQ-lkp@intel.com/config) > compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a= 15a9eac96088ae5e9134248d8236e34b91b1) > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/archi= ve/20240831/202408310130.t9EBKteQ-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202408310130.t9EBKteQ-lkp= @intel.com/ > > All errors (new ones prefixed by >>): > > >> kernel/events/uprobes.c:1157:2: error: call to undeclared function 'sy= nchronize_rcu_tasks_trace'; ISO C99 and later do not support implicit funct= ion declarations [-Wimplicit-function-declaration] > 1157 | synchronize_rcu_tasks_trace(); > | ^ > kernel/events/uprobes.c:1157:2: note: did you mean 'synchronize_rcu_ta= sks_rude'? > include/linux/rcupdate.h:206:6: note: 'synchronize_rcu_tasks_rude' dec= lared here > 206 | void synchronize_rcu_tasks_rude(void); > | ^ > 1 error generated. Missing #include , will add. > > > vim +/synchronize_rcu_tasks_trace +1157 kernel/events/uprobes.c > > 1145 > 1146 void uprobe_unregister_sync(void) > 1147 { > 1148 /* > 1149 * Now that handler_chain() and handle_uretprobe_chain() = iterate over > 1150 * uprobe->consumers list under RCU protection without ho= lding > 1151 * uprobe->register_rwsem, we need to wait for RCU grace = period to > 1152 * make sure that we can't call into just unregistered > 1153 * uprobe_consumer's callbacks anymore. If we don't do th= at, fast and > 1154 * unlucky enough caller can free consumer's memory and c= ause > 1155 * handler_chain() or handle_uretprobe_chain() to do an u= se-after-free. > 1156 */ > > 1157 synchronize_rcu_tasks_trace(); > 1158 } > 1159 EXPORT_SYMBOL_GPL(uprobe_unregister_sync); > 1160 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki