From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B8ACD18144 for ; Mon, 14 Oct 2024 20:27:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 785466B0082; Mon, 14 Oct 2024 16:27:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 735126B0083; Mon, 14 Oct 2024 16:27:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 623986B0085; Mon, 14 Oct 2024 16:27:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4970D6B0082 for ; Mon, 14 Oct 2024 16:27:27 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BD6F2A1286 for ; Mon, 14 Oct 2024 20:27:11 +0000 (UTC) X-FDA: 82673342724.12.E6459D4 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf09.hostedemail.com (Postfix) with ESMTP id D8B6414001A for ; Mon, 14 Oct 2024 20:27:19 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hbco96lX; spf=pass (imf09.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728937502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T7hR8tJ06xrBOZxmj2ZoouJ4PMBncoMUs3f9JxO7pTk=; b=ev1E6YjtBThWhyamTnw6X+CcqkTH7+7/fgku8xLs/YOLNLSVYlhfXRQ0a73J0/sVyhByfI JYf3SH6adwxOyYd0uGZtosQAuaHTfT7iQcJKc4LFM1eJ1+JC74+q9KrWZ7uX+c8jRS8Zar YnHsH02f1gx5ZT3ZbJRqP0m277di88o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728937502; a=rsa-sha256; cv=none; b=2OX+pSxYRnZ+i59icY5hM/KNMxWoSHfw3MyHnVXwoOLV146vWQhek/MHq9VptrMVq5y+7D NJtFbuP59PPmYkhx479W1lbvvuLYQqrHXTZdyGQCpfVLHvyOnefdvZzMTOJ8xpIx6vlXbO s8+aU/tz4oCfKZjQyXEasZPIWGGt9G4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hbco96lX; spf=pass (imf09.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-71e585ef0b3so1325723b3a.1 for ; Mon, 14 Oct 2024 13:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728937643; x=1729542443; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=T7hR8tJ06xrBOZxmj2ZoouJ4PMBncoMUs3f9JxO7pTk=; b=hbco96lXX0p5NaTi0qHAbLGynBA0LdRvzWJwsnbHvMOdYOOE64CxX8ejqi83aOHnLz IvLD4jGc6+GpnRjOMWORmKMGJ43ph256JYD2j/jeZZ5DvL5vmBHpDd+2OJxUZZu/9Vlr Y1O85KHqIssmvouQ/ivn9c7QFzKgHxknrljTiePLQJMfJpffHE9jo7ypqMJDmYgC2qwn I5uDLUbhY2CT7t0Q5FcJ8eVb6pjBI6d4x+sOlmF2FNPO/IUiE1XaIDDSqO5F4RfSe+wd /4IlB+C4eWYGw/HVn3C2i0IoVE7BrZljGMKM+HGyOHxiiC5TCKCJbq0HXM56xtLYcnBX Dqgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728937643; x=1729542443; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T7hR8tJ06xrBOZxmj2ZoouJ4PMBncoMUs3f9JxO7pTk=; b=D6+2L2fMNQCEB2Wk8xmkrsbJaEf0RJ8aCvzl+n18LG36oYi6q6Sp0tnGRbQ9upCABj lFVv4iOCVCIUgOxJdVxr6k/kgj3ulWAQ54sZ+4AwjrVXkxjkoNs9mB8Z8mmae6/VK/B5 aCYK8aUdX7R61MsWUFmf+2cItbkosH8CH9ULGYk6G3H5qyobMlVyIFDLJyaRnWl5Ntli NgwfJkKKOrxZVwazrbO/VeKnxf2YMXGdUKvhQgstu04FS5ELi+TUykeUmxXQBDE2jyX2 DUK013RAfxG4a2cxC1+m8Wz6tAwNC8KlAQdK40d/7Z27M87fokGa4tvhi5Um0j9rC9+g YWyw== X-Forwarded-Encrypted: i=1; AJvYcCWdWSe0o3NSVg+mIc4FVJxAWsewhO8N59SyTGHBxJY7V2WRmcIpKT1Fpn8xEW/QOWkwn4qElF0fqg==@kvack.org X-Gm-Message-State: AOJu0YwJfxS1b1wylZuxVApYXHkPJS7ICZ01qASUg5Up5xxmVauPXLDm URRBMWELoxxD9twyFxENAbPX44nMxdDLlnQ8vkG1kMXfB34IVal7gi/aqBTq7ebpC+QgwAqdiq/ cA5hPogKH0wh3EMG0qZDGsH8O3LI= X-Google-Smtp-Source: AGHT+IFwGAVjPCdEfP0TFh0THmiQ2svUymXIDU62M+8OYi04yZko9TY8AU62qmmEpn/aJdwuEt6QmxmqOdM2SpHuNKk= X-Received: by 2002:a05:6a00:8d3:b0:71e:5a6a:94ca with SMTP id d2e1a72fcca58-71e5a6a9589mr10680912b3a.19.1728937643345; Mon, 14 Oct 2024 13:27:23 -0700 (PDT) MIME-Version: 1.0 References: <20241010205644.3831427-1-andrii@kernel.org> <20241010205644.3831427-2-andrii@kernel.org> In-Reply-To: From: Andrii Nakryiko Date: Mon, 14 Oct 2024 13:27:11 -0700 Message-ID: Subject: Re: [PATCH v3 tip/perf/core 1/4] mm: introduce mmap_lock_speculation_{start|end} To: Shakeel Butt Cc: Andrii Nakryiko , linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, peterz@infradead.org, oleg@redhat.com, rostedt@goodmis.org, mhiramat@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, paulmck@kernel.org, willy@infradead.org, surenb@google.com, akpm@linux-foundation.org, mjguzik@gmail.com, brauner@kernel.org, jannh@google.com, mhocko@kernel.org, vbabka@suse.cz, hannes@cmpxchg.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D8B6414001A X-Stat-Signature: 3ib9bjs1r8xnrodqadyf9ur1qi1xangj X-HE-Tag: 1728937639-225220 X-HE-Meta: U2FsdGVkX1/aDYyxJK24PRFENfMrT60erQ+4CCmACbB5CpjgM/wl9g0j4dnZuAGft7sThVCuJDvXwvmaHZT/7gI+GzgXnnlrXw7ACaVwX14d44rHKWEfgrxlLdN3+bBvDeJdOYRSCN1t0pCCUk3iBGdbhAs1gkpmxST6eQ6PPvRuAZLQfpVA3Y+P/DzsUxxbVbhriSLuWECbwBXLwXli/MydG8mj15JUqn+BwPou6NOj4JfOq6nrQAwZkk+A2GGS7pKpLnmuEqwzfQbIOBxbS2Cwn6t3KHoRWyB5uxaqICgCiENtudE0aQGe0pZGdyookb4Ba9j7xGb9/ql7xavmzTBURLsnrNXu/nQWFsTFAWYCObOhNyH0ihqemhMHi91UAYwAgwPi2KTNVhc2DvsrTAly7sraP5+cbnfluwID/LlTqt723rc20VjQ8USdmccKbVKux10kHARfN/DcFjIchhRZ1oyatRZVQSi4Qi9BcD8H9NuTQWC01AVudwd20fHN/V2HAatOvphH/vSBcpkisbrnFco6kaVu6aR3boZpn8yqXlNfMdkc3CuDh3k9hKZ7VGvXPrAshvU9J4zjyPTSWb30ITDDoYa8bHz586NNQn1GC1XQhVb6IfVuuSzLdR9fF9FCofWHA2QOlWiBpOEt0cIlTm5sQzo4wbvvwg4ARadJcSfUufSWeMew8es4hw7b0sTsH+bTJLkZ9rRURRgpoveZaDTnpCdiaFU3MmolzapVNui1ziohNXucGKgO2KYqirRRubkFa2vz0ZUbSEMaNC+VH84lmwgBcJExpMuby/YkoL1QkNJvYgMhNXwLx6wKHyeBd3QrNnYGqTlq5RFu6EdflOMu3uxdwt36Uj39E9Fk7n5Vga3QMXZKUZrt5rZVSwGLqT+6Zuwj+/hJbhieMRjgq/9FlmCD0U/uLotABWs9Aw8kudreGvrP1XfpCZYdVwEwLM323RyvTiGCBSl XKIwR9ry OfEafz+s00zpBjcICifmx0GnTqcLY5GNQyyHXDzyWzqa7GGSFMXoJzMK5NKTE+oz43Rg5nws/F8/dPlIOBm0sdCp6hQWEBon8jm6zQt0HsmfWRyxw5ZuSnAseKUkLUOTvpTYGFLI/V0Qp4mgQJTynq8I+z/7TQH2w5VJx3AAqJygc6cEe5JlKc9FxdEDNWQ2pwb51m70mQ9ry/pCj7J/FMGMw4vnDzOi24yML+U3sIkIehT+i03TueTJwFQFJ9n6lM+FiPr9WcO10WxTM0rZteye7M9WQw+eGVxqajc7hcaK0QC4lUFgybWH1lEXs2+dSW6drm3/zkd2M2iLmKFrx0FvjwDO4bU/NOomm3fr7lmuBvQoXQSIfFsUcNYxY4bRzWGU/5nSd9biITlzwBwIQ3SJJsL6q5ZcZCSqC4ET8GRH/qEljr4hv9JwWEa6vc65vrQJNk1QYZEl31ZOI4n7UfmavB3/372ewTST4VZ3OV4o5Go1BYEYLIqEqmYtG0aERTj/9F+/iiZgy88g5b6I7jRPdJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Oct 13, 2024 at 12:56=E2=80=AFAM Shakeel Butt wrote: > > On Thu, Oct 10, 2024 at 01:56:41PM GMT, Andrii Nakryiko wrote: > > From: Suren Baghdasaryan > > > > Add helper functions to speculatively perform operations without > > read-locking mmap_lock, expecting that mmap_lock will not be > > write-locked and mm is not modified from under us. > > > > Suggested-by: Peter Zijlstra > > Signed-off-by: Suren Baghdasaryan > > Signed-off-by: Andrii Nakryiko > > Link: https://lore.kernel.org/bpf/20240912210222.186542-1-surenb@google= .com > > Looks good to me. mmap_lock_speculation_* functions could use kerneldoc > but that can be added later. Yep, though probably best if Suren can do that in the follow up, as he knows all the right words to use :) > > Reviewed-by: Shakeel Butt > Thanks! >