From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9217C433F5 for ; Mon, 1 Nov 2021 23:47:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5513C60F42 for ; Mon, 1 Nov 2021 23:47:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5513C60F42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E37AF940034; Mon, 1 Nov 2021 19:47:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBF8C94002B; Mon, 1 Nov 2021 19:47:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C601A940034; Mon, 1 Nov 2021 19:47:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id B4B0894002B for ; Mon, 1 Nov 2021 19:47:54 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 815F35C085 for ; Mon, 1 Nov 2021 23:47:54 +0000 (UTC) X-FDA: 78762001668.08.2564E4F Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf24.hostedemail.com (Postfix) with ESMTP id 3136AB0000A7 for ; Mon, 1 Nov 2021 23:47:54 +0000 (UTC) Received: by mail-yb1-f177.google.com with SMTP id v7so48775744ybq.0 for ; Mon, 01 Nov 2021 16:47:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FBiWAJTIxuy3ItLyF6ugs0XoTouSN2poKfACp6muzeU=; b=HCef1svqJC9lBUd5duB92ijfUT5eRbFNY6HLDjzlGkQUpwd60ln2Wij+gYdq8HNT9T sb7V/QqQxkFbgg982LjzFs8ml9FFZk/VwylwQitcHEk08wHHwWErIPES2L+IDqUT3gBs 9LplQea12M5qpyTMK0urKPM5EltKdsjjKMojrOiTpguMMSwlVUUdB5ciBBci5taDIEoi gWw1gjoaTVb+SEzW3GXoQJOCZg6hgC+dJOcj9hMlcXLT01W/1I3LjcXSj948Zw0diw4N dAB65Fn6kTT9lrlp64cjArjG4I3qD4Mr5tlryjf3IYHj8ngu42fTN0rGTfyeOBDJKIi7 blOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FBiWAJTIxuy3ItLyF6ugs0XoTouSN2poKfACp6muzeU=; b=DzZ+Z/YHmWtFmNO1Oky2IKkAkUYK/03UIvXpzUMwZUc8tuxq+h7nnFYEzGKZ8ld2OX hAoWwsAL7LnbiZ0GiL65B5bpqqrAMqqnnyg3zd21HIzxeEi5O8OfP7rEBqHu5Wj8+Gra O95WFaL1cxuBEz4LdiLlv5/KVo7oBoRkwdIHpaL/JmSypFCMxm/kYsKQZYNVUbbzgEwq VvkNRnW1iMkjpoUjhPox0oToZD6EawwAGhojPiJWgdgWWvTOQVY2Y9FoP5LAoF6vF02d HcC9vZ+BIbkVG+7HKBFH1/+iNzOTjiiEsmvtKVHUJGFB1/oWbqEUEHkk8QNJfdxFnucj Zi1Q== X-Gm-Message-State: AOAM533mYYxLC8sXrLeDAc+zfwbLSqBloIK0Ct5OhKp6fZPnprjpc4lx UTWBKZSaNtGsT4Ol09lJ/1t88LDQCp4rVgFP3SM= X-Google-Smtp-Source: ABdhPJxlpHGgK7He7Tl6X9dpvDabko/7ti4gevdzxJpVQ8OpaApql1I6fxpzu3nMALBQpSWeYKjJVGmJI9w8ZqNn9aA= X-Received: by 2002:a25:cc4c:: with SMTP id l73mr33871640ybf.114.1635810473549; Mon, 01 Nov 2021 16:47:53 -0700 (PDT) MIME-Version: 1.0 References: <20211101060419.4682-1-laoar.shao@gmail.com> <20211101060419.4682-8-laoar.shao@gmail.com> In-Reply-To: <20211101060419.4682-8-laoar.shao@gmail.com> From: Andrii Nakryiko Date: Mon, 1 Nov 2021 16:47:42 -0700 Message-ID: Subject: Re: [PATCH v7 07/11] tools/bpf/bpftool/skeleton: make it adopt to task comm size change To: Yafang Shao Cc: Andrew Morton , Kees Cook , Steven Rostedt , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Petr Mladek , Peter Ziljstra , Al Viro , Valentin Schneider , Qiang Zhang , robdclark , Christian Brauner , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Vincent Guittot , "David S. Miller" , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin Lau , Song Liu , Yonghong Song , john fastabend , KP Singh , dennis.dalessandro@cornelisnetworks.com, mike.marciniszyn@cornelisnetworks.com, Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, Networking , bpf , "linux-perf-use." , linux-fsdevel@vger.kernel.org, Linux Memory Management List , open list , kernel test robot , kbuild test robot , Alexei Starovoitov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3136AB0000A7 X-Stat-Signature: 65iemtjon15bsgeawkey4mxdufukuxmz Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HCef1svq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com X-HE-Tag: 1635810474-982683 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 31, 2021 at 11:04 PM Yafang Shao wrote: > > bpf_probe_read_kernel_str() will add a nul terminator to the dst, then > we don't care about if the dst size is big enough. > > Signed-off-by: Yafang Shao > Cc: Mathieu Desnoyers > Cc: Arnaldo Carvalho de Melo > Cc: Alexei Starovoitov > Cc: Andrii Nakryiko > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Al Viro > Cc: Kees Cook > Cc: Petr Mladek > --- LGTM. Acked-by: Andrii Nakryiko > tools/bpf/bpftool/skeleton/pid_iter.bpf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/bpf/bpftool/skeleton/pid_iter.bpf.c b/tools/bpf/bpftool/skeleton/pid_iter.bpf.c > index d9b420972934..f70702fcb224 100644 > --- a/tools/bpf/bpftool/skeleton/pid_iter.bpf.c > +++ b/tools/bpf/bpftool/skeleton/pid_iter.bpf.c > @@ -71,8 +71,8 @@ int iter(struct bpf_iter__task_file *ctx) > > e.pid = task->tgid; > e.id = get_obj_id(file->private_data, obj_type); > - bpf_probe_read_kernel(&e.comm, sizeof(e.comm), > - task->group_leader->comm); > + bpf_probe_read_kernel_str(&e.comm, sizeof(e.comm), > + task->group_leader->comm); > bpf_seq_write(ctx->meta->seq, &e, sizeof(e)); > > return 0; > -- > 2.17.1 >