From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2759C433C1 for ; Wed, 31 Mar 2021 07:30:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8DBD0619B9 for ; Wed, 31 Mar 2021 07:30:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DBD0619B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0E0976B007E; Wed, 31 Mar 2021 03:30:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08FF06B0081; Wed, 31 Mar 2021 03:30:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E72E76B0085; Wed, 31 Mar 2021 03:30:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id CBE186B007E for ; Wed, 31 Mar 2021 03:30:37 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 806A2364B for ; Wed, 31 Mar 2021 07:30:37 +0000 (UTC) X-FDA: 77979346914.09.5553759 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf22.hostedemail.com (Postfix) with ESMTP id 115D5C0007D3 for ; Wed, 31 Mar 2021 07:30:36 +0000 (UTC) Received: by mail-pg1-f175.google.com with SMTP id y32so12427834pga.11 for ; Wed, 31 Mar 2021 00:30:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=suhM1QfpnyObFdI0zpuVstsmyjlbl9DzdyUeQfv0xhk=; b=Vyeg9010q8jK0TZSKz/pqaEzuB+X76J2mf/fjLBJtPn1K2bUN4r0QwbpUE6zj6nEpL z/7k4TT41vQLC79PNMKqFeEbc/QIp/EdPNNrViy0bl2j26KyaUM2611CD2SGbmuoGAPc PJcwYDyC1utR8x0rJ9AhF+H9uad9NYxDrmvSfl0OOMtAdVCB5XflNh2F9mYzmR4PaJpw Mr1DbeFRTDmi1U2uawviymenx6BxgJ8ZBsW0HyxGKWOBweEeNTjzB9tXIm97H530THay 9QEstDsbup9ifmGWFyDfyYnaiwpVUZWdhP5Mb2cXgiG7Vw5NPYmSv1/xDgpnFdorMBYO umQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=suhM1QfpnyObFdI0zpuVstsmyjlbl9DzdyUeQfv0xhk=; b=jShAawlTTNXx/8SFGyTyIu2AI5t4Cs6xUnJFOXM4b9MdEaGiAv2X+crUaziSIDjpq8 q7q6WSdKTVDxe1A3pLWVydk80oSzIGWJEG/zhxrZAwj8anT9RmbOQRHj+mKrf5h0Vbl4 /Iov2UNObgpwtZ4QgI/3+NJmQxcf8ZmbfdRg4ivHq/LzXBQWdwMHcYm2bwMyWLvboSFD As2xZekVspEj8beOudP7PLSrvYq6L3KJChL9xuKrmSBv189EtkSNKSAoCK4f+N1lC385 EfCgJh1VQKlRX5EuPzCasyWKHVVrEkEQPLXztiFR9jWZgABVjTlb6IUuhO62vvtKEv6b YLtw== X-Gm-Message-State: AOAM533KTPKx6YQpZY5yWLn09qk8qaNxRNukOai2DrcoLX54Gn11vXZk YrFvcM3ahklwsSJ7M1aVSR2J6kZpx5Zd/guDegw= X-Google-Smtp-Source: ABdhPJyynYH0zLuS3m1ItZ25UwUMuB7N/DuJWlrrwMJx3XX2CYouYLia5lpwteqMti9GcxmHraFHSmVtLO7EXFO8GmU= X-Received: by 2002:a63:1a0d:: with SMTP id a13mr1962305pga.167.1617175836176; Wed, 31 Mar 2021 00:30:36 -0700 (PDT) MIME-Version: 1.0 References: <20210330175126.26500-1-rppt@kernel.org> <20210330181347.GQ351017@casper.infradead.org> In-Reply-To: <20210330181347.GQ351017@casper.infradead.org> From: Greentime Hu Date: Wed, 31 Mar 2021 15:30:00 +0800 Message-ID: Subject: Re: [PATCH] nds32: flush_dcache_page: use page_mapping_file to avoid races with swapoff To: Matthew Wilcox Cc: Mike Rapoport , Andrew Morton , Huang Ying , Mike Rapoport , Nick Hu , Vincent Chen , Linux Kernel Mailing List , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 115D5C0007D3 X-Stat-Signature: qgnjay1ymzmcyxepiy6h5uzscwkhf8fp Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=mail-pg1-f175.google.com; client-ip=209.85.215.175 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617175836-794645 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox =E6=96=BC 2021=E5=B9=B43=E6=9C=8831=E6= =97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8A=E5=8D=882:14=E5=AF=AB=E9=81=93=EF=BC=9A > > On Tue, Mar 30, 2021 at 08:51:26PM +0300, Mike Rapoport wrote: > > From: Mike Rapoport > > > > Commit cb9f753a3731 ("mm: fix races between swapoff and flush dcache") > > updated flush_dcache_page implementations on several architectures to u= se > > page_mapping_file() in order to avoid races between page_mapping() and > > swapoff(). > > > > This update missed arch/nds32 and there is a possibility of a race ther= e. > > > > Replace page_mapping() with page_mapping_file() in nds32 implementation= of > > flush_dcache_page(). > > > > Fixes: cb9f753a3731 ("mm: fix races between swapoff and flush dcache") > > Signed-off-by: Mike Rapoport > > Reviewed-by: Matthew Wilcox (Oracle) Acked-by: Greentiime Hu