From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B1B0C4BA06 for ; Thu, 27 Feb 2020 03:16:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AC69921D7E for ; Thu, 27 Feb 2020 03:16:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GncBPt1s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC69921D7E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 198576B0003; Wed, 26 Feb 2020 22:16:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 149BE6B0005; Wed, 26 Feb 2020 22:16:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05EBF6B0006; Wed, 26 Feb 2020 22:16:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id DE6846B0003 for ; Wed, 26 Feb 2020 22:16:55 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A73203D01 for ; Thu, 27 Feb 2020 03:16:55 +0000 (UTC) X-FDA: 76534445190.12.truck63_3c70992543f5a X-HE-Tag: truck63_3c70992543f5a X-Filterd-Recvd-Size: 5697 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Feb 2020 03:16:55 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id d9so1223205qte.12 for ; Wed, 26 Feb 2020 19:16:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=GNFaQ4pluFw8jN6ZAQ7EikUVsXH3cDB1i3nM4ExeGWE=; b=GncBPt1sqnvquN782tXx1HuE1qPtvRP/RmcJ6YRLvimUhtBYr/CP3w6q/+AwnlKaAy QTMhk9z/DxmVkMZViS26wLeYzl+tdWlSZBTy3BaGtI0SoPxgJddw9tja1WnHr3/PoQLO MMYalt8Rh1aE/VPUCeEXr2Bg/HwqvJGAKWGeCIbj+UlVCNnUnJJamVpXGadKZq0RoNx5 7QfS+yrGesZ3V35yqZ5T7JIwhjOMt0huTSkp0tJ4t7lSJ0hW1SzVPBpnFFQwc2VjxC39 Jg6u7z5p+iI5TAXdel/4NkR1m5gcZqQz8eqwbrGVAcjCbgtG53rp0Ofb3w1mfeynOEAx yNxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=GNFaQ4pluFw8jN6ZAQ7EikUVsXH3cDB1i3nM4ExeGWE=; b=ZBynsmfMyKtmEuyIVUO1OXnRFcKXsUB6QfwHBQHA2WrPVEDbpFU6RPzrOSZfppY9ti EcKeTUXB6gJSrLDbWwBjbADs/+Z3kbXkidwVWWhrV1qa2rm3x/ya1LT/ZYtDtNXgTKbG jY8omiX8ai/lIb+2L8NkDDwWCVQq1VMGf/k1ZX/lVctveVG28OAmlLalIaFrxyAPjW7C j/v4sAfr8wUKRLNz5ygaNtw1kgL8bt/ir5sEZCOtJ07DTorf5QuKdnS9UgUgzK1lBKCJ 31V3Tt3qlQrLoqdxocObUsAmKHAT6BiXJBDAQG8fs20+OjuQiOtbYfgd/nWP6bzxO8Mv /zMQ== X-Gm-Message-State: APjAAAUmWqBmUBJC81KmjNZWfTJAa9SSNxPV2Nr7EJsIM0Vvrhs4oiDk XX+9BYwsWQDqaGTLVYTCII3NicsTIn1xW+gH0R4= X-Google-Smtp-Source: APXvYqy9AbiVj+xiDVyuXp3EyJxb0qdwG4zNqI/kktMbKXu8SmKR9mzD6GfThAgr10X5bDDEvN4B5uTcUJEX0yCPHEE= X-Received: by 2002:ac8:7309:: with SMTP id x9mr2517717qto.338.1582773414517; Wed, 26 Feb 2020 19:16:54 -0800 (PST) MIME-Version: 1.0 References: <20200220141916.55455-3-glider@google.com> <202002260412.ybvj1aPM%lkp@intel.com> In-Reply-To: From: Greentime Hu Date: Thu, 27 Feb 2020 11:16:17 +0800 Message-ID: Subject: Re: [PATCH 3/3] kasan: stackdepot: move filter_irq_stacks() to stackdepot.c To: Alexander Potapenko Cc: Nick Hu , Vincent Chen , Andrey Ryabinin , Andrew Morton , Arnd Bergmann , Linux Memory Management List , kbuild-all@lists.01.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Alexander Potapenko =E6=96=BC 2020=E5=B9=B42=E6=9C=8826= =E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=885:53=E5=AF=AB=E9=81=93=EF=BC= =9A > > Hi Andes maintainers, > > On Tue, Feb 25, 2020 at 9:26 PM kbuild test robot wrote: > > > > Hi, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on linus/master] > > [also build test ERROR on v5.6-rc3 next-20200225] > > [if your patch is applied to the wrong git tree, please drop us a note = to help > > improve the system. BTW, we also suggest to use '--base' option to spec= ify the > > base tree in git format-patch, please see https://stackoverflow.com/a/3= 7406982] > > > > url: https://github.com/0day-ci/linux/commits/glider-google-com/stac= kdepot-check-depot_index-before-accessing-the-stack-slab/20200222-065605 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.= git 0c0ddd6ae47c9238c18f475bcca675ca74c9dc31 > > config: nds32-randconfig-a001-20200225 (attached as .config) > > compiler: nds32le-linux-gcc (GCC) 9.2.0 > > reproduce: > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/s= bin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # save the attached .config to linux build tree > > GCC_VERSION=3D9.2.0 make.cross ARCH=3Dnds32 > > > > If you fix the issue, kindly add following tag > > Reported-by: kbuild test robot > > > > All errors (new ones prefixed by >>): > > > > nds32le-linux-ld: lib/stackdepot.o: in function `filter_irq_stacks': > > >> stackdepot.c:(.text+0xc6): undefined reference to `__softirqentry_te= xt_start' > > >> nds32le-linux-ld: stackdepot.c:(.text+0xca): undefined reference to = `__softirqentry_text_start' > > >> nds32le-linux-ld: stackdepot.c:(.text+0xce): undefined reference to = `__softirqentry_text_end' > > nds32le-linux-ld: stackdepot.c:(.text+0xd2): undefined reference to = `__softirqentry_text_end' > > Can you please help me with this? > I couldn't find out where this section needs to be declared, and I > don't really know whether nds32 is supposed to have softirqs or not. > Maybe filter_irq_stacks() should be no-op on nds32? Hi Alexander, I've disccussed this with Nick. There might be 2 solutions, but we are not sure which one is better or maybe there are another better solutions. Since nds32 doesn't support KASAN, we might not need to use this section. Solution 1. We may just add the dependency in STACKDEPOT depend on KASAN Solution 2. Just add SOFTIRQENTRY_TEXT this section to nds32's linker script What do you think? :)