From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B14E5C6FA8F for ; Wed, 30 Aug 2023 13:09:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47E6144015B; Wed, 30 Aug 2023 09:09:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42EA0440159; Wed, 30 Aug 2023 09:09:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31CE644015B; Wed, 30 Aug 2023 09:09:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1EBD6440159 for ; Wed, 30 Aug 2023 09:09:43 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id ACF35120133 for ; Wed, 30 Aug 2023 13:09:42 +0000 (UTC) X-FDA: 81180803004.27.682CD6E Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf28.hostedemail.com (Postfix) with ESMTP id BED40C002B for ; Wed, 30 Aug 2023 13:09:40 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=W7KaVrL8; dmarc=none; spf=pass (imf28.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.208.175 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693400980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8UTTWFj2vKP575z4DigdGNUxxYXECz/tkiCbjV/NlsQ=; b=ED4AowFdPS3u0+KDCeXj+9S+qEj0qhottAAmx/baHSbEP3B0Rrqmagl+N70AopMsTLgSV5 dcC7Lr6OcjVk+lA+mu4rzZRj9r/7KVqx9IiUV+kUufQCji0wWZgMOKqa5i2O9M3brxztMq 0KH+yLkeqUvpgC9N6QU/3g4I9jMRYl8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=W7KaVrL8; dmarc=none; spf=pass (imf28.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.208.175 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693400980; a=rsa-sha256; cv=none; b=ZJcIdmCtPD+ncwOLUE0HofUdI/AAgyVS//Guri0z+uCVernKQEW6Pvr36ldpTP2bDNK8y5 V4F9h5kGiHaqvfrocNZiMJQkKJIJM/NJLnyt5CeaJQ9ijNY+Hvi40DJ9ftrGuZb1YVLMWE N723WOeH7AmkKmPCYizD52I5YLV4BD8= Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2ba1e9b1fa9so85201411fa.3 for ; Wed, 30 Aug 2023 06:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1693400979; x=1694005779; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8UTTWFj2vKP575z4DigdGNUxxYXECz/tkiCbjV/NlsQ=; b=W7KaVrL8/LnmD6MyGRIKyYmpy2vISOrQ+1jLeypYvGEf4KQjF/gi2Q0rBpqTHqSbm+ 9V09jLjajVtgvjvU4WlVG7OL4PwNi+iR0v+yHVP6T/tn0wMQjFuH1gVnhwczJJBsevbr tgXVPUIxIFE3Z84OXozVHm3X3aPnTbNKpBJsI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693400979; x=1694005779; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8UTTWFj2vKP575z4DigdGNUxxYXECz/tkiCbjV/NlsQ=; b=iUtvoAuoclxFp7Arp2LKfcQc73NaIg+0ZLeMukWOw9SK12vTEe2cvAxGYSNIsQg3PA DpZyQNTIOAopTLZIQp4ZZ57i87K64LpgyCKYoAxYra8rgyYHM4+Z2Ux3U9pdLp0gu4EP YnJyvbojCC1SFg5jeW+FyRqu1GtF1gxV2rrBcnbtkPjseGCrGICO1cr08QQwyu/vxbix 3gSH1ekjo339E8ijv/r4g3T+g5ZVvX878LfsPE83m1YHUxwq/xxl7cZR2OYMe7QvGMmY GRv2PD8Y476yWkP4rZrIBL9UNgnkzgbJ5lMh51jgqpJjpSe9IGEm3r5L8UAJd+2OGixY jepw== X-Gm-Message-State: AOJu0YwYSgdeH6IbWob7bVlEruT4Cm0AR+w6wPpBrVMu7ly6CEnxPTQI 2F+tRtBkuimfuntrnfUvI6vn6QKL6MZvaAnHzTcD0A== X-Google-Smtp-Source: AGHT+IFug5Pn0iCtcHTxdYxtn/dxRL6m7q37tl1uS0fITM+sBu4ZDYI6ADuJFmJtHXSl++R49UIn01Vju8rKW4euhUs= X-Received: by 2002:a2e:7308:0:b0:2b9:ee3e:2412 with SMTP id o8-20020a2e7308000000b002b9ee3e2412mr1914441ljc.22.1693400978045; Wed, 30 Aug 2023 06:09:38 -0700 (PDT) MIME-Version: 1.0 References: <20230830110402.386898-1-joel@joelfernandes.org> In-Reply-To: From: Joel Fernandes Date: Wed, 30 Aug 2023 09:09:27 -0400 Message-ID: Subject: Re: [PATCH 1/2] mm/vmalloc: Add a safer version of find_vm_area() for debug To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, Andrew Morton , Uladzislau Rezki , Lorenzo Stoakes , Zhen Lei , "Paul E . McKenney" , rcu@vger.kernel.org, Zqiang , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: kh5djm1sg64oizgynpiuqecpy6nqdbb9 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BED40C002B X-HE-Tag: 1693400980-61702 X-HE-Meta: U2FsdGVkX1/QWM06lZPHUKtQ2YyriI+qUEt1S4RG9cIq8Q04QVjkzz3b1SaX+SksxJeoouH4qAZPWewaJ4+XWkR9sqx7Ntda03moaWFkTnlwhHbp52drhMAh9WoMIgeRZlEZuL6zwJSTjoFWgZOqSqP9gy3afJd6KkO7xhxGzc/1D/a3hzH/cArVcGpZ5eiWVPVj0xm3N4IZrIVO4ePX2vUZcdtxR866ED9LwCPPrY1dHSN7DHApidJIQjzqGwAbPIcI5HxeW7ZaZ7IWPN9VmbDB3AijgeVioqrei6r6R8G63yEgB4cQ8cSqH6H/Xldr8Q5GSKJD1klGcyAJ/tzIdROfR1FRkzVDMG+ImqrUJ+RO0wqbTLGeyEQwxfr202mBYhh26i5upjyK15Rq0942KlmKxkJlP5budv92U2nx2O3tt2zyaCShFIpZt5XD5IDIXUs7ZJkwvLvl3ux1fCslQ7J+AuYUvE2FEejbqDknaLwlb6A0yEHCyGXmeL/ymfDe95I0Fd3fZSFT6q2fk43SHX8/6/B9XGsrLYQzHbH7wrEJV/FPCUpCj6ibzYFRn4y6SodY6QwcxgdG3/SH6VNI2SFTD1nVHRCbMlTY/y538tgWO1VEHPW/zRF+Sw0G0e1Js/+Pdb5tN+JUVQoJI/ClLMzvKL4TkgTtso1rWzrakrsYUVRWJN4jKpG250vvul3iYV0ptHa+h2j3tIm/MK7ciWLfor+owwiQu7RbBW5yBM9jhmg+3PDW98VE9Selbrzx2I4ldXBEqC+yurWCBfMjc1l3GnCWKgkyYy6NRo2aVErED1cyCDZqU/s6FGdVcAtn+6hHxRS45Bd/pUgluks8tuyq//d5mKdYl6haPRCgJD/0uAKkYuYKqq1VWbv3KlxZaoE71ITwq/X5Zn9go5yIqcwOMELuKde3XcQWUiDNMhm2dE4mp1SFNUIZQ8u9V3oot7jwvdL5xGDC5KaVfSa TtUNM3RW V3/Pv2H2fHf+nDvKyxxHmuCvqFnnWudm6acfKdDyGQjYUAZ1DvlZwBPnwm3ZDxdJed6Y9B3hgl0U0uXsOquLNWmRkkk1SchDstYHl91WQC3F12u5OF4qwDBmYw1Rf/U1cWnYG0LYPaYQPFgjxTt6cPKmSlwPueGJm0YmisLwyo89n6UCYiQP4MhjVGMx/K2Se7pkTtW5NWpRUzltnQebZWsQTcw2+Qe2lFb/c75lrzzIRQQFIJRPx9yDbKFvOfr7ewBpk/qQmTwaiMlIVMEy+ofrzyLFgczkTv6v8PiSKhdj1sDlHMpXhEJz+Yykb4ql6W/N912PfolMYL9qs1NeKEuQ+uhkP0/MbOmwgmIMJfU2glUmvJWcRW4ZWIY4YLLxXEaf7zaMlWD6BohHqqpWj3c4r1Fdynq5pQ+y/JsnhMG8QH6L1pKSnHO+qLmjb8QAUhlLFVOQCU0BgGDItUEcqr0QPDtUGIUOHonQ4LmLgZSPYzjJPG30LyvV/cN7dORlqzCmGIVYJRY4BXz4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Christoph, On Wed, Aug 30, 2023 at 8:48=E2=80=AFAM Christoph Hellwig wrote: > > On Wed, Aug 30, 2023 at 11:03:59AM +0000, Joel Fernandes (Google) wrote: > > It is unsafe to dump vmalloc area information when trying to do so from > > some contexts. Add a safer trylock version of the same function to do a > > best-effort VMA finding and use it from vmalloc_dump_obj(). > > Seems like 2/2 to actually use this is missing? 1/2 itself uses it. And then 2/2 is here which does additional improvement courtesy of Zqiang: https://lore.kernel.org/all/20230830110402.386898-2-joel@joelfernandes.org/ I used git send-email with cc-cmd set to get_maintainer.pl script. thanks, - Joel