From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69763CF34CA for ; Thu, 3 Oct 2024 22:10:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8AC86B014E; Thu, 3 Oct 2024 18:10:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3A956B0165; Thu, 3 Oct 2024 18:10:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 903BB6B014F; Thu, 3 Oct 2024 18:10:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 73B596B0438 for ; Thu, 3 Oct 2024 18:10:04 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 26758160C0F for ; Thu, 3 Oct 2024 22:10:04 +0000 (UTC) X-FDA: 82633684728.08.9C1434E Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf01.hostedemail.com (Postfix) with ESMTP id 49F7740009 for ; Thu, 3 Oct 2024 22:10:01 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=W1JlnO1v; dmarc=none; spf=pass (imf01.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.219.180 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727993305; a=rsa-sha256; cv=none; b=I2CuoDp9z3Y9QecfBtPM0BgASdyGpxdYhvVpbA9k0CkhpNKttENC5J4emPptQAqIsaW7K0 N3JAmLXTGp/+/np4qsnKypyTqIohSBpSPY4nO8NHJNiWZndsSfBIG9a6wPT9YLXiIAryJJ Zyb4KuNPkyYd9t2Swqdrbyvr+N7lniE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=W1JlnO1v; dmarc=none; spf=pass (imf01.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.219.180 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727993305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RIEY/VvBXBpbOFws0YW9ZSyNHIhNNXGVpnHlXG+8ISU=; b=DF6rTAbCWsNB6R9W3DZjvOHapuwb6EeKDjrtoZsfGddAVKvmE6MfzwGeCJKIdfZ2hahB44 nuEWTkWG3oClfLbxnZiqD2B44LvWuRWwPCV1GzUV84LJuCbvHVnny+U9CJGHHqlboJ23+T 9zroFQ5RqRatbUKbyQY7sExXDsfczAc= Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-e04196b7603so1264832276.0 for ; Thu, 03 Oct 2024 15:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1727993400; x=1728598200; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RIEY/VvBXBpbOFws0YW9ZSyNHIhNNXGVpnHlXG+8ISU=; b=W1JlnO1vKkui/Dib6ULkdyQIzLBRNhLbIKUghNjXXWkVf8VSKBEeKzIH1ZL97xObTa ED86UAf980t+L4c3WViIzzt3oQ8K1mSHnTRt5Ch7rayE6a4mFyjFlg2xvs2bXOc/tA2Z lLO8hLB5LOrPBT8hRd2ypo7kI/BAIXm/itQt8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727993400; x=1728598200; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RIEY/VvBXBpbOFws0YW9ZSyNHIhNNXGVpnHlXG+8ISU=; b=l9Svyz0WDmP9fmAGmaTNLlQFO+6Fn+9hMZxUa2U06PvL4/DekJfcnBvybTJ2bMXrVq A1NCRck+Shn2SeyoLYLp7B8xRzXKaQy1SZI2ZKufEAQJdtr23YhRqx/6pCkVYBoWgpO8 oTpzMgq7QH/2mETTODtcBwXq/YCNwqct9wAhyrPkDSZUlg4Vt2eB1S04M9IZkOhrnT1c 6LZjEJpOk1V7lK5lzaomHnqpSYSvBi9bAAzDK+Qm0liziIkFf0zF5B74ADhNqzqADLg1 l0RJADBo9Uf73g5HXED6TGsM6MszphIj9N/devO6hppW6OY1Wf/X92cqmbAwAZ8UAqdp 3Xkw== X-Forwarded-Encrypted: i=1; AJvYcCUGXE7RqL+rNjHlPN1L2CXt1OQtwuApgeEcLKgTpeWExdtIlndPokmUel7A/9vPd8CQc14mmo+6hw==@kvack.org X-Gm-Message-State: AOJu0Ywd7Kva4IIGbXYZKscBIlU1MOLePP6lZGKLyQe3FqtUwNwtFuf0 83zmuQ72Xtp5nnTYI4G1hygGeCCG/HKrNCZMDzgQ8w7O6O3alt7m1SZoxphDPv/utrr1nq9of8y AGTcHxIjlOSDkjaX2xX1Kpaqm536NA7sGL43ipg== X-Google-Smtp-Source: AGHT+IGHUNzUYhVLVAPDGU9H/0WV5ShOsg0ptxWufYbLbDAiDNM07Pwk/MoJ8LvG3kzNc/NTlu+JDUt/1ryUfofqvJ8= X-Received: by 2002:a05:6902:2b8e:b0:e26:11ae:6de9 with SMTP id 3f1490d57ef6-e28939561eemr459827276.52.1727993399239; Thu, 03 Oct 2024 15:09:59 -0700 (PDT) MIME-Version: 1.0 References: <20241002010205.1341915-1-mathieu.desnoyers@efficios.com> <20241002010205.1341915-2-mathieu.desnoyers@efficios.com> <20241003000843.GA192403@google.com> <7cc83ffc-c9cc-4e87-a3ee-bb62588a594c@efficios.com> In-Reply-To: <7cc83ffc-c9cc-4e87-a3ee-bb62588a594c@efficios.com> From: Joel Fernandes Date: Thu, 3 Oct 2024 18:09:48 -0400 Message-ID: Subject: Re: [RFC PATCH 1/4] compiler.h: Introduce ptr_eq() to preserve address dependency To: Mathieu Desnoyers Cc: Linus Torvalds , Andrew Morton , Peter Zijlstra , linux-kernel@vger.kernel.org, Nicholas Piggin , Michael Ellerman , Greg Kroah-Hartman , Sebastian Andrzej Siewior , "Paul E. McKenney" , Will Deacon , Boqun Feng , Alan Stern , John Stultz , Neeraj Upadhyay , Frederic Weisbecker , Josh Triplett , Uladzislau Rezki , Steven Rostedt , Lai Jiangshan , Zqiang , Ingo Molnar , Waiman Long , Mark Rutland , Thomas Gleixner , Vlastimil Babka , maged.michael@gmail.com, Mateusz Guzik , Jonas Oberhauser , rcu@vger.kernel.org, linux-mm@kvack.org, lkmm@lists.linux.dev, Gary Guo , Nikita Popov , llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 49F7740009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: pp6ibq7zuotmt1e9if4qmmrmhhr9dtgc X-HE-Tag: 1727993401-426543 X-HE-Meta: U2FsdGVkX19Yf6+Lfc3UtHrULy06HT5udMoKEpgMfADT8XxtR0fnRF+anHca8waNJiBd6SDkbVy+cBoAiFFPRTFgkuBSPPLXk4Qq9WpTts9fXHIxeJk/a45Gr6ZxmDL/9jNzjzm1FF+7iZxLiJ44/xoAYPtEugxQi5/KKuu9YCj3fTah3rGVnQ24UfapVaTwq9BzAC23YRn3/HJFAwD6Smsx/oMVKx1PPHgvA7rEMGAbf2iQSShChIElVN848GEMT0UWExcLvvz7UkOTVHSrXTtu01S++1XyNpU30+WZduc5guFMG7xLRSjDxBVw0ByKzeiqVYLHvRGv+/5Zt14LCGwWEKh0Bzk9af4aV4nvdKWlR3y8GUjjC6Blnn2z6xkzW8oqAz5o3vLDSsOjg1nZYBTQFcft8w18hd5kEADT9kDGkbKn5KhyUcWc+4jW7b2u1xHSXRlPrTyfkP4Q9rNcE+z5v7NylYQlcWrnR6oACy2ZlIGa0Qx+KKJ+iAwz1e9velpNDTPrVYXm6RwCT6QI0vPiNHLLm4yFIxmV862KqfJIJ5tFuTdtRChjvfyBJWwPUeBOd5JRhOy1ZnssD1dVUkBrVd+Knl/7Q+V2iNegOpculGIJSnGoNU/hJVjv0WOl6UgHF920kzqg8rXh4BkN0BGUA9G/MNMjL5sn2LnjGbHvlIJobfkIaUC1NcSYFb60wK8812YENehHysqWVgr28dV7YdJs9wt+EoV+s2hVTCK7itPStvWW1yHQHy/5KA+2xOKNU+2L1Zsd5hHhls8A8lJLBqWMxv5amaGO+Q8awFOrIx2hBD2u46ZjUW1Yiup56CCQCk1gszpqZWaxbfOFKPkVfX56knS4kQAO3oLOVca9x8YrLHNkcOX5d2UigMr6cfg8w5wXxTl3QSzRMcW49b+4VvY6FaF7njHOf9B8/4cEZQbgBE0L6qkE4MLJFQmfagGX8hFx8DyDyaze0Sd REv0MR4w T+vwhONi4gbDIel51d89RFN1PmpK7nidRL9KL3Xe2y2+rclGbbTckMajAV1Qw0VWAgaodQQasAbFPwke+ZTuNKfxiHpB2SUt/AUmCx1CmgTu+Qbk2HVYo3WS3hI9uZ+xpGv5wEx4gXm1yrqZI9bBAjcq2BrWaJlrO0vB9ajsyyhZ2brp9m2drk++rUDYCGCMwzoBAdfS/kHuK5D+ufcSHDysRNtP3CPfTL33HwVhYy1MzDazdk3UCwK5S6WuOlwXDuPDgOv1iG1/vsgAZhlniq5OLPFwECTUNRPcULGprStGSE9XGhObl5g0ZJjJF3lHeGIP7YcE5hIgrXgH8znCN/osGF5jaEUWUvY271WCfMz4jq4jexUiiE/BfbjbSpzdUG+2i99vePPX+tO4KrV7OHzfW7lu7wuedQ5kj2b/MBET69UzMMl9/x8+DKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 3, 2024 at 10:21=E2=80=AFAM Mathieu Desnoyers wrote: > > > > Reviewed-by: Joel Fernandes (Google) > > Please double-check with -O2, and let me know if you still agree with > the patch :) > You are quite right, with -O2 I can indeed see that the optimize hide var fixes it. FWIW: Tested-by: Joel Fernandes (Google) Thanks! - Joel