From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EEE9C41513 for ; Mon, 7 Aug 2023 14:16:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E6096B0074; Mon, 7 Aug 2023 10:16:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 996736B0075; Mon, 7 Aug 2023 10:16:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8381B8D0002; Mon, 7 Aug 2023 10:16:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 769B96B0074 for ; Mon, 7 Aug 2023 10:16:12 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 45E8A140ABF for ; Mon, 7 Aug 2023 14:16:12 +0000 (UTC) X-FDA: 81097508184.26.EA7BA91 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf20.hostedemail.com (Postfix) with ESMTP id 6D98A1C002C for ; Mon, 7 Aug 2023 14:16:10 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=KDeUHSfD; spf=pass (imf20.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.208.174 as permitted sender) smtp.mailfrom=joel@joelfernandes.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691417770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mVE/GJTe1IuiufpABjiYZn1olHI1ifx/I1TivYEBHQg=; b=JHQrqYKsXDMVJLYzub0jVJR6+Ayg6ZnGVC4ttnTd5t5l3vN7lk9sH/CzxVulb3UuSbjHYY N8wfr1tpv1cB8DW1ENKh9n+/hi5NnCK+F1UouuY5+GI3mjvXe+BrAHB9xf4ek2xGTA9l9W sCo/K+5MljS2I6PKDh/qJYW3nVvg3YY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691417770; a=rsa-sha256; cv=none; b=0HzHIX+9saaeEKacNZ4K+n+AvR1l6sQDjPiRDLDcfzFp+vvedx6fok3QWVyadCfiNlIVyH KPsldicQ0ohYymOPCFs1mQCXCQD/1a1EVgbDQRm7HklU+8wWhv3LKbUseflrQ3aGP01u+s eu6Gp3GxgG9gfLbhq5TNjzHm5mv4ksg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=KDeUHSfD; spf=pass (imf20.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.208.174 as permitted sender) smtp.mailfrom=joel@joelfernandes.org; dmarc=none Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2b9cbaee7a9so73828901fa.0 for ; Mon, 07 Aug 2023 07:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1691417769; x=1692022569; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mVE/GJTe1IuiufpABjiYZn1olHI1ifx/I1TivYEBHQg=; b=KDeUHSfDD3L4EI9ZDbXXnOCIgf36k4kTiyHRIIffaGRG3HCFl39GcfvKDi2APyBxt9 uIkOV41JjBWzvcfkl4hWbMoMF6B7yW2N6o4toZetNa+16q9cwIbk8dhp8WLMlbMnqtzs lrCcsJN2ho/fqPCpmMmUqd/p18Lc2P1XhR9Zc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691417769; x=1692022569; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mVE/GJTe1IuiufpABjiYZn1olHI1ifx/I1TivYEBHQg=; b=NuVrhUhZTJ1d8e1sD+5VjebXKfk/C+ZadQ6r33Grcg+iGrOR8A6Gxv5FaPZn4BljDB GQ6OUwfLWjm47OC7O+MSxjJZuM0LC1o76U75NUFqHpFqp3v6E9AeZYAvQ+VNZ8AncwXd VbFhMcbVN+exmTw8DdHwKYlTjnK7uT4i3ig6lw6PD/BpcLNWabn+RSwEYQV2xbMwJ5A4 c1fy3iqFxYb47YdOofCPFaRXeJHfOBbE0epYwsiz4X8qyMbRTeGtTBnkK4QxxqA9UyGJ Bnc4m6++tKSPnZ63/Qs5Wr1jilgFVhc96XCDHBwnEYQzkhXj7BhHDdbHtwcuUXbVhmfe 1mwg== X-Gm-Message-State: AOJu0Yw3E4ppUlT0QhAkc3/iGNnK80WtEd/ftovW3thrbWFEiURd2pHK 8dcBg30WqKAkgysTOHXBpmjfto0NL4fkbyWgqa5J/g== X-Google-Smtp-Source: AGHT+IGOrJUhdG+ahMA8bObfIwJouhmkY47ZzUfvTwinDgzhZuBpH+4Q7OaueJuZRAHK8xn8XVlTzjWWvAUYbt+ovvQ= X-Received: by 2002:a2e:b166:0:b0:2b9:dd3b:cf43 with SMTP id a6-20020a2eb166000000b002b9dd3bcf43mr6572529ljm.13.1691417768626; Mon, 07 Aug 2023 07:16:08 -0700 (PDT) MIME-Version: 1.0 References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> <20230807110936.21819-19-zhengqi.arch@bytedance.com> In-Reply-To: <20230807110936.21819-19-zhengqi.arch@bytedance.com> From: Joel Fernandes Date: Mon, 7 Aug 2023 10:16:03 -0400 Message-ID: Subject: Re: [PATCH v4 18/48] rcu: dynamically allocate the rcu-lazy shrinker To: Qi Zheng Cc: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6D98A1C002C X-Rspam-User: X-Stat-Signature: r5kmo55odnkomx35t9xypeii6ak8r1dn X-Rspamd-Server: rspam03 X-HE-Tag: 1691417770-121448 X-HE-Meta: U2FsdGVkX19FYXCwN9+OzAhZEVT9I6a9/Kcfgc0/KVHi7flEdpoHnwNHJZCn7ZD/XSZPxix3CVhPpiUiiI+ACRnmMzigm57CrwTGrIOFuX8Ews4x+Oov/1jjMSonFPkcoU6IftyNaN9P805cL129JQ2AfgO/cvenA8PHZt4U3dIyTAo1QY9VHgmQa9YMP+NOLx7NzDYoGP/8JKOo14jlaR/murz3Qs1JjzTGerQ5+TDdRlGsb+QgGQbo2rYOjuy77EqdI5zwBDUIzCosmrei7bqLm3SVDjcqupcwGUt3/OlbLT4ZcWu5qd/Wl6/3iyK1j5qJr6G9LWx3RBv7ZgtuA53hg9wIuAWCiUkatwnCqX6J6xsjPtLCR17G6aLAzYoXFoLFlhlTYG5fCz13q+yKUHC913y5VYcQZ06k+0ZjldI5dXriJclSK4p7PZRjkZrL0yx81d8LEmytRp8BrgZBZmsqirX0p7+dYo7VZ3AR3gkoSU/CQ/xyFZSXD9QiMey2gQWHdsL5YjvQNOkQOJ+1PHqffdEm+Nm62Fjhry9ONjTL0rDYehMooGjTi6h4ZuEvMtfd4T3yT8vetxfWTOP3Dm/jhyblYIBJY8sXO0alWIee9jZ9zWUv8dnLwytMC84lAwhzmjIM4cl2xKrkoJWjgKONvMZFg8Uo2lP1ZlscpfW/XCyIbd37n0Xq+pVMWEP5UPkxhgc3NZS38DTSmYHuAS4ECWu9xoLbET4HXMHBXysXY21rn8PN4M2C04Mxf2jULT3QXlyfL+plTT9rm8Esj4vMPjV8o5MaA1x+jCRGeLvnufpULbEsvcbwXC8ziEfjLwvGcb39Au7WNrbILGtTRbRP8U+mSH9ZirP+CIbS+LMI5By1+QHj+3gCSXhqqHs1EGIsvoIfF18NjF3auFGCKCeOBpUINUYDZv5x2/UZRYQaUK3s67HA60m6+Gd+Qa9jIE+gZDoUujoPVVXG2UW OLK4XcZb b3e2Bw104zU+vobhQfrYehRHBeSQRjAbICJ1aB523kU3FdArrddZl/pMeU1a4Adn8wenjqRRiiD8AgvdgGWUEs/wnklzXsLtap6rTZSB5Vo+hWJr6fg4cqGDxIC+A4oYeBzo6fQIoRFD7pDv0Oqauynz3o5Gz9dQPL8Wj0BbZ85jQnYKflKtVG4ATt4XUTMOjciWD3WArp404uGNJkqJIGTA+UHAhdN4N2IKfAm7aF+7nyWKvgFyGdDGxS9KFevavnllcfXtoE3TB9QjVSeHCpKUhKknKiQug27EMiR5XCl3/8JM7FJfAXD/0+/vMF3SdiZFUyrIOb7MIQfgTHD+BoxWlSXt+a6fNhN1o X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 7, 2023 at 7:36=E2=80=AFAM Qi Zheng wrote: > > Use new APIs to dynamically allocate the rcu-lazy shrinker. > > Signed-off-by: Qi Zheng For RCU: Reviewed-by: Joel Fernandes (Google) thanks, - Joel > --- > kernel/rcu/tree_nocb.h | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h > index 5598212d1f27..e1c59c33738a 100644 > --- a/kernel/rcu/tree_nocb.h > +++ b/kernel/rcu/tree_nocb.h > @@ -1396,13 +1396,6 @@ lazy_rcu_shrink_scan(struct shrinker *shrink, stru= ct shrink_control *sc) > > return count ? count : SHRINK_STOP; > } > - > -static struct shrinker lazy_rcu_shrinker =3D { > - .count_objects =3D lazy_rcu_shrink_count, > - .scan_objects =3D lazy_rcu_shrink_scan, > - .batch =3D 0, > - .seeks =3D DEFAULT_SEEKS, > -}; > #endif // #ifdef CONFIG_RCU_LAZY > > void __init rcu_init_nohz(void) > @@ -1410,6 +1403,7 @@ void __init rcu_init_nohz(void) > int cpu; > struct rcu_data *rdp; > const struct cpumask *cpumask =3D NULL; > + struct shrinker * __maybe_unused lazy_rcu_shrinker; > > #if defined(CONFIG_NO_HZ_FULL) > if (tick_nohz_full_running && !cpumask_empty(tick_nohz_full_mask)= ) > @@ -1436,8 +1430,16 @@ void __init rcu_init_nohz(void) > return; > > #ifdef CONFIG_RCU_LAZY > - if (register_shrinker(&lazy_rcu_shrinker, "rcu-lazy")) > - pr_err("Failed to register lazy_rcu shrinker!\n"); > + lazy_rcu_shrinker =3D shrinker_alloc(0, "rcu-lazy"); > + if (!lazy_rcu_shrinker) { > + pr_err("Failed to allocate lazy_rcu shrinker!\n"); > + } else { > + lazy_rcu_shrinker->count_objects =3D lazy_rcu_shrink_coun= t; > + lazy_rcu_shrinker->scan_objects =3D lazy_rcu_shrink_scan; > + lazy_rcu_shrinker->seeks =3D DEFAULT_SEEKS; > + > + shrinker_register(lazy_rcu_shrinker); > + } > #endif // #ifdef CONFIG_RCU_LAZY > > if (!cpumask_subset(rcu_nocb_mask, cpu_possible_mask)) { > -- > 2.30.2 >