From: Joel Fernandes <joel@joelfernandes.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
linux- stable <stable@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <guro@fb.com>, Michal Hocko <mhocko@kernel.org>,
lkft-triage@lists.linaro.org, Chris Down <chris@chrisdown.name>,
Michel Lespinasse <walken@google.com>,
Fan Yang <Fan_Yang@sjtu.edu.cn>,
Brian Geffon <bgeffon@google.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
pugaowei@gmail.com, Jerome Glisse <jglisse@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mel Gorman <mgorman@techsingularity.net>,
Hugh Dickins <hughd@google.com>,
Al Viro <viro@zeniv.linux.org.uk>, Tejun Heo <tj@kernel.org>,
Sasha Levin <sashal@kernel.org>
Subject: Re: WARNING: at mm/mremap.c:211 move_page_tables in i386
Date: Tue, 14 Jul 2020 14:12:33 -0400 [thread overview]
Message-ID: <CAEXW_YRTnCb-z6TeboA3OCYv8eoX8UiCNn7K1hGMX+41Zdz8Og@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wjffJ=EBrLjsz=KUFyPXVQUO03L=VJmHnLhVr4XvT3Mpw@mail.gmail.com>
On Tue, Jul 14, 2020 at 12:11 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Tue, Jul 14, 2020 at 9:08 AM Joel Fernandes <joel@joelfernandes.org> wrote:
> >
> > I was thinking we should not call move_page_tables() with overlapping ranges
> > at all, just to keep things simple.
>
> No, we're not breaking the existing stack movement code just to keep
> things simple.
>
> The rule is "make it as simple as possible, but no simpler".
>
> And "as possible" in the case of Linux means "no breaking of old
> interfaces". The stack randomization movement most certainly counts.
Hi Linus,
I think you misunderstood me. I was not advocating breaking the stack
movement code or breaking stack randomization, I was going to try to
see if I could keep that working while not having to do an overlapping
move. That would be what I would do in the future patch (until which
as you mentioned, you would switch the WARN_ON to WARN_ON_ONCE).
I agree with you that we keep things as simple as possible while not
breaking functionality.
Cheers,
- Joel
next prev parent reply other threads:[~2020-07-14 18:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 5:28 Naresh Kamboju
2020-07-09 8:25 ` Arnd Bergmann
2020-07-10 4:17 ` Naresh Kamboju
2020-07-09 19:12 ` Linus Torvalds
2020-07-10 4:28 ` Naresh Kamboju
2020-07-10 5:22 ` Linus Torvalds
2020-07-10 17:48 ` Naresh Kamboju
2020-07-10 20:05 ` Linus Torvalds
2020-07-11 17:27 ` Naresh Kamboju
2020-07-11 18:12 ` Linus Torvalds
2020-07-11 18:21 ` Linus Torvalds
2020-07-11 23:33 ` Joel Fernandes
2020-07-12 17:30 ` Matthew Wilcox
2020-07-12 20:38 ` Linus Torvalds
2020-07-12 21:50 ` Joel Fernandes
2020-07-12 22:58 ` Linus Torvalds
2020-07-13 2:53 ` Joel Fernandes
2020-07-13 3:51 ` Linus Torvalds
2020-07-13 12:12 ` Joel Fernandes
2020-07-14 7:33 ` Kirill A. Shutemov
2020-07-14 11:27 ` Naresh Kamboju
2020-07-14 16:08 ` Joel Fernandes
2020-07-14 16:10 ` Linus Torvalds
2020-07-14 18:12 ` Joel Fernandes [this message]
2020-07-14 18:49 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEXW_YRTnCb-z6TeboA3OCYv8eoX8UiCNn7K1hGMX+41Zdz8Og@mail.gmail.com \
--to=joel@joelfernandes.org \
--cc=Fan_Yang@sjtu.edu.cn \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=arnd@arndb.de \
--cc=bgeffon@google.com \
--cc=catalin.marinas@arm.com \
--cc=chris@chrisdown.name \
--cc=gregkh@linuxfoundation.org \
--cc=guro@fb.com \
--cc=hughd@google.com \
--cc=jglisse@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkft-triage@lists.linaro.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=pugaowei@gmail.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=walken@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox