From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA7BD5D674 for ; Thu, 7 Nov 2024 17:50:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 433BF6B0082; Thu, 7 Nov 2024 12:50:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E4156B0083; Thu, 7 Nov 2024 12:50:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2ABBE6B0085; Thu, 7 Nov 2024 12:50:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 080146B0082 for ; Thu, 7 Nov 2024 12:50:13 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B1E27AB712 for ; Thu, 7 Nov 2024 17:50:12 +0000 (UTC) X-FDA: 82760036058.03.2B4F8C1 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf29.hostedemail.com (Postfix) with ESMTP id 7328412001D for ; Thu, 7 Nov 2024 17:49:22 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0635FFVP; spf=pass (imf29.hostedemail.com: domain of kerensun@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=kerensun@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731001725; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eufMSunbjw3M9ozDORGZEe7dg/+U9e4sHgKnbXcbU9U=; b=vZPKJsQ31L2Z6bRY4rixKrhtQR37E3Z+MZ/sOHWTtWPQHp8bMT0UpewHa8TT0C5QxHjbA9 u2Wx7cbEXnOKiXlxz02w3eoAeBpouPgsXmqOGf9b9hNil+g8QWlOZ9ZRNRvC13HvU81Hfk 3lP3qLqVRDqLfzIxPTusiXR8koaJqAc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731001725; a=rsa-sha256; cv=none; b=NprpKAZTOLDyi29dfdFzpoh3eFMzUVihc7iU2kVDh5IwIqg5CNY+maa3+f8S6rsvGMDgI7 rAahw6fd45DWIXJTmvAckUqFW6gSuGw6kD634zh5iWusw+oEz3FZg1ZatU+1+xKFCAvHnp CxAd5hmTuerfYjqUOdcYeEKVKsYzwTY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0635FFVP; spf=pass (imf29.hostedemail.com: domain of kerensun@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=kerensun@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-460969c49f2so3301cf.0 for ; Thu, 07 Nov 2024 09:50:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1731001810; x=1731606610; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eufMSunbjw3M9ozDORGZEe7dg/+U9e4sHgKnbXcbU9U=; b=0635FFVPCpEexA6J6erCFKcp3OAYumMZMpCX8VMamqgYQqewJAXPWNcyM74mqE0aFr FIRcaMgOt8uDC7RA8yF6jG83XMplCIIlB2dFsEC9Z3FI6vnhObFPLmsLPibw6GeBIcFv Pob9kDlq2DOVoDOHE6y84pi76kw4OJYe59jM3IuGaRRKtcrKKm3Q92PIP457Cv+lrsD9 G+fTldpN/TsWDpZ0Ooa0ENqpIW0wkIGbPyjo2j826CsN/GO91HPbCKkavLH2cCM7qUCM PTA4PME0CZqra7+oEK2/jPK7xr+rl6w4HMuEKAQpQ6tDPyul/tdBqj2j7cB42L6Oi3i1 KhQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731001810; x=1731606610; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eufMSunbjw3M9ozDORGZEe7dg/+U9e4sHgKnbXcbU9U=; b=ap5LzO4sr3U746oDcVsdpt1SMiKZSZTk+THadMWHTf+ipcNLBWHI+Rx5RpP5Q7wn2N zPRw5JH8RPwKJvnyL1sYeRDs0NSPGn6d/Lu5fcAzB4lAcV7WDyTY4Jwyf2I1j9KWmqeZ MUzTrI0SiQtwF7INYa60ZWBjkffXdPmgff3HnmTv8it41Nwi75WJS/Af3US78YXYTj+h ttL59yL+4duZaqgRjGsnLAAD2Q8bwOA6GxTc7opyTxbPXz0nA4wj6/8T2IywuYzB29ew g90uUuXP5otUfDTNVJUM+qWtCP00gx1uux89BcIpDxY3ADHMnmd+WpyKJNTz2qRbDJva WQeQ== X-Forwarded-Encrypted: i=1; AJvYcCX7pbPL+fVFaraRfV6ErX39TxhW1fd3PHHcyNItJyYX4xcp1aT+kPvOkrnTcStRq4p6lAUWSfXo/Q==@kvack.org X-Gm-Message-State: AOJu0YwXE2h+ZUA+AnWv53AKfYkJRUORlfax4F38vVwxUZgz7H5P1X3o jb7YNEsnGMiz4lZApAPHRwbmwYFtcV/mJaYZD9JyB7geZEn/n6T2so6anB7bh6se2oFu4reLHrd hdAD6/Ar/z7xy7lyuBh1IDAoUo5+x9orcY1V29Y7KBYh+VyRHfG5s X-Gm-Gg: ASbGncvtWVk/gv6q9FHPxBzE1Q193/BidQzOQGgopQjuR8yrNEHD4MNQrC93F/KiS8N 6ZePVk2pIvybZsb9U15YBu7BxGXLeMiVrfxTpY498aJnMbO+47IFyDllnwvo= X-Google-Smtp-Source: AGHT+IH1VObiXknqREVB2jSbe3W4tlOT3yvcKOnoUO2TLGn89+5qdSA2SBXzkRAJibVCGeV6K4A8xULHl6XLVm50FGI= X-Received: by 2002:a05:622a:47c8:b0:462:eb1a:89e7 with SMTP id d75a77b69052e-462fa55aae1mr4617911cf.2.1731001809774; Thu, 07 Nov 2024 09:50:09 -0800 (PST) MIME-Version: 1.0 References: <20241104222737.298130-1-kerensun@google.com> <20241104222737.298130-5-kerensun@google.com> In-Reply-To: From: Keren Sun Date: Thu, 7 Nov 2024 09:49:57 -0800 Message-ID: Subject: Re: [PATCH 4/4] mm: Replace simple_strtoul() with kstrtoul() To: Roman Gushchin Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: multipart/alternative; boundary="000000000000fab67206265643b7" X-Rspamd-Server: rspam10 X-Stat-Signature: kr6c3qci7odsfryunp6i98wuhzujaec7 X-Rspamd-Queue-Id: 7328412001D X-Rspam-User: X-HE-Tag: 1731001762-409540 X-HE-Meta: U2FsdGVkX19AFpHdSbp/cu33xAayu3kA7LNzslEkZwdA4aB7DhONozCVAX/Ae47XhRg0BqZg6g+eH/dSXsgbjx3rWxjl0GD6POnjqLELtBlTUVF4ct5EjO+VaLMqMA+XYGY8FHcbjuKIHmUpA5GNncqJneUL8kONoJLu0IjaRPvWcemw5xcTIV5svcD2tKSW8rj2CQSlnJgwUnBv918sO3L9dpa37nXKlK7nKPVmfybniq/DhaIL2wW8ydVi3l6A8YESYKKcxiKdfFPnd3wV4Jbm2+6oIJOIX/zGxp+CYoIypOJt2kIkK9gOlFYyQQnPx7fhRg9lXHNSHauxnSkAPnZ2mRjimwVQy/RzzBFH3oaHCIClYqfgsl1HrBFcN4Ri7thYEZx/amRdVWB1a4cn51cXMVEx2T/hgqn/+PScPxR2zk3PnXbkQ+CA5VnqRTZ0b/jFDH/5Ecnn8TI/5UZvpjwzZTPYrfNmiP2aFxRwXojKcllFweGkrefsebFH6yPj4/Wo9uinKCpFtSCDkeCdZi3ol/lpzmKAhCwnePAyS2v9rB+YuKRo+doBUND7zOw7w/fQGeHLmqyclod1No/wfB+QjrOaAPhJEczqJ7jsHzc9lEk/UISG7aL4B0k1N3BusbphH5yEJGBcin9PI6kXFD1NoQJQeagICDHVlslBMsWgOdYVCLqABgzRYpJVCI+Pls4/1GM1FOJcbooY7MhiSglMd6Ega0yMNVvNbdx54w1TxYjSDvs8JfoxAYnertsRsKWMITnAoaLMGLxWEQLhVru3lappD2dG9BqI+/MapLXijgIAI7mwN5/im+8ifW4zENO8KdfnYWxpu29FCKf/NkDVFg6TbQT04NkSA2IjrHaKikUswrutZMOO9aaYyjBpX/ltNnlHrDySXeni+aXxbII1wAogSh2Ka3JbcxpO+ooPNAQAknJrCZn8UtzZH5eMXmsyVzKBE8DA9TAiY2i JRy0wfbp ZH6Tui0+X5mpff6dJpH8qsUbFWNjjWbxXTJJMeRuA2keCo5ejpxeZAwv/zFEdbJJC6jbjzmwXLYRvnY87PkoIFt6DzyKm3C6S9l7vUs8x7IrTs4lnDxcPQBm2UH2NFXYzrM3Fn9X2dNal2dYyOK0i0yr+SqtLqG5HCFhHnIXraW0szU73CnMPifm465QchqTeIIUpOy8KlpaT49xaQPe1VuG28HV5TBpNhYVuq3sIB8iAR4omgvcJ0KrMZBjVvcKYKW6MKwDiA2ydOXxZ8k4qn4WC9m7sJuayii/N2NkOZu5Jk2pArFq0d4wWmuM0zt48dfCg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000289, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --000000000000fab67206265643b7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I'm trying to come up with a test. I did look into the code and saw that the pointer to the string moves as it's being parsed, and the parsing stops when the string is no longer a number. So I think it's good to use this function to replace simple_strtoul(), as kstrtoul() has an overflow check as a plus. On Thu, Nov 7, 2024 at 9:20=E2=80=AFAM Roman Gushchin wrote: > On Mon, Nov 04, 2024 at 02:27:37PM -0800, Keren Sun wrote: > > simple_strtoul() has caveat and is obsolete, use kstrtoul() instead in > mmcg. > > ^^^^ > = ? > Btw, did you test this code? Shakeel was poiting out that kstrtoul() migh= t > not > work here, is it false? > > Thanks! > --000000000000fab67206265643b7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I'm trying to come up with a test. I did look into the= code and saw that the pointer to the string moves as it's being parsed= , and the parsing stops when the string is no longer=C2=A0a number. So I th= ink it's good to use this function to replace=C2=A0simple_strtoul(), as= =C2=A0kstrtoul() has an overflow check as a plus.

On Thu, Nov 7, 2024 at 9:2= 0=E2=80=AFAM Roman Gushchin <roman.gushchin@linux.dev> wrote:
On Mon, Nov 04, 2024 at 02:27:37PM -0800, Keren Su= n wrote:
> simple_strtoul() has caveat and is obsolete, use kstrtoul() instead in= mmcg.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^^^^
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ?
Btw, did you test this code? Shakeel was poiting out that kstrtoul() might = not
work here, is it false?

Thanks!
--000000000000fab67206265643b7--