From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 133BAD36122 for ; Tue, 5 Nov 2024 19:56:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A12406B0092; Tue, 5 Nov 2024 14:56:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C1466B0096; Tue, 5 Nov 2024 14:56:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 888876B0098; Tue, 5 Nov 2024 14:56:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6B1326B0092 for ; Tue, 5 Nov 2024 14:56:47 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D58E2C1513 for ; Tue, 5 Nov 2024 19:56:46 +0000 (UTC) X-FDA: 82753098162.10.49ABD0F Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf29.hostedemail.com (Postfix) with ESMTP id D432112000E for ; Tue, 5 Nov 2024 19:55:59 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lGM+mTQe; spf=pass (imf29.hostedemail.com: domain of kerensun@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=kerensun@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730836382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZaeSm2GuldiVCV5bztcTQlAykP32wuroZ7vcOSn2ZlY=; b=X9xWAgLeQPuqRLrC7TEcCUhJLFNugOmKoxSCJvsRTlHnqt+FMpx3+Od4cFSQMXxC7WC/FY PjWPcXjlwjqPf5iYjsUOw9bSIJ8RcsugJ8LbUXdMpKSgfXk9YaA2KLWAEFHJjP0kEnEfuG y8jSCGmaduXRN19+hCAN2m/vEgoxN28= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lGM+mTQe; spf=pass (imf29.hostedemail.com: domain of kerensun@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=kerensun@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730836382; a=rsa-sha256; cv=none; b=I1k71xYyEIEYUn8raieuO0dR6RuslE/MMNHZAs0FAat5qwDulC6qaRZEfPJrEVCIKqGQ9X TY8VQnLnw0RI80/9Y+JlBKVal+UCJJFpzRxUebIxTSxfqVAlWxALOjmWOLnPAnXZGZORwi FO7AmGqJF5QcxaWYJf4w7PtH1E8Hg9c= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-460a8d1a9b7so43671cf.1 for ; Tue, 05 Nov 2024 11:56:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730836604; x=1731441404; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZaeSm2GuldiVCV5bztcTQlAykP32wuroZ7vcOSn2ZlY=; b=lGM+mTQel4W/kEWPe9xf7DAfr27HbO3+zQOLuWpVY/iBzbASWd4N7XzKgvPpKEYHqD 7hZVQoAcPmkNHVdjkQEWWpOPHc47eLn+LuTpESZItITWAskqKFI+Wz74IcM5WoWlJx51 qXugflig3aBgU3k2EMapiQdzdX7x2slZ034d7X7DFeADXTxNwuDoMFh8YOYiQ57ACVBR x4/oZ3JV1l/sBNzO9UBLMz1LiE2zDv8O76l0L2VRjE5t2ArW3hTIfh7AQ79OXeHzRmSf UHieF2P3np3qlV+148X0b/y43K19Fss/26fRcM0PFNZRH5VVGuwu1geB1alr6OU/HbF3 g+pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730836604; x=1731441404; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZaeSm2GuldiVCV5bztcTQlAykP32wuroZ7vcOSn2ZlY=; b=Q8KU+Nh8T8dqBSP1ZWX2yduaXOK11qLYbN+Bf3tn5KK0YJSiy2L+vKsugrtimxlESR BfRuQKBq0kZHPAPmnOrrs3KksEnk5JXXD7jzvEXSAx6t2o4hWbkJNvpEfMlrpwyrCfkK c17hRlLCS0/thePHA1uexEqVh9fB5k8qwcNPChwnk0vBCmSFbjBrM1RIiDcpSK2yb61z hYAgQ1M6xP/30M/LAw2nzzOPFFXvPmCztGHPHFSpJj6dUJ5+ZVhNdE3osuqph3/uXPxL 1M3yHHKoIIxnus+7zll+UXfdngwqksdqVqK+gTiODJZTDlQLu/jrdTmcmXzkZA+84jjh rQ5Q== X-Forwarded-Encrypted: i=1; AJvYcCU15KVcTojku4lkjqRgsS9HpXXCrO8kG/zrog7ukatx9N1i565PbXdpSFdF9lxo6pnx91fd71fIrQ==@kvack.org X-Gm-Message-State: AOJu0Yyx+lkPfrWRICtUXAnwjm0Pvu2790Icl4nxuQSwfHEntwDMTABl k0JuuAZbhuGuewsUtcFa28013NKcNI0sC/twUZ37Ru3aG8WQQIQOVcKxj35Tu2ahMfX+OaNeGKS uHkv2sV+CHJ7MAXhQSE/AgpAp8ANsnqL7wKBr X-Gm-Gg: ASbGnctbFgAd2oRhcsHaWmBb8VZ0FNDf8fAYybTSH1Ds+hCOzpzBJinHjJOgb2OJqhi N+up6Ec6cHRJDWPS4TBApBsjIU7pgllHufc6M9jMxCcYFgVRk+MXHuS4jc4A= X-Google-Smtp-Source: AGHT+IEorwrageqShVAeVsBxvgQL6yWE30AUoEWb5tEDK1oTBuuHwavfKEvJTa1HlMO/NcFfcZrBKf8/6WiZqF7IGco= X-Received: by 2002:a05:622a:d2:b0:461:48f9:4852 with SMTP id d75a77b69052e-462f01ecb01mr302111cf.28.1730836603862; Tue, 05 Nov 2024 11:56:43 -0800 (PST) MIME-Version: 1.0 References: <20241104222737.298130-1-kerensun@google.com> <20241104222737.298130-5-kerensun@google.com> In-Reply-To: From: Keren Sun Date: Tue, 5 Nov 2024 11:56:31 -0800 Message-ID: Subject: Re: [PATCH 4/4] mm: Replace simple_strtoul() with kstrtoul() To: Shakeel Butt Cc: akpm@linux-foundation.org, roman.gushchin@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: multipart/alternative; boundary="000000000000f09d4606262fcccd" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D432112000E X-Stat-Signature: hmnt4r916qkgigf7irrab5rwdxoerp4y X-Rspam-User: X-HE-Tag: 1730836559-409217 X-HE-Meta: U2FsdGVkX1+OvpzdB0Wv8mdo23ZPk5rzCxSuC3BOs1KxeXDrMEPFh9QY0Y6hR69sw+Ki+6BsUtMEuFxKYmAX0N3Pmsvcfj5cA52MQyGzvvf6RM0IaLx+x9oPdP2eetmB/dwbXMZ0cNRI4MS6FzrtiOyHj6J0E5HIoZDl57UGHOGt+Zy1vyiZXCsiiFhiQrFuH+rvZdHgH6CNT+7zoZoNRtB5SnIXFh9MGQlk0TNGl1oskZ+aEhXB2UUSQF4IanYW6WKE45fZlx9TVUn7nNvAKSoZCAPMw3tF6LTaQdsJPp9G134baXCnodXtabvXg8wxNhkUR2WMXy7xU4WWg23ws6vyEe/VVKKNl7AvPGSV6/K7nxJcLgiiVXvlg6ALq2jVAlw54yU+jD4JzknhrsAncaLKRv+4OhQ+BMP4CGf/10qSk+/clh4dt9jawjkjsEFFL8T8f5jhxZu3H7YubrMCo8pwAUY97YkevCWXu4Aq7pRxueAD8R5qj1cQXR+HbtYiQmSfXhiR4KYEC6PhLRkn8rnhIW+Iitb0RLrDsy9A877KCSidXc6rOEf6uj+lo7xg8/2S6/6otoFpoBdxvOtnQoeZ5ZZSrXW6nVvhyOyPz02oGzjm+5Gjj/sOPcSDNZlH9ZELNn4A+1gchyNkuBlRqQgreDgZqH6ie6SRyk6BydMnsyY5Q2OHUHsxL1NdW+oM02g0IOfn1nQMQHRs/Jqhq3BThAE2mbjW5SGxB7HlL9jxBzzKbiXeUnL7RoASD8F7Flh6aHoN3CBze//nrm05ByJQxnnNAvjw8tMSgFFf7BXwOoKlAvt4m6jLM8IOFxw3zh2VRjcFWOml7DCeUJDXMS21WpQhr4L39xTnmYobdGpKZzy/jPytqWUoFivt5hV6oNnEO4ZPnpBHU9WQc3/0TRl0hBA2/1Az8855qqXkxVNXbe1BgICpcNcYD7SwKAQsuAm0Lv7Q+5mrpo7+/Z5 cGWfho8l hiFlSYMAYtA93So3aqxQLnIKubIsvYVgPts5AcKBVL3vALdj78NKe9JWjWgrKI4sxhEUn4+f9EdhpYhIowi9RIkxZ/5ojy/mj1CpWySqLp7CSZCq6sBLSnNa/u1+Xwani6Yx+C/Ttr4minuycMHaVbnoBGajBJnH/PHYCh1ZKf/pxtGCljlTNJvGMIEhJ2lSuUxjPcZwqkY8FqjPHUmJyO6A4zmkFCQI66nKJJ7TjwDvRdpwtn8mLsCs24F4OZgAUXjaYtuS4FHxTwBj7KLoWMHTBrDE37DafbM4k0tBAGo8/KmDx3y4e3ClAiJJRWPO/RT+v86a9FzkGk5qQn7MbDC7yeqbhFZTa29jMEQg5QDj+maw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000936, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --000000000000f09d4606262fcccd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry I wasn't sure which test to test with. I'll revert this patch then. On Tue, Nov 5, 2024 at 8:38=E2=80=AFAM Shakeel Butt wrote: > On Mon, Nov 04, 2024 at 02:27:37PM -0800, Keren Sun wrote: > > simple_strtoul() has caveat and is obsolete, use kstrtoul() instead in > mmcg. > > Did you test this patch? I don't think kstrtoul() can be used here as it > expects a string containing a single number. > > > > > Signed-off-by: Keren Sun > > --- > > mm/memcontrol-v1.c | 17 ++++++++--------- > > 1 file changed, 8 insertions(+), 9 deletions(-) > > > > diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c > > index 5e1854623824..260b356cea5a 100644 > > --- a/mm/memcontrol-v1.c > > +++ b/mm/memcontrol-v1.c > > @@ -1,5 +1,6 @@ > > // SPDX-License-Identifier: GPL-2.0-or-later > > > > +#include "linux/kstrtox.h" > > #include > > #include > > #include > > @@ -1922,17 +1923,15 @@ static ssize_t memcg_write_event_control(struct > kernfs_open_file *of, > > > > buf =3D strstrip(buf); > > > > - efd =3D simple_strtoul(buf, &endp, 10); > > - if (*endp !=3D ' ') > > + kstrtoul(buf, 10, efd); > > + if (*buf !=3D ' ') > > return -EINVAL; > > - buf =3D endp + 1; > > + buf++; > > > > - cfd =3D simple_strtoul(buf, &endp, 10); > > - if (*endp =3D=3D '\0') > > - buf =3D endp; > > - else if (*endp =3D=3D ' ') > > - buf =3D endp + 1; > > - else > > + kstrtoul(buf, 10, cfd); > > + if (*buf =3D=3D ' ') > > + buf++; > > + else if (*buf !=3D '\0') > > return -EINVAL; > > > > event =3D kzalloc(sizeof(*event), GFP_KERNEL); > > -- > > 2.47.0.163.g1226f6d8fa-goog > > > --000000000000f09d4606262fcccd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry=C2=A0I wasn't sure which test to test with. I= 9;ll revert this patch then.

On Tue, Nov 5, 2024 at 8:38=E2=80=AFAM Shakee= l Butt <shakeel.butt@linux.dev= > wrote:
= On Mon, Nov 04, 2024 at 02:27:37PM -0800, Keren Sun wrote:
> simple_strtoul() has caveat and is obsolete, use kstrtoul() instead in= mmcg.

Did you test this patch? I don't think kstrtoul() can be used here as i= t
expects a string containing a single number.

>
> Signed-off-by: Keren Sun <kerensun@google.com>
> ---
>=C2=A0 mm/memcontrol-v1.c | 17 ++++++++---------
>=C2=A0 1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c
> index 5e1854623824..260b356cea5a 100644
> --- a/mm/memcontrol-v1.c
> +++ b/mm/memcontrol-v1.c
> @@ -1,5 +1,6 @@
>=C2=A0 // SPDX-License-Identifier: GPL-2.0-or-later
>=C2=A0
> +#include "linux/kstrtox.h"
>=C2=A0 #include <linux/memcontrol.h>
>=C2=A0 #include <linux/swap.h>
>=C2=A0 #include <linux/mm_inline.h>
> @@ -1922,17 +1923,15 @@ static ssize_t memcg_write_event_control(struc= t kernfs_open_file *of,
>=C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0buf =3D strstrip(buf);
>=C2=A0
> -=C2=A0 =C2=A0 =C2=A0efd =3D simple_strtoul(buf, &endp, 10);
> -=C2=A0 =C2=A0 =C2=A0if (*endp !=3D ' ')
> +=C2=A0 =C2=A0 =C2=A0kstrtoul(buf, 10, efd);
> +=C2=A0 =C2=A0 =C2=A0if (*buf !=3D ' ')
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return -EINVAL;<= br> > -=C2=A0 =C2=A0 =C2=A0buf =3D endp + 1;
> +=C2=A0 =C2=A0 =C2=A0buf++;
>=C2=A0
> -=C2=A0 =C2=A0 =C2=A0cfd =3D simple_strtoul(buf, &endp, 10);
> -=C2=A0 =C2=A0 =C2=A0if (*endp =3D=3D '\0')
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0buf =3D endp;
> -=C2=A0 =C2=A0 =C2=A0else if (*endp =3D=3D ' ')
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0buf =3D endp + 1;
> -=C2=A0 =C2=A0 =C2=A0else
> +=C2=A0 =C2=A0 =C2=A0kstrtoul(buf, 10, cfd);
> +=C2=A0 =C2=A0 =C2=A0if (*buf =3D=3D ' ')
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0buf++;
> +=C2=A0 =C2=A0 =C2=A0else if (*buf !=3D '\0')
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return -EINVAL;<= br> >=C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0event =3D kzalloc(sizeof(*event), GFP_KERNEL= );
> --
> 2.47.0.163.g1226f6d8fa-goog
>
--000000000000f09d4606262fcccd--