From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99B87D3E770 for ; Tue, 5 Nov 2024 21:23:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 324F26B008A; Tue, 5 Nov 2024 16:23:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D49C6B008C; Tue, 5 Nov 2024 16:23:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19C906B0092; Tue, 5 Nov 2024 16:23:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EFC626B008A for ; Tue, 5 Nov 2024 16:23:24 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7BD7AA12C0 for ; Tue, 5 Nov 2024 21:23:24 +0000 (UTC) X-FDA: 82753316562.24.0189D9B Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf19.hostedemail.com (Postfix) with ESMTP id B22101A0003 for ; Tue, 5 Nov 2024 21:22:40 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=cPhk0wI2; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of kerensun@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=kerensun@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730841719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QUGNavzkBE8mIeLuVJtj4NgqSq5Vswste6QLNDSFObo=; b=bZoeVZBAtzjP0y96mGQnN7SKoHK1A/CKlLLz6+lOGv6jGeGr/NpBJxyuJBl7K9wtVq5iBF 1J0G/lzEQJZkKKw55KjQIQmYFIgQBX1tKeqt6IiDbvhNSFGh902RermntI6FO1dfLUYz2A OmRuv6bCSnbxi2SgN7FUvsHMd8hqMzg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=cPhk0wI2; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of kerensun@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=kerensun@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730841719; a=rsa-sha256; cv=none; b=68z9ubpOS/fAYIjTCRJtWYfB9BHyjcJ406gEPYRDLapQ1FfftD19MZmWOF0vscTmqXvZsB IKnF0d6mcrOvCrWgJWKpEsKPzkb3l7GcrPtT03J72+3FzwwFeNfDT2lPVj8OEGHRs3ej1Q KPyMpJed3Dl6DFnWvbwTF3RgcEq2tQ8= Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-460969c49f2so69331cf.0 for ; Tue, 05 Nov 2024 13:23:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730841802; x=1731446602; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QUGNavzkBE8mIeLuVJtj4NgqSq5Vswste6QLNDSFObo=; b=cPhk0wI2NjO0k1BHDT0wPpP5hbhXHgK7w8wuy3SgXwvo9Q6Ldi0ToWuVmDXxtHNs04 YggO6Y/8fx2D6sevXi4LBR9k7X+2YhL1DQyCgyMfdD0Gg/q1EVLHnlREPzw3h757sniQ TywK/B79ZkfMnbxxQtuY9RibAsrY2k6kJ1m2YRT8rSfRw16E/geq2jbnnqkOI4208+Y1 5P0YT5GS248iFnvU9Z/r3Hu4obGwMmHLtPO4BOWBuEoVQqFwyzEh4rRQSqKw230qGRZT 375J4mxs7xTG4X6836nrwJKQP+JK0sENY23/jEcccXXJhEh1SprIN3w6ve/fKlQY+3v3 WLdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730841802; x=1731446602; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QUGNavzkBE8mIeLuVJtj4NgqSq5Vswste6QLNDSFObo=; b=VLS1h82lu4RaEBWtdjcDY6z4iGatsZTiHfan07dENjiLcOVILfJOkFbJhs8b1pFduO kKZrqJa0vHn/NxUbgQ6cDVTnd3fMfnDZgWPWH9ertIT7EikhXdUAX50S5j7tyW4nnlwX VCRiLGJQi7Fy2jrpXoUrf9KEB6g+2h4+Tj0L2oq28Cng5yGZBuXWMKNTzo4y0E+z+dMl 4tOWp8ZgyYStgqeXEpPPtoXun3Z2j25ljVYBiKG0Gi8CmXbmB3mmZcGawdJTwvt4q9AY XX6QVmlA6lS2YRS7IMzcXSoRG/ksjs7ir3Wker5B2jdD9IYD3wR04mt10Skfv8NU4PxA xsFA== X-Forwarded-Encrypted: i=1; AJvYcCWaYyA4rdS4x7dFUtplaI/fdGU+H96yq4BE5kg3b8Lsa4cBP4+PQwFU3KeW5i1+jkDlupnltlBhiA==@kvack.org X-Gm-Message-State: AOJu0YyuOzDOe4UN0Al5QXugXgDoT1eFuDQRcRv8/+2rRhjkRoKYHRh7 YUEfitGRt1xcFCn/HILtAJEt2nSa5Lm+mYUDLRSptPriRL3x+hiP1LW0V7Acy1nghlkC5aRhVv0 ITwn3V2JkPDZIDjw5Cpe58bIytlaszrO6BYG0 X-Gm-Gg: ASbGncto4eWekQvlEM9XfzdAF8FhyWnKQY7CVQJQQqVSQsppFxG1D13bILvhCcbTe3w bVBi5SG51lVHp2ShP7g5wmL80uti35cW8UqO9ckCPOuOF2yIvFCZEILxVvvw= X-Google-Smtp-Source: AGHT+IFqE3ycaF1lNaan9EmlpMOHMYuy8PoUfTFkLBK9k5ZZfSEC0fIgBcHfu73IYNr35lDRxUMj8viFBu0bTqWxS8k= X-Received: by 2002:ac8:7d8e:0:b0:460:e7fa:cf2 with SMTP id d75a77b69052e-462f02f420emr658021cf.23.1730841801407; Tue, 05 Nov 2024 13:23:21 -0800 (PST) MIME-Version: 1.0 References: <20241104222737.298130-1-kerensun@google.com> <20241104222737.298130-2-kerensun@google.com> In-Reply-To: From: Keren Sun Date: Tue, 5 Nov 2024 13:23:08 -0800 Message-ID: Subject: Re: [PATCH 1/4] mm: fix quoted strings spliting across lines To: Shakeel Butt Cc: akpm@linux-foundation.org, roman.gushchin@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: multipart/alternative; boundary="000000000000bca319062631026c" X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B22101A0003 X-Stat-Signature: xsxyozhramwmdrbjf45boubjp8nif3gu X-HE-Tag: 1730841760-548925 X-HE-Meta: U2FsdGVkX1+lmwd7WfhJrHkYy2PRTkrDf/FfJpUfHZaoS+Iiv7/Kdf0zjIUwqhDSeKobKmXuGa55x86qHtRDyol27i+7YLOd6RzWpqJePjmPPuYeWT7pwMooORMUDAAUHGJ4MBZ2SFYwPTqssn5uMijSNb1kVN4VCl+rXeA3F+J/EtjWgD4SGVpKjnJV52sU57QF06zHOLJWFGDdra+iF9J2HaSwFmdYCVQLDiJZNL43a47Yi0mGBq0mYTpf365V10FikrmTEoZalpGrkeGtPmn3ziImaFSTJX6dYCEO9EozBW0DcYg3aidyGD9SFQOddbVuxb8nuGgrRE/9LIcjBBTz1HALDYNDraDSvsBYvSE1WWke+l0p8NchzWUQmOUOhLsokHOoeUUleTWLRDsd+61/dG9SiUYXhfxm5boJQJYuFQFfr28vfn7PMIyX52RiS208XNqoOvROkLneqXzkO9NwwHeTTh6Mo74Uw2d0I+GBqo74NChkYyzG4mmm46URdOGCjUjDFFACXInPZKa1dDWzoGfHarngV8DQ2ct+2R1v1ioiSLmIcVOvyWZLkG4Errzx/rc10NC+n1e+wGP/vTwqR97ZRdW7PF6nx7ukuuG01YuAhZX1VRzFHp3KJz4D50Zn0ba3LLxUVyfLGP3HgZqtwpHbQjxryJVDBDm/BeCP/pOBCfDI70TijZwOkdh5VMct4z13x7k53GZuoAHBmgcWCE2t6WqG9se/NVRJ0uRGwzAM6Odf9kccN1pN4xAghNQQRWsAtjlx3QcuMfB4W7RibHI8ks8KkIY2AMsU5adL6myxe3WR18nt8fwOkjT6B8s1jhOok6SrUqolL/cALXzlDnS4f/ySqi3pKawEPL1FoyTcf6LfSLFgMZgPGPRJMXAs0ZYwn87PWs959RUoschwtViJx+xTGWPpIdFHK6C7BfWk4ENzkVFXbLq3V/QtWFXHIJrY5qA0YWhmsqA XA04LsmU 63ahnYZhVHY5X5RtZMBfFfioeZdQ0ljuu/AEyaaN49sXf3t6QEuat6fhJVM0dIntmBX0g6lQC/u1+hY/L87q32EyGeYnogK0yEhzAX9ewrz2Blpq4dufCigoACh+rqBgUuPDgia31KIwm9FY+fr0DVR6NO0qFG7bLFBanXlriB/ChzLlsB9QC+1EZNWvevW2D/xp3IxAYmDOPpKL7tYb3UXq/otVKgaDB1gxQcy1s8PfAs+Kdo08OKhk02Io2/Z3cZFxcWljw9Dq4OuVdTZiLG5Ct+FO22hIingATWvjBE8uo2ks8/piAy6rJZ4VQ8yx2nVmZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.314333, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --000000000000bca319062631026c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Gotcha, will drop this one then. On Mon, Nov 4, 2024 at 5:56=E2=80=AFPM Shakeel Butt wrote: > On Mon, Nov 04, 2024 at 02:27:34PM -0800, Keren Sun wrote: > > This patch fixes quoted strings splitting across lines in > > pr_warn_once() by putting them into one line. > > > > Signed-off-by: Keren Sun > > Other patches seems fine but personally I don't like this patch. I > would prefer a multi line string over a very long single line of string. > > --000000000000bca319062631026c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Gotcha, will drop this one then.

On Mon, Nov 4, 2024 at 5:5= 6=E2=80=AFPM Shakeel Butt <sha= keel.butt@linux.dev> wrote:
On Mon, Nov 04, 2024 at 02:27:34PM -0800, Keren Sun wrot= e:
> This patch fixes quoted strings splitting across lines in
> pr_warn_once() by putting them into one line.
>
> Signed-off-by: Keren Sun <kerensun@google.com>

Other patches seems fine but personally I don't like this patch. I
would prefer a multi line string over a very long single line of string.
--000000000000bca319062631026c--