From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f171.google.com (mail-lb0-f171.google.com [209.85.217.171]) by kanga.kvack.org (Postfix) with ESMTP id AA3DF6B0038 for ; Fri, 24 Jul 2015 14:17:51 -0400 (EDT) Received: by lbbyj8 with SMTP id yj8so20278515lbb.0 for ; Fri, 24 Jul 2015 11:17:50 -0700 (PDT) Received: from mail-lb0-f176.google.com (mail-lb0-f176.google.com. [209.85.217.176]) by mx.google.com with ESMTPS id ld20si8204989lbb.61.2015.07.24.11.17.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jul 2015 11:17:49 -0700 (PDT) Received: by lbbqi7 with SMTP id qi7so20198057lbb.3 for ; Fri, 24 Jul 2015 11:17:49 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20150714152516.29844.69929.stgit@buzz> <20150714153738.29844.39039.stgit@buzz> <20150721080046.GC2475@hori1.linux.bs1.fc.nec.co.jp> Date: Fri, 24 Jul 2015 19:17:49 +0100 Message-ID: Subject: Re: [PATCH v4 3/5] pagemap: rework hugetlb and thp report From: Mark Williamson Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Konstantin Khlebnikov Cc: Naoya Horiguchi , Konstantin Khlebnikov , "linux-mm@kvack.org" , Andrew Morton , "Kirill A. Shutemov" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" Reviewed-by: Mark Williamson On Tue, Jul 21, 2015 at 9:43 AM, Konstantin Khlebnikov wrote: > On Tue, Jul 21, 2015 at 11:00 AM, Naoya Horiguchi > wrote: >> On Tue, Jul 14, 2015 at 06:37:39PM +0300, Konstantin Khlebnikov wrote: >>> This patch moves pmd dissection out of reporting loop: huge pages >>> are reported as bunch of normal pages with contiguous PFNs. >>> >>> Add missing "FILE" bit in hugetlb vmas. >>> >>> Signed-off-by: Konstantin Khlebnikov >> >> With reflecting Kirill's comment about #ifdef, I'm OK for this patch. > > That ifdef works most like documentation: "all thp magic happens here". > I'd like to keep it, if two redundant lines isn't a big deal. > >> >> Reviewed-by: Naoya Horiguchi >> -- >> To unsubscribe, send a message with 'unsubscribe linux-mm' in >> the body to majordomo@kvack.org. For more info on Linux MM, >> see: http://www.linux-mm.org/ . >> Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org