From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9611C433EF for ; Tue, 10 May 2022 12:31:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 358BC6B0072; Tue, 10 May 2022 08:31:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E0F26B0073; Tue, 10 May 2022 08:31:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15C436B0074; Tue, 10 May 2022 08:31:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F42306B0072 for ; Tue, 10 May 2022 08:31:18 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BABB0617B4 for ; Tue, 10 May 2022 12:31:18 +0000 (UTC) X-FDA: 79449768636.27.0869EDF Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf10.hostedemail.com (Postfix) with ESMTP id 74A19C005C for ; Tue, 10 May 2022 12:30:56 +0000 (UTC) Received: by mail-pf1-f176.google.com with SMTP id v11so14825284pff.6 for ; Tue, 10 May 2022 05:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5szIJGzV0jSwpdMcVThWBXZCjy3WCoA0MTb2LX3xhCM=; b=XdXho14QbkW4+7KXZQm31h4NDObx1KZJaVmm+Wi/4imUCJ5/V5Grjl3XyGiy+w04kM 2xInfGisbMeQ0Gzl1A/45vw+BoJ0bbWEX5RBkjgFGKmOlDU1UlBRqukA6VQ5+PriiTf0 5ZVMmwyhWAVl0pJ+1DkhrsWmh5FNTbjbf3T7pWYSqo6Lll7MaqhtODnmk86PcLqFtbbS +UreMTh2UO4LNLdfFBqKvkkz7+T5DRRkOKz/NaAa3GffN1v9zzrPwiT/ejfeytBldU/d gek+hMa0LuDNmW34pEhwrl+80zQJyzJ+02byc9R48q4xM2C1aVldCkfW5d4DTtF7VZgA qoSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5szIJGzV0jSwpdMcVThWBXZCjy3WCoA0MTb2LX3xhCM=; b=nfV1khy2/tIaffcRm1kzIkhLbKTaX8Y1Mlhqc0zRUKo0DjsZ06LDemD6RutWfHtBeg WE5N0RW772bXc1ITYiESVxjpOwLz6uIdMXzbRrg+APIj8t9+hK056JAUNzMr89kWX3fc KcK29yHAfnMlw1ksaHFq96VpI/wq+VanqM9ZLW3rkLFXEhjywkKK7OcyBXEaqGvxQV90 CI1mSVnKTmg3W4Z8im1mK35rfeQonG4cwPtpZQ+V2x4lGJyw7VroBNphe+N1qcKgqXAx la3Kf4fPJTDIfZpUp8S6Lel3SRcSB0l2x8UGLbc5EUkGAHJoGpTTdnQqktTxWEa5Qa33 yuTg== X-Gm-Message-State: AOAM5311U/wy6XIscUOUUb09aOhbKevw2Qnsqsw1X4rQaYp0IkoJ4pqg EIdcNEhGAOxafhKgwmOJ9qgC3iSCPiotfW1BQZw= X-Google-Smtp-Source: ABdhPJzrJCardUGNn0sRK4dh3zHTqkuzQjE0rpQ0gLzRUFv9JP5rBqD5GG+VE5m4pT9XfMJgMd7sfjOqSGlpE7tATdU= X-Received: by 2002:a05:6a00:244a:b0:4fa:ebf9:75de with SMTP id d10-20020a056a00244a00b004faebf975demr20427580pfj.73.1652185877343; Tue, 10 May 2022 05:31:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Xiongwei Song Date: Tue, 10 May 2022 20:30:50 +0800 Message-ID: Subject: Re: squashfs performance regression and readahea To: Hsin-Yi Wang Cc: Matthew Wilcox , Zheng Liang , Phillip Lougher , Zhang Yi , Hou Tao , Miao Xie , Andrew Morton , Linus Torvalds , "Song, Xiongwei" , "linux-mm@kvack.org" , "squashfs-devel@lists.sourceforge.net" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 74A19C005C X-Stat-Signature: 9ao6nxdaj8ofmzc59z6tcrsybfz8qfx4 X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XdXho14Q; spf=pass (imf10.hostedemail.com: domain of sxwjean@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=sxwjean@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1652185856-833186 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Hsin-Yi, On Mon, May 9, 2022 at 10:29 PM Hsin-Yi Wang wrote: > > On Mon, May 9, 2022 at 9:21 PM Matthew Wilcox wrote= : > > > > On Mon, May 09, 2022 at 08:43:45PM +0800, Xiongwei Song wrote: > > > Hi Hsin-Yi and Matthew, > > > > > > With the patch from the attachment on linux 5.10, ran the command as = I > > > mentioned earlier, > > > got the results below: > > > 1:40.65 (1m + 40.65s) > > > 1:10.12 > > > 1:11.10 > > > 1:11.47 > > > 1:11.59 > > > 1:11.94 > > > 1:11.86 > > > 1:12.04 > > > 1:12.21 > > > 1:12.06 > > > > > > The performance has improved obviously, but compared to linux 4.18, t= he > > > performance is not so good. > > > > I think you shouldn't compare the performance with 4.18 directly, > since there might be other factors that impact the performance. Make sense. >I'd suggest comparing the same kernel version with: > a) with this patch > b) with c1f6925e1091 ("mm: put readahead pages in cache earlier") reverte= d. With 9eec1d897139 ("squashfs: provide backing_dev_info in order to disable read-ahead") reverted and applied 0001-WIP-squashfs-implement-readahead.pat= ch, test result on linux 5.18=EF=BC=9A 1:41.51 (1m + 41.51s) 1:08.11 1:10.37 1:11.17 1:11.32 1:11.59 1:12.23 1:12.08 1:12.76 1:12.51 performance worse 1 ~ 2s than linux 5.18 vanilla. > > According to https://lore.kernel.org/linux-mm/Ynfzh2ifG85MZEoN@casper.inf= radead.org/t/ > It seems to be a 3 sec difference? 5 ~ 6s difference. Regards, Xiongwei > > 1:37.16 (1m + 37.16s) > 1:04.18 > 1:05.28 > 1:06.07 > 1:06.31 > 1:06.58 > 1:06.80 > 1:06.79 > 1:06.95 > 1:06.61 > > > > Moreover, I wanted to test on linux 5.18. But I think I should revert > > > 9eec1d897139 ("squashfs: provide backing_dev_info in order to disable > > > read-ahead"), > > > right? Otherwise, the patch doesn't work? > > > > I've never seen patch 9eec1d897139 before. If you're going to point > > out bugs in my code, at least have the decency to cc me on it. It > > should never have gone in, and should be reverted so the problem can > > be fixed properly.