From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2EB7C433EF for ; Fri, 13 May 2022 23:13:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D0826B0073; Fri, 13 May 2022 19:13:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37EA86B0075; Fri, 13 May 2022 19:13:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 220EB6B0078; Fri, 13 May 2022 19:13:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1423C6B0073 for ; Fri, 13 May 2022 19:13:07 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DDCBC9B8 for ; Fri, 13 May 2022 23:13:06 +0000 (UTC) X-FDA: 79462272372.15.5D580C9 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf10.hostedemail.com (Postfix) with ESMTP id 3F804C0002 for ; Fri, 13 May 2022 23:12:41 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id n10so9283974pjh.5 for ; Fri, 13 May 2022 16:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ed+m13mmsGPsehFvKSi9eEmy3edAo/yW4BAPYfUU/Bw=; b=MSGeukp1lvEESCHek8ZuvAYf73Zgo988LXQF7U/nFjiZtSXi8vHDet3AIfSpzf8UWz jIdnVH8kn4eIAZ50vhbid3G3TOCfiIhofL3yw7GFwgy8nsDlSBhMwd2G8MTnczLIc4/E 9xnb/ORerw4M2DionXC9kX8ArMjOlItMpKv8eg2tPvb0JvXni6OPVknKet1BKe6LjjYD 5TUEZxL2bduSuALbHJj3asOVU1QON5BtU3/JiU8MAEFOVpgxEATDuVzqKnBlDOWEWDb5 iUEzR5s4/OVqe7Ke/kPz0AsXnKOrcoTLbiSVfb1a5lCAa/o2sw8udU5iazvpkhhAh2f2 NzxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ed+m13mmsGPsehFvKSi9eEmy3edAo/yW4BAPYfUU/Bw=; b=S4vDneOgMxvNCyK9iBl4L+TGHg+RuqTbB64hSSAZ+2EelrCYFwMQoJaNciQ0iqmxf2 QlrV4PxhS3DC7nCblFKexcc1wvbZTKQrPH0DgtlvzSoNUsPfbiHNN+ykYd28cBQ6sl9l 9w2CzL2qXT1fAWqidBTtv7AXrWVLHwOOnIsDE2a8FsJJw5MmLiNKxWUldfIYoArX7bYU 1/pjZkf0Hw1uYbN6s0+VddlOUJ8Vhm2r3CmaLmyBWKQN5ut6q1AlvJxJ50svvnlY8+el pn2vPRcrefssb88y4llgIqUefGAAoPlE1JctCBx0nylwTdCwWWn2N/4gKo7ShaZ9Oo/h csMQ== X-Gm-Message-State: AOAM530IcBERuoRhZZ5Rnz0mXKUm0HbkUuO1AijQBfqqyln4Z/TTsEZ0 k3E5sOZaEwjkrIuNpGjJYLKaMNCHc/fezOfZmk0= X-Google-Smtp-Source: ABdhPJxrixcaQXSQjby92wPBlcWMh6yYWzkJzx1O9h2VHjkA8F/NsmRPt9UjL5nHkx+SJXzIF7hryG/Zq6EJIH8L2QM= X-Received: by 2002:a17:903:124a:b0:154:c7a4:9375 with SMTP id u10-20020a170903124a00b00154c7a49375mr6939477plh.0.1652483585509; Fri, 13 May 2022 16:13:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Xiongwei Song Date: Sat, 14 May 2022 07:12:39 +0800 Message-ID: Subject: Re: squashfs performance regression and readahea To: Matthew Wilcox Cc: Hsin-Yi Wang , Phillip Lougher , Zheng Liang , Zhang Yi , Hou Tao , Miao Xie , Andrew Morton , Linus Torvalds , "Song, Xiongwei" , "linux-mm@kvack.org" , "squashfs-devel@lists.sourceforge.net" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3F804C0002 X-Stat-Signature: h4916uawiyjuntikgqmcgek4ddfj9xx8 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MSGeukp1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of sxwjean@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=sxwjean@gmail.com X-Rspam-User: X-HE-Tag: 1652483561-234850 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 14, 2022 at 2:12 AM Matthew Wilcox wrote: > > On Sat, May 14, 2022 at 12:43:47AM +0800, Hsin-Yi Wang wrote: > > > One stupid question, see below code from your patch: > > > > > > + } > > > + > > > + kfree(actor); > > > + return; > > > + > > > +skip_pages: > > > > > > when release page pointers array after pages cached? I don't see > > > any chance to do that. > > > > > actor is not a page pointer. This is allocated from > > squashfs_page_actor_init() and should be freed after use. Or do you > > mean skip_pages? There are some situations where we can't decompress > > the whole block, so we will skip those pages. > > I think the concern is that you don't seem to kfree(pages) on this > exit path. That's exactly what I wanted to say. Thanks Matthew.